Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-17 Thread Chris Wilson
On Wed, Nov 16, 2016 at 10:05:04PM +0800, Min He wrote: > For a singl_port_submission context, it can only be submitted to port 0, > and there shouldn't be any other context in port 1 at the same time. This > is required by GVT-g context to have an opportunity to save/restore some > non-hw context

Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for single_port_submission context

2016-11-17 Thread He, Min
> -Original Message- > From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] > Sent: Thursday, November 17, 2016 4:01 PM > To: He, Min > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH v3] drm/i915: fix the dequeue logic for > single_port_submission context > > On W

Re: [Intel-gfx] [igvt-g-dev] [PULL] GVT-g device model fixes

2016-11-17 Thread Zhenyu Wang
On 2016.11.17 08:55:26 +0100, Daniel Vetter wrote: > Just to clarify the process: This week we have the cut-off for feature > work for 4.10. Bugfixes are of course always welcome. But if you think > it's serious enough I'm happy to wait. > yeah, I'd like to include those for initial 4.10 merge.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Complete requests in nop_submit_request

2016-11-17 Thread Patchwork
== Series Details == Series: drm/i915: Complete requests in nop_submit_request URL : https://patchwork.freedesktop.org/series/15471/ State : success == Summary == Series 15471v1 drm/i915: Complete requests in nop_submit_request https://patchwork.freedesktop.org/api/1.0/series/15471/revisions/1

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things

2016-11-17 Thread Paul Bolle
On Mon, 2016-11-14 at 18:35 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > When we end up not recomputing the cdclk, we need to populate > intel_state->cdclk with the "atomic_cdclk_freq" instead of the > current cdclk_freq. When no pipes are active, the actual cdclk_freq >

[Intel-gfx] [PULL] drm-intel-fixes

2016-11-17 Thread Jani Nikula
Hi Dave, here's a small batch of i915 fixes. I was hoping to get these to -rc6 as it's getting kind of close to 4.9 release, but looks like I missed your pull to Linus. Any chance for another pull? BR, Jani. The following changes since commit 54905ab5fe7aa453610e31cec640e528aaedb2e2: drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-17 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 02:55:59PM +, Chris Wilson wrote: > On Wed, Nov 16, 2016 at 03:41:53PM +0100, Daniel Vetter wrote: > > On Wed, Nov 16, 2016 at 08:58:30AM +, Chris Wilson wrote: > > > Soft-pinning depends upon being able to check for availabilty of an > > > interval and evict overlap

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 04:03:27PM +, Chris Wilson wrote: > On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > > > On 16/11/2016 15:27, Chris Wilson wrote: > > >Avoid requiring struct_mutex for exclusive access to the temporary > > >dfs_link inside the i915_dependency as not a

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Daniel Vetter
On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > We need to clean up the global_timeline in i915_gem_load_cleanup. > > Cc: Chris Wilson > Signed-off-by: Matthew Auld Fixes: line probably missing? And why was that not caught when the original patch landed? -Daniel > --- > driver

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:45:17AM +0100, Daniel Vetter wrote: > On Wed, Nov 16, 2016 at 04:03:27PM +, Chris Wilson wrote: > > On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > > > > > On 16/11/2016 15:27, Chris Wilson wrote: > > > >Avoid requiring struct_mutex for exclusive

Re: [Intel-gfx] [[PATCH ddx]] intel: Adding Marketing names for Skylake, Kabylake and Apollolake/Broxton.

2016-11-17 Thread David Weinehall
On Tue, Nov 15, 2016 at 02:21:01PM -0800, Rodrigo Vivi wrote: > This commit adding all known marketing names for latest gen9 platforms. > > Cc: Chris Wilson > Signed-off-by: Rodrigo Vivi > --- > README | 2 +- > man/intel.man | 2 +- > src/intel_module.c | 29

Re: [Intel-gfx] [PATCH] drm/i915: don't leak global_timeline

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:48:18AM +0100, Daniel Vetter wrote: > On Wed, Nov 16, 2016 at 07:32:49PM +, Matthew Auld wrote: > > We need to clean up the global_timeline in i915_gem_load_cleanup. > > > > Cc: Chris Wilson > > Signed-off-by: Matthew Auld > > Fixes: line probably missing? And why

[Intel-gfx] [PATCH] drm/i915: Fix gen9 forcewake range table

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case") accidentaly dropped a MMIO range between 0xc000 to 0xcfff out of the blitter forcewake domain. Fix it. Signed-off-by: Tvrtko Ursulin Fixes: 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case") Reported-by: Dani

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 08:52:59AM +, Chris Wilson wrote: > On Thu, Nov 17, 2016 at 09:45:17AM +0100, Daniel Vetter wrote: > > On Wed, Nov 16, 2016 at 04:03:27PM +, Chris Wilson wrote: > > > On Wed, Nov 16, 2016 at 03:54:23PM +, Tvrtko Ursulin wrote: > > > > > > > > On 16/11/2016 15:27

Re: [Intel-gfx] [PATCH v2] drm/i915/dp: Update connector status for DP MST hotplugs

2016-11-17 Thread Pandiyan, Dhinakaran
On Thu, 2016-11-17 at 08:53 +0100, Daniel Vetter wrote: > On Thu, Nov 17, 2016 at 01:53:31AM +, Pandiyan, Dhinakaran wrote: > > On Sun, 2016-11-13 at 11:39 +0100, Daniel Vetter wrote: > > > On Fri, Nov 11, 2016 at 10:21:39PM +0100, Daniel Vetter wrote: > > > > On Mon, Nov 07, 2016 at 04:27:30PM

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Use a local lock for dfs_link access

2016-11-17 Thread David Weinehall
On Wed, Nov 16, 2016 at 03:27:21PM +, Chris Wilson wrote: > Avoid requiring struct_mutex for exclusive access to the temporary > dfs_link inside the i915_dependency as not all callers may want to touch > struct_mutex. So rather than force them to take a highly contended > lock, introduce a loca

[Intel-gfx] [PATCH] drm/i915/guc: Do not bypass forcewakes in i915_guc_submit

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Commit ed4596ea992d ("drm/i915/guc: WA to address the Ringbuffer coherency issue"), based on incorrect assumptions from a partialy broken commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case") used POSTING_READ_FW instead of the POSTING_READ. With the latter buggy comm

Re: [Intel-gfx] [PATCH] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:42:52AM +0100, Daniel Vetter wrote: > On Wed, Nov 16, 2016 at 02:55:59PM +, Chris Wilson wrote: > > On Wed, Nov 16, 2016 at 03:41:53PM +0100, Daniel Vetter wrote: > > > On Wed, Nov 16, 2016 at 08:58:30AM +, Chris Wilson wrote: > > > > Soft-pinning depends upon bei

[Intel-gfx] [PATCH v12 4/4] drm/i915: Put "cooked" vlank counters in frame CRC lines

2016-11-17 Thread Tomeu Vizoso
Use drm_accurate_vblank_count so we have the full 32 bit to represent the frame counter and userspace has a simpler way of knowing when the counter wraps around. Signed-off-by: Tomeu Vizoso Reviewed-by: Emil Velikov --- drivers/gpu/drm/i915/i915_irq.c | 6 +++--- 1 file changed, 3 insertions(+

[Intel-gfx] [PATCH v12 3/4] drm/i915: Use new CRC debugfs API

2016-11-17 Thread Tomeu Vizoso
The core provides now an ABI to userspace for generation of frame CRCs, so implement the ->set_crc_source() callback and reuse as much code as possible with the previous ABI implementation. When handling the pageflip interrupt, we skip 1 or 2 frames depending on the HW because they contain wrong v

Re: [Intel-gfx] [PATCH] drm/i915/guc: Do not bypass forcewakes in i915_guc_submit

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:17:35AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit ed4596ea992d ("drm/i915/guc: WA to address the Ringbuffer > coherency issue"), based on incorrect assumptions from a partialy > broken commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special > case")

[Intel-gfx] [PATCH v12 1/4] drm/i915/debugfs: Move out pipe CRC code

2016-11-17 Thread Tomeu Vizoso
In preparation to using a generic API in the DRM core for continuous CRC generation, move the related code out of i915_debugfs.c into a new file. Eventually, only the Intel-specific code will remain in this new file. v2: Rebased. v6: Rebased. v7: Fix whitespace issue. v9: Have intel_display_cr

[Intel-gfx] [PATCH v12 0/4] New debugfs API for capturing CRC of frames

2016-11-17 Thread Tomeu Vizoso
Hi, here are the patches that remain to be merged in this series. They have been rebased and I have also addressed two smaller comments: - Move locking into drm_crtc_add_crc_entry (Daniel Vetter). - Define intel_crtc_set_crc_source as NULL if !CONFIG_DEBUG_FS (Jani Nikula). Thanks, Tomeu To

Re: [Intel-gfx] [PATCH 0/3] drm/i915/opregion: proper handling of DIDL, and some hacks on CADL

2016-11-17 Thread Rainer Koenig
Hi Jani, applied those patches to the 4.9.0-rc4 from http://anongit.freedesktop.org/git/drm-intel.git and tested it on the Fujitsu LIFEBOOK E736. Works perfectly, even after suspend and resume. Adding my hopes that this will be merged into the mainline soon. Best regards and thanks a lot Rainer

[Intel-gfx] [PATCH i-g-t v3] lib/debugfs: Support new generic ABI for CRC capture

2016-11-17 Thread Tomeu Vizoso
The kernel has now a new debugfs ABI that can also allow capturing frame CRCs for drivers other than i915. Add alternative codepaths so the new ABI is used if the kernel is recent enough, and fall back to the legacy ABI if not. Signed-off-by: Tomeu Vizoso --- Have just rebased this, and made s

Re: [Intel-gfx] [PATCH] drm/i915/guc: Do not bypass forcewakes in i915_guc_submit

2016-11-17 Thread Tvrtko Ursulin
On 17/11/2016 09:28, Chris Wilson wrote: On Thu, Nov 17, 2016 at 09:17:35AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit ed4596ea992d ("drm/i915/guc: WA to address the Ringbuffer coherency issue"), based on incorrect assumptions from a partialy broken commit 0dd356bb6ff5 ("drm/i91

[Intel-gfx] [i-g-t PATCH v8 2/5] lib: add igt_dummyload

2016-11-17 Thread Abdiel Janulgue
A lot of igt testcases need some GPU workload to make sure a race window is big enough. Unfortunately having a fixed amount of workload leads to spurious test failures or overly long runtimes on some fast/slow platforms. This library contains functionality to submit GPU workloads that should consum

[Intel-gfx] [PATCH] drm/i915: Make scaler updates less chatty

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It looks to me skl_update_scaler will already log interesting debug messages when the state transitions or there is an error. In this case it feels we can remove the two unconditional debug messages which happen immediately before calling skl_update_scaler. This way we get r

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix gen9 forcewake range table

2016-11-17 Thread Patchwork
== Series Details == Series: drm/i915: Fix gen9 forcewake range table URL : https://patchwork.freedesktop.org/series/15474/ State : success == Summary == Series 15474v1 drm/i915: Fix gen9 forcewake range table https://patchwork.freedesktop.org/api/1.0/series/15474/revisions/1/mbox/ Test drv_m

Re: [Intel-gfx] [i-g-t PATCH v7 3/5] igt/gem_wait: Use new igt_spin_batch

2016-11-17 Thread Chris Wilson
On Wed, Nov 16, 2016 at 11:18:02PM +0200, Abdiel Janulgue wrote: > + int wait_s = (flags == 0) ? NSEC_PER_SEC : 0; > + wait_s = ((flags & HANG) == 0) ? wait_s : -1; > + igt_spin_t *spin = igt_spin_batch_new(fd, wait_s, engine, 0); We haven't been using C99 locals. If you separated out

Re: [Intel-gfx] [i-g-t PATCH v7 4/5] igt/kms_flip: Use new igt_spin_batch

2016-11-17 Thread Chris Wilson
On Wed, Nov 16, 2016 at 11:18:03PM +0200, Abdiel Janulgue wrote: > if (o->flags & TEST_WITH_DUMMY_BCS) > - emit_dummy_load__bcs(o, 1); > + igt_spin_batch_wait(drm_fd, NSEC_PER_SEC, I915_EXEC_BLT, > + o->fb_info[o->current_fb_id].gem_hand

[Intel-gfx] [PATCH] drm: also move DSI panels to the front of the connector list

2016-11-17 Thread Jani Nikula
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this. Cc: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/drm_modeset_helper.c |

Re: [Intel-gfx] [i-g-t PATCH v7 5/5] igt/kms_busy.c: Use new igt_spin_batch

2016-11-17 Thread Chris Wilson
On Wed, Nov 16, 2016 at 11:18:04PM +0200, Abdiel Janulgue wrote: > @@ -179,7 +111,8 @@ static void flip_to_fb(igt_display_t *dpy, int pipe, > } > igt_assert_f(nanosleep(&tv, NULL) == -1, >"flip to %s blocked waiting for busy fb", name); > - finish_fb_busy(batch,

[Intel-gfx] [PATCH v2] drm: also move DSI panels to the front of the connector list

2016-11-17 Thread Jani Nikula
We've overlooked adding DSI panels to the front of the connector list. This seems to be the right thing to do, and I suspect this might fix some issues, although I currently have no evidence to support this. v2: also git add the comment change Cc: Daniel Vetter Signed-off-by: Jani Nikula --- d

Re: [Intel-gfx] [i-g-t PATCH v7 5/5] igt/kms_busy.c: Use new igt_spin_batch

2016-11-17 Thread Abdiel Janulgue
On 17.11.2016 12:27, Chris Wilson wrote: > On Wed, Nov 16, 2016 at 11:18:04PM +0200, Abdiel Janulgue wrote: >> @@ -179,7 +111,8 @@ static void flip_to_fb(igt_display_t *dpy, int pipe, >> } >> igt_assert_f(nanosleep(&tv, NULL) == -1, >> "flip to %s blocked waiting for b

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Do not bypass forcewakes in i915_guc_submit

2016-11-17 Thread Patchwork
== Series Details == Series: drm/i915/guc: Do not bypass forcewakes in i915_guc_submit URL : https://patchwork.freedesktop.org/series/15476/ State : success == Summary == Series 15476v1 drm/i915/guc: Do not bypass forcewakes in i915_guc_submit https://patchwork.freedesktop.org/api/1.0/series/1

Re: [Intel-gfx] [PATCH v2] drm: also move DSI panels to the front of the connector list

2016-11-17 Thread Daniel Vetter
On Thu, Nov 17, 2016 at 12:29:08PM +0200, Jani Nikula wrote: > We've overlooked adding DSI panels to the front of the connector > list. This seems to be the right thing to do, and I suspect this might > fix some issues, although I currently have no evidence to support this. > > v2: also git add th

Re: [Intel-gfx] [PATCH 0/3] drm/i915/opregion: proper handling of DIDL, and some hacks on CADL

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Rainer Koenig wrote: > Hi Jani, > > applied those patches to the 4.9.0-rc4 from > http://anongit.freedesktop.org/git/drm-intel.git > and tested it on the Fujitsu LIFEBOOK E736. > > Works perfectly, even after suspend and resume. > > Adding my hopes that this will be merged int

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make scaler updates less chatty

2016-11-17 Thread Patchwork
== Series Details == Series: drm/i915: Make scaler updates less chatty URL : https://patchwork.freedesktop.org/series/15481/ State : success == Summary == Series 15481v1 drm/i915: Make scaler updates less chatty https://patchwork.freedesktop.org/api/1.0/series/15481/revisions/1/mbox/ fi-bdw-

[Intel-gfx] [PATCH v2 1/4] drm: Define drm_mm_for_each_node_in_range()

2016-11-17 Thread Chris Wilson
Some clients would like to iterate over every node within a certain range. Make a nice little macro for them to hide the mixing of the rbtree search and linear walk. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_mm.c | 11 ++-

[Intel-gfx] [PATCH v2 4/4] drm/i915: Fix i915_gem_evict_for_vma (soft-pinning)

2016-11-17 Thread Chris Wilson
Soft-pinning depends upon being able to check for availabilty of an interval and evict overlapping object from a drm_mm range manager very quickly. Currently it uses a linear list, and so performance is dire and not suitable as a general replacement. Worse, the current code will oops if it tries to

[Intel-gfx] [PATCH v2 2/4] drm: Check against color expansion in drm_mm_reserve_node()

2016-11-17 Thread Chris Wilson
Use the color_adjust callback when reserving a node to check if inserting a node into this hole requires any additional space, and so if that space then conflicts with an existing allocation. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: dri-de...@list.freedesktop.org --- drivers/gpu/drm/dr

[Intel-gfx] [PATCH v2 3/4] drm/i915: Mark all non-vma being inserted into the address spaces

2016-11-17 Thread Chris Wilson
We need to distinguish between full i915_vma structs and simple drm_mm_nodes when considering eviction (i.e. we must be careful not to treat a mere drm_mm_node as a much larger i915_vma causing memory corruption, if we are lucky). To do this, color these not-a-vma with -1 (UNCOLORED). Signed-off-b

Re: [Intel-gfx] [PATCH v2] drm: also move DSI panels to the front of the connector list

2016-11-17 Thread Andrzej Hajda
On 17.11.2016 11:29, Jani Nikula wrote: > We've overlooked adding DSI panels to the front of the connector > list. This seems to be the right thing to do, and I suspect this might > fix some issues, although I currently have no evidence to support this. > > v2: also git add the comment change > > C

[Intel-gfx] ✓ Fi.CI.BAT: success for drm: also move DSI panels to the front of the connector list (rev2)

2016-11-17 Thread Patchwork
== Series Details == Series: drm: also move DSI panels to the front of the connector list (rev2) URL : https://patchwork.freedesktop.org/series/15483/ State : success == Summary == Series 15483v2 drm: also move DSI panels to the front of the connector list https://patchwork.freedesktop.org/api

Re: [Intel-gfx] [PATCH v2] drm: also move DSI panels to the front of the connector list

2016-11-17 Thread Jani Nikula
On Thu, 17 Nov 2016, Andrzej Hajda wrote: > On 17.11.2016 11:29, Jani Nikula wrote: >> We've overlooked adding DSI panels to the front of the connector >> list. This seems to be the right thing to do, and I suspect this might >> fix some issues, although I currently have no evidence to support thi

Re: [Intel-gfx] [PATCH 0/5] Handle link training failure during modeset

2016-11-17 Thread Jani Nikula
On Tue, 15 Nov 2016, Manasi Navare wrote: > Submitting new series that adds proper commit messages/cover letter > and kernel documentation. It also moved the set_link_status function > to drm core so other kernel drivers can make use of it. > > The idea presented in these patches is to address lin

[Intel-gfx] [PATCH 1/7] drm/i915: Extract intel_link_m_n config printing into a helper

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin And also only dump DP config for crtcs with DP encoders. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 32 +--- 1 file changed, 17 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/dr

[Intel-gfx] [PATCH 4/7] drm/i915: Compact a few pipe config debug lines

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 15 +++ 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 05afd628b9f2..3c03c0172a2d 100644 --

[Intel-gfx] [PATCH 5/7] drm/i915: Only dump scaler config where supported

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 34 ++ 1 file changed, 18 insertions(+), 16 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3c03c0172a2d..3

[Intel-gfx] [PATCH 0/7] Pipe config debug dump diet

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin My Nth attempt to trim this by merging some short lines together and also by not dumping data not relevant for the platform at hand. On Skylake it saves six lines from a typical modesetting dump, from 26: [i915]] [CRTC:29:pipe A][modeset] config 88014b886800 for pipe A

[Intel-gfx] [PATCH 6/7] drm/i915: Only dump possible panel fitter config for the platform

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 3cbf9fa98512..0e31d2c9edde 100

[Intel-gfx] [PATCH 7/7] drm/i915: Introduce enableddisabled helper

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Similar to existing yesno and onoff and use it throughout the code. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c| 3 +-- drivers/gpu/drm/i915/i915_drv.h| 5 + drivers/gpu/drm/i915/intel_display.c | 14 ++

[Intel-gfx] [PATCH 2/7] drm/i915: Dump FDI config only where applicable

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2fbc18081f81..1932d1eed

[Intel-gfx] [PATCH 3/7] drm/i915: Don't log pipe config kernel pointer and duplicated pipe name

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Kernel pointer does not sound like an useful thing to log and pipe name is already contained in the crtc name. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v2,1/4] drm: Define drm_mm_for_each_node_in_range()

2016-11-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/4] drm: Define drm_mm_for_each_node_in_range() URL : https://patchwork.freedesktop.org/series/15489/ State : success == Summary == Series 15489v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/15489/revision

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Implement Link Rate fallback on Link training failure

2016-11-17 Thread Jani Nikula
On Tue, 15 Nov 2016, Manasi Navare wrote: > If link training at a link rate optimal for a particular > mode fails during modeset's atomic commit phase, then we > let the modeset complete and then retry. We save the link rate > value at which link training failed, update the link status property >

Re: [Intel-gfx] [PATCH] drm/i915: Fix gen9 forcewake range table

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 09:02:43AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case") > accidentaly dropped a MMIO range between 0xc000 to 0xcfff out > of the blitter forcewake domain. Fix it. > > Signed-off-by: Tvrtko Ursulin >

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Find fallback link rate/lane count

2016-11-17 Thread Jani Nikula
On Tue, 15 Nov 2016, Manasi Navare wrote: > If link training fails, then we need to fallback to lower > link rate first and if link training fails at RBR, then > fallback to lower lane count. > This function finds the next lower link rate/lane count > value after link training failure. > > v2: > S

Re: [Intel-gfx] [PATCH] drm/i915: Make scaler updates less chatty

2016-11-17 Thread Paulo Zanoni
Em Qui, 2016-11-17 às 10:00 +, Tvrtko Ursulin escreveu: > From: Tvrtko Ursulin > > It looks to me skl_update_scaler will already log interesting > debug messages when the state transitions or there is an error. > > In this case it feels we can remove the two unconditional > debug messages wh

[Intel-gfx] [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges

2016-11-17 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We have to make sure there are no holes in the table in Gen9. Signed-off-by: Tvrtko Ursulin Suggested-by: Chris Wilson Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_uncore.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/dr

[Intel-gfx] ✓ Fi.CI.BAT: success for Pipe config debug dump diet

2016-11-17 Thread Patchwork
== Series Details == Series: Pipe config debug dump diet URL : https://patchwork.freedesktop.org/series/15493/ State : success == Summary == Series 15493v1 Pipe config debug dump diet https://patchwork.freedesktop.org/api/1.0/series/15493/revisions/1/mbox/ fi-bdw-5557u total:244 pass:22

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix gen9 forcewake range table

2016-11-17 Thread Tvrtko Ursulin
On 17/11/2016 10:16, Patchwork wrote: == Series Details == Series: drm/i915: Fix gen9 forcewake range table URL : https://patchwork.freedesktop.org/series/15474/ State : success == Summary == Series 15474v1 drm/i915: Fix gen9 forcewake range table https://patchwork.freedesktop.org/api/1.0/s

Re: [Intel-gfx] [PATCH] drm/i915: Fix gen9 forcewake range table

2016-11-17 Thread Tvrtko Ursulin
On 17/11/2016 12:50, Chris Wilson wrote: On Thu, Nov 17, 2016 at 09:02:43AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit 0dd356bb6ff5 ("drm/i915: Eliminate Gen9 special case") accidentaly dropped a MMIO range between 0xc000 to 0xcfff out of the blitter forcewake domain. Fix it. S

Re: [Intel-gfx] [PATCH v2 2/4] drm: Check against color expansion in drm_mm_reserve_node()

2016-11-17 Thread Joonas Lahtinen
On to, 2016-11-17 at 12:08 +, Chris Wilson wrote: > Use the color_adjust callback when reserving a node to check if > inserting a node into this hole requires any additional space, and so if > that space then conflicts with an existing allocation. > > Signed-off-by: Chris Wilson > Cc: Daniel

Re: [Intel-gfx] [PATCH] drm/i915: Waterproof verification of gen9 forcewake table ranges

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 01:13:55PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > We have to make sure there are no holes in the table in Gen9. > > Signed-off-by: Tvrtko Ursulin > Suggested-by: Chris Wilson > Cc: Chris Wilson That actually worked! ... Got any paracetamol? :) Review

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Mark all non-vma being inserted into the address spaces

2016-11-17 Thread Joonas Lahtinen
On to, 2016-11-17 at 12:08 +, Chris Wilson wrote: > We need to distinguish between full i915_vma structs and simple > drm_mm_nodes when considering eviction (i.e. we must be careful not to > treat a mere drm_mm_node as a much larger i915_vma causing memory > corruption, if we are lucky). To do

[Intel-gfx] [PATCH igt 2/2] intel_ci: Add gem_exec_reloc/basic-softpin to BAT

2016-11-17 Thread Chris Wilson
Signed-off-by: Chris Wilson Cc: Petri Latvala --- tests/intel-ci/fast-feedback.testlist | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/intel-ci/fast-feedback.testlist b/tests/intel-ci/fast-feedback.testlist index 6efaaa4..0c8213b 100644 --- a/tests/intel-ci/fast-feedback.testlist +++

[Intel-gfx] [PATCH igt 1/2] igt/gem_exec_reloc: Trivial test for softpin ABI

2016-11-17 Thread Chris Wilson
Signed-off-by: Chris Wilson --- tests/gem_exec_reloc.c | 35 +++ 1 file changed, 35 insertions(+) diff --git a/tests/gem_exec_reloc.c b/tests/gem_exec_reloc.c index c56fb43..e6db8e6 100644 --- a/tests/gem_exec_reloc.c +++ b/tests/gem_exec_reloc.c @@ -528,6 +528,38

Re: [Intel-gfx] [PATCH v2 1/4] drm: Define drm_mm_for_each_node_in_range()

2016-11-17 Thread Joonas Lahtinen
On to, 2016-11-17 at 12:08 +, Chris Wilson wrote: > Some clients would like to iterate over every node within a certain > range. Make a nice little macro for them to hide the mixing of the > rbtree search and linear walk. > > Signed-off-by: Chris Wilson > Cc: Daniel Vetter > Cc: dri-de...@li

Re: [Intel-gfx] [PATCH] drm/i915: Make scaler updates less chatty

2016-11-17 Thread Maarten Lankhorst
Op 17-11-16 om 14:06 schreef Paulo Zanoni: > Em Qui, 2016-11-17 às 10:00 +, Tvrtko Ursulin escreveu: >> From: Tvrtko Ursulin >> >> It looks to me skl_update_scaler will already log interesting >> debug messages when the state transitions or there is an error. >> >> In this case it feels we can

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Make scaler updates less chatty

2016-11-17 Thread Tvrtko Ursulin
On 17/11/2016 11:45, Patchwork wrote: == Series Details == Series: drm/i915: Make scaler updates less chatty URL : https://patchwork.freedesktop.org/series/15481/ State : success == Summary == Series 15481v1 drm/i915: Make scaler updates less chatty https://patchwork.freedesktop.org/api/1.0

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for Remove __I915__ magic macro

2016-11-17 Thread Tvrtko Ursulin
On 16/11/2016 09:16, Patchwork wrote: == Series Details == Series: Remove __I915__ magic macro URL : https://patchwork.freedesktop.org/series/15393/ State : success == Summary == Series 15393v1 Remove __I915__ magic macro https://patchwork.freedesktop.org/api/1.0/series/15393/revisions/1/mb

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Mark all non-vma being inserted into the address spaces

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 03:31:54PM +0200, Joonas Lahtinen wrote: > On to, 2016-11-17 at 12:08 +, Chris Wilson wrote: > > We need to distinguish between full i915_vma structs and simple > > drm_mm_nodes when considering eviction (i.e. we must be careful not to > > treat a mere drm_mm_node as a m

Re: [Intel-gfx] [PATCH v2 13/15] drm/i915: dev_priv cleanup in intel_display.c

2016-11-17 Thread Maarten Lankhorst
Op 16-11-16 om 13:32 schreef Tvrtko Ursulin: > From: Tvrtko Ursulin > > v2: Rebase. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/i915_drv.c | 2 +- > drivers/gpu/drm/i915/i915_drv.h | 3 +- > drivers/gpu/drm/i915/intel_display.c | 167 > +++---

Re: [Intel-gfx] [PATCH 11/15] drm/i915: dev_priv cleanup in intel_dp.c

2016-11-17 Thread Maarten Lankhorst
Op 16-11-16 om 09:55 schreef Tvrtko Ursulin: > From: Tvrtko Ursulin > > And as usual a little bit of cascaded function prototype changes. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/intel_display.c | 6 +++--- > drivers/gpu/drm/i915/intel_dp.c | 26 +++---

Re: [Intel-gfx] [PATCH] drm/i915: Demote i915_gem_open() debugging from DRIVER to USER

2016-11-17 Thread Tvrtko Ursulin
On 09/11/2016 10:45, Chris Wilson wrote: We use DRM_DEBUG() when reporting on user actions, to try and keep intentional errors out of the CI dmesg. Demote the debug from i915_gem_open() similarly so that it is only apparent with drm.debug & 1 like its brethren. Signed-off-by: Chris Wilson ---

Re: [Intel-gfx] [PATCH] drm/i915: Remove stolen object spam

2016-11-17 Thread Chris Wilson
On Wed, Nov 16, 2016 at 12:36:12PM +, Tvrtko Ursulin wrote: > On 16/11/2016 12:26, Chris Wilson wrote: > >We don't spam the debug when we create a normal object, nor when we > >allocate their pages. Yet we do for stolen objects, and since these are > >quite frequently used (at least once per co

Re: [Intel-gfx] [PATCH] drm/i915: Demote i915_gem_open() debugging from DRIVER to USER

2016-11-17 Thread Chris Wilson
On Thu, Nov 17, 2016 at 02:13:36PM +, Tvrtko Ursulin wrote: > > On 09/11/2016 10:45, Chris Wilson wrote: > >We use DRM_DEBUG() when reporting on user actions, to try and keep > >intentional errors out of the CI dmesg. Demote the debug from > >i915_gem_open() similarly so that it is only appare

Re: [Intel-gfx] [PATCH 0/7] Pipe config debug dump diet

2016-11-17 Thread Maarten Lankhorst
Op 17-11-16 om 13:30 schreef Tvrtko Ursulin: > From: Tvrtko Ursulin > > My Nth attempt to trim this by merging some short lines together and also by > not dumping data not relevant for the platform at hand. > > On Skylake it saves six lines from a typical modesetting dump, from 26: > > [i915]] [C

[Intel-gfx] [PATCH] drm: Define drm_mm_for_each_node_in_range()

2016-11-17 Thread Chris Wilson
Some clients would like to iterate over every node within a certain range. Make a nice little macro for them to hide the mixing of the rbtree search and linear walk. v2: Blurb Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: dri-de...@lists.freedesktop.org --- drivers/gpu/drm/drm_mm.c | 11 ++

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Fix cdclk vs. dev_cdclk mess when not recomputing things

2016-11-17 Thread Joseph Yasi
On Thu, Nov 17, 2016 at 3:17 AM, Paul Bolle wrote: > On Mon, 2016-11-14 at 18:35 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > When we end up not recomputing the cdclk, we need to populate > > intel_state->cdclk with the "atomic_cdclk_freq" instead of the > > curren

[Intel-gfx] [PATCH i-g-t v6 00/21] Implement sw_sync test

2016-11-17 Thread robert . foss
From: Robert Foss This series implements the sw_sync test and the lib/sw_sync helper functions for said test. The sw_sync subtests range from very basic tests of the sw_sync functionality, to stress testing and randomized tests. Changes since v1: Added "Reviewed-by: Eric Engestrom " tag l

[Intel-gfx] [PATCH i-g-t v6 01/21] lib/sw_sync: Add helper functions for managing synchronization primitives

2016-11-17 Thread robert . foss
From: Robert Foss Base functions to help testing the Sync File Framework (explicit fencing mechanism ported from Android). These functions allow you to create, use and destroy timelines and fences. Signed-off-by: Robert Foss Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom --- lib/

[Intel-gfx] [PATCH i-g-t v6 04/21] tests/sw_sync: Add subtest test_alloc_fence_invalid_timeline

2016-11-17 Thread robert . foss
From: Robert Foss This subtests tests that creating fences on negative timelines fail. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index 8f6208b..75bd471 100644 --- a/te

[Intel-gfx] [PATCH i-g-t v6 06/21] tests/sw_sync: Add subtest test_sync_busy

2016-11-17 Thread robert . foss
From: Robert Foss This subtest verifies that waiting on fences works properly. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 37 + 1 file changed, 37 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index ecc75ca.

[Intel-gfx] [PATCH i-g-t v6 12/21] tests/sw_sync: Add subtest test_sync_multi_timeline_wait

2016-11-17 Thread robert . foss
From: Robert Foss This subtest verifies that waiting, timing out on a wait and that counting fences in various states works. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 66 + 1 file changed, 66 insertions

[Intel-gfx] [PATCH i-g-t v6 07/21] tests/sw_sync: Add subtest test_sync_merge

2016-11-17 Thread robert . foss
From: Robert Foss Add subtest test_sync_merge that tests merging fences and the validity of the resulting merged fence. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 67 + 1 file changed, 67 insertions(+)

[Intel-gfx] [PATCH i-g-t v6 09/21] tests/sw_sync: Add subtest test_sync_multi_consumer

2016-11-17 Thread robert . foss
From: Robert Foss This subtest verifies the access ordering of multiple consumer threads. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 103 1 file changed, 103 insertions(+) diff --git a/tests/sw_sync.c

[Intel-gfx] [PATCH i-g-t v6 03/21] tests/sw_sync: Add subtest test_alloc_fence

2016-11-17 Thread robert . foss
From: Robert Foss Add subtest alloc_fence that verifies that it's possible to allocate a fence on a timeline. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 16 1 file changed, 16 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c inde

[Intel-gfx] [PATCH i-g-t v6 10/21] tests/sw_sync: Add subtest test_sync_multi_consumer_producer

2016-11-17 Thread robert . foss
From: Robert Foss This test verifies that stressing the kernel by creating multiple consumer/producer threads that wait on a single timeline to be incremented by another conumer/producer thread does not fail. And that the order amongst the threads is maintained. Signed-off-by: Robert Foss Revie

[Intel-gfx] [PATCH i-g-t v6 05/21] tests/sw_sync: Add subtest test_alloc_merge_fence

2016-11-17 Thread robert . foss
From: Robert Foss This subtest verifies that merging two fences works in the simples possible case. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index 7

[Intel-gfx] [PATCH i-g-t v6 15/21] tests/sw_sync: Add subtest test_timeline_closed

2016-11-17 Thread robert . foss
From: Robert Foss This subtest verifies that the fences of a timeline are not signalled when a timelne is closed. Signed-off-by: Robert Foss --- tests/sw_sync.c | 17 + 1 file changed, 17 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index 65416ad..f19eaa8 10064

[Intel-gfx] [PATCH i-g-t v6 11/21] tests/sw_sync: Add subtest test_sync_random_merge

2016-11-17 Thread robert . foss
From: Robert Foss This subtest verifies that creating many timelines and merging random fences from each timeline with eachother results in merged fences that are fully functional. Signed-off-by: Robert Foss Reviewed-by: Eric Engestrom --- tests/sw_sync.c | 73

[Intel-gfx] [PATCH i-g-t v6 16/21] tests/sw_sync: Add subtest test_timeline_closed_signaled

2016-11-17 Thread robert . foss
From: Robert Foss Add subtest test_timeline_closed_signaled that verifies that a signaled fence stays signaled after its timeline has been closed. Signed-off-by: Robert Foss --- tests/sw_sync.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_s

[Intel-gfx] [PATCH i-g-t v6 14/21] tests/sw_sync: Add subtest test_sync_expired_merge

2016-11-17 Thread robert . foss
From: Rafael Antognolli This test creates an already expired fence, then creates a merged fence out of that expired one (passed twice to the merge operation), and finally closes the merged fence. It shows that if the refcounts are wrong on the original expired fence, it might get freed while stil

[Intel-gfx] [PATCH i-g-t v6 17/21] lib/sw_sync: Add igt_require_sw_sync to enable skipping on no sw_sync support

2016-11-17 Thread robert . foss
From: Robert Foss Add igt_require_sw_sync to provide tests to skip if sw_sync support isn't available on the host machine. Signed-off-by: Robert Foss --- lib/sw_sync.c | 22 ++ lib/sw_sync.h | 1 + 2 files changed, 23 insertions(+) diff --git a/lib/sw_sync.c b/lib/sw_sync

[Intel-gfx] [PATCH i-g-t v6 21/21] tests/sw_sync: Add subtest test_sync_busy_unixsocket

2016-11-17 Thread robert . foss
From: Robert Foss Add subtest test_sync_busy_fork which increments the timeline in a forked child process, where the timeline fd has been sent through a UNIX socket. Signed-off-by: Robert Foss --- tests/sw_sync.c | 103 1 file changed, 1

[Intel-gfx] [PATCH i-g-t v6 18/21] tests/sw_sync: Add igt_require check for sw_sync feature

2016-11-17 Thread robert . foss
From: Robert Foss Make sure that this test is skipped if the sw_sync feature is missing from the host system. Signed-off-by: Robert Foss --- lib/sw_sync.c | 1 + tests/sw_sync.c | 3 +++ 2 files changed, 4 insertions(+) diff --git a/lib/sw_sync.c b/lib/sw_sync.c index 38fe670..ac793ad 10064

[Intel-gfx] [PATCH i-g-t v6 20/21] tests/sw_sync: Add subtest test_sync_busy_fork

2016-11-17 Thread robert . foss
From: Robert Foss Add subtest test_sync_busy_fork which increments the timeline in a forked child process. Signed-off-by: Robert Foss --- tests/sw_sync.c | 39 +++ 1 file changed, 39 insertions(+) diff --git a/tests/sw_sync.c b/tests/sw_sync.c index d60fb32

  1   2   >