[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config (rev2)

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915/bxt: Fix PHY init with partial BIOS config (rev2) URL : https://patchwork.freedesktop.org/series/6010/ State : failure == Summary == Series 6010v2 drm/i915/bxt: Fix PHY init with partial BIOS config http://patchwork.freedesktop.org/api/1.0/series/6010/revi

[Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Chris Wilson
When releasing the intel_fbdev, we should unpin the framebuffer that we pinned during construction. Signed-off-by: Chris Wilson --- I'm hoping this explains some of the flip-flip in DMESG-WARN for drv_module_reload_basic... -Chris --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.BAT: warning for Pre-calculate SKL-style atomic watermarks (rev3)

2016-04-22 Thread Patchwork
== Series Details == Series: Pre-calculate SKL-style atomic watermarks (rev3) URL : https://patchwork.freedesktop.org/series/5158/ State : warning == Summary == Series 5158v3 Pre-calculate SKL-style atomic watermarks http://patchwork.freedesktop.org/api/1.0/series/5158/revisions/3/mbox/ Test

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Add support for new aspect ratios

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 10:58:34AM +0530, Sharma, Shashank wrote: > Thanks for the review Daniel. > My comments inline. > > Regards > Shashank > On 4/21/2016 8:34 PM, Daniel Vetter wrote: > >On Fri, Mar 25, 2016 at 01:47:35PM +0530, Shashank Sharma wrote: > >>HDMI 2.0/CEA-861-F introduces two new

Re: [Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: > Daniel, > > Thanks a lot for the quick reply! > > On 20 Apr 01:34 PM, Daniel Vetter wrote: > > On Tue, Apr 19, 2016 at 02:31:13PM -0300, Ezequiel Garcia wrote: > > > Currently, our implementation of drm_connector_funcs.detect is >

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915/fbdev: Call intel_unpin_fb_obj() on release URL : https://patchwork.freedesktop.org/series/6137/ State : warning == Summary == Series 6137v1 drm/i915/fbdev: Call intel_unpin_fb_obj() on release http://patchwork.freedesktop.org/api/1.0/series/6137/revisions

Re: [Intel-gfx] [PATCH] libdrm/fourcc: Add formats R8, RG88, GR88

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 08:44:36PM +0300, Hwang, Dongseong wrote: > Ok, I'll send new patch with the commit and tree. You can't do that yet since the commit hasn't landed in upstream. Taking a sha1 from your own tree is useless. My point of noting the sha1 is that it must be from a non-rebasing tr

Re: [Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

2016-04-22 Thread Ville Syrjälä
On Fri, Apr 22, 2016 at 10:15:20AM +0200, Daniel Vetter wrote: > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: > > Daniel, > > > > Thanks a lot for the quick reply! > > > > On 20 Apr 01:34 PM, Daniel Vetter wrote: > > > On Tue, Apr 19, 2016 at 02:31:13PM -0300, Ezequiel Garcia

[Intel-gfx] [PATCH v3] drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf

2016-04-22 Thread tim . gore
From: Tim Gore This patch applies a performance enhancement workaround based on analysis of DX and OCL S-Curve workloads. We increase the General Priority Credits for L3SQ from the hardware default of 56 to the max value 62, and decrease the High Priority credits from 8 to 2. v2: Only apply to B

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Tvrtko Ursulin
On 22/04/16 08:47, Chris Wilson wrote: When releasing the intel_fbdev, we should unpin the framebuffer that we pinned during construction. Signed-off-by: Chris Wilson --- I'm hoping this explains some of the flip-flip in DMESG-WARN for drv_module_reload_basic... -Chris --- drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH] lib: Always NUL terminate ucs2_as_utf8

2016-04-22 Thread Matt Fleming
( Good Lord, I hate doing string manipulation in C ) On Wed, 20 Apr, at 03:25:32PM, Laszlo Ersek wrote: > > So, "len" does not include the room for the terminating NUL-byte here. > When "len" is passed to ucs2_as_utf8(), with the proposed patch applied, > a NUL byte will be produced in "name", bu

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 09:47:47AM +0100, Tvrtko Ursulin wrote: > > On 22/04/16 08:47, Chris Wilson wrote: > >When releasing the intel_fbdev, we should unpin the framebuffer that we > >pinned during construction. > > > >Signed-off-by: Chris Wilson > >--- > >I'm hoping this explains some of the fl

[Intel-gfx] [PATCH i-g-t] lib: Actually use provided size when creating BO

2016-04-22 Thread Tomeu Vizoso
When reworking igt_create_fb_with_bo_size to use igt_create_bo_with_dimensions, we mistakenly stopped acknowledging non-zero size parameters. To fix this, we move the core of the code to create_bo_for_fb and teach it to use the GEM APIs when a size is passed. igt_create_bo_with_dimensions ends up

Re: [Intel-gfx] [PATCH] kms_atomic: Fix crtc_id comparison failing.

2016-04-22 Thread Marius Vlad
You've already sent this yesterday. Its pushed. On Thu, Apr 21, 2016 at 10:24:28PM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Fixed ctrc_id comparison failing due to bad initialization of > crtc variable. > > Signed-off-by: Robert Foss > --- > tests/kms_atomic.c | 2 +- >

[Intel-gfx] ✗ Fi.CI.BAT: warning for lib: Always NUL terminate ucs2_as_utf8

2016-04-22 Thread Patchwork
== Series Details == Series: lib: Always NUL terminate ucs2_as_utf8 URL : https://patchwork.freedesktop.org/series/5969/ State : warning == Summary == Series 5969v1 lib: Always NUL terminate ucs2_as_utf8 http://patchwork.freedesktop.org/api/1.0/series/5969/revisions/1/mbox/ Test kms_flip:

[Intel-gfx] [PATCH i-g-t] tests/kms_sink_crc_basic: clean up assert_color and provide more details

2016-04-22 Thread Jani Nikula
We can simply sscanf the crc in one go. Also split up the igt asserts to get better details about what went wrong. Signed-off-by: Jani Nikula --- tests/kms_sink_crc_basic.c | 36 ++-- 1 file changed, 10 insertions(+), 26 deletions(-) diff --git a/tests/kms_sink_c

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) URL : https://patchwork.freedesktop.org/series/5990/ State : warning == Summary == Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf http://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Simplify i915_gem_obj_ggtt_bound_view

2016-04-22 Thread Dave Gordon
On 21/04/16 13:04, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Can use the new vma->is_gtt to simplify the check and get rid of the local variables. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_gem.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-22 Thread Matthew Auld
From: Chris Wilson Propagate the real error from drm_gem_object_init(). Note this also fixes some confusion in the error return from i915_gem_alloc_object... v2: (Matthew Auld) - updated new users of gem_alloc_object from latest drm-nightly - replaced occurrences of IS_ERR_OR_NULL() with IS_

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-04-22 Thread Robert Bragg
On Wed, Apr 20, 2016 at 11:46 PM, Chris Wilson wrote: > On Wed, Apr 20, 2016 at 03:23:10PM +0100, Robert Bragg wrote: > > +static void gen7_init_oa_buffer(struct drm_i915_private *dev_priv) > > +{ > > + /* Pre-DevBDW: OABUFFER must be set with counters off, > > + * before OASTATUS1, but

[Intel-gfx] [PATCH 2/3] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-22 Thread Matthew Auld
If we are not in FULL_48BIT_PPGTT mode then we really shouldn't continue on with our allocations, given that the call to free_pdp would bail early without freeing everything, thus leaking memory. v2: (Joonas Lahtinen) - tidy up with goto teardown path Cc: Chris Wilson Cc: Joonas Lahtinen Sign

[Intel-gfx] [PATCH] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-22 Thread Matthew Auld
Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt. v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen) Cc: Joonas Lahtinen Signed-off-by: Matthew Auld Reviewed-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 delet

Re: [Intel-gfx] [PATCH 5/9] drm/i915: Enable i915 perf stream for Haswell OA unit

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 12:04:26PM +0100, Robert Bragg wrote: >On Wed, Apr 20, 2016 at 11:46 PM, Chris Wilson ><[1]ch...@chris-wilson.co.uk> wrote: > > On Wed, Apr 20, 2016 at 03:23:10PM +0100, Robert Bragg wrote: > > +static void gen7_init_oa_buffer(struct drm_i915_private *dev_

[Intel-gfx] Cleanup of early quirks

2016-04-22 Thread Joonas Lahtinen
Preparatory series to de-duplicate the stolen memory calculation code which currently resides both in early-quirks.c and i915_gem_stolen.c files. Open question is how to best deliver the information from the early quirks code to the i915 driver? Adding a new E820 memory type is one obvious option,

[Intel-gfx] [PATCH 1/2] drm/i915: Canonicalize stolen memory calculations

2016-04-22 Thread Joonas Lahtinen
Move the better constructs/comments from i915_gem_stolen.c to early-quirks.c and increase readability in preparation of only having one set of functions. - intel_stolen_base -> gen3_stolen_base - use phys_addr_t instead of u32 for address for future proofing Cc: Chris Wilson Cc: Mika Kuoppala C

[Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Joonas Lahtinen
Move graphics stolen memory related early quirk into a function to allow easy adding of other graphics quirks to fix memory maps on machines running old BIOS versions. While at it; - _funcs -> _ops to follow de facto naming - make the iteration code tad more readable - remove unused variables Cc:

Re: [Intel-gfx] [PATCH] lib: Always NUL terminate ucs2_as_utf8

2016-04-22 Thread Dave Gordon
On 21/04/16 16:13, Peter Jones wrote: On Thu, Apr 21, 2016 at 01:18:27PM +0100, Matt Fleming wrote: ( Good Lord, I hate doing string manipulation in C ) (yep) On Wed, 20 Apr, at 03:25:32PM, Laszlo Ersek wrote: So, "len" does not include the room for the terminating NUL-byte here. When "le

[Intel-gfx] [PATCH 01/16] drm/i915: Introduce global id for contexts

2016-04-22 Thread sourab . gupta
From: Sourab Gupta The current context user handles are specific to drm file instance. There are some usecases, which may require a global id for the contexts. For e.g. a system level GPU profiler tool may lean upon the global context ids to associate the performance snapshots with individual con

[Intel-gfx] [PATCH 02/16] drm/i915: Constrain intel_context::global_id to 20 bits

2016-04-22 Thread sourab . gupta
From: Robert Bragg This will allow the ID to be given to the HW as the unique context identifier that's written, for example, to the context status buffer on preemption and included in reports written by the OA unit. Cc: Sourab Gupta Signed-off-by: Robert Bragg --- drivers/gpu/drm/i915/i915_g

[Intel-gfx] [PATCH 03/16] drm/i915: return ctx->global_id from intel_execlists_ctx_id()

2016-04-22 Thread sourab . gupta
From: Robert Bragg The newly added intel_context::global_id is suitable (a globally unique 20 bit ID) for giving to the hardware as a unique context identifier. Compared to using the pinned address of a logical ring context these IDs are constant for the lifetime of a context whereas a context c

[Intel-gfx] [PATCH 04/16] drm/i915: Add ctx getparam ioctl parameter to retrieve ctx global id

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch adds a new ctx getparam ioctl parameter, which can be used to retrieve ctx global_id for any particular ctx by userspace. This can be used by userspace to map the i915 perf samples with their particular ctx's, since those would be having ctx global_id's. Otherwise t

[Intel-gfx] [PATCH 05/16] drm/i915: Expose OA sample source to userspace

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch exposes a new sample source field to userspace. This field can be populated to specify the origin of the OA report. For e.g. for internally triggerred reports (non MI_RPC reports), the RPT_ID field has bitfields for specifying the origin such as timer, or render ctx

[Intel-gfx] [PATCH 00/16] Framework to collect command stream gpu metrics using i915 perf

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This series adds framework for collection of gpu performance metrics associated with the command stream of a particular engine. These metrics include OA reports, timestamps, mmio metrics, etc. These metrics are are collected around batchbuffer boundaries. This work utilizes th

[Intel-gfx] [PATCH 10/16] drm/i915: Add support for having pid output with OA report

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch introduces flags and adds support for having pid output with the OA reports generated through the RCS commands. When the stream is opened with pid sample type, the pid information is also captured through the command stream samples and forwarded along with the OA re

[Intel-gfx] [PATCH 14/16] drm/i915: Support opening multiple concurrent perf streams

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch adds support for opening multiple concurrent perf streams for different gpu engines, while having the restriction to open only a single stream open for a particular gpu engine. This enables userspace client to open multiple streams, one per engine, at any time to cap

[Intel-gfx] [PATCH 07/16] drm/i915: flush periodic samples, in case of no pending CS sample requests

2016-04-22 Thread sourab . gupta
From: Sourab Gupta When there are no pending CS OA samples, flush the periodic OA samples collected so far. We can safely forward the periodic OA samples in the case we have no pending CS samples, but we can't do so in the case we have pending CS samples, since we don't know what the ordering be

[Intel-gfx] [PATCH 11/16] drm/i915: Add support for emitting execbuffer tags through OA counter reports

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch enables userspace to specify tags (per workload), provided via execbuffer ioctl, which could be added to OA reports, to help associate reports with the corresponding workloads. There may be multiple stages within a single context, from a userspace perspective. An ab

[Intel-gfx] [PATCH 06/16] drm/i915: Framework for capturing command stream based OA reports

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch introduces a framework to enable OA counter reports associated with Render command stream. We can then associate the reports captured through this mechanism with their corresponding context id's. This can be further extended to associate any other metadata informatio

[Intel-gfx] [PATCH 08/16] drm/i915: Handle the overflow condition for command stream buf

2016-04-22 Thread sourab . gupta
From: Sourab Gupta Add a compile time option for detecting the overflow condition of command stream buffer, and not overwriting the old entries in such a case. Also, set a status flag to forward the overflow condition to userspace if overflow is detected. Signed-off-by: Sourab Gupta --- driver

[Intel-gfx] [PATCH 13/16] drm/i915: Extract raw GPU timestamps from OA reports to forward in perf samples

2016-04-22 Thread sourab . gupta
From: Sourab Gupta The OA reports contain the least significant 32 bits of the gpu timestamp. This patch enables retrieval of the timestamp field from OA reports, to forward as 64 bit raw gpu timestamps in the perf samples. Signed-off-by: Sourab Gupta --- drivers/gpu/drm/i915/i915_drv.h | 1

[Intel-gfx] [PATCH 15/16] drm/i915: Mechanism to forward clock monotonic time in perf samples

2016-04-22 Thread sourab . gupta
From: Sourab Gupta Currently, we have the ability to only forward the GPU timestamps in the samples (which are generated via OA reports or PIPE_CONTROL commands inserted in the ring). This limits the ability to correlate these samples with the system events. If we scale the GPU timestamps accordi

[Intel-gfx] [PATCH 09/16] drm/i915: Populate ctx ID for periodic OA reports

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This adds support for populating the ctx id for the periodic OA reports when requested through the corresponding property. For Gen8, the OA reports itself have the ctx ID and it is the one programmed into HW while submitting workloads. Thus it's retrieved from reports itself.

[Intel-gfx] [PATCH 12/16] drm/i915: Extend i915 perf framework for collecting timestamps on all gpu engines

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch extends the i915 perf framework to handle the perf sample collection for any given gpu engine. Particularly, the support for collecting timestamp sample type is added, which can be requested for any engine. With this, for RCS, timestamps and OA reports can be collec

[Intel-gfx] [PATCH 16/16] drm/i915: Support for capturing MMIO register values

2016-04-22 Thread sourab . gupta
From: Sourab Gupta This patch adds support for capturing MMIO register values through i915 perf interface. The userspace can request upto 8 MMIO register values to be dumped. The addresses of these registers can be passed through the corresponding property 'value' field while opening the stream.

[Intel-gfx] [PATCH v2 2/3] drm/i915: Correct the i915_frequency_info debugfs output

2016-04-22 Thread akash . goel
From: Akash Goel There are certain registers, which captures the time elapsed in the in current Up/Down EI, for how long GT has been Idle/Busy/Avg in the current Up/Down EI and also in the previous Up/Down EI. These register values are reported by the i915_frequency_info debugfs interface. The Dr

[Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread akash . goel
From: Akash Goel Added a new GT_PM_INTERVAL_TO_US macro to perform the platform specific conversion of PM time interval values to microseconds unit. Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/i915_reg.h | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v2 3/3] drm/i915/bxt: Explicitly clear the Turbo control register

2016-04-22 Thread akash . goel
From: Akash Goel As a part of WaGsvDisableTurbo, Driver makes an early exit from the Gen9 Turbo enabling function, so doesn't program the Turbo Control register. But BIOS could leave the Hw Turbo as enabled, so need to explicitly clear out the Control register just to avoid inconsitency with debu

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Canonicalize stolen memory calculations

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 02:25:06PM +0300, Joonas Lahtinen wrote: > Move the better constructs/comments from i915_gem_stolen.c to > early-quirks.c and increase readability in preparation of only > having one set of functions. > > - intel_stolen_base -> gen3_stolen_base > - use phys_addr_t instead o

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > Move graphics stolen memory related early quirk into a function to > allow easy adding of other graphics quirks to fix memory maps on > machines running old BIOS versions. > > While at it; > - _funcs -> _ops to follow de facto nami

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) URL : https://patchwork.freedesktop.org/series/5990/ State : warning == Summary == Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf http://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 05:22:24PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added a new GT_PM_INTERVAL_TO_US macro to perform the platform > specific conversion of PM time interval values to microseconds unit. > > Signed-off-by: Akash Goel Reviewed-by: Chris Wilson -Chris --

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Tvrtko Ursulin
On 22/04/16 10:00, Chris Wilson wrote: On Fri, Apr 22, 2016 at 09:47:47AM +0100, Tvrtko Ursulin wrote: On 22/04/16 08:47, Chris Wilson wrote: When releasing the intel_fbdev, we should unpin the framebuffer that we pinned during construction. Signed-off-by: Chris Wilson --- I'm hoping this e

Re: [Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-22 Thread Dave Gordon
On 22/04/16 11:57, Matthew Auld wrote: From: Chris Wilson Propagate the real error from drm_gem_object_init(). Note this also fixes some confusion in the error return from i915_gem_alloc_object... v2: (Matthew Auld) - updated new users of gem_alloc_object from latest drm-nightly - replac

Re: [Intel-gfx] [PATCH v2 2/3] drm/i915: Correct the i915_frequency_info debugfs output

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 05:22:25PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > There are certain registers, which captures the time elapsed in the > in current Up/Down EI, for how long GT has been Idle/Busy/Avg in the > current Up/Down EI and also in the previous Up/Down EI. > These

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:55 +0100, Chris Wilson wrote: > On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > > > > Move graphics stolen memory related early quirk into a function to > > allow easy adding of other graphics quirks to fix memory maps on > > machines running old BIOS ver

Re: [Intel-gfx] [PATCH] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 12:59:12PM +0100, Tvrtko Ursulin wrote: > > On 22/04/16 10:00, Chris Wilson wrote: > >Something about CI results being hidden and not seeing the same failures > >locally... > > Didn't really understand any of that. Is think blocking the > premature unpin series? Is the war

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 03:07:42PM +0300, Joonas Lahtinen wrote: > On pe, 2016-04-22 at 12:55 +0100, Chris Wilson wrote: > > On Fri, Apr 22, 2016 at 02:25:07PM +0300, Joonas Lahtinen wrote: > > > > > > Move graphics stolen memory related early quirk into a function to > > > allow easy adding of ot

[Intel-gfx] [PATCH v2 2/2] drm/i915: Function per early graphics quirk

2016-04-22 Thread Joonas Lahtinen
Move graphics stolen memory related early quirk into a function to allow easy adding of other graphics quirks to fix memory maps on machines running old BIOS versions. While at it; - _funcs -> _ops to follow de facto naming - make the iteration code tad more readable - remove unused variables Cc:

[Intel-gfx] [PATCH v2 1/2] drm/i915: Canonicalize stolen memory calculations

2016-04-22 Thread Joonas Lahtinen
Move the better constructs/comments from i915_gem_stolen.c to early-quirks.c and increase readability in preparation of only having one set of functions. - intel_stolen_base -> gen3_stolen_base - use phys_addr_t instead of u32 for address for future proofing v2: - Print the invalid register value

Re: [Intel-gfx] [PATCH] drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:09 +0100, Matthew Auld wrote: > Remove dev local and use to_i915() in gen8_ppgtt_notify_vgt. > > v2: use dev_priv directly for QUESTION_MACROS (Joonas Lahtinen) > > Cc: Joonas Lahtinen > Signed-off-by: Matthew Auld > Reviewed-by: Joonas Lahtinen Merged, thanks for the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt URL : https://patchwork.freedesktop.org/series/6152/ State : failure == Summary == Series 6152v1 drm/i915: use dev_priv directly in gen8_ppgtt_notify_vgt http://patchwork.freedesktop.org/api/1.0/series/6152/r

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib/igt_kms: Make sure that default planes aren't overwritten.

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 01:31:48PM -0400, Robert Foss wrote: > > > On 04/21/2016 10:50 AM, Daniel Vetter wrote: > >On Wed, Apr 20, 2016 at 10:59:45AM -0400, robert.f...@collabora.com wrote: > >>From: Robert Foss > >> > >>Avoid overwriting planes with statically asigned indices > >>with planes th

Re: [Intel-gfx] [PATCH i-g-t 4/7] lib/igt_kms: Only move the in cursor plane for Intel hw.

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 01:24:53PM -0400, Robert Foss wrote: > > > On 04/21/2016 10:48 AM, Daniel Vetter wrote: > >On Wed, Apr 20, 2016 at 10:59:46AM -0400, robert.f...@collabora.com wrote: > >>From: Robert Foss > >> > >>Avoid moving the cursor plane when on non-intel hardware. > >>Running the m

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Macros to convert PM time interval values to microseconds

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 05:22:24PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > Added a new GT_PM_INTERVAL_TO_US macro to perform the platform > specific conversion of PM time interval values to microseconds unit. > > Signed-off-by: Akash Goel Note that if you submit a new series

Re: [Intel-gfx] [PATCH i-g-t] tests: atomic: add test to verify page flip event emissions

2016-04-22 Thread Daniel Vetter
On Thu, Apr 21, 2016 at 05:01:31PM +0100, Lionel Landwerlin wrote: > It seems we don't have a test verifying events with atomic commits > yet. Here is a first step. > > Cc: Maarten Lankhorst > Signed-off-by: Lionel Landwerlin Feel like also making a testcase variant for the other cases of crtc'

Re: [Intel-gfx] [PATCH] kms_atomic: Fix crtc_id comparison failing.

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 12:54:59PM +0300, Marius Vlad wrote: > You've already sent this yesterday. Its pushed. When you push patches (especially from other people), please send out a quick confirmation mail to the mailing list. Avoids confusion like this one here. -Daniel > > On Thu, Apr 21, 201

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fixes for runtime and system suspend/resume

2016-04-22 Thread Imre Deak
On to, 2016-04-21 at 12:05 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fixes for runtime and system suspend/resume > URL   : https://patchwork.freedesktop.org/series/6009/ > State : failure > > == Summary == There was a previous email with 'success' for this same tes

[Intel-gfx] [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Chris Wilson
When tearing down the device, emit a warning if there are any contexts remaining, as they all should be freed by this point. Signed-off-by: Chris Wilson Cc: Mika Kuoppala Cc: Tvrtko Ursulin Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_gem_context.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [Intel-gfx] [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 02:03:02PM +0100, Chris Wilson wrote: > When tearing down the device, emit a warning if there are any contexts > remaining, as they all should be freed by this point. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen I guess

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config

2016-04-22 Thread Imre Deak
On to, 2016-04-21 at 12:05 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fix PHY init with partial BIOS config > URL   : https://patchwork.freedesktop.org/series/6010/ > State : failure > > == Summary == > > Series 6010v1 drm/i915/bxt: Fix PHY init with partial BIOS co

Re: [Intel-gfx] [RFC/PATCH xf86-video-intel] sna: Let modestting + glamor handle gen9+

2016-04-22 Thread Timo Aaltonen
08.04.2016, 16:21, Hans de Goede kirjoitti: > Hi, Hi, sorry for the delay.. > On 11-03-16 11:07, Timo Aaltonen wrote: >> >> I've been trying to make this work, but there are cases where it fails >> bad: >> >> # a config file with a Device section that loads 'intel' makes the >> server fail >> [

Re: [Intel-gfx] [PATCH i-g-t 3/7] lib/igt_kms: Make sure that default planes aren't overwritten.

2016-04-22 Thread Robert Foss
On 04/22/2016 08:53 AM, Daniel Vetter wrote: On Thu, Apr 21, 2016 at 01:31:48PM -0400, Robert Foss wrote: On 04/21/2016 10:50 AM, Daniel Vetter wrote: On Wed, Apr 20, 2016 at 10:59:45AM -0400, robert.f...@collabora.com wrote: From: Robert Foss Avoid overwriting planes with statically asig

Re: [Intel-gfx] [PATCH] drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 14:03 +0100, Chris Wilson wrote: > When tearing down the device, emit a warning if there are any contexts > remaining, as they all should be freed by this point. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > Cc: Tvrtko Ursulin > Cc: Joonas Lahtinen Reviewed-by: Jo

Re: [Intel-gfx] [PATCH i-g-t] tests: atomic: add test to verify page flip event emissions

2016-04-22 Thread Lionel Landwerlin
On 22/04/16 13:59, Daniel Vetter wrote: On Thu, Apr 21, 2016 at 05:01:31PM +0100, Lionel Landwerlin wrote: It seems we don't have a test verifying events with atomic commits yet. Here is a first step. Cc: Maarten Lankhorst Signed-off-by: Lionel Landwerlin Feel like also making a testcase var

[Intel-gfx] [RFC] x86/e820: Add E820_RESERVED_GFX for graphics memory

2016-04-22 Thread Joonas Lahtinen
Add a type of memory alongside E820_RESERVED_KERN that is specifically reserved for graphics usage, E820_RESERVED_GFX. An example is Intel Gen graphics stolen memory. Cc: Chris Wilson Signed-off-by: Joonas Lahtinen --- arch/x86/include/uapi/asm/e820.h | 5 + arch/x86/kernel/e820.c

[Intel-gfx] re Fi.CI.BAT: failure for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)

2016-04-22 Thread Gore, Tim
Fi.CI.BAT: failure output (BAT didn't send me an email - at least not yet. Cut and pasted from patchwork archive) > Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) > URL : https://patchwork.freedesktop.org/series/5990/ > State : failure > Series 5990v4 drm/i915:bxt: im

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2)

2016-04-22 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2) URL : https://patchwork.freedesktop.org/series/6153/ State : warning == Summary == Series 6153v2 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/6153/re

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config (rev2)

2016-04-22 Thread Imre Deak
On pe, 2016-04-22 at 07:27 +, Patchwork wrote: > == Series Details == > > Series: drm/i915/bxt: Fix PHY init with partial BIOS config (rev2) > URL   : https://patchwork.freedesktop.org/series/6010/ > State : failure > Thanks for the review I pushed the patchset to -dinq. Explanation for the f

Re: [Intel-gfx] [PATCH] drm/i915: Propagate error from drm_gem_object_init()

2016-04-22 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:59 +0100, Dave Gordon wrote: > On 22/04/16 11:57, Matthew Auld wrote: > > > > From: Chris Wilson > > > > Propagate the real error from drm_gem_object_init(). Note this also > > fixes some confusion in the error return from i915_gem_alloc_object... > > > > v2: > > (Matthe

[Intel-gfx] [PATCH i-g-t v2 4/6] lib/igt_kms: Switch to verbose assert.

2016-04-22 Thread robert . foss
From: Robert Foss Switch igt_assert to igt_assert_lte to provide more diagnostic information. Signed-off-by: Robert Foss --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 5751913..99b6279 100644 --- a/lib/igt_kms.c +++ b/l

[Intel-gfx] [PATCH i-g-t v2 5/6] kms_flip_event_leak: Enable test on DRIVER_ANY.

2016-04-22 Thread robert . foss
From: Robert Foss Change DRIVER_INTEL to DRIVER_ANY to enable tests/kms_flip_event_leak on any driver. Switch the tiling format to something intel indenpendant. Signed-off-by: Robert Foss --- tests/kms_flip_event_leak.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t v2 2/6] lib/igt_kms: Add support for up to 10 planes.

2016-04-22 Thread robert . foss
From: Robert Foss Increase the number of planes supported to 10. kmstest_plane_name only previously supported 4 planes, this patch adds support for up to 10 planes. Signed-off-by: Robert Foss --- lib/igt_kms.c | 6 ++ lib/igt_kms.h | 11 ++- 2 files changed, 16 insertions(+), 1 d

[Intel-gfx] [PATCH i-g-t v2 0/6] kms_flip_event_leak and kms_vblank fixes for VC4

2016-04-22 Thread robert . foss
From: Robert Foss Changes since v1: - Removed un-used members of data_t struct in kms_vblank.c. - Renamed plane_counter to n_planes. - Removed un-needed handling CURSOR plane location. - Added names for additional planes in update kmstest_plane_name. Robert Foss (6): lib/igt_kms: Move IGT_MAX

[Intel-gfx] [PATCH i-g-t v2 1/6] lib/igt_kms: Move IGT_MAX_PLANES into the igt_plane enum

2016-04-22 Thread robert . foss
From: Robert Foss Makes sure we automatically extend that when adding more planes. Inspired by a patch from Robert Foss who extended the max, but forgot all about the enum. While at it, also fix up the whitespace damage. Cc: robert.f...@collabora.com Author: Daniel Vetter Signed-off-by: Daniel

[Intel-gfx] [PATCH i-g-t v2 6/6] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-04-22 Thread robert . foss
From: Robert Foss Previously crtc0 was statically used for VBLANK tests, but that assumption is not valid for the VC4 platform. Instead we're now explicitly setting the mode. Also add support for testing all connected connectors during the same test. Signed-off-by: Robert Foss --- tests/kms_v

[Intel-gfx] [PATCH i-g-t v2 3/6] lib/igt_kms: Fix plane counting in igt_display_init.

2016-04-22 Thread robert . foss
From: Robert Foss Fix issue where the plane counting fails due to the number and configuration of planes being unlike the intel configuration. Signed-off-by: Robert Foss --- lib/igt_kms.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c in

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Fix PHY init with partial BIOS config (rev2)

2016-04-22 Thread Ville Syrjälä
On Fri, Apr 22, 2016 at 04:37:29PM +0300, Imre Deak wrote: > On pe, 2016-04-22 at 07:27 +, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915/bxt: Fix PHY init with partial BIOS config (rev2) > > URL   : https://patchwork.freedesktop.org/series/6010/ > > State : failure > > >

Re: [Intel-gfx] [PATCH v2 15/16] drm/i915/gen9: Reject display updates that exceed wm limitations

2016-04-22 Thread Lyude Paul
Unfortunately dropping that patch just results with the screen staying blank starting from the moment the driver loads.  As for the external monitors question: the only time this issue seems to happen with this patchset is when there's no external monitors connected. If I boot with just the laptop

Re: [Intel-gfx] [PATCH] drm/i915: Make RPS EI/thresholds multiple of 25 on SNB

2016-04-22 Thread Ville Syrjälä
On Thu, Apr 21, 2016 at 02:20:35PM +0200, Patrik Jakobsson wrote: > On Wed, Apr 20, 2016 at 04:43:56PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Somehow my SNB GT1 (Dell XPS 8300) gets very unhappy around > > GPU hangs if the RPS EI/thresholds aren't suitably ali

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Warn there are any unfreed contexts when we shutdown

2016-04-22 Thread Patchwork
== Series Details == Series: drm/i915: Warn there are any unfreed contexts when we shutdown URL : https://patchwork.freedesktop.org/series/6157/ State : failure == Summary == Series 6157v1 drm/i915: Warn there are any unfreed contexts when we shutdown http://patchwork.freedesktop.org/api/1.0/s

[Intel-gfx] [PATCH i-g-t 2/2] kms_pipe_crc_basic: Rename test to kms_pipe_crc

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Previous patch has marked individual subtests as basic so now rename the test binary name accordingly. Signed-off-by: Tvrtko Ursulin --- tests/Makefile.sources | 2 +- tests/kms_pipe_crc.c | 246 + tests/kms_pipe_crc_

[Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin I would argue it is enough to test one pipe in the BAT set. Signed-off-by: Tvrtko Ursulin --- tests/kms_pipe_crc_basic.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/tests/kms_pipe_crc_basic.c b/tests/kms_pipe_crc_basic.c in

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-22 Thread Chris Wilson
On Fri, Apr 22, 2016 at 03:41:55PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I would argue it is enough to test one pipe in the BAT set. > > Signed-off-by: Tvrtko Ursulin > --- > tests/kms_pipe_crc_basic.c | 23 +-- > 1 file changed, 13 insertions(+), 10 delet

[Intel-gfx] [PATCH i-g-t 2/2] kms_flip: Run basic tests only on one pipe

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It brings enough value for the basic test set to check one connector with one pipe only, rather every connector with all possible pipes. Signed-off-by: Tvrtko Ursulin --- tests/kms_flip.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t 1/2] kms_flip: Shorten basic tests a bit

2016-04-22 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Seems like an overkill for a basic test to keep flipping for a full minute. Dial it down a bit. Signed-off-by: Tvrtko Ursulin --- tests/kms_flip.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/kms_flip.c b/tests/kms_flip.c index 3d445440

Re: [Intel-gfx] [PATCH] drm: i915: Improve behavior in case of broken HDMI EDID

2016-04-22 Thread Ezequiel Garcia
On 22 Apr 10:15 AM, Daniel Vetter wrote: > On Thu, Apr 21, 2016 at 03:13:51PM -0300, Ezequiel Garcia wrote: > > Daniel, > > > > Thanks a lot for the quick reply! > > > > On 20 Apr 01:34 PM, Daniel Vetter wrote: > > > On Tue, Apr 19, 2016 at 02:31:13PM -0300, Ezequiel Garcia wrote: > > > > Current

Re: [Intel-gfx] [PATCH v6 00/34] GPU scheduler for i915 driver

2016-04-22 Thread John Harrison
This patch series can be pulled from 'ssh://people.freedesktop.org/~johnharr/scheduler' as the 'scheduler' branch. On 20/04/2016 18:13, john.c.harri...@intel.com wrote: From: John Harrison Implemented a batch buffer submission scheduler for the i915 DRM driver. The general theory of operat

Re: [Intel-gfx] [PATCH v7 0/8] Convert requests to use struct fence

2016-04-22 Thread John Harrison
This patch series can be pulled from 'ssh://people.freedesktop.org/~johnharr/scheduler' as the 'fence' branch. On 20/04/2016 18:09, john.c.harri...@intel.com wrote: From: John Harrison There is a construct in the linux kernel called 'struct fence' that is intended to keep track of work that

[Intel-gfx] ✓ Fi.CI.BAT: success for lib: Always NUL terminate ucs2_as_utf8

2016-04-22 Thread Patchwork
== Series Details == Series: lib: Always NUL terminate ucs2_as_utf8 URL : https://patchwork.freedesktop.org/series/5969/ State : success == Summary == Series 5969v1 lib: Always NUL terminate ucs2_as_utf8 http://patchwork.freedesktop.org/api/1.0/series/5969/revisions/1/mbox/ bdw-nuci7

Re: [Intel-gfx] [isg-gms] [PATCH] drm/i915: Get audio power domain during initial hw readout (v2)

2016-04-22 Thread Xiong, James
-Original Message- From: isg-gms-requ...@eclists.intel.com [mailto:isg-gms-requ...@eclists.intel.com] On Behalf Of Paauwe, Bob J Sent: Wednesday, April 20, 2016 1:38 PM To: isg-gms ; intel-gfx Cc: Paauwe, Bob J ; Ville Syrjälä Subject: [isg-gms] [PATCH] drm/i915: Get audio power doma

  1   2   >