[Intel-gfx] ✗ failure: Fi.CI.BAT

2016-01-14 Thread Patchwork
== Summary == Built on 8fb2feecca499d11e104264071ac55e273e23af5 drm-intel-nightly: 2016y-01m-14d-13h-06m-44s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: dmesg-warn -> PASS (skl-i5k-2) UNSTABLE dmesg-warn -> PASS (bdw-

[Intel-gfx] [PATCH] drm/i915: Don't do pre plane update on disabled crtcs

2016-01-14 Thread Mika Kuoppala
CI/Bat got following (shortened) trace on byt and also on bsw: [ cut here ]--- Unclaimed register detected before reading register 0x186500 Call Trace: __unclaimed_reg_debug+0x68/0x80 [i915] vlv_read32+0x2de/0x370 [i915] intel_set_memory_cxsr+0x87/0x1a0 [i915] intel_pre_plane_

[Intel-gfx] ✗ failure: Fi.CI.BAT

2016-01-14 Thread Patchwork
== Summary == HEAD is now at 8fb2fee drm-intel-nightly: 2016y-01m-14d-13h-06m-44s UTC integration manifest Applying: drm/i915/bxt: Check BIOS RC6 setup before enabling RC6 Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/i915_drv.h M drivers/gpu/drm/i915/i915_gem_

Re: [Intel-gfx] [PATCH] drm/i915: Acquire RPM wakeref for KMS atomic commit

2016-01-14 Thread Imre Deak
On la, 2015-12-19 at 09:58 +, Chris Wilson wrote: > Once all the preparations are complete, we are ready to write the > modesetting to the hardware. During this phase, we will be making > lots > of HW register access, so take a top level wakeref to prevent an > unwarranted rpm suspend cycle mid

Re: [Intel-gfx] [PATCH] drm/i915: Don't do pre plane update on disabled crtcs

2016-01-14 Thread Ville Syrjälä
On Thu, Jan 14, 2016 at 06:32:10PM +0200, Mika Kuoppala wrote: > CI/Bat got following (shortened) trace on byt and also > on bsw: > > [ cut here ]--- > Unclaimed register detected before reading register 0x186500 > Call Trace: > __unclaimed_reg_debug+0x68/0x80 [i915] > vlv_rea

Re: [Intel-gfx] [PATCH] drm/i915: Make sure DC writes are coherent on flush.

2016-01-14 Thread Francisco Jerez
Jani Nikula writes: > On Thu, 14 Jan 2016, Francisco Jerez wrote: >> We need to set the DC FLUSH PIPE_CONTROL bit on Gen7+ to guarantee >> that writes performed via the HDC are visible in memory. Fixes an >> intermittent failure in a Piglit test that writes to a BO from a >> shader using GL ato

[Intel-gfx] ✗ warning: Fi.CI.BAT

2016-01-14 Thread Patchwork
== Summary == Built on 8fb2feecca499d11e104264071ac55e273e23af5 drm-intel-nightly: 2016y-01m-14d-13h-06m-44s UTC integration manifest Test gem_storedw_loop: Subgroup basic-render: dmesg-warn -> PASS (skl-i5k-2) UNSTABLE dmesg-warn -> PASS (bdw-

Re: [Intel-gfx] [PATCH 7/7] drm/i915/skl: WA for watermark calculation based on Arbitrated Display BW

2016-01-14 Thread kbuild test robot
Hi Mahesh, [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20160114] [cannot apply to v4.4] [if your patch is applied to the wrong git tree, please drop us a note to help improving the system] url: https://github.com/0day-ci/linux/commits/Shobhit-Kumar

Re: [Intel-gfx] [PATCH] drm/i915: Hold a RPM reference during i915_driver_unload

2016-01-14 Thread Imre Deak
On ke, 2015-12-30 at 15:03 +0200, Joonas Lahtinen wrote: > Hi, > > On ti, 2015-12-29 at 12:55 +0200, Gabriel Feceoru wrote: > > This fixes an issue added with: "1f814da drm/i915: add support for > > checking > > if we hold an RPM reference", noticed while running > > drv_module_reload_basic. > >

Re: [Intel-gfx] [PATCH 7/7] drm/i915/skl: WA for watermark calculation based on Arbitrated Display BW

2016-01-14 Thread Damien Lespiau
On Thu, Jan 14, 2016 at 11:30:31PM +0800, kbuild test robot wrote: > Hi Mahesh, > > [auto build test ERROR on drm-intel/for-linux-next] > [also build test ERROR on next-20160114] > [cannot apply to v4.4] > [if your patch is applied to the wrong git tree, please drop us a note to

Re: [Intel-gfx] [PATCH 02/22] drm: Add functions to setup/tear down drm_events.

2016-01-14 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 11 January 2016 22:40:56 Daniel Vetter wrote: > An attempt at not spreading out the file_priv->event_space stuff out > quite so far and wide. And I think fixes something in ipp_get_event() > that is broken (or if they are doing something more weird/s

Re: [Intel-gfx] [PATCH 09/22] drm: Clean up pending events in the core

2016-01-14 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 11 January 2016 22:41:03 Daniel Vetter wrote: > There's really no reason to not do so, instead of replicating this > for every use-case and every driver. Now we can't just nuke the events, > since that would still mean that all drm_event users would n

Re: [Intel-gfx] [PATCH] drm: Clean up pending events in the core

2016-01-14 Thread Laurent Pinchart
Hi Daniel, On Monday 11 January 2016 14:51:46 Daniel Stone wrote: > On 10 January 2016 at 23:48, Laurent Pinchart wrote: > > On Saturday 09 January 2016 14:28:46 Daniel Vetter wrote: > >> @@ -353,18 +354,16 @@ static void drm_events_release(struct drm_file > >> *file_priv) { > >> > >> struc

Re: [Intel-gfx] [PATCH 05/22] drm: Create drm_send_event helpers

2016-01-14 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Monday 11 January 2016 22:40:59 Daniel Vetter wrote: > Use them in the core vblank code and exynos/vmwgfx drivers. > > Note that the difference between wake_up_all and _interruptible in > vmwgfx doesn't matter since the only waiter is the core code in > drm

Re: [Intel-gfx] [PATCH 1/7] drm/i915/skl+: Use proper bytes_per_pixel during WM calculation

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:42PM +0530, Shobhit Kumar wrote: > From: "Kumar, Mahesh" > > Don't always use bytes_per_pixel using y_plane=0, instead use it > according to pixel format. If NV12 use y_plane eqal to 1 > > Signed-off-by: Kumar, Mahesh The second parameter to drm_format_plane_cpp()

Re: [Intel-gfx] [PATCH 5/5] drm: Enable markdown^Wasciidoc for gpu.tmpl

2016-01-14 Thread Jani Nikula
On Tue, 12 Jan 2016, Jonathan Corbet wrote: > On Sat, 12 Dec 2015 12:13:45 +0100 > Daniel Vetter wrote: > >> I just figured there's no way this could get it, and I'd >> much rather improve the docs themselves than trying to convince core >> kernel folks that this might be useful. > > So I'm not q

[Intel-gfx] [PULL] drm-intel-next-fixes

2016-01-14 Thread Jani Nikula
Hi Dave - Our first bag of fixes for drm-next/v4.5. BR, Jani. The following changes since commit 7447a2b221cd4df3960e82478a4ee29312589611: drm/i915: Update DRIVER_DATE to 20151218 (2015-12-18 20:26:17 +0100) are available in the git repository at: git://anongit.freedesktop.org/drm-intel

Re: [Intel-gfx] [PATCH 5/5] drm: Enable markdown^Wasciidoc for gpu.tmpl

2016-01-14 Thread Jonathan Corbet
On Thu, 14 Jan 2016 22:03:26 +0200 Jani Nikula wrote: > What if we added support for some markup language as an alternative to > DocBook for the high level documentation? What if we taught kernel-doc > to output said markup natively, and included those generated pieces into > the high level docum

[Intel-gfx] [PATCH i-g-t] lib/igt_kms, tests/testdisplay: allow probing of new connector modes

2016-01-14 Thread Jesse Barnes
Fixup some fallout from the connector probing changes so testdisplay -m will pick up newly hotplugged displays correctly. Signed-off-by: Jesse Barnes mode_valid = 0; return; } @@ -456,7 +463,7 @@ set_stereo_mode(struct connector *c) * Each connector has a corresponding en

Re: [Intel-gfx] [PATCH] drm/i915: Decouple execbuf uAPI from internal implementation

2016-01-14 Thread Chris Wilson
On Thu, Jan 14, 2016 at 03:02:59PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > At the moment execbuf ring selection is fully coupled to > internal ring ids which is not a good thing on its own. > > This dependency is also spread between two source files and > not spelled out at eithe

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Make display gtt offsets u32

2016-01-14 Thread Chris Wilson
On Thu, Jan 14, 2016 at 03:22:15PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Using 'unsigned long' for ggtt offsets doesn't make much sense. Use > 'u32' instead since we've not yet seen a >4GiB ggtt. We should do: diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c b/d

Re: [Intel-gfx] [PATCH v4] drm/i915: edp resume/On time optimization.

2016-01-14 Thread Kumar, Abhay
On 1/12/2016 5:57 PM, Kumar, Abhay wrote: From: Abhay Kumar Make resume/on codepath not to wait for panel_power_cycle_delay(t11_t12) if this time is already spent in suspend/poweron time. v2: Use CLOCK_BOOTTIME and remove jiffies for panel power cycle delay calculation(Ville). v3: Addr

Re: [Intel-gfx] [PATCH 2/7] drm/i915/skl+: Use fb size for relative data rate calculation

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:43PM +0530, Shobhit Kumar wrote: > From: "Kumar, Mahesh" > > Use FB size for relative data rate calculation. don't always use Minor wording nitpick: it's not really the FB size you're using here but rather the plane size. The FB itself may be larger than the plane

Re: [Intel-gfx] [PATCH 3/7] drm/i915/skl+: calculate ddb minimum allocation

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:44PM +0530, Shobhit Kumar wrote: > From: "Kumar, Mahesh" > > don't always use 8 ddb as minimum, instead calculate using proper > algorithm. > > Signed-off-by: Kumar, Mahesh > --- > drivers/gpu/drm/i915/intel_pm.c | 57 > +++-- >

Re: [Intel-gfx] [PATCH 4/7] drm/i915/skl+: calculate plane pixel rate.

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:45PM +0530, Shobhit Kumar wrote: > From: "Kumar, Mahesh" > > Don't use pipe pixel rate for plane pixel rate. > Calculate plane pixel according to formula > > adjusted plane_pixel_rate = adjusted pipe_pixel_rate * downscale ammount > > downscale amount = max[1, src_

Re: [Intel-gfx] [PATCH 5/7] drm/i915/skl+: Use scaling amount for plane data rate calculation

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:46PM +0530, Shobhit Kumar wrote: > From: "Kumar, Mahesh" > > Signed-off-by: Kumar, Mahesh > --- > drivers/gpu/drm/i915/intel_pm.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/dr

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Add support to parse DMI table and get platform memory info

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:47PM +0530, Shobhit Kumar wrote: > This is needed for WM computation workaround for arbitrated display > bandwidth. > > Signed-off-by: Shobhit Kumar > --- > drivers/gpu/drm/i915/i915_dma.c | 19 +++ > drivers/gpu/drm/i915/i915_drv.h | 6 ++ > 2

Re: [Intel-gfx] [PATCH 0/7] Misc WM fixes and Arbitrated Display Bandwidth WA for SKL

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 05:32:41PM +0530, Shobhit Kumar wrote: > Hi, > This series add a set of updates to the WM calculation and also enables > arbitrated display bandwidth based WA. Some of these patches do overlap > with Matts work but we wanted to send them out as we have them in our > internal

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use the active wm config for merging on ILK-BDW

2016-01-14 Thread Matt Roper
On Thu, Jan 14, 2016 at 02:53:35PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > ilk_program_watermarks() is supposed to merge the active watermarks from > all pipes. Thus we need to use the active config too instead of some > precomputed stuff. So to clarify, the bug you

Re: [Intel-gfx] [PATCH 0/7] Misc WM fixes and Arbitrated Display Bandwidth WA for SKL

2016-01-14 Thread Kumar, Shobhit
On 01/15/2016 07:18 AM, Matt Roper wrote: On Thu, Jan 14, 2016 at 05:32:41PM +0530, Shobhit Kumar wrote: Hi, This series add a set of updates to the WM calculation and also enables arbitrated display bandwidth based WA. Some of these patches do overlap with Matts work but we wanted to send them

Re: [Intel-gfx] [PATCH 5/5] drm: Enable markdown^Wasciidoc for gpu.tmpl

2016-01-14 Thread Jani Nikula
On Thu, 14 Jan 2016, Jonathan Corbet wrote: > On Thu, 14 Jan 2016 22:03:26 +0200 > Jani Nikula wrote: > >> What if we added support for some markup language as an alternative to >> DocBook for the high level documentation? What if we taught kernel-doc >> to output said markup natively, and includ

Re: [Intel-gfx] [PATCH] drm/i915/bios: Fix the sequence size calculations for MIPI seq v3

2016-01-14 Thread Mika Kahola
On Thu, 2016-01-14 at 17:12 +0200, Jani Nikula wrote: > Two errors in a single line. The size was read from the wrong offset, > and the end index didn't take the five bytes for sequence byte and size > of sequence into account. Fix it all, and break up the calculations a > bit to make it clearer. >

<    1   2