Re: [Intel-gfx] [PATCH] drm/i915: Disable primary plane if we fail to reconstruct BIOS fb

On Mon, Nov 23, 2015 at 04:10:58PM -0800, Matt Roper wrote: > On Mon, Nov 23, 2015 at 04:53:55PM +, Chris Wilson wrote: > > On Mon, Nov 23, 2015 at 08:48:32AM -0800, Matt Roper wrote: > > > If we fail to reconstruct the BIOS fb (e.g., because the FB is too > > > large), we'll be left with plane

[Intel-gfx] [PATCH] drm/armada: Use a private mutex to protect priv->linear

Reusing the Big DRM Lock just leaks, and the few things left that dev->struct_mutex protected are very well contained - it's just the linear drm_mm manager. With this armada is completely struct_mutex free! v2: Convert things properly and also take the lock in armage_gem_free_object, and remove t

[Intel-gfx] [PATCH 1/9] drm/i915: Set connector_state->connector correctly.

I can't believe we didn't trip over this sooner.. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 2917fef33f31..dcc7ec7665c2 100644 -

[Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/tegra/dsi.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index f0a138ef68ce..6b8ae3d08eeb 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/tegra/d

[Intel-gfx] [PATCH 4/9] drm/core: Add drm_for_each_encoder_mask.

Signed-off-by: Maarten Lankhorst --- include/drm/drm_crtc.h | 11 +++ 1 file changed, 11 insertions(+) diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 29cfb4f8f99d..c54da2d297ec 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -1172,6 +1172,17 @@ str

[Intel-gfx] [PATCH 3/9] drm/core: Add drm_encoder_index.

This is useful for adding encoder_mask in crtc_state. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_crtc.c | 23 +++ include/drm/drm_crtc.h | 1 + 2 files changed, 24 insertions(+) diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 32d

[Intel-gfx] [PATCH 7/9] drm/atomic: Small documentation fix.

Use the correct function name for drm_atomic_clean_old_fb docs. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index f70350ca200f..5789649a4099 10064

[Intel-gfx] [PATCH 5/9] drm/atomic: add connector mask to drm_crtc_state.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 11 +++ include/drm/drm_crtc.h | 3 +++ 2 files changed, 14 insertions(+) diff --git a/drivers/gpu/drm/drm_atomic.c b/drivers/gpu/drm/drm_atomic.c index d8cc2328317a..f70350ca200f 100644 --- a/drivers/gpu/drm/drm_

[Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index dcc7ec7665c2..21b1984e828b 100644 --- a/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 0/9] drm/atomic: Add encoder_mask and connector_mask to crtc_state.

First 2 patches are fixes for a missing connector_state->connector. The atomic code doesn't use it currently but with these patches it causes a null pointer dereference. It's useful to know from the crtc_state what connectors and encoders are attached. This makes it possible to do iterations ov

[Intel-gfx] [PATCH 9/9] drm/atomic: Add encoder_mask to crtc_state.

This allows iteration over encoders without requiring connection_mutex. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 4 drivers/gpu/drm/i915/intel_display.c | 3 +++ include/drm/drm_crtc.h | 2 ++ 3 files changed, 9 insertions(+) diff --git a/dr

[Intel-gfx] [PATCH 8/9] drm/atomic: Remove drm_atomic_connectors_for_crtc.

Now that connector_mask is reliable there's no need for this function any more. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c| 29 - drivers/gpu/drm/drm_atomic_helper.c | 9 ++--- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- include/dr

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/tegra/dsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) Acked-by: Thierry Reding signature.asc Description: PGP signature __

[Intel-gfx] [PATCH 1/2] drm/i915: Use a crtc mask instead of a active refcount for dpll functions.

This makes it easier to verify correct dpll setup with only a single crtc. It it also useful to detect double dpll enable/disable. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 2/2] drm/i915: Perform dpll commit first.

Warn for the wrong mask in enable only. Disable will have the wrong mask now because the new state is committed before disabling the old state. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a

[Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

From: Akash Goel When the object is moved out of CPU read domain, the cachelines are not invalidated immediately. The invalidation is deferred till next time the object is brought back into CPU read domain. But the invalidation is done unconditionally, i.e. even for the case where the cachelines

Re: [Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

On Tue, Nov 24, 2015 at 03:35:24PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > When the object is moved out of CPU read domain, the cachelines > are not invalidated immediately. The invalidation is deferred till > next time the object is brought back into CPU read domain. > But the

Re: [Intel-gfx] [PATCH] drm/i915 : Avoid superfluous invalidation of CPU cache lines

On Tue, Nov 24, 2015 at 03:35:24PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > When the object is moved out of CPU read domain, the cachelines > are not invalidated immediately. The invalidation is deferred till > next time the object is brought back into CPU read domain. > But the

[Intel-gfx] [PATCH 1/4] drm/i915/skl: Do not allow scaling when crtc is disabled.

This fixes a warning when the crtc is turned off. In that case fb will be NULL, and crtc_clock will be 0. Because the crtc is no longer active this is not a bug, and shouldn't trigger the WARN_ON. Also remove handling a null crtc_state, with all transitional helpers gone this can no longer happen.

[Intel-gfx] [PATCH 4/4] drm/i915/bxt: Use the bypass frequency if there are no active pipes.

Now that pixel clock is set to 0 when there are no active pipes it's easy to set the bypass frequency for this case. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_displ

[Intel-gfx] [PATCH 2/4] drm/i915: Handle cdclk limits on broadwell.

As the comment indicates this can only fail gracefully when called from compute_config. Fortunately this is now what's happening, so the fixme can be removed and the DRM_ERROR downgraded. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 10 +++--- 1 file changed, 3

[Intel-gfx] [PATCH 3/4] drm/i915: Do not acquire crtc state to check clock during modeset, v3.

Parallel modesets are still not allowed, but this will allow updating a different crtc during a modeset if the clock is not changed. Additionally when all pipes are DPMS off the cdclk will be lowered to the minimum allowed. Changes since v1: - Add dev_priv->active_crtcs for tracking which crtcs a

[Intel-gfx] [PATCH 0/4] cdclk fixes

The first patch fixes a WARN_ON that happens when running kms_flip. Second patch fixes a FIXME. Now that the code's atomic the cdclk is calculated in compute_config so -EINVAL can be returned. The third patch introduces active_crtcs which is useful to have in general, and also calculates the state

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Handle cdclk limits on broadwell.

On Tue, Nov 24, 2015 at 11:29:03AM +0100, Maarten Lankhorst wrote: > As the comment indicates this can only fail gracefully when > called from compute_config. Fortunately this is now what's happening, > so the fixme can be removed and the DRM_ERROR downgraded. > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/tegra/dsi.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c > index f0a138ef68ce..6b

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

On Tue, Nov 24, 2015 at 10:34:33AM +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_display.c | 11 --- > 1 file changed, 8 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH v1] drm/i915: Fix a false alert of memory leak when free LRC

On 23/11/15 22:30, Yu Dai wrote: On 11/23/2015 02:34 AM, Tvrtko Ursulin wrote: On 20/11/15 08:31, Daniel Vetter wrote: > On Thu, Nov 19, 2015 at 04:10:26PM -0800, yu@intel.com wrote: >> From: Alex Dai >> >> There is a memory leak warning message from i915_gem_context_clean >> when GuC subm

Re: [Intel-gfx] [PATCH 7/9] drm/atomic: Small documentation fix.

On Tue, Nov 24, 2015 at 10:34:34AM +0100, Maarten Lankhorst wrote: > Use the correct function name for drm_atomic_clean_old_fb docs. > > Signed-off-by: Maarten Lankhorst Applied to topic/drm-misc, thanks. -Daniel > --- > drivers/gpu/drm/drm_atomic.c | 2 +- > 1 file changed, 1 insertion(+), 1

Re: [Intel-gfx] [PATCH] drm/sysfs: Send out uevent when connector->force changes

On Fri, Nov 20, 2015 at 09:25:14AM +, Chris Wilson wrote: > On Fri, Nov 20, 2015 at 09:11:00AM +0100, Daniel Vetter wrote: > > On Thu, Nov 19, 2015 at 09:06:04PM +, Chris Wilson wrote: > > > On Thu, Nov 19, 2015 at 05:46:50PM +0100, Daniel Vetter wrote: > > > > To avoid even more code dupli

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

On Tue, Nov 24, 2015 at 11:37:47AM +0100, Daniel Vetter wrote: > On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: > > Signed-off-by: Maarten Lankhorst > > --- > > drivers/gpu/drm/tegra/dsi.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drive

Re: [Intel-gfx] [PATCH v1] drm/i915: Fix a false alert of memory leak when free LRC

On Mon, Nov 23, 2015 at 10:34:59AM +, Tvrtko Ursulin wrote: > > On 20/11/15 08:31, Daniel Vetter wrote: > >On Thu, Nov 19, 2015 at 04:10:26PM -0800, yu@intel.com wrote: > >>From: Alex Dai > >> > >>There is a memory leak warning message from i915_gem_context_clean > >>when GuC submission i

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae > Author: Tvrtko Ursulin > Date: Mon Oct 5 13:26:36 2015 +0100 > > drm/i915: Clean up associated VMAs on context destruction > > Added a warning base

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

On Thu, Nov 19, 2015 at 01:02:36PM -0700, Alex Williamson wrote: > On Thu, 2015-11-19 at 04:06 +, Tian, Kevin wrote: > > > From: Alex Williamson [mailto:alex.william...@redhat.com] > > > Sent: Thursday, November 19, 2015 2:12 AM > > > > > > [cc +qemu-devel, +paolo, +gerd] > > > > > > Another

Re: [Intel-gfx] [PATCH 2/9] drm/tegra: Assign conn_state->connector when allocating connector state.

Op 24-11-15 om 11:51 schreef Thierry Reding: > On Tue, Nov 24, 2015 at 11:37:47AM +0100, Daniel Vetter wrote: >> On Tue, Nov 24, 2015 at 10:34:29AM +0100, Maarten Lankhorst wrote: >>> Signed-off-by: Maarten Lankhorst >>> --- >>> drivers/gpu/drm/tegra/dsi.c | 4 +++- >>> 1 file changed, 3 insertio

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Update connector_mask during readout.

Op 24-11-15 om 11:38 schreef Daniel Vetter: > On Tue, Nov 24, 2015 at 10:34:33AM +0100, Maarten Lankhorst wrote: >> Signed-off-by: Maarten Lankhorst >> --- >> drivers/gpu/drm/i915/intel_display.c | 11 --- >> 1 file changed, 8 insertions(+), 3 deletions(-) >> >> diff --git a/drivers/gpu/d

Re: [Intel-gfx] [PATCH] drm/sysfs: Send out uevent when connector->force changes

On Tue, Nov 24, 2015 at 11:51:09AM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 09:25:14AM +, Chris Wilson wrote: > > And something like .fill_modes -> .probe (after removing .detect). > > Hm, not sure. For panels we never really probe anything, the important bit > is (at least for th

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

On Tue, Nov 24, 2015 at 12:19:18PM +0100, Daniel Vetter wrote: > Downside: Tracking mapping changes on the guest side won't be any easier. > This is mostly a problem for integrated gpus, since discrete ones usually > require contiguous vram for scanout. I think saying "don't do that" is a > valid o

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_kms: Introduce get_first_connected_output macro

On Mon, Nov 23, 2015 at 03:49:20PM +0200, Ander Conselvan De Oliveira wrote: > On Fri, 2015-11-20 at 18:56 -0800, Vivek Kasireddy wrote: > > In some cases, we just need one valid (connected) output to perform > > a test. This macro can help in these situations by not having to > > put the test code

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Use insert_page for pwrite_fast

On Fri, Nov 20, 2015 at 10:06:16AM +, Chris Wilson wrote: > On Fri, Nov 20, 2015 at 03:07:58PM +0530, Ankitprasad Sharma wrote: > > On Wed, 2015-11-18 at 10:59 +0100, Daniel Vetter wrote: > > > On Thu, Nov 05, 2015 at 05:15:59PM +0530, ankitprasad.r.sha...@intel.com > > > wrote: > > > > From:

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Move disable_cxsr to the crtc_state.

Reviewed-by: Ander Conselvan de Oliveira On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote: > intel_crtc->atomic will be removed later on, move this member > to intel_crtc_state. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_atomic.c | 1 + > drivers/gpu/dr

Re: [Intel-gfx] [PATCH v4 10/12] drm/i915/gen9: Turn DC handling into a power well

On Tue, Nov 24, 2015 at 01:09:03AM +0200, Imre Deak wrote: > On Mon, 2015-11-23 at 14:58 -0800, Matt Roper wrote: > > On Mon, Nov 16, 2015 at 04:20:01PM +0100, Patrik Jakobsson wrote: > > > Handle DC off as a power well where enabling the power well will > > > prevent > > > the DMC to enter selecte

Re: [Intel-gfx] [PATCH 2/2] drm/i915: PSR: Mask LPSP hw tracking back again.

On Mon, Nov 23, 2015 at 01:52:37PM -0800, Rodrigo Vivi wrote: > Hi Daniel > > Would you please consider merging patches 2,3 and 4 from this series > that are ready to get merged? > They don't depend on patch 1 that is under review yet. Done. -Daniel > > Thanks, > > On Wed, Nov 18, 2015 at 1:49

Re: [Intel-gfx] [PATCH] drm/i915: Remove PSR Perf Counter for SKL+

On Mon, Nov 23, 2015 at 02:16:40PM -0800, Rodrigo Vivi wrote: > Whenever DMC firmware put the HW into DC State a bunch > of registers including this perf counter is reset to 0. > > Even with PSR active and working we could still read > "Performance_Counter: 0" what will misslead people to believe

Re: [Intel-gfx] [PATCH] drm/i915: Also disable PSR on Sink when disabling it on Source.

On Tue, Nov 24, 2015 at 04:40:08AM +, Jindal, Sonika wrote: > Reviewed-by: Sonika Jindal > > -Original Message- > From: Vivi, Rodrigo > Sent: Tuesday, November 24, 2015 3:50 AM > To: intel-gfx@lists.freedesktop.org > Cc: Vivi, Rodrigo; Jindal, Sonika > Subject: [PATCH] drm/i915: Also

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

Hi, > > Yes, vGPU may have additional features, like a framebuffer area, that > > aren't present or optional for direct assignment. Obviously we support > > direct assignment of GPUs for some vendors already without this feature. > > For exposing framebuffers for spice/vnc I highly recommend a

Re: [Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

On Fri, Nov 20, 2015 at 12:18:41PM +0100, Takashi Iwai wrote: > On Thu, 19 Nov 2015 17:04:20 +0100, > Takashi Iwai wrote: > > > > On Thu, 19 Nov 2015 16:51:05 +0100, > > Daniel Vetter wrote: > > > > > > On Thu, Nov 19, 2015 at 12:09:56PM +0100, Takashi Iwai wrote: > > > > Currently a DDI port may

Re: [Intel-gfx] [PATCH v1] drm/i915: Fix a false alert of memory leak when free LRC

On Tue, Nov 24, 2015 at 11:57:22AM +0100, Daniel Vetter wrote: > On Mon, Nov 23, 2015 at 10:34:59AM +, Tvrtko Ursulin wrote: > > > > On 20/11/15 08:31, Daniel Vetter wrote: > > >On Thu, Nov 19, 2015 at 04:10:26PM -0800, yu@intel.com wrote: > > >>From: Alex Dai > > >> > > >>There is a memo

Re: [Intel-gfx] [PATCH v1] drm/i915: Fix a false alert of memory leak when free LRC

On Tue, Nov 24, 2015 at 11:57:22AM +0100, Daniel Vetter wrote: > Ok, I get things now. Fundamentally the problem is that we track active > per-obj, but we want it per-vma. In a way this patch just diggs us deeper > into that hole, which doesn't make me all too happy. Oh well. Why not, I've been ch

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae > > Author: Tvrtko Ursulin > > Date: Mon Oct 5 13:26:36 2015 +0100 > > > > drm/

[Intel-gfx] [PATCH] drm/i915: Solve IVB FDI bifurcation problems using atomic

From: Ville Syrjälä Now that we have atomic modesetting, we can use it to solve the IVB pipe B/C FDI lane sharing issue. That is, we can force a modeset on pipe B if pipe C requires the FDI lanes currently used by pipe B. To achieve this we do the following: First stage: - first compute the ini

Re: [Intel-gfx] [PATCH i-g-t v2] lib/igt_kms: Introduce get_first_connected_output macro

On Fri, Nov 20, 2015 at 06:56:50PM -0800, Vivek Kasireddy wrote: > In some cases, we just need one valid (connected) output to perform > a test. This macro can help in these situations by not having to > put the test code inside a for loop that iterates over all the outputs. > > v2: Added a brief

Re: [Intel-gfx] [PATCH] drm/i915/guc: Move wait for GuC out of spinlock/unlock

On Mon, Nov 23, 2015 at 03:02:58PM -0800, yu@intel.com wrote: > From: Alex Dai > > When GuC Work Queue is full, driver will wait GuC for avaliable > space by delaying 1ms. The wait needs to be out of spinlockirq / > unlock. Otherwise, lockup happens because jiffies won't be updated > dur to i

Re: [Intel-gfx] [PATCH] drm/i915: Tidy aliasing_gtt_bind_vma()

On Fri, Nov 20, 2015 at 10:27:18AM +, Chris Wilson wrote: > In commit 0a878716265e9af9f697264dc2e858fcc060d833 > Author: Daniel Vetter > Date: Thu Oct 15 14:23:01 2015 +0200 > > drm/i915: restore ggtt double-bind avoidance > > we wrote the ggtt_bind_vma() observing a number of cleanups

Re: [Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

On Tue, Nov 24, 2015 at 01:44:46PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:18:41PM +0100, Takashi Iwai wrote: > > On Thu, 19 Nov 2015 17:04:20 +0100, > > Takashi Iwai wrote: > > > > > > On Thu, 19 Nov 2015 16:51:05 +0100, > > > Daniel Vetter wrote: > > > > > > > > On Thu, Nov 19,

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

On 24/11/15 12:53, Chris Wilson wrote: On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae Author: Tvrtko Ursulin Date: Mon Oct 5 13:26:36 2015 +

Re: [Intel-gfx] [PATCH] drm/i915/guc: Move wait for GuC out of spinlock/unlock

On ti, 2015-11-24 at 14:04 +0100, Daniel Vetter wrote: > On Mon, Nov 23, 2015 at 03:02:58PM -0800, yu@intel.com wrote: > > From: Alex Dai > > > > When GuC Work Queue is full, driver will wait GuC for avaliable > > space by delaying 1ms. The wait needs to be out of spinlockirq / > > unlock. Ot

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: > > On 24/11/15 12:53, Chris Wilson wrote: > >On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: > >>On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: > >>>From: Tvrtko Ursulin > >>> > >>>Commit e9f24d5fb7cf

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

Hi, On 24 November 2015 at 13:27, Chris Wilson wrote: > On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: >> On 24/11/15 12:53, Chris Wilson wrote: >> >The WARN_ON is accurate though. The original patch fails to fix even the >> >limited aspect of the bug it claimed to. >> >> That is

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

On Tue, Nov 24, 2015 at 01:38:55PM +0100, Gerd Hoffmann wrote: > Hi, > > > > Yes, vGPU may have additional features, like a framebuffer area, that > > > aren't present or optional for direct assignment. Obviously we support > > > direct assignment of GPUs for some vendors already without this f

[Intel-gfx] About dealing with CSB.context element switch in execlist mode.

Hi Gurus: I'm wondering what's the right approach to deal with the context switch reason: element_switch? According to b-spec, one ELSP submission may include two elements, when one element is finished, HW will move to process next element, the previous context will be scheduled out with a "elem

Re: [Intel-gfx] [PATCH] drm/i915: Don't override output type for DDI HDMI

On Tue, Nov 24, 2015 at 03:08:17PM +0200, Ville Syrjälä wrote: > On Tue, Nov 24, 2015 at 01:44:46PM +0100, Daniel Vetter wrote: > > On Fri, Nov 20, 2015 at 12:18:41PM +0100, Takashi Iwai wrote: > > > On Thu, 19 Nov 2015 17:04:20 +0100, > > > Takashi Iwai wrote: > > > > > > > > On Thu, 19 Nov 2015

[Intel-gfx] [PATCH 1/3] drm/i915: Set connector_state->connector using the helper.

The atomic helper sets connector_state->connector, which the i915 code didn't. This will become a problem when we start using it. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i9

[Intel-gfx] [PATCH 3/3] drm/tegra: Use __drm_atomic_helper_reset_connector for subclassing connector state.

Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/tegra/dsi.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/dsi.c b/drivers/gpu/drm/tegra/dsi.c index f0a138ef68ce..33ad50487f2e 100644 --- a/drivers/gpu/drm/tegra/dsi.c +++ b/drivers/gpu/drm/t

[Intel-gfx] [PATCH 2/3] drm/atomic: Add __drm_atomic_helper_connector_reset.

This is useful for drivers that subclass connector_state, like tegra. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 30 ++ include/drm/drm_atomic_helper.h | 2 ++ 2 files changed, 28 insertions(+), 4 deletions(-) diff --git a/drivers

Re: [Intel-gfx] [PATCH v2] drm/i915: Move the mb() following release-mmap into release-mmap

On Fri, Nov 20, 2015 at 10:31:38AM +, Chris Wilson wrote: > As paranoia, we want to ensure that the CPU's PTEs have been revoked for > the object before we return from i915_gem_release_mmap(). This allows us > to rely on there being no outstanding memory accesses and guarantees > serialisation

Re: [Intel-gfx] [PATCH 01/12] drm/i915: Convert i915_semaphores_is_enabled over to drm_i915_private

On Fri, Nov 20, 2015 at 12:43:41PM +, Chris Wilson wrote: > We only need our private device struct for checking semapahore status, > and to reduce churn later convert the parameter over now. > > Signed-off-by: Chris Wilson Assuming gcc hasn't become unhappy: Reviewed-by: Daniel Vetter > -

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

On 24/11/15 13:27, Chris Wilson wrote: On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: On 24/11/15 12:53, Chris Wilson wrote: On Tue, Nov 24, 2015 at 11:58:22AM +0100, Daniel Vetter wrote: On Fri, Nov 20, 2015 at 01:23:36PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH v2] drm/i915: Move the mb() following release-mmap into release-mmap

On Tue, Nov 24, 2015 at 02:36:43PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 10:31:38AM +, Chris Wilson wrote: > > As paranoia, we want to ensure that the CPU's PTEs have been revoked for > > the object before we return from i915_gem_release_mmap(). This allows us > > to rely on the

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Use the new rq->i915 field where appropriate

On Fri, Nov 20, 2015 at 12:43:42PM +, Chris Wilson wrote: > In a few frequent cases, having a direct pointer to the drm_i915_private > from the request is very useful. > > Signed-off-by: Chris Wilson req->i915 is a bit inconsistent imo, i915_dev would be better. Anyway, not something you sta

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

On Tue, Nov 24, 2015 at 01:29:07PM +, Daniel Stone wrote: > Hi, > > On 24 November 2015 at 13:27, Chris Wilson wrote: > > On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: > >> On 24/11/15 12:53, Chris Wilson wrote: > >> >The WARN_ON is accurate though. The original patch fails

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Calculate watermark related members in the crtc_state, v3.

On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote: > This removes pre/post_wm_update from intel_crtc->atomic, and > creates atomic state for it in intel_crtc. > > Changes since v1: > - Rebase on top of wm changes. > Changes since v2: > - Split disable_cxsr into a separate patch. > > Sign

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Suppress spurious CPU FIFO underruns on ILK-IVB

On Mon, Nov 23, 2015 at 04:55:17PM +0200, Ville Syrjälä wrote: > On Mon, Nov 23, 2015 at 02:28:29PM +, Chris Wilson wrote: > > On Mon, Nov 23, 2015 at 04:22:08PM +0200, Ville Syrjälä wrote: > > > On Sat, Nov 21, 2015 at 10:51:50AM +, Chris Wilson wrote: > > > > On Fri, Nov 20, 2015 at 10:09

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

Hi, > But there's some work to add generic mmap support to dma-bufs, and for > really simple case (where we don't have a gl driver to handle the dma-buf > specially) for untiled framebuffers that would be all we need? Not requiring gl is certainly a bonus, people might want build qemu without o

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Check for underruns after crtc disable

On Mon, Nov 23, 2015 at 02:42:21PM +, Chris Wilson wrote: > On Mon, Nov 23, 2015 at 04:10:32PM +0200, Ville Syrjälä wrote: > > On Sat, Nov 21, 2015 at 10:49:04AM +, Chris Wilson wrote: > > > On Fri, Nov 20, 2015 at 10:09:20PM +0200, ville.syrj...@linux.intel.com > > > wrote: > > > > From:

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Suppress spurious CPU FIFO underruns on ILK-IVB

On Fri, Nov 20, 2015 at 10:09:18PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > We still get spurious pipe underruns on ILK/SNB/IVB under two > circumstances when dealing with PCH ports: > * When the pipe has been disabled, but FDI RX/TX is still enabled > * During FDI li

Re: [Intel-gfx] [PATCH] drm/i915: Remove incorrect warning in context cleanup

Hey, On 24 November 2015 at 13:59, Daniel Vetter wrote: > On Tue, Nov 24, 2015 at 01:29:07PM +, Daniel Stone wrote: >> On 24 November 2015 at 13:27, Chris Wilson wrote: >> > On Tue, Nov 24, 2015 at 01:17:57PM +, Tvrtko Ursulin wrote: >> >> On 24/11/15 12:53, Chris Wilson wrote: >> >> >Th

Re: [Intel-gfx] [Announcement] 2015-Q3 release of XenGT - a Mediated Graphics Passthrough Solution from Intel

On Tue, Nov 24, 2015 at 03:12:31PM +0100, Gerd Hoffmann wrote: > Hi, > > > But there's some work to add generic mmap support to dma-bufs, and for > > really simple case (where we don't have a gl driver to handle the dma-buf > > specially) for untiled framebuffers that would be all we need? > >

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Check for underruns after crtc disable

On Tue, Nov 24, 2015 at 03:14:23PM +0100, Daniel Vetter wrote: > On Mon, Nov 23, 2015 at 02:42:21PM +, Chris Wilson wrote: > > On Mon, Nov 23, 2015 at 04:10:32PM +0200, Ville Syrjälä wrote: > > > On Sat, Nov 21, 2015 at 10:49:04AM +, Chris Wilson wrote: > > > > On Fri, Nov 20, 2015 at 10:09

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Use the new rq->i915 field where appropriate

On Tue, Nov 24, 2015 at 02:57:04PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:43:42PM +, Chris Wilson wrote: > > In a few frequent cases, having a direct pointer to the drm_i915_private > > from the request is very useful. > > > > Signed-off-by: Chris Wilson > > req->i915 is a

Re: [Intel-gfx] [PATCH 2/2] drm/i915: take a power domain reference while checking the HDMI live status

On pe, 2015-11-20 at 13:13 +0200, Jani Nikula wrote: > On Fri, 20 Nov 2015, Imre Deak wrote: > > On Fri, 2015-11-20 at 11:54 +0200, Imre Deak wrote: > > > On Thu, 2015-11-19 at 21:17 +0200, Ville Syrjälä wrote: > > > > On Thu, Nov 19, 2015 at 09:13:04PM +0200, Imre Deak wrote: > > > > > On Thu, 20

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit

On Fri, Nov 20, 2015 at 12:43:43PM +, Chris Wilson wrote: > Both perform the same actions with more or less indirection, so just > unify the code. > > Signed-off-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_gem.c| 2 +- > drivers/gpu/drm/i915/i915_gem_context.c| 8 +

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Unify intel_ring_begin()

On Fri, Nov 20, 2015 at 12:43:44PM +, Chris Wilson wrote: > Combine the near identical implementations of intel_logical_ring_begin() > and intel_ring_begin() - the only difference is that the logical wait > has to check for a matching ring (which is assumed by legacy). > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Use the new rq->i915 field where appropriate

On Tue, Nov 24, 2015 at 02:23:03PM +, Chris Wilson wrote: > On Tue, Nov 24, 2015 at 02:57:04PM +0100, Daniel Vetter wrote: > > On Fri, Nov 20, 2015 at 12:43:42PM +, Chris Wilson wrote: > > > In a few frequent cases, having a direct pointer to the drm_i915_private > > > from the request is v

Re: [Intel-gfx] [PATCH 05/12] drm/i915: Remove the identical implementations of request space reservation

On Fri, Nov 20, 2015 at 12:43:45PM +, Chris Wilson wrote: > Now that we share intel_ring_begin(), reserving space for the tail of > the request is identical between legacy/execlists and so the tautology > can be removed. > > Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter > --- > d

Re: [Intel-gfx] [PATCH 06/12] drm/i915: Rename request->ring to request->engine

On Fri, Nov 20, 2015 at 12:43:46PM +, Chris Wilson wrote: > In order to disambiguate between the pointer to the intel_engine_cs > (called ring) and the intel_ringbuffer (called ringbuf), rename > s/ring/engine/. > > Signed-off-by: Chris Wilson Ah, here we go. Slight amend for the commit mess

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Suppress spurious CPU FIFO underruns on ILK-IVB

On Tue, Nov 24, 2015 at 03:16:24PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 10:09:18PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > We still get spurious pipe underruns on ILK/SNB/IVB under two > > circumstances when dealing with PCH ports: > > * When t

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Rename request->ringbuf to request->ring

On Fri, Nov 20, 2015 at 12:43:47PM +, Chris Wilson wrote: > Now that we have disambuigated ring and engine, we can use the clearer > and more consistent name for the intel_ringbuffer pointer in the > request. > > Signed-off-by: Chris Wilson Reviewed-by: Daniel Vetter > --- > drivers/gpu/d

Re: [Intel-gfx] [PATCH 03/12] drm/i915: Unify intel_logical_ring_emit and intel_ring_emit

On Tue, Nov 24, 2015 at 03:33:12PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:43:43PM +, Chris Wilson wrote: > > @@ -547,7 +547,7 @@ mi_set_context(struct drm_i915_gem_request *req, u32 > > hw_flags) > > > > intel_ring_emit(ring, MI_LOAD_REGISTER_IMM(num_rin

Re: [Intel-gfx] [PATCH 02/12] drm/i915: Calculate watermark related members in the crtc_state, v3.

Op 24-11-15 om 15:03 schreef Ander Conselvan De Oliveira: > On Thu, 2015-11-19 at 16:07 +0100, Maarten Lankhorst wrote: >> This removes pre/post_wm_update from intel_crtc->atomic, and >> creates atomic state for it in intel_crtc. >> >> Changes since v1: >> - Rebase on top of wm changes. >> Changes

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Rename backpointer from intel_ringbuffer to intel_engine_cs

On Fri, Nov 20, 2015 at 12:43:48PM +, Chris Wilson wrote: > Having ringbuf->ring point to an engine is confusing, so rename it once > again to ring->engine. > > Signed-off-by: Chris Wilson This massively conflicts with commit e84fe80337dc85cca07d0417ea97edbec4789d8b Author: Nick Hoath Date

Re: [Intel-gfx] [PATCH 04/12] drm/i915: Unify intel_ring_begin()

On Tue, Nov 24, 2015 at 03:38:46PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:43:44PM +, Chris Wilson wrote: > > Combine the near identical implementations of intel_logical_ring_begin() > > and intel_ring_begin() - the only difference is that the logical wait > > has to check for

Re: [Intel-gfx] [PATCH] drm/i915: Don't register CRT connector when it's fused off

On Mon, Nov 23, 2015 at 05:07:29PM +0200, Ville Syrjälä wrote: > On Sat, Nov 21, 2015 at 10:44:12AM +, Chris Wilson wrote: > > On Fri, Nov 20, 2015 at 10:35:41PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > On some machines the CRT connector may be fu

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Rename intel_context[engine].ringbuf

On Fri, Nov 20, 2015 at 12:43:49PM +, Chris Wilson wrote: > Perform s/ringbuf/ring/ on the context struct for consistency with the > ring/engine split. > > Signed-off-by: Chris Wilson I presume all ringbuf are now gone? Anyway, Reviewed-by: Daniel Vetter > --- > drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH 10/12] drm/i915: Reduce the pointer dance of i915_is_ggtt()

On Fri, Nov 20, 2015 at 12:43:50PM +, Chris Wilson wrote: > The multiple levels of indirect do nothing but hinder the compiler and > the pointer chasing turns to be quite painful but painless to fix. > > Signed-off-by: Chris Wilson vma->is_ggtt = vm->is_ggtt is robust enough for me to carry

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Rename request->ringbuf to request->ring

On 20/11/15 12:43, Chris Wilson wrote: Now that we have disambuigated ring and engine, we can use the clearer and more consistent name for the intel_ringbuffer pointer in the request. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_drv.h| 2 +- drivers/gpu/drm/i915/i

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Rename backpointer from intel_ringbuffer to intel_engine_cs

On Tue, Nov 24, 2015 at 03:58:13PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:43:48PM +, Chris Wilson wrote: > > Having ringbuf->ring point to an engine is confusing, so rename it once > > again to ring->engine. > > > > Signed-off-by: Chris Wilson > > This massively conflicts w

Re: [Intel-gfx] [PATCH 08/12] drm/i915: Rename backpointer from intel_ringbuffer to intel_engine_cs

On Tue, Nov 24, 2015 at 03:58:13PM +0100, Daniel Vetter wrote: > On Fri, Nov 20, 2015 at 12:43:48PM +, Chris Wilson wrote: > > Having ringbuf->ring point to an engine is confusing, so rename it once > > again to ring->engine. > > > > Signed-off-by: Chris Wilson > > This massively conflicts w

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Rename intel_context[engine].ringbuf

On 20/11/15 12:43, Chris Wilson wrote: Perform s/ringbuf/ring/ on the context struct for consistency with the ring/engine split. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/i915_gpu_e

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Rename request->ringbuf to request->ring

On Tue, Nov 24, 2015 at 03:08:09PM +, Tvrtko Ursulin wrote: > > On 20/11/15 12:43, Chris Wilson wrote: > >Now that we have disambuigated ring and engine, we can use the clearer > >and more consistent name for the intel_ringbuffer pointer in the > >request. > > > >Signed-off-by: Chris Wilson >

Re: [Intel-gfx] [PATCH 09/12] drm/i915: Rename intel_context[engine].ringbuf

On Tue, Nov 24, 2015 at 03:09:42PM +, Tvrtko Ursulin wrote: > > On 20/11/15 12:43, Chris Wilson wrote: > >Perform s/ringbuf/ring/ on the context struct for consistency with the > >ring/engine split. > > > >Signed-off-by: Chris Wilson > >--- > > drivers/gpu/drm/i915/i915_debugfs.c | 2 +-

  1   2   >