On Tue, 13 Oct 2015, Chris Rainey wrote:
> [1.] One line summary of the problem: 8086:0f31_freezes_totally
>
> [2.] Full description of the problem/report: Total lockup(cannot even
> switch to console via Alt-F1, F2, etc.). Bug is most easily
> reproducible via Chromium browser when opening mult
On Wed, 14 Oct 2015, Jani Nikula wrote:
> On Tue, 13 Oct 2015, Chris Rainey wrote:
>> [1.] One line summary of the problem: 8086:0f31_freezes_totally
>>
>> [2.] Full description of the problem/report: Total lockup(cannot even
>> switch to console via Alt-F1, F2, etc.). Bug is most easily
>> rep
On Wed, 14 Oct 2015, "Miramontes Caton, Jairo Daniel"
wrote:
> Created bug in fdo bugzilla to keep track of this regression:
> https://bugs.freedesktop.org/show_bug.cgi?id=92454
Please disregard that, there's already a bug report at
https://bugs.freedesktop.org/show_bug.cgi?id=92084.
BR,
Jani.
On Tue, 13 Oct 2015, Michel Thierry wrote:
> The PTE_map trace added in commit 4c06ec8d13d2 ("drm/i915/gen8: Add
> dynamic page trace events") was using the full start and length values,
> instead of the page directory ones.
>
> Since this is just a trace, I don't think it requires cc'ing stable.
On Tue, Oct 13, 2015 at 09:24:26AM -0700, Dan Williams wrote:
> On Tue, Oct 13, 2015 at 1:24 AM, Daniel Vetter wrote:
> > On Mon, Oct 12, 2015 at 09:12:57PM +, Williams, Dan J wrote:
> >> On Mon, 2015-10-12 at 09:01 +0200, Daniel Vetter wrote:
> >> > On Fri, Oct 09, 2015 at 06:16:25PM -0400, D
On Wed, 14 Oct 2015, Kevin Strasser wrote:
> On HSW the crc differs between black and disabled primary planes, causing an
> assert to fail in the kms_universal_plane test. It seems that things like
> gamma
> correction are causing the black primary plane case to result in a brighter
> color than
On Wed, 14 Oct 2015, Jani Nikula wrote:
> On Wed, 14 Oct 2015, Kevin Strasser wrote:
>> On HSW the crc differs between black and disabled primary planes, causing an
>> assert to fail in the kms_universal_plane test. It seems that things like
>> gamma
>> correction are causing the black primary p
On Tue, 2015-10-13 at 16:08 +0200, Daniel Vetter wrote:
> On Tue, Oct 13, 2015 at 04:00:37PM +0200, Maarten Lankhorst wrote:
> > Op 13-10-15 om 15:58 schreef Daniel Vetter:
> > > On Tue, Oct 13, 2015 at 03:43:28PM +0200, Maarten Lankhorst wrote:
> > > > Op 13-10-15 om 15:35 schreef Daniel Vetter:
>
On Wed, 2015-10-14 at 11:59 +0530, Animesh Manna wrote:
>
> On 9/30/2015 7:54 PM, Imre Deak wrote:
> > On ke, 2015-08-26 at 16:58 +0530, Animesh Manna wrote:
> >> Note that for bxt without dmc, display engine can go to lowest
> >> possible state (dc9), so releasing the rpm reference.
> >>
> >> Cc:
On Wed, 14 Oct 2015, Animesh Manna wrote:
> On 9/30/2015 7:54 PM, Imre Deak wrote:
>> On ke, 2015-08-26 at 16:58 +0530, Animesh Manna wrote:
>>> Note that for bxt without dmc, display engine can go to lowest
>>> possible state (dc9), so releasing the rpm reference.
>>>
>>> Cc: Daniel Vetter
>>> C
From: Ville Syrjälä
Move the sprite/cursor plane disabling to occur in intel_sanitize_crtc()
where it belongs instead of doing it in intel_modeset_readout_hw_state().
The plane disabling was first added in
4cf0ebbd4fafbdf8e6431dbb315e5511c3efdc3b drm/i915: Rework plane readout.
I got the idea f
From: Maarten Lankhorst
This fixes the warnings like
"plane A assertion failure, should be disabled but not"
that on the initial modeset during boot. This can happen if
the primary plane is enabled by the firmware, but inheriting
it fails because the DMAR is active or for other reasons.
Most l
I'm proposing to backport these to v4.3/-fixes, objections or acks?
BR,
Jani.
References: https://bugs.freedesktop.org/show_bug.cgi?id=91910#c4
Jani Nikula (1):
Revert "drm/i915: Add primary plane to mask if it's visible"
Maarten Lankhorst (1):
drm/i915: Add primary plane to mask if it's v
From: Ville Syrjälä
The dotclock is often calculated in encoder .get_config(), so we
shouldn't copy the adjusted_mode to hwmode until we have read out the
dotclock.
Gets rid of some warnings like these:
[drm:drm_calc_timestamping_constants [drm]] *ERROR* crtc 21: Can't calculate
constants, dotc
This reverts commit 721a09f7393de6c28a07516dccd654c6e995944a.
There is nothing wrong with the commit per se. We had two versions of
the commit, one in -next headed for v4.4 and this one for v4.3. Turns
out we'll need to backport more fixes from -next, and they conflict with
the v4.3 version. It ge
Op 14-10-15 om 11:06 schreef Jani Nikula:
> I'm proposing to backport these to v4.3/-fixes, objections or acks?
>
> BR,
> Jani.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=91910#c4
>
>
> Jani Nikula (1):
> Revert "drm/i915: Add primary plane to mask if it's visible"
>
> Maarten L
Compliance test 4.3.1.11 requires source to perform link training
always if the automated test requests for it. This patch
enforces this requirement.
Signed-off-by: Sivakumar Thulasimani
Signed-off-by: Shubhangi Shrivastava
---
drivers/gpu/drm/i915/intel_dp.c | 4 +++-
1 file changed, 3 inserti
This patchset performs link training whenever it is requested by Panel
as stated in compliance test requirement. This requires clearing the
automated test data during every short pulse or long pulse instead of
clearing it only during the automated requests.
Shubhangi Shrivastava (2):
drm/i915: C
Automated test data that is updated when a test is requested is not cleared
till next automated test request is recevied which can cause various
problems. This patch fixes this by clearing this during the next
short pulse and on hot unplug.
For example, when TEST_LINK_TRAINING is requested it is u
On Tue, Oct 13, 2015 at 06:04:40PM +0300, Ville Syrjälä wrote:
> > + mutex_lock(&dev->struct_mutex);
> > +
>
> I'm thinking we won't even need the lock here anymore. But maybe I'm
> missing something.
Yeah, not so much here atm, but there is a bug here where we don't take an
explicit pin on the
On 13 October 2015 at 16:35, Daniel Vetter wrote:
> On Tue, Oct 13, 2015 at 04:16:18PM +0100, Derek Morton wrote:
>> Changes since #1b492e311 have broken the Android build. This patch
>> fixes the build for Android.
>>
>> core_prop_blob was using ioctls not in the android kernel. Added a
>> igt_re
>-Original Message-
>From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
>Sent: Tuesday, October 13, 2015 9:17 PM
>To: Shankar, Uma
>Cc: intel-gfx@lists.freedesktop.org; Kumar, Shobhit
>Subject: Re: [Intel-gfx] [BXT DSI timing fixes v1 3/3] drm/i915/bxt: Fixed d
On Tue, Oct 13, 2015 at 03:52:57PM +0200, Daniel Vetter wrote:
> On Fri, Oct 09, 2015 at 02:43:21PM +0100, Tvrtko Ursulin wrote:
> >
> > On 09/10/15 14:11, Chris Wilson wrote:
> > >Since the remove of the pin-ioctl, we only care about not changing the
> > >cache level on buffers pinned to the hard
On Tue, Oct 06, 2015 at 03:40:02PM +0100, Tvrtko Ursulin wrote:
>
>
> Hi,
>
> On 06/10/15 12:58, Chris Wilson wrote:
> >As paranoia, we want to ensure that the CPU's PTEs have been revoked for
> >the object before we return from i915_gem_release_mmap(). This allows us
> >to rely on there being n
We do not need to loop through crtc_state to get the
encoder if we already have a valid one available.
Signed-off-by: Durgadoss R
---
drivers/gpu/drm/i915/intel_ddi.c | 11 ---
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel_drv.h | 3 ++-
3 files change
To support USB type C alternate DP mode, the display driver needs to
know the number of lanes required by the DP panel as well as number
of lanes that can be supported by the type-C cable. Sometimes, the
type-C cable may limit the bandwidth even if Panel can support
more lanes. To address these sce
This patch exports the intel_{enable/disable}_shared_dpll
methods so that they can be called from other files also.
Subsequent patches need to call this from intel_ddi.c
Signed-off-by: Durgadoss R
---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
drivers/gpu/drm/i915/intel_drv.h | 2 ++
2 f
Do not call intel_get_shared_dpll() if there exists a
valid shared DPLL already.
Signed-off-by: Durgadoss R
---
drivers/gpu/drm/i915/intel_ddi.c | 70
drivers/gpu/drm/i915/intel_display.c | 2 +-
drivers/gpu/drm/i915/intel_drv.h | 2 +-
3 files chan
This patch wraps the get_ddi_pll() methods for
SKL/BXT/HSW+ with a common intel_get_ddi_pll()
method, and exports it, so that it can be shared
by other users also.
Signed-off-by: Durgadoss R
---
drivers/gpu/drm/i915/intel_display.c | 18 --
drivers/gpu/drm/i915/intel_drv.h |
This is an RFC series to start the review/discussion on approach
to support USB type C based DP panel.
To support USB type C alternate DP mode, the display driver needs to
know the number of lanes required by the DP panel as well as number
of lanes that can be supported by the type-C cable. Someti
To support USB type C alternate DP mode, the display driver needs to know the
number of lanes required by DP panel as well as number of lanes that can be
supported by the type-C cable. Sometimes, the type-C cable may limit the
bandwidth even if Panel can support more lanes. To address these scenari
On 13/10/2015 12:39, Daniel Vetter wrote:
On Fri, Oct 09, 2015 at 12:25:26PM +0100, Tomas Elf wrote:
On 09/10/2015 08:48, Chris Wilson wrote:
On Thu, Oct 08, 2015 at 07:31:35PM +0100, Tomas Elf wrote:
Since we're not synchronizing the ring request list during error state capture
the request li
On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote:
> On HSW the crc differs between black and disabled primary planes, causing an
> assert to fail in the kms_universal_plane test. It seems that things like
> gamma
> correction are causing the black primary plane case to result in a br
On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote:
> On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote:
> > On HSW the crc differs between black and disabled primary planes, causing an
> > assert to fail in the kms_universal_plane test. It seems that things like
> > gamma
On Wed, 14 Oct 2015, Maarten Lankhorst
wrote:
> Op 14-10-15 om 11:06 schreef Jani Nikula:
>> I'm proposing to backport these to v4.3/-fixes, objections or acks?
>>
>> BR,
>> Jani.
>>
>> References: https://bugs.freedesktop.org/show_bug.cgi?id=91910#c4
>>
>>
>> Jani Nikula (1):
>> Revert "drm/i9
On Wed, Oct 14, 2015 at 01:12:27PM +0100, Chris Wilson wrote:
> On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote:
> > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote:
> > > On HSW the crc differs between black and disabled primary planes, causing
> > > an
> > > assert t
On Wed, Oct 14, 2015 at 11:21:46AM +0300, Ander Conselvan De Oliveira wrote:
> On Tue, 2015-10-13 at 16:08 +0200, Daniel Vetter wrote:
> > On Tue, Oct 13, 2015 at 04:00:37PM +0200, Maarten Lankhorst wrote:
> > > Op 13-10-15 om 15:58 schreef Daniel Vetter:
> > > > On Tue, Oct 13, 2015 at 03:43:28PM
On Wed, Oct 14, 2015 at 12:46:51PM +0100, Tomas Elf wrote:
> On 13/10/2015 12:39, Daniel Vetter wrote:
> >On Fri, Oct 09, 2015 at 12:25:26PM +0100, Tomas Elf wrote:
> >>On 09/10/2015 08:48, Chris Wilson wrote:
> >>>On Thu, Oct 08, 2015 at 07:31:35PM +0100, Tomas Elf wrote:
> Since we're not syn
On Wed, Oct 14, 2015 at 10:20:32AM +, Shankar, Uma wrote:
>
>
> >-Original Message-
> >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel
> >Vetter
> >Sent: Tuesday, October 13, 2015 9:17 PM
> >To: Shankar, Uma
> >Cc: intel-gfx@lists.freedesktop.org; Kumar, Shobh
On Tue, Oct 13, 2015 at 02:51:25PM -0500, Chris wrote:
> On Tue, 2015-10-13 at 17:30 +0200, Daniel Vetter wrote:
> > On Tue, Oct 13, 2015 at 08:56:52AM -0500, Chris wrote:
> > > This is an issue that has been ongoing for over 1 1/2 years now. I have
> > > tried kernel after kernel and whether it's
On Tue, Oct 13, 2015 at 10:19:45PM +0530, Sagar Arun Kamble wrote:
> RPM reference taken before CSR load is not dropped if CSR fails to load.
> As Display DC9 state that is entered on RPM suspend does not depend on CSR
> firmware,
> RPM reference can be dropped for BXT.
>
> Cc: Animesh Manna
> C
On 17/09/15 14:20, Damien Lespiau wrote:
Not the first time! not the last time?
There is a possibility to use gcc 5's -Wbool-compare to try and compare
(reg) in those macros to a constant and gcc will warn that the
comparison between a boolean expression and a constant is always either
true or f
On Wed, 2015-09-23 at 13:27 +0200, Maarten Lankhorst wrote:
> atomic->disabled_planes is a hack that had to exist because
> prepare_fb was only called when a new fb was set. This messed
> up fb tracking in some circumstances like aborts from
> interruptible waits. As a result interruptible waiting
On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote:
> On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote:
> > On HSW the crc differs between black and disabled primary planes, causing an
> > assert to fail in the kms_universal_plane test. It seems that things like
> > gamma
On Wed, Oct 14, 2015 at 03:04:05PM +0200, Daniel Vetter wrote:
> On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote:
> > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote:
> > > On HSW the crc differs between black and disabled primary planes, causing
> > > an
> > > assert
On Wed, Oct 14, 2015 at 01:58:59PM +0100, Dave Gordon wrote:
> On 17/09/15 14:20, Damien Lespiau wrote:
> >Not the first time! not the last time?
> >
> >There is a possibility to use gcc 5's -Wbool-compare to try and compare
> >(reg) in those macros to a constant and gcc will warn that the
> >compa
On Wed, 14 Oct 2015, Durgadoss R wrote:
> Do not call intel_get_shared_dpll() if there exists a
> valid shared DPLL already.
>
> Signed-off-by: Durgadoss R
> ---
> drivers/gpu/drm/i915/intel_ddi.c | 70
>
> drivers/gpu/drm/i915/intel_display.c | 2 +-
>
Since the beginning we have conflated the size of the global GTT with
that of the per-process context sizes. In recent times (gen8+), those
are no longer the same where the global GTT is limited to 2/4GiB but the
per-process GTT may be anything up to 256TiB. Userspace knows nothing of
this discrepa
Hi Durgadoss,
[auto build test WARNING on drm-intel/for-linux-next -- if it's inappropriate
base, please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Durgadoss-R/Add-support-for-USB-typeC-based-DP/20151014-193613
config: x86_64-randc
On Wed, 14 Oct 2015, Dave Gordon wrote:
> On 17/09/15 14:20, Damien Lespiau wrote:
>> Not the first time! not the last time?
>>
>> There is a possibility to use gcc 5's -Wbool-compare to try and compare
>> (reg) in those macros to a constant and gcc will warn that the
>> comparison between a boole
On Wed, 14 Oct 2015, Jani Nikula wrote:
> On Wed, 14 Oct 2015, Dave Gordon wrote:
>> On 17/09/15 14:20, Damien Lespiau wrote:
>>> Not the first time! not the last time?
>>>
>>> There is a possibility to use gcc 5's -Wbool-compare to try and compare
>>> (reg) in those macros to a constant and gcc
Hi Durgadoss,
[auto build test WARNING on drm-intel/for-linux-next -- if it's inappropriate
base, please suggest rules for selecting the more suitable base]
url:
https://github.com/0day-ci/linux/commits/Durgadoss-R/Add-support-for-USB-typeC-based-DP/20151014-193613
config: x86_64-randc
Op 14-10-15 om 14:59 schreef Ander Conselvan De Oliveira:
> On Wed, 2015-09-23 at 13:27 +0200, Maarten Lankhorst wrote:
>> atomic->disabled_planes is a hack that had to exist because
>> prepare_fb was only called when a new fb was set. This messed
>> up fb tracking in some circumstances like aborts
On Wed, 2015-10-14 at 14:44 +0200, Daniel Vetter wrote:
> On Wed, Oct 14, 2015 at 11:21:46AM +0300, Ander Conselvan De Oliveira wrote:
> > On Tue, 2015-10-13 at 16:08 +0200, Daniel Vetter wrote:
> > > On Tue, Oct 13, 2015 at 04:00:37PM +0200, Maarten Lankhorst wrote:
> > > > Op 13-10-15 om 15:58 sc
On Wed, 2015-10-14 at 14:55 +0200, Daniel Vetter wrote:
> On Tue, Oct 13, 2015 at 02:51:25PM -0500, Chris wrote:
> > On Tue, 2015-10-13 at 17:30 +0200, Daniel Vetter wrote:
> > > On Tue, Oct 13, 2015 at 08:56:52AM -0500, Chris wrote:
> > > > This is an issue that has been ongoing for over 1 1/2 yea
On 13/10/15 12:36, Chris Wilson wrote:
On Tue, Oct 13, 2015 at 01:29:56PM +0200, Daniel Vetter wrote:
On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote:
On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote:
On Fri, Oct 09, 2015 at 10:45:35AM +0100, Chris Wilson wrote:
On F
The rotated view depends upon the rotation paramters, but thus far we
didn't bother checking for those. This seems to have been an issue
ever since this was introduce in
commit fe14d5f4e5468c5b80a24f1a64abcbe116143670
Author: Tvrtko Ursulin
Date: Wed Dec 10 17:27:58 2014 +
drm/i915: In
We don't need 2 separate unions.
Note that this was done intentinoally
Author: Joonas Lahtinen
Date: Wed May 6 14:35:38 2015 +0300
drm/i915: Add a partial GGTT view type
on Tvrtko's request, but without a clear justification. Rotated views
are also not checking for matching paramters in
It can't fail and there's even a WARN_ON suggesting that if it would,
it would be a disaster.
Correct this to make things less confusing.
Cc: Tvrtko Ursulin
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_display.c | 16 +---
1 file changed, 5 insertions(+), 11 deletion
On Wed, Oct 14, 2015 at 04:58:55PM +0300, Ander Conselvan De Oliveira wrote:
> On Wed, 2015-10-14 at 14:44 +0200, Daniel Vetter wrote:
> > On Wed, Oct 14, 2015 at 11:21:46AM +0300, Ander Conselvan De Oliveira wrote:
> > > On Tue, 2015-10-13 at 16:08 +0200, Daniel Vetter wrote:
> > > > On Tue, Oct 1
Hi,
On 14/10/15 15:51, Daniel Vetter wrote:
The rotated view depends upon the rotation paramters, but thus far we
didn't bother checking for those. This seems to have been an issue
ever since this was introduce in
commit fe14d5f4e5468c5b80a24f1a64abcbe116143670
Author: Tvrtko Ursulin
Date:
On Wed, Oct 14, 2015 at 04:08:25PM +0100, Tvrtko Ursulin wrote:
>
> Hi,
>
> On 14/10/15 15:51, Daniel Vetter wrote:
> >The rotated view depends upon the rotation paramters, but thus far we
> >didn't bother checking for those. This seems to have been an issue
> >ever since this was introduce in
>
On Wed, Oct 14, 2015 at 04:08:25PM +0100, Tvrtko Ursulin wrote:
>
> Hi,
>
> On 14/10/15 15:51, Daniel Vetter wrote:
> >The rotated view depends upon the rotation paramters, but thus far we
> >didn't bother checking for those. This seems to have been an issue
> >ever since this was introduce in
>
On 14/10/15 16:35, Chris Wilson wrote:
On Wed, Oct 14, 2015 at 04:08:25PM +0100, Tvrtko Ursulin wrote:
Hi,
On 14/10/15 15:51, Daniel Vetter wrote:
The rotated view depends upon the rotation paramters, but thus far we
didn't bother checking for those. This seems to have been an issue
ever sin
On 14/10/15 16:33, Chris Wilson wrote:
On Wed, Oct 14, 2015 at 04:08:25PM +0100, Tvrtko Ursulin wrote:
Hi,
On 14/10/15 15:51, Daniel Vetter wrote:
The rotated view depends upon the rotation paramters, but thus far we
didn't bother checking for those. This seems to have been an issue
ever sin
On Tue, Oct 13, 2015 at 12:23:38PM +0300, Ville Syrjälä wrote:
> On Sat, Oct 10, 2015 at 10:44:32AM +0100, Chris Wilson wrote:
> > We should serialise access to the intel_crtc->unpin_work through the
> > dev->event_lock spinlock. It should not be possible for it to disappear
> > without severe erro
On Wed, Oct 14, 2015 at 04:55:47PM +0100, Tvrtko Ursulin wrote:
>
> On 14/10/15 16:35, Chris Wilson wrote:
> >On Wed, Oct 14, 2015 at 04:08:25PM +0100, Tvrtko Ursulin wrote:
> >>
> >>Hi,
> >>
> >>On 14/10/15 15:51, Daniel Vetter wrote:
> >>>The rotated view depends upon the rotation paramters, but
On Wed, Oct 14, 2015 at 04:56:44PM +0100, Tvrtko Ursulin wrote:
>
> On 14/10/15 16:33, Chris Wilson wrote:
> >On Wed, Oct 14, 2015 at 04:08:25PM +0100, Tvrtko Ursulin wrote:
> >>
> >>Hi,
> >>
> >>On 14/10/15 15:51, Daniel Vetter wrote:
> >>>The rotated view depends upon the rotation paramters, but
On 14/10/2015 15:42, Dave Gordon wrote:
On 13/10/15 12:36, Chris Wilson wrote:
On Tue, Oct 13, 2015 at 01:29:56PM +0200, Daniel Vetter wrote:
On Fri, Oct 09, 2015 at 06:23:50PM +0100, Chris Wilson wrote:
On Fri, Oct 09, 2015 at 07:18:21PM +0200, Daniel Vetter wrote:
On Fri, Oct 09, 2015 at 10
core_prop_blob was using ioctls not in the android kernel. Added a
igt_require_propblob() function and local defines/structures so the
test will compile and skip on kernels where the feature is unsupported.
v2: moved igt_require_propblob() to core_prop_blob.c (Daniel Vetter)
Moved gem_blt.c to a s
From: Ville Syrjälä
In preparation for handling more than X tiling, pass the fb modifier to
gen4_compute_page_offset() instead of the obj->tiling_mode.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 8
drivers/gpu/drm/i915/intel_drv.h | 4 ++--
drivers/gpu
From: Ville Syrjälä
Add a few helpers to get the dimensions of the chroma plane(s).
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Ville Syrjälä
---
include/drm/drm_crtc.h | 12
1 file changed, 12 insertions(+)
diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h
inde
From: Ville Syrjälä
So while reviewing the NV12 stuff it became clear to me no one
had really given fb->offsets[] handling any serious thought.
So this patch series aims to fix that. We now treat fb->offsets[]
as a linear offset always. One clear benefit over treating it as
a linear offset as opp
From: Ville Syrjälä
Pull the tile width calculations from intel_fb_stride_alignment() into a
new function intel_tile_width().
Also take the opportunity to pass aroun dev_priv instead of dev to
intel_fb_stride_alignment().
v2: Reorder argumnents to be more consistent with other functions
Cha
From: Ville Syrjälä
Make intel_gen4_compute_page_offset() ready for other tiling formats
besied X-tile by getting the tile dimensions through
intel_tile_{size,width,height}().
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 15 ++-
1 file changed, 10 inserti
From: Ville Syrjälä
Use the actual tile size as to compute stuff in
intel_fill_fb_ggtt_view() instead of assuming it's PAGE_SIZE. I suppose
it doesn't matter since we don't use the results on gen2 platforms
where the tile size is 2k.
v2: Update due to CbCr plane
Signed-off-by: Ville Syrjälä
--
From: Ville Syrjälä
intel_pin_and_fence_fb_obj() only needs the framebuffer, and the desird
rotation (to find the right GTT view for it), so no need to pass all
kinds of plane stuff.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 39
From: Ville Syrjälä
rotate_pages() doesn't modify the passed in dma addresses, so make
them const.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
b/drivers/gpu/drm/i91
From: Ville Syrjälä
I find more usual to think about tile widths than heights, so changing
the intel_tile_height() to calculate the tile height as
tile_size/tile_width is easier than the opposite to the poor brain.
v2: Reorder arguments for consistency
Constify dev_priv arguments
Signed-off
From: Ville Syrjälä
In case we have multiple different rotated views into the same object,
each one may need its own vma due to being of different sizes. So don't
treat all rotated views as equal.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem_gtt.h | 2 ++
1 file changed, 2 in
From: Ville Syrjälä
The page aligned surface address calculation needs to know which way
things are rotated. The contract now says that the caller must pass the
rotate x/y coordinates, as well as the tile_height aligned stride in
the tile_height direction. This will make it fairly simple to deal
From: Ville Syrjälä
Since intel_gen4_compute_page_offset() can now handle tiling formats
all the way down to gen2, rename it to intel_compute_page_offset().
Not that we actually use it on gen2/3 since there's no DSPSURF etc.
registers which would take a page aligned address.
Signed-off-by: Ville
From: Ville Syrjälä
Each gtt view only has a single type, and so don't need to contain data
for both rotated and partial views. So we can move the data into the
same union to avoid wasting space.
Also rename 'rotation_info' to 'rotated' to match the view type exactly,
this should avoid confusion
From: Ville Syrjälä
SKL+ needs >4K alignment for tiled surfaces, so make
intel_compute_page_offset() handle it.
The way we do it is first we compute the closest tile boundary
as before, and then figure out how many tiles we need to go
to reach the desired alignment. The difference in the offset
From: Ville Syrjälä
intel_rotate_fb_obj_pages() doens't need the entire gtt view, just the
rotation info suffices.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem_gtt.c
From: Ville Syrjälä
We convert the fb->offsets[] into x/y offsets, so they must be
(macro)pixel aligned.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 36 +---
1 file changed, 33 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/d
From: Ville Syrjälä
Just for clarity set the type for i915_ggtt_view_normal explicitly.
While at it fix the indentation fail for i915_ggtt_view_rotated.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git
From: Ville Syrjälä
Pass stride in addition to width and height to rotate_pages(). For now
width and stride are the same, but once framebuffer offsets enter the
scene that may no longer be the case.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 7 +--
1 file change
From: Ville Syrjälä
Don't increment obj->framebuffer_references until we know we actually
managed to create the framebuffer.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/intel_display.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_di
From: Ville Syrjälä
Pull the code to determine the surface alignment for both linear and
tiled surfaces into a separate function intel_surf_alignment(). This
will be used not only for the vma alignment but actually aligning
the plane SURF once SKL+ starts using intel_compute_page_offset()
(since
From: Ville Syrjälä
Redo the fb rotation handling in order to:
- eliminate the NV12 special casing
- handle fb->offsets[] properly
- make the rotation handling reasier for the plane code
To achieve these goals we reduce intel_rotation_info to only contain
(for each plane) the rotated view width,
From: Ville Syrjälä
intel_compute_page_offsets() gets passed a bunch of the framebuffer
metadate sepearately. Just pass the framebuffer itself to make life
simpler for the caller, and make it less likely they would make a
mistake in the order of the arguments (as most as just unsigned ints and
su
From: Ville Syrjälä
intel_compute_page_offset() can dig up the correct pitch from the fb
itself, no need for the caller to pass it in.
A bit of extra care is needed for the lower level
_intel_compute_page_offset() since that one gets called before the
rotated pitch under intel_fb is populated. N
To fix a build error on android
Signed-off-by: Derek Morton
---
benchmarks/gem_blt.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/benchmarks/gem_blt.c b/benchmarks/gem_blt.c
index 181a5f1..8ab5302 100644
--- a/benchmarks/gem_blt.c
+++ b/benchmarks/gem_blt.c
@@ -25,6 +25
On Wed, Oct 14, 2015 at 04:51:05PM +0200, Daniel Vetter wrote:
> We don't need 2 separate unions.
>
> Note that this was done intentinoally
>
> Author: Joonas Lahtinen
> Date: Wed May 6 14:35:38 2015 +0300
>
> drm/i915: Add a partial GGTT view type
>
> on Tvrtko's request, but without a
On Wed, Oct 14, 2015 at 04:51:06PM +0200, Daniel Vetter wrote:
> The rotated view depends upon the rotation paramters, but thus far we
> didn't bother checking for those. This seems to have been an issue
> ever since this was introduce in
>
> commit fe14d5f4e5468c5b80a24f1a64abcbe116143670
> Autho
>-Original Message-
>From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter
>Sent: Wednesday, October 14, 2015 6:20 PM
>To: Shankar, Uma
>Cc: Daniel Vetter; intel-gfx@lists.freedesktop.org; Kumar, Shobhit
>Subject: Re: [Intel-gfx] [BXT DSI timing fixes v1 3/3] drm/
On Wed, Oct 14, 2015 at 07:29:10PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> We convert the fb->offsets[] into x/y offsets, so they must be
> (macro)pixel aligned.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/intel_display.c | 36
>
>Hi,
>
>On 13 October 2015 at 16:35, Daniel Vetter wrote:
>>> +void igt_require_propblob(int fd)
>>> +{
>>> + struct local_drm_mode_create_blob c;
>>> + struct local_drm_mode_destroy_blob d;
>>> + uint32_t blob_data;
>>> + c.data = &blob_data;
>>> + c.length = sizeof(blob_data
On Wed, Oct 14, 2015 at 07:28:52PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> So while reviewing the NV12 stuff it became clear to me no one
> had really given fb->offsets[] handling any serious thought.
> So this patch series aims to fix that. We now treat fb->offsets[
1 - 100 of 112 matches
Mail list logo
