Re: [Intel-gfx] [PATCH] drm/i915: Push vblank enable/disable past encoder->enable/disable

2015-02-16 Thread Jani Nikula
On Wed, 07 Jan 2015, Daniel Vetter wrote: > It is platform/output depenedent when exactly the pipe will start > running. Sometimes we just need the (cpu) pipe enabled, in other cases > the pch transcoder is enough and in yet other cases the (DP) port is > sending the frame start signal. > > In a p

Re: [Intel-gfx] [PATCH] drm/i915: Align initial plane backing objects correctly

2015-02-16 Thread Jani Nikula
On Wed, 11 Feb 2015, Daniel Vetter wrote: > Some bios really like to joke and start the planes at an offset ... > hooray! > > Align start and end to fix this. > > v2: Fixup calculation of size, spotted by Chris Wilson. > > v3: Fix serious fumble I've just spotted. > > Bugzilla: https://bugs.freede

[Intel-gfx] [v2 1/5] drm/i915: Add new PHY reg definitions for lock threshold

2015-02-16 Thread Vijay Purushothaman
Added new PHY register definitions to control TDC buffer calibration and digital lock threshold. Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/i915_reg.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_re

[Intel-gfx] [v2 0/5] More DPIO magic for CHV HDMI & DP

2015-02-16 Thread Vijay Purushothaman
Changes since version 1: Addressed Ville's review comments Decoded the magic numbers as much as possible Split the single patch into logical patch set Dropped the DPIO_CLK_EN changes Vijay Purushothaman (5): drm/i915: Add new PHY reg definitions for lock thresho

[Intel-gfx] [v2 3/5] drm/i915: Disable M2 frac division for integer case

2015-02-16 Thread Vijay Purushothaman
Handle M2 frac division for both M2 frac and int cases Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/intel_display.c | 23 +-- 1 file changed, 17 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_dis

[Intel-gfx] [v2 4/5] drm/i915: Initialize CHV digital lock detect threshold

2015-02-16 Thread Vijay Purushothaman
Initialize lock detect threshold and select coarse threshold if M2 is zero Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/intel_display.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c i

[Intel-gfx] [v2 5/5] drm/i915: Update prop, int co-eff and gain threshold for CHV

2015-02-16 Thread Vijay Purushothaman
This patch implements latest PHY changes in Gain, prop and int co-efficients based on the vco freq. Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/i915_reg.h |1 + drivers/gpu/drm/i915/intel_display.c | 42 -- 2 files changed, 31 insertions

[Intel-gfx] [v2 2/5] drm/i915: Limit max VCO supported in CHV to 6.48GHz

2015-02-16 Thread Vijay Purushothaman
As per the recommendation from PHY team, limit the max vco supported in CHV to 6.48 GHz Signed-off-by: Vijay Purushothaman --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Fix a use after free, and unbalanced refcounting

2015-02-16 Thread Daniel, Thomas
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Daniel Vetter > Sent: Friday, February 13, 2015 1:50 PM > To: Hoath, Nicholas > Cc: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix a use after free, and

Re: [Intel-gfx] [v2 1/5] drm/i915: Add new PHY reg definitions for lock threshold

2015-02-16 Thread Ville Syrjälä
On Mon, Feb 16, 2015 at 03:07:58PM +0530, Vijay Purushothaman wrote: > Added new PHY register definitions to control TDC buffer calibration and > digital lock threshold. > > Signed-off-by: Vijay Purushothaman Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/i915/i915_reg.h | 10 ++

Re: [Intel-gfx] [v2 2/5] drm/i915: Limit max VCO supported in CHV to 6.48GHz

2015-02-16 Thread Ville Syrjälä
On Mon, Feb 16, 2015 at 03:07:59PM +0530, Vijay Purushothaman wrote: > As per the recommendation from PHY team, limit the max vco supported in CHV > to 6.48 GHz > > Signed-off-by: Vijay Purushothaman > --- > drivers/gpu/drm/i915/intel_display.c |2 +- > 1 file changed, 1 insertion(+), 1 del

Re: [Intel-gfx] [v2 3/5] drm/i915: Disable M2 frac division for integer case

2015-02-16 Thread Ville Syrjälä
On Mon, Feb 16, 2015 at 03:08:00PM +0530, Vijay Purushothaman wrote: > Handle M2 frac division for both M2 frac and int cases > > Signed-off-by: Vijay Purushothaman > --- > drivers/gpu/drm/i915/intel_display.c | 23 +-- > 1 file changed, 17 insertions(+), 6 deletions(-) >

Re: [Intel-gfx] [v2 4/5] drm/i915: Initialize CHV digital lock detect threshold

2015-02-16 Thread Ville Syrjälä
On Mon, Feb 16, 2015 at 03:08:01PM +0530, Vijay Purushothaman wrote: > Initialize lock detect threshold and select coarse threshold if M2 is > zero "if M2 fractional part is zero"? > > Signed-off-by: Vijay Purushothaman > --- > drivers/gpu/drm/i915/intel_display.c | 11 +++ > 1 file

Re: [Intel-gfx] [v2 5/5] drm/i915: Update prop, int co-eff and gain threshold for CHV

2015-02-16 Thread Ville Syrjälä
On Mon, Feb 16, 2015 at 03:08:02PM +0530, Vijay Purushothaman wrote: > This patch implements latest PHY changes in Gain, prop and int co-efficients > based on the vco freq. > > Signed-off-by: Vijay Purushothaman > --- > drivers/gpu/drm/i915/i915_reg.h |1 + > drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH] drm/i915/skl: handle all pixel formats in skylake_update_primary_plane()

2015-02-16 Thread Damien Lespiau
On Tue, Feb 10, 2015 at 01:43:39PM +0200, Ville Syrjälä wrote: > On Tue, Feb 10, 2015 at 01:15:49PM +0200, Jani Nikula wrote: > > skylake_update_primary_plane() did not handle all pixel formats returned > > by skl_format_to_fourcc(). Handle alpha similar to skl_update_plane(). > > > > Bugzilla: ht

[Intel-gfx] [PATCH 1/2] drm/i915: Move drm_framebuffer_unreference out of struct_mutex for flips

2015-02-16 Thread Chris Wilson
intel_user_framebuffer_destroy() requires the struct_mutex for its object bookkeeping, so this means that all calls to drm_framebuffer_reference must be held without that lock. Regression from commit ab8d66752a9c28cd6c94fa173feacdfc1554aa03 Author: Tvrtko Ursulin Date: Mon Feb 2 15:44:15 2015 +

[Intel-gfx] [PATCH 2/2] drm/i915: Move drm_framebuffer_unreference out of struct_mutex for takeover

2015-02-16 Thread Chris Wilson
intel_user_framebuffer_destroy() requires the struct_mutex for its object bookkeeping, so this means that all calls to drm_framebuffer_reference must be held without that lock. References: https://bugs.freedesktop.org/show_bug.cgi?id=89166 Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/int

[Intel-gfx] [PATCH] drm: Fix the CRTC_STEREO_DOUBLE_ONLY define to include stero modes

2015-02-16 Thread Damien Lespiau
The CRTC_STEREO_DOUBLE_ONLY define was introduced in commit: commit ecb7e16bf187bc369cf6a5cd108582c01329980d Author: Gustavo Padovan Date: Mon Dec 1 15:40:09 2014 -0800 drm: add helper to get crtc timings (v5) but if we want the stereo h/v adjustments, we need to set the CRTC_STER

Re: [Intel-gfx] [PATCH] drm/i915/skl: handle all pixel formats in skylake_update_primary_plane()

2015-02-16 Thread Ville Syrjälä
On Mon, Feb 16, 2015 at 02:22:20PM +, Damien Lespiau wrote: > On Tue, Feb 10, 2015 at 01:43:39PM +0200, Ville Syrjälä wrote: > > On Tue, Feb 10, 2015 at 01:15:49PM +0200, Jani Nikula wrote: > > > skylake_update_primary_plane() did not handle all pixel formats returned > > > by skl_format_to_fou

[Intel-gfx] [PATCH] drm/i915: Reset logical ring contexts' head and tail during GPU reset

2015-02-16 Thread Thomas Daniel
Work was getting left behind in LRC contexts during reset. This causes a hang if the GPU is reset when HEAD==TAIL because the context's ringbuffer head and tail don't get reset and retiring a request doesn't alter them, so the ring still appears full. Added a function intel_lr_context_reset() to

Re: [Intel-gfx] [PATCH] drm/i915/skl: handle all pixel formats in skylake_update_primary_plane()

2015-02-16 Thread Damien Lespiau
On Tue, Feb 10, 2015 at 01:15:49PM +0200, Jani Nikula wrote: > skylake_update_primary_plane() did not handle all pixel formats returned > by skl_format_to_fourcc(). Handle alpha similar to skl_update_plane(). > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89052 > Signed-off-by: Jani Ni

[Intel-gfx] [PATCH 2/2] drm/i915: Don't try to set INSTPM for the _ABSOLUTE constant buffer address

2015-02-16 Thread Damien Lespiau
Gen9 bit to control whether the 3DSTATE_CONSTANT_* address should be an offset against the Dynamic State Base Address Vs an absolute address has moved to a different register. As no-one complained yet and I don't see any use of the I915_EXEC_CONSTANTS_ABSOLUTE flag in either the DDX, mesa, libdrm

[Intel-gfx] [PATCH 1/2] drm/i915: Re-order some checks to do the unlikely one first

2015-02-16 Thread Damien Lespiau
instpm_mode != relative_constants_mode is quite unlikely to happen, so we can test it first to use C's && short-circuiting and not test on 'ring'. I know, probably a useless micro-optimisation in the big scheme of things, but I'm going to add another test here, so might as well do it. Signed-off-

Re: [Intel-gfx] [PATCH 1/7] drm/i915/skl: Added new macros

2015-02-16 Thread Damien Lespiau
On Fri, Feb 06, 2015 at 08:26:32PM +0530, akash.g...@intel.com wrote: > From: Akash Goel > > For SKL, register definition for RPNSWREQ (A008), RPSTAT1(A01C) > have changed slightly. Also on SKL, frequency is specified in > units of 16.66 MHZ, compared to 50 MHZ for most of the earlier > platforms

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Re-order some checks to do the unlikely one first

2015-02-16 Thread Chris Wilson
On Mon, Feb 16, 2015 at 06:25:10PM +, Damien Lespiau wrote: > instpm_mode != relative_constants_mode is quite unlikely to happen, so > we can test it first to use C's && short-circuiting and not test on > 'ring'. > > I know, probably a useless micro-optimisation in the big scheme of > things,

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Move drm_framebuffer_unreference out of struct_mutex for takeover

2015-02-16 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5783 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 277/277

Re: [Intel-gfx] [PATCH] drm: Fix the CRTC_STEREO_DOUBLE_ONLY define to include stero modes

2015-02-16 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5784 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -36 277/277

Re: [Intel-gfx] [PATCH] drm/i915: Reset logical ring contexts' head and tail during GPU reset

2015-02-16 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5785 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -5 277/277

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Don't try to set INSTPM for the _ABSOLUTE constant buffer address

2015-02-16 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5786 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -5 277/277