[Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Imre Deak
Without emitting the default 3DSTATE_WM_DEPTH_STENCIL state the test will fail. Signed-off-by: Imre Deak --- lib/rendercopy_gen9.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/lib/rendercopy_gen9.c b/lib/rendercopy_gen9.c index e20a84f..b7b133c 100644 --- a/lib/

Re: [Intel-gfx] [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-29 Thread Mauro Carvalho Chehab
Em Wed, 28 Jan 2015 18:24:03 +0530 Sumit Semwal escreveu: > +/** > + * helper macro for exporters; zeros and fills in most common values > + */ > +#define DEFINE_DMA_BUF_EXPORT_INFO(a)\ > + struct dma_buf_export_info a = { .exp_name = KBUILD_MODNAME } > + I suspect that this will let

Re: [Intel-gfx] memcontrol.c BUG

2015-01-29 Thread Chris Wilson
On Wed, Jan 28, 2015 at 03:32:43PM +0100, Michal Hocko wrote: > On Wed 28-01-15 08:48:52, Chris Wilson wrote: > > On Wed, Jan 28, 2015 at 08:13:06AM +1000, Dave Airlie wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1165369 > > > > > > ov 18 09:23:22 elissa.gathman.org kernel: page:f5e36a

[Intel-gfx] [PULL] drm-intel-fixes

2015-01-29 Thread Jani Nikula
Hi Dave - i915 fixes all around, mostly cc: stable. Was surprised to see your pull request already on Tuesday, are you planning on doing another one before -rc7? BR, Jani. The following changes since commit 26bc420b59a38e4e6685a73345a0def461136dce: Linux 3.19-rc6 (2015-01-25 20:04:41 -0800

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Damien Lespiau
On Thu, Jan 29, 2015 at 12:03:19AM -0800, Imre Deak wrote: > Without emitting the default 3DSTATE_WM_DEPTH_STENCIL state the test > will fail. > > Signed-off-by: Imre Deak Question: Wasn't the golden context supposed to paper over those? -- Damien > --- > lib/rendercopy_gen9.c | 10 -

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Imre Deak
On Thu, 2015-01-29 at 10:51 +, Damien Lespiau wrote: > On Thu, Jan 29, 2015 at 12:03:19AM -0800, Imre Deak wrote: > > Without emitting the default 3DSTATE_WM_DEPTH_STENCIL state the test > > will fail. > > > > Signed-off-by: Imre Deak > > Question: Wasn't the golden context supposed to paper

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent

2015-01-29 Thread Damien Lespiau
On Wed, Jan 28, 2015 at 11:21:17AM +0200, Jani Nikula wrote: > On Tue, 27 Jan 2015, Damien Lespiau wrote: > > Missing commit message. I need some description to decide whether this > is required for fixes/stable or not. This patch wasn't prompted by an actual problem I witnessed, but from going

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Chris Wilson
On Thu, Jan 29, 2015 at 03:01:50AM -0800, Imre Deak wrote: > On Thu, 2015-01-29 at 10:51 +, Damien Lespiau wrote: > > On Thu, Jan 29, 2015 at 12:03:19AM -0800, Imre Deak wrote: > > > Without emitting the default 3DSTATE_WM_DEPTH_STENCIL state the test > > > will fail. > > > > > > Signed-off-by

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Damien Lespiau
On Thu, Jan 29, 2015 at 11:12:46AM +, Chris Wilson wrote: > On Thu, Jan 29, 2015 at 03:01:50AM -0800, Imre Deak wrote: > > On Thu, 2015-01-29 at 10:51 +, Damien Lespiau wrote: > > > On Thu, Jan 29, 2015 at 12:03:19AM -0800, Imre Deak wrote: > > > > Without emitting the default 3DSTATE_WM_DE

[Intel-gfx] [PATCH] tools/intel_reg_read:Adding lib calls for CHT/VLV

2015-01-29 Thread meghanelogal
From: meghanelogal Calling the library functions for reg read and write Signed-off-by: meghanelogal --- tools/intel_reg_read.c | 17 +++-- 1 file changed, 3 insertions(+), 14 deletions(-) diff --git a/tools/intel_reg_read.c b/tools/intel_reg_read.c index c550b02..bdff92c 100644

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 01:46:53PM -0500, Rob Clark wrote: > On Wed, Jan 28, 2015 at 12:37 PM, Daniel Vetter > wrote: > > From: Rob Clark > > > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > > formats. Especially in the case of dmabuf/prime buffer sharing, where > > we c

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: > > On 01/28/2015 05:37 PM, Daniel Vetter wrote: > >From: Rob Clark > > > >In DRM/KMS we are lacking a good way to deal with tiled/compressed > >formats. Especially in the case of dmabuf/prime buffer sharing, where > >we cannot alwa

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Chris Wilson
On Thu, Jan 29, 2015 at 11:17:04AM +, Damien Lespiau wrote: > On Thu, Jan 29, 2015 at 11:12:46AM +, Chris Wilson wrote: > > On Thu, Jan 29, 2015 at 03:01:50AM -0800, Imre Deak wrote: > > > On Thu, 2015-01-29 at 10:51 +, Damien Lespiau wrote: > > > > On Thu, Jan 29, 2015 at 12:03:19AM -0

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Damien Lespiau
On Thu, Jan 29, 2015 at 11:32:46AM +, Chris Wilson wrote: > On Thu, Jan 29, 2015 at 11:17:04AM +, Damien Lespiau wrote: > > On Thu, Jan 29, 2015 at 11:12:46AM +, Chris Wilson wrote: > > > On Thu, Jan 29, 2015 at 03:01:50AM -0800, Imre Deak wrote: > > > > On Thu, 2015-01-29 at 10:51 +000

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Tvrtko Ursulin
On 01/29/2015 11:30 AM, Daniel Vetter wrote: On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: On 01/28/2015 05:37 PM, Daniel Vetter wrote: From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffe

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: > > On 01/29/2015 11:30 AM, Daniel Vetter wrote: > >On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: > >> > >>On 01/28/2015 05:37 PM, Daniel Vetter wrote: > >>>From: Rob Clark > >>> > >>>In DRM/KMS we are lacking a goo

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-29 Thread Ville Syrjälä
On Wed, Jan 28, 2015 at 10:29:06AM +, Chris Wilson wrote: > On Tue, Jan 27, 2015 at 04:36:16PM +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Replace the valleyview_set_rps() and gen6_set_rps() calls with > > intel_set_rps() which itself does the IS_VALLEYVIEW() c

[Intel-gfx] [PATCH] drm/i915/skl: Enable eDRAM for gen9 as well

2015-01-29 Thread Damien Lespiau
Suggested-by: Daniel Vetter Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_uncore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/drivers/gpu/drm/i915/intel_uncore.c index 0e9bf82..0a1089b 100644 --- a/drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Tvrtko Ursulin
On 01/29/2015 11:57 AM, Daniel Vetter wrote: On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: On 01/29/2015 11:30 AM, Daniel Vetter wrote: On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wrote: On 01/28/2015 05:37 PM, Daniel Vetter wrote: From: Rob Clark In DRM/KM

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 12:55:48PM +, Tvrtko Ursulin wrote: > > On 01/29/2015 11:57 AM, Daniel Vetter wrote: > >On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: > >> > >>On 01/29/2015 11:30 AM, Daniel Vetter wrote: > >>>On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin wr

[Intel-gfx] [PATCH 2/2] tests/gem_reset_stats: add tests for ban period ioctl

2015-01-29 Thread Mika Kuoppala
Test parameter set/get for ban periods. Test actual impact on banning. Signed-off-by: Mika Kuoppala --- tests/gem_reset_stats.c | 101 +++- 1 file changed, 100 insertions(+), 1 deletion(-) diff --git a/tests/gem_reset_stats.c b/tests/gem_reset_stats.c

[Intel-gfx] [PATCH 1/2] tests: Add gem_ctx_params

2015-01-29 Thread Mika Kuoppala
Add gem_ctx_params to check context parameters ioctl test for set and getting ban periods. Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- tests/Makefile.sources | 1 + tests/gem_ctx_params.c | 211 + 2 files changed, 212 insertions(+) create

[Intel-gfx] [PATCH] tests: Add gem_copy_align_blt test

2015-01-29 Thread Mika Kuoppala
Copy a block into destination object with varying dst/src offsets. Put guard area before and after the blit target to see that it didn't touch memory out of blit boundaries. v2: Test description, git add and gitignore (Thomas) Strip it out from gem_userptr (Chris) References: https://bugs.fre

[Intel-gfx] [PATCH 2/3] drm/i915/skl: Declare that GT3 has a second VCS

2015-01-29 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_drv.c | 19 +-- 1 file changed, 17 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c index 6484229..9fdaf64 100644 --- a/drivers/gpu/drm/i915/i915_drv.c +++ b/dr

[Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-01-29 Thread Damien Lespiau
We need to have a separate GT3 struct intel_device_info to declare they have a second VCS. Let's start by splitting the PCI ids per-GT. Signed-off-by: Damien Lespiau --- include/drm/i915_pciids.h | 28 +++- 1 file changed, 19 insertions(+), 9 deletions(-) diff --git a/in

[Intel-gfx] [PATCH 3/3] drm/i915/skl: Remove the check enforcing VCS2 to be gen8 only

2015-01-29 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ringbuffer.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c b/drivers/gpu/drm/i915/intel_ringbuffer.c index d393026..bbe439d 100644 --- a/drivers/gpu/drm/i915/intel_ri

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-29 Thread Mika Kuoppala
Damien Lespiau writes: > On Thu, Jan 29, 2015 at 11:32:46AM +, Chris Wilson wrote: >> On Thu, Jan 29, 2015 at 11:17:04AM +, Damien Lespiau wrote: >> > On Thu, Jan 29, 2015 at 11:12:46AM +, Chris Wilson wrote: >> > > On Thu, Jan 29, 2015 at 03:01:50AM -0800, Imre Deak wrote: >> > > > O

[Intel-gfx] [PATCH i-g-t 0/2] printing log messages on test failure

2015-01-29 Thread Thomas Wood
This series replaces the earlier one dealing with printing recent log messages and avoids any issues with signal handlers by only printing the log on a test failure. Thomas Wood (2): lib: add a ring buffer for log entries lib: print recent log messages to stderr when a test or subtest fails

[Intel-gfx] [PATCH i-g-t 1/2] lib: add a ring buffer for log entries

2015-01-29 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/Makefile.am | 3 ++- lib/igt_core.c | 72 - 2 files changed, 63 insertions(+), 12 deletions(-) diff --git a/lib/Makefile.am b/lib/Makefile.am index 3826a1c..a5a4390 100644 --- a/lib/Makefile.am +++ b/lib

[Intel-gfx] [PATCH i-g-t 2/2] lib: print recent log messages to stderr when a test or subtest fails

2015-01-29 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/igt_core.c | 40 +--- 1 file changed, 37 insertions(+), 3 deletions(-) diff --git a/lib/igt_core.c b/lib/igt_core.c index b03b7df..596ab77 100644 --- a/lib/igt_core.c +++ b/lib/igt_core.c @@ -236,6 +236,9 @@ enum { OPT_HELP

[Intel-gfx] [PATCH 1/4] drm/i915: Split shared dpll setup out of __intel_set_mode()

2015-01-29 Thread Ander Conselvan de Oliveira
This simplifies __intel_set_mode() a little. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 50 1 file changed, 33 insertions(+), 17 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i91

[Intel-gfx] [PATCH 2/4] drm/i915: Move pll new_config field into intel_atomic_state

2015-01-29 Thread Ander Conselvan de Oliveira
In order to implement atomic mode sets, we'll need to hold state shared by multiple crtcs in the drm_atomic_state struct. This patch moves towards that goal by introducing struct intel_atomic_state for that purpose and moving the staged pll configuration into it. Current state will be moved in a fo

[Intel-gfx] [PATCH 3/4] drm/i915: Move current pll config to shared global state

2015-01-29 Thread Ander Conselvan de Oliveira
This patch adds a display_state pointer to drm_i915_private and moves the current pll config into it. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/i915_debugfs.c | 15 --- drivers/gpu/drm/i915/i915_drv.h | 4 +- drivers/gpu/drm/i915/intel_ddi.c | 13 --

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-29 Thread Michael Auchter
On Wed, Jan 28, 2015 at 10:36:02PM -0800, O'Rourke, Tom wrote: > On Wed, Jan 28, 2015 at 01:28:58PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 28, 2015 at 09:58:15AM +, Chris Wilson wrote: > > > On Wed, Jan 28, 2015 at 12:43:21AM -0500, Michael Auchter wrote: > > > > Testing out 3.19-rc6 on my

[Intel-gfx] [PATCH 4/4] drm/i915: Simplify pll state commit by swapping new and old state

2015-01-29 Thread Ander Conselvan de Oliveira
This deletes some code and is closer to what the logic will look like with atomic mode setting. Signed-off-by: Ander Conselvan de Oliveira --- drivers/gpu/drm/i915/intel_display.c | 58 1 file changed, 12 insertions(+), 46 deletions(-) diff --git a/drivers/

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-29 Thread Rob Clark
On Thu, Jan 29, 2015 at 7:55 AM, Tvrtko Ursulin wrote: > > On 01/29/2015 11:57 AM, Daniel Vetter wrote: >> >> On Thu, Jan 29, 2015 at 11:43:07AM +, Tvrtko Ursulin wrote: >>> >>> >>> On 01/29/2015 11:30 AM, Daniel Vetter wrote: On Wed, Jan 28, 2015 at 05:57:56PM +, Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Subsume intel_ctx_submit_request in to drm_i915_gem_request

2015-01-29 Thread Tvrtko Ursulin
On 01/15/2015 01:10 PM, Nick Hoath wrote: void intel_execlists_retire_requests(struct intel_engine_cs *ring) { - struct intel_ctx_submit_request *req, *tmp; + struct drm_i915_gem_request *req, *tmp; struct drm_i915_private *dev_priv = ring->dev->dev_private; unsig

Re: [Intel-gfx] [RFC PATCH 12/12] drm/i915/dsi: remove intel_dsi_cmd.c and the unused functions therein

2015-01-29 Thread Daniel Vetter
On Fri, Jan 23, 2015 at 05:58:43PM +0530, Shobhit Kumar wrote: > On 01/16/2015 05:57 PM, Jani Nikula wrote: > >The removed functions can be resurrected in intel_dsi.c as need arises. > > > >Signed-off-by: Jani Nikula > > Reviewed-By: Shobhit Kumar Ok, merged all the remaining patches. Thanks,

Re: [Intel-gfx] [PATCH] drm/i915/documentation: Add intel_uncore.c to drm.tmpl

2015-01-29 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 05:47:58PM +0200, Mika Kuoppala wrote: > Include intel_uncore.c in template for it to include d > documentation for intel_uncore_forcewake_get and *_put. > > Cc: Daniel Vetter > Signed-off-by: Mika Kuoppala Queued for -next, thanks for the patch. -Daniel > --- > Docume

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent

2015-01-29 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5657 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353

Re: [Intel-gfx] [PATCH] drm/i915/skl: Enabling PSR on Skylake

2015-01-29 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 09:27:14AM +0530, sonika wrote: > > On Wednesday 28 January 2015 09:32 PM, Daniel Vetter wrote: > >On Thu, Jan 22, 2015 at 02:30:54PM +0530, Sonika Jindal wrote: > >>Mainly taking care of some register offsets, otherwise things are similar to > >>hsw. Also, programming ddi

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-29 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 04:52:53PM +, Tvrtko Ursulin wrote: > > On 01/28/2015 09:29 AM, Daniel Vetter wrote: > >On Tue, Jan 27, 2015 at 11:29:36AM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>Add Android native sync support with fences exported as file descriptors via > >>th

[Intel-gfx] [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests

2015-01-29 Thread Nick Hoath
Remove request from list before unreferencing it, in case it's actually the only reference. (Found by Tvrtko Ursulin) Signed-off-by: Nick Hoath --- drivers/gpu/drm/i915/intel_lrc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/drivers/gpu/

[Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-29 Thread Daniel Vetter
From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags. The proposal is to

Re: [Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-01-29 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 03:30:35PM +, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 05:03:14PM +0200, Mika Kuoppala wrote: > > Now when we declare gpu errors only through our own dedicated > > hangcheck workqueue there is no need to have a separate workqueue > > for handling the resetting and w

[Intel-gfx] intel_crtc_wait_for_pending_flips

2015-01-29 Thread Kenneth Johansson
I have a rather infrequent hang of the graphics system but when it happens the only way out is to pull the power. This has happened on serveral kernel versions but it is infrequent enough so that I now only have the most resent still in the logs. what I remember is that I always see intel_crtc

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-29 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 10:36:02PM -0800, O'Rourke, Tom wrote: > On Wed, Jan 28, 2015 at 01:28:58PM +0200, Ville Syrjälä wrote: > > On Wed, Jan 28, 2015 at 09:58:15AM +, Chris Wilson wrote: > > > On Wed, Jan 28, 2015 at 12:43:21AM -0500, Michael Auchter wrote: > > > > Testing out 3.19-rc6 on my

Re: [Intel-gfx] intel_crtc_wait_for_pending_flips

2015-01-29 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 06:00:26PM +0100, Kenneth Johansson wrote: > I have a rather infrequent hang of the graphics system but when it happens > the only way out is to pull the power. This has happened on serveral kernel > versions but it is infrequent enough so that I now only have the most resen

[Intel-gfx] [PATCH] drm/i915: More DPIO magic for CHV HDMI & DP

2015-01-29 Thread Vijay Purushothaman
This patch implements latest changes in Gain, lock threshold and integer co-efficient values using sideband r/w. Without these changes there will be signal integrity issues for both HDMI and DP. Change-Id: I7b7151b5ab3a52c4c912cf10602c69a7d1a70222 Signed-off-by: Vijay Purushothaman Tested-by: Hon

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-01-29 Thread Jeff McGee
On Thu, Jan 29, 2015 at 02:13:38PM +, Damien Lespiau wrote: > We need to have a separate GT3 struct intel_device_info to declare they > have a second VCS. Let's start by splitting the PCI ids per-GT. > Would it be a good idea to do more programmatic population of these fields, rather than crea

[Intel-gfx] [PATCH 1/2] drm/i915: Keep plane->state updated on pageflip

2015-01-29 Thread Matt Roper
Until all drivers have transitioned to atomic, the framebuffer associated with a plane is tracked in both plane->fb (for legacy) and plane->state->fb (for all the new atomic codeflow). All of our modeset and plane updates use drm_plane->update_plane(), so in theory plane->fb and plane->state->fb s

[Intel-gfx] [PATCH 2/2] drm/i915: Switch planes from transitional helpers to full atomic helpers

2015-01-29 Thread Matt Roper
There are two sets of helper functions provided by the DRM core that can implement the .update_plane() and .disable_plane() hooks in terms of a driver's atomic entrypoints. The transitional helpers (which we have been using so far) create a plane state and then use the plane's atomic entrypoints t

Re: [Intel-gfx] [Intel HD 4400] strongly irritating artefacts on 2560x1440 laptop display

2015-01-29 Thread Martin Wilck
On 01/28/2015 10:45 AM, Chris Wilson wrote: > From watching the video, and your comments here, it is clear this is not > a driver bug (neither in the ddx nor opengl compositor). That leaves us > with hardware misconfiguration, aka kernel bug. Some of the artefacts > could be a display underrun. It

Re: [Intel-gfx] [Intel HD 4400] strongly irritating artefacts on 2560x1440 laptop display

2015-01-29 Thread Martin Wilck
On 01/28/2015 10:45 AM, Jani Nikula wrote: > Just a quick guess, what does this say: > > # cat /sys/module/i915/parameters/enable_{fbc,ips,psr} fbc: -1, ips: 1, psr: 0 > > Please try these module parameters for the non-zero ones: > > i915.enable_fbc=0 > i915.enable_ips=0 > i915.enable_psr=0

Re: [Intel-gfx] [Intel HD 4400] strongly irritating artefacts on 2560x1440 laptop display

2015-01-29 Thread Martin Wilck
On 01/28/2015 10:45 AM, Chris Wilson wrote: > From watching the video, and your comments here, it is clear this is not > a driver bug (neither in the ddx nor opengl compositor). That leaves us > with hardware misconfiguration, aka kernel bug. Some of the artefacts > could be a display underrun. It

Re: [Intel-gfx] memcontrol.c BUG

2015-01-29 Thread Dave Airlie
On 29 January 2015 at 18:16, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 03:32:43PM +0100, Michal Hocko wrote: >> On Wed 28-01-15 08:48:52, Chris Wilson wrote: >> > On Wed, Jan 28, 2015 at 08:13:06AM +1000, Dave Airlie wrote: >> > > https://bugzilla.redhat.com/show_bug.cgi?id=1165369 >> > > >> >

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-29 Thread Michael Auchter
On Thu, Jan 29, 2015 at 06:12:31PM +0100, Daniel Vetter wrote: > On Wed, Jan 28, 2015 at 10:36:02PM -0800, O'Rourke, Tom wrote: > > On Wed, Jan 28, 2015 at 01:28:58PM +0200, Ville Syrjälä wrote: > > > On Wed, Jan 28, 2015 at 09:58:15AM +, Chris Wilson wrote: > > > > On Wed, Jan 28, 2015 at 12:4

Re: [Intel-gfx] memcontrol.c BUG

2015-01-29 Thread Hugh Dickins
On Wed, 28 Jan 2015, Michal Hocko wrote: > On Wed 28-01-15 08:48:52, Chris Wilson wrote: > > On Wed, Jan 28, 2015 at 08:13:06AM +1000, Dave Airlie wrote: > > > https://bugzilla.redhat.com/show_bug.cgi?id=1165369 > > > > > > ov 18 09:23:22 elissa.gathman.org kernel: page:f5e36a40 count:2 > > > mapc

Re: [Intel-gfx] intel_crtc_wait_for_pending_flips

2015-01-29 Thread Kenneth Johansson
On 2015-01-29 18:15, Daniel Vetter wrote: On Thu, Jan 29, 2015 at 06:00:26PM +0100, Kenneth Johansson wrote: I have a rather infrequent hang of the graphics system but when it happens the only way out is to pull the power. This has happened on serveral kernel versions but it is infrequent enough

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-01-29 Thread Jani Nikula
On Thu, 29 Jan 2015, Jeff McGee wrote: > On Thu, Jan 29, 2015 at 02:13:38PM +, Damien Lespiau wrote: >> We need to have a separate GT3 struct intel_device_info to declare they >> have a second VCS. Let's start by splitting the PCI ids per-GT. >> > Would it be a good idea to do more programmat