Re: [Intel-gfx] memcontrol.c BUG

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 08:13:06AM +1000, Dave Airlie wrote: > https://bugzilla.redhat.com/show_bug.cgi?id=1165369 > > ov 18 09:23:22 elissa.gathman.org kernel: page:f5e36a40 count:2 > mapcount:0 mapping: (null) index:0x0 > Nov 18 09:23:22 elissa.gathman.org kernel: page flags: > 0x80090029(locke

[Intel-gfx] [PATCH] tools/intel_reg_read: Adding the reg offset for VLV and CHT

2015-01-28 Thread meghanelogal
From: meghanelogal For VLV and CHT for each register access we need to add base offset of 0x18. Signed-off-by: meghanelogal --- tools/intel_reg_read.c | 20 ++-- 1 file changed, 14 insertions(+), 6 deletions(-) diff --git a/tools/intel_reg_read.c b/tools/intel_reg_read.c

Re: [Intel-gfx] [PATCH] drm/mst: fix recursive sleep warning on qlock

2015-01-28 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 04:37:01PM +1300, Dave Airlie wrote: > From: Dave Airlie > > With drm-next, we can get a backtrace like below, > this is due to the callback checking the txmsg state taking > the mutex, which can cause a sleep inside a sleep, > > Fix this my creating a spinlock protecting

[Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-28 Thread Michael Auchter
Testing out 3.19-rc6 on my 2014 Thinkpad X1 Carbon (Haswell) resulted in this WARN at boot (and pretty frequently afterwards): WARNING: CPU: 0 PID: 989 at drivers/gpu/drm/i915/intel_pm.c:4377 gen6_set_rps+0x371/0x3c0() WARN_ON(val > dev_priv->rps.max_freq_softlimit) Modules linked in: CPU: 0 PID:

[Intel-gfx] [PATCH] drivers: gpu: drm: i915: intel_fifo_underrun.c: Fix a typo in comment

2015-01-28 Thread Kumar Amit Mehta
The comment for intel_cpu_fifo_underrun_irq_handler() is not consistent with the code and the rest of the comment for this routine. This patch fixes this typo in comment. Signed-off-by: Kumar Amit Mehta --- drivers/gpu/drm/i915/intel_fifo_underrun.c | 2 +- 1 file changed, 1 insertion(+), 1 dele

[Intel-gfx] [Intel HD 4400] strongly irritating artefacts on 2560x1440 laptop display

2015-01-28 Thread Martin Wilck
Dear list members, I suffer from highly disturbing artefacts with the Intel HD 4400 chip set on thw 2560x1440 display (Sharp LQ133T1JW19) of my Fujitsu Lifebook S904. The effects are hard to describe, therefore I have uploaded a video to https://www.dropbox.com/sh/9wh0nzvp0w1phxz/AAAsvAqHN8ApXzor5

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Fallback to using CPU relocations for large batch buffers

2015-01-28 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 09:43:00PM +, Chris Wilson wrote: > On Tue, Jan 27, 2015 at 04:09:37PM +0100, Daniel Vetter wrote: > > On Wed, Jan 14, 2015 at 11:20:56AM +, Chris Wilson wrote: > > > static int > > > i915_gem_execbuffer_reserve_vma(struct i915_vma *vma, > > >

Re: [Intel-gfx] [PATCH v2] agp/intel: Serialise after GTT updates

2015-01-28 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 09:44:01PM +, Chris Wilson wrote: > On Tue, Jan 27, 2015 at 03:58:05PM +0100, Daniel Vetter wrote: > > On Mon, Jan 26, 2015 at 10:47:10AM +, Chris Wilson wrote: > > > An interesting bug occurs on Pineview through which the root cause is > > > that the writes of the P

Re: [Intel-gfx] [RFC PATCH 05/12] drm/i915/dsi: remove unnecessary dsi device callbacks

2015-01-28 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 10:38:45AM +0530, Shobhit Kumar wrote: > On 01/27/2015 06:43 PM, Chris Wilson wrote: > >On Tue, Jan 27, 2015 at 02:09:21PM +0100, Daniel Vetter wrote: > >>On Tue, Jan 27, 2015 at 02:11:18PM +0530, Shobhit Kumar wrote: > >>>On 01/23/2015 08:52 PM, Daniel Vetter wrote: > O

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 11:08:43AM +, Tvrtko Ursulin wrote: > > On 01/24/2015 09:47 AM, Daniel Vetter wrote: > >On Fri, Jan 23, 2015 at 5:49 PM, Tvrtko Ursulin > > wrote: > >>Could you please translate this into something understandable by newcomers? > >>:) > > > >I don't know which parts are

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Implement WaForceContextSaveRestoreNonCoherent

2015-01-28 Thread Jani Nikula
On Tue, 27 Jan 2015, Damien Lespiau wrote: Missing commit message. I need some description to decide whether this is required for fixes/stable or not. BR, Jani. > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/i915_reg.h | 1 + > drivers/gpu/drm/i915/intel_ringbuffer.c |

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 09:08:03AM +, Chris Wilson wrote: > On Mon, Jan 26, 2015 at 08:52:39AM +0100, Daniel Vetter wrote: > > I think the problem will be platforms that want full explicit fence (like > > android) but allow delayed creation of the fence fd from a gl sync object > > (like the an

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 10:22:15AM +0100, Daniel Vetter wrote: > On Mon, Jan 26, 2015 at 09:08:03AM +, Chris Wilson wrote: > > On Mon, Jan 26, 2015 at 08:52:39AM +0100, Daniel Vetter wrote: > > > I think the problem will be platforms that want full explicit fence (like > > > android) but allow

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-28 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 01:43:02PM +, Tvrtko Ursulin wrote: > > On 01/27/2015 12:18 PM, Chris Wilson wrote: > >On Tue, Jan 27, 2015 at 12:13:14PM +, Tvrtko Ursulin wrote: > >>On 01/27/2015 11:40 AM, Chris Wilson wrote: > > [snip] > > >>>Explain how fence_release interacts with enable_sig

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-28 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 11:29:36AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Add Android native sync support with fences exported as file descriptors via > the execbuf ioctl (rsvd2 field is used). > > This is a continuation of Jesse Barnes's previous work, squashed to arrive at > t

Re: [Intel-gfx] [PATCH] drm/i915: Drop pipe_enable checks in vblank funcs

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 11:03:14PM +0200, Laurent Pinchart wrote: > Hi Daniel, > > Thank you for the patch. > > On Monday 26 January 2015 07:41:59 Daniel Vetter wrote: > > With Ville's rework to use drm_crtc_vblank_on/off the core will take > > care of rejecting drm_vblank_get calls when the pipe

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Fallback to using CPU relocations for large batch buffers

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 10:14:47AM +0100, Daniel Vetter wrote: > On Tue, Jan 27, 2015 at 09:43:00PM +, Chris Wilson wrote: > > On Tue, Jan 27, 2015 at 04:09:37PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 14, 2015 at 11:20:56AM +, Chris Wilson wrote: > > > > static int > > > > i915_gem

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Remove nested work in gpu error handling

2015-01-28 Thread Daniel Vetter
On Tue, Jan 27, 2015 at 09:53:20AM +, Chris Wilson wrote: > On Mon, Jan 26, 2015 at 06:03:05PM +0200, Mika Kuoppala wrote: > > Now when we declare gpu errors only through our own dedicated > > hangcheck workqueue there is no need to have a separate workqueue > > for handling the resetting and w

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-28 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 12:43:21AM -0500, Michael Auchter wrote: > Testing out 3.19-rc6 on my 2014 Thinkpad X1 Carbon (Haswell) resulted in > this WARN at boot (and pretty frequently afterwards): > > WARNING: CPU: 0 PID: 989 at drivers/gpu/drm/i915/intel_pm.c:4377 > gen6_set_rps+0x371/0x3c0() > W

Re: [Intel-gfx] [Intel HD 4400] strongly irritating artefacts on 2560x1440 laptop display

2015-01-28 Thread Jani Nikula
On Tue, 27 Jan 2015, Martin Wilck wrote: > Dear list members, > > I suffer from highly disturbing artefacts with the Intel HD 4400 chip > set on thw 2560x1440 display (Sharp LQ133T1JW19) of my Fujitsu Lifebook > S904. The effects are hard to describe, therefore I have uploaded a > video to > https

Re: [Intel-gfx] [Intel HD 4400] strongly irritating artefacts on 2560x1440 laptop display

2015-01-28 Thread Chris Wilson
On Tue, Jan 27, 2015 at 10:49:43PM +0100, Martin Wilck wrote: > Dear list members, > > I suffer from highly disturbing artefacts with the Intel HD 4400 chip > set on thw 2560x1440 display (Sharp LQ133T1JW19) of my Fujitsu Lifebook > S904. The effects are hard to describe, therefore I have uploaded

[Intel-gfx] [PATCH] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Mika Kuoppala
intel_uncore_early_sanitize() will reset the forcewake registers. When forcewake domains were introduced, the domain init was done after the sanitization of the forcewake registers. And as the resetting of registers use the domain accessors, we tried to reset the forcewake registers with unitialize

Re: [Intel-gfx] [PATCH] tools/intel_reg_read: Adding the reg offset for VLV and CHT

2015-01-28 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 02:19:50PM +0530, meghanelogal wrote: > From: meghanelogal > > For VLV and CHT for each register access we need to add base offset of > 0x18. > > Signed-off-by: meghanelogal Nah, vlv/cht have new decoder tools, and skl will have yet another one. Unfortunately no one

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-01-28 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 09:23:46AM +, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 10:22:15AM +0100, Daniel Vetter wrote: > > On Mon, Jan 26, 2015 at 09:08:03AM +, Chris Wilson wrote: > > > On Mon, Jan 26, 2015 at 08:52:39AM +0100, Daniel Vetter wrote: > > > > I think the problem will be p

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Remove pinned check from madvise_ioctl

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 04:43:17AM -0800, Rodrigo Vivi wrote: > From: Chris Wilson > > We don't need to incur the overhead of checking whether the object is > pinned prior to changing its madvise. If the object is pinned, the > madvise will not take effect until it is unpinned and so we cannot fr

Re: [Intel-gfx] [PATCH 08/11] Revert "drm/i915: Fix mutex->owner inspection race under DEBUG_MUTEXES"

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 04:43:22AM -0800, Rodrigo Vivi wrote: > From: Chris Wilson > > The core fix was applied in > > commit a63b03e2d2477586440741677ecac45bcf28d7b1 > Author: Chris Wilson > Date: Tue Jan 6 10:29:35 2015 + > > mutex: Always clear owner field upon mutex_unlock() > >

Re: [Intel-gfx] [PATCH 10/11] drm/i915: add irq_barrier operation for synchronising reads

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 04:43:24AM -0800, Rodrigo Vivi wrote: > From: Dave Gordon > > On some generations of chips, it is necessary to read an MMIO register > before getting the sequence number from the status page in main memory, > in order to ensure coherency; and on all generations this should

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 12:43:21AM -0500, Michael Auchter wrote: > Testing out 3.19-rc6 on my 2014 Thinkpad X1 Carbon (Haswell) resulted in > this WARN at boot (and pretty frequently afterwards): > > WARNING: CPU: 0 PID: 989 at drivers/gpu/drm/i915/intel_pm.c:4377 > gen6_set_rps+0x371/0x3c0() > W

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Extend GET_APERTURE ioctl to report available map space

2015-01-28 Thread Daniel Vetter
On Mon, Jan 26, 2015 at 04:43:18AM -0800, Rodrigo Vivi wrote: > When constructing a batchbuffer, it is sometimes crucial to know the > largest hole into which we can fit a fenceable buffer (for example when > handling very large objects on gen2 and gen3). This depends on the > fragmentation of pinn

Re: [Intel-gfx] [PATCH 10/11] drm/i915: add irq_barrier operation for synchronising reads

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 10:55:53AM +0100, Daniel Vetter wrote: > On Mon, Jan 26, 2015 at 04:43:24AM -0800, Rodrigo Vivi wrote: > > From: Dave Gordon > > > > On some generations of chips, it is necessary to read an MMIO register > > before getting the sequence number from the status page in main m

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 10:50:18AM +0100, Daniel Vetter wrote: > On Wed, Jan 28, 2015 at 09:23:46AM +, Chris Wilson wrote: > > On Wed, Jan 28, 2015 at 10:22:15AM +0100, Daniel Vetter wrote: > > > On Mon, Jan 26, 2015 at 09:08:03AM +, Chris Wilson wrote: > > > > On Mon, Jan 26, 2015 at 08:52

Re: [Intel-gfx] [PATCH] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 11:45:04AM +0200, Mika Kuoppala wrote: > intel_uncore_early_sanitize() will reset the forcewake registers. When > forcewake domains were introduced, the domain init was done after the > sanitization of the forcewake registers. And as the resetting of > registers use the doma

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-28 Thread Chris Wilson
On Tue, Jan 27, 2015 at 04:36:16PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Replace the valleyview_set_rps() and gen6_set_rps() calls with > intel_set_rps() which itself does the IS_VALLEYVIEW() check. The > code becomes simpler since the callers don't have to do this

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Handle CHV in vlv_set_rps_idle()

2015-01-28 Thread Chris Wilson
On Tue, Jan 27, 2015 at 04:36:15PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Move the CHV check into vlv_set_rps_idle() to simplify the caller a bit. > > Signed-off-by: Ville Syrjälä Reviewed-by: Chris Wilson -Chris -- Chris Wilson, Intel Open Source Technology Ce

Re: [Intel-gfx] [PATCH] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 10:17:39AM +, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 11:45:04AM +0200, Mika Kuoppala wrote: > > intel_uncore_early_sanitize() will reset the forcewake registers. When > > forcewake domains were introduced, the domain init was done after the > > sanitization of the

Re: [Intel-gfx] [PATCH] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Mika Kuoppala
Chris Wilson writes: > On Wed, Jan 28, 2015 at 10:17:39AM +, Chris Wilson wrote: >> On Wed, Jan 28, 2015 at 11:45:04AM +0200, Mika Kuoppala wrote: >> > intel_uncore_early_sanitize() will reset the forcewake registers. When >> > forcewake domains were introduced, the domain init was done after

Re: [Intel-gfx] [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Daniel Thompson
On 28/01/15 06:00, Sumit Semwal wrote: > At present, dma_buf_export() takes a series of parameters, which > makes it difficult to add any new parameters for exporters, if required. > > Make it simpler by moving all these parameters into a struct, and pass > the struct * as parameter to dma_buf_exp

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-28 Thread Ville Syrjälä
On Wed, Jan 28, 2015 at 09:58:15AM +, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 12:43:21AM -0500, Michael Auchter wrote: > > Testing out 3.19-rc6 on my 2014 Thinkpad X1 Carbon (Haswell) resulted in > > this WARN at boot (and pretty frequently afterwards): > > > > WARNING: CPU: 0 PID: 989 a

Re: [Intel-gfx] [PATCH] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 12:59:52PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > Also, why are we not calling fw_domain_reset() from fw_domain_init()? > > That would be enough to avoid the early santize required for ivb, > > right? > > Agreed here. That was my plan originally, doing the

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Be consistent on printing seqnos

2015-01-28 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5645 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 353/353

Re: [Intel-gfx] [PATCH v2] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
On 28 January 2015 at 16:50, Daniel Thompson wrote: > On 28/01/15 06:00, Sumit Semwal wrote: >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a)\ >> + struct dma_buf_export_info a = {0};

[Intel-gfx] [PATCH 3/3] drm/i915: Do only one posting read on forcewake get sequence

2015-01-28 Thread Mika Kuoppala
Follow the same semantics as in put side where we go through all domains before doing posting read. Cc: Chris Wilson Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_uncore.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_uncore.c b/

[Intel-gfx] [PATCH 2/3] drm/i915: Do only one posting read on forcewake put sequence

2015-01-28 Thread Mika Kuoppala
commit 05a2fb157e44a53c79133805d30eaada43911941 Author: Mika Kuoppala Date: Mon Jan 19 16:20:43 2015 +0200 drm/i915: Consolidate forcewake code introduced domain handling where each domain has it's own posting read registers. This changed the forcewake sequence on 'put' side when there is

[Intel-gfx] [PATCH 1/3] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Mika Kuoppala
intel_uncore_early_sanitize() will reset the forcewake registers. When forcewake domains were introduced, the domain init was done after the sanitization of the forcewake registers. And as the resetting of registers use the domain accessors, we tried to reset the forcewake registers with unitialize

Re: [Intel-gfx] [PATCH] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Mika Kuoppala
Chris Wilson writes: > On Wed, Jan 28, 2015 at 12:59:52PM +0200, Mika Kuoppala wrote: >> Chris Wilson writes: >> > Also, why are we not calling fw_domain_reset() from fw_domain_init()? >> > That would be enough to avoid the early santize required for ivb, >> > right? >> >> Agreed here. That was

[Intel-gfx] [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
At present, dma_buf_export() takes a series of parameters, which makes it difficult to add any new parameters for exporters, if required. Make it simpler by moving all these parameters into a struct, and pass the struct * as parameter to dma_buf_export(). While at it, unite dma_buf_export_named()

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do only one posting read on forcewake put sequence

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 02:43:25PM +0200, Mika Kuoppala wrote: > commit 05a2fb157e44a53c79133805d30eaada43911941 > Author: Mika Kuoppala > Date: Mon Jan 19 16:20:43 2015 +0200 > > drm/i915: Consolidate forcewake code > > introduced domain handling where each domain has it's own posting > r

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do only one posting read on forcewake get sequence

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 02:43:26PM +0200, Mika Kuoppala wrote: > Follow the same semantics as in put side where we go through > all domains before doing posting read. > > Cc: Chris Wilson > Signed-off-by: Mika Kuoppala Having just argued that I don't want a posting read here at all (and that th

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Do uncore early sanitize after domain init

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 02:43:24PM +0200, Mika Kuoppala wrote: > intel_uncore_early_sanitize() will reset the forcewake registers. When > forcewake domains were introduced, the domain init was done after the > sanitization of the forcewake registers. And as the resetting of > registers use the doma

[Intel-gfx] [PATCH] drm/i915: Don't do posting reads on getting forcewake

2015-01-28 Thread Mika Kuoppala
The checking for ack and also any subsequent mmio access will serialize with setting the forcewake bit. Drop the posting read as superfluous. Note that in the put side we still want to keep the posting read as it will ensure that the hw sees our forcewake release in a timely manner and doesn't kee

Re: [Intel-gfx] [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Sumit Semwal
Hi Mauro, On 28 January 2015 at 18:53, Mauro Carvalho Chehab wrote: > Em Wed, 28 Jan 2015 18:24:03 +0530 > Sumit Semwal escreveu: > >> +/** >> + * helper macro for exporters; zeros and fills in most common values >> + */ >> +#define DEFINE_DMA_BUF_EXPORT_INFO(a)\ >> + struct dma_buf_

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do only one posting read on forcewake put sequence

2015-01-28 Thread Mika Kuoppala
Chris Wilson writes: > On Wed, Jan 28, 2015 at 02:43:25PM +0200, Mika Kuoppala wrote: >> commit 05a2fb157e44a53c79133805d30eaada43911941 >> Author: Mika Kuoppala >> Date: Mon Jan 19 16:20:43 2015 +0200 >> >> drm/i915: Consolidate forcewake code >> >> introduced domain handling where each

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do only one posting read on forcewake put sequence

2015-01-28 Thread Ville Syrjälä
On Wed, Jan 28, 2015 at 03:28:56PM +0200, Mika Kuoppala wrote: > Chris Wilson writes: > > > On Wed, Jan 28, 2015 at 02:43:25PM +0200, Mika Kuoppala wrote: > >> commit 05a2fb157e44a53c79133805d30eaada43911941 > >> Author: Mika Kuoppala > >> Date: Mon Jan 19 16:20:43 2015 +0200 > >> > >> dr

Re: [Intel-gfx] [PATCH] drm/i915: Don't do posting reads on getting forcewake

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 03:25:05PM +0200, Mika Kuoppala wrote: > The checking for ack and also any subsequent mmio access > will serialize with setting the forcewake bit. Drop the > posting read as superfluous. > > Note that in the put side we still want to keep the posting read > as it will ensur

Re: [Intel-gfx] memcontrol.c BUG

2015-01-28 Thread Michal Hocko
On Wed 28-01-15 08:48:52, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 08:13:06AM +1000, Dave Airlie wrote: > > https://bugzilla.redhat.com/show_bug.cgi?id=1165369 > > > > ov 18 09:23:22 elissa.gathman.org kernel: page:f5e36a40 count:2 > > mapcount:0 mapping: (null) index:0x0 > > Nov 18 09:23:22

Re: [Intel-gfx] [PATCH v3] dma-buf: cleanup dma_buf_export() to make it easily extensible

2015-01-28 Thread Maarten Lankhorst
Op 28-01-15 om 13:54 schreef Sumit Semwal: > At present, dma_buf_export() takes a series of parameters, which > makes it difficult to add any new parameters for exporters, if required. > > Make it simpler by moving all these parameters into a struct, and pass > the struct * as parameter to dma_buf_

[Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-01-28 Thread Mika Kuoppala
Now when we declare gpu errors only through our own dedicated hangcheck workqueue there is no need to have a separate workqueue for handling the resetting and waking up the clients as the deadlock concerns are no more. The only exception is i915_debugfs::i915_set_wedged, which triggers error handl

Re: [Intel-gfx] [PATCH] drm/i915: Remove nested work in gpu error handling

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 05:03:14PM +0200, Mika Kuoppala wrote: > Now when we declare gpu errors only through our own dedicated > hangcheck workqueue there is no need to have a separate workqueue > for handling the resetting and waking up the clients as the deadlock > concerns are no more. > > The

[Intel-gfx] [PATCH] drm/i915/documentation: Add intel_uncore.c to drm.tmpl

2015-01-28 Thread Mika Kuoppala
Include intel_uncore.c in template for it to include d documentation for intel_uncore_forcewake_get and *_put. Cc: Daniel Vetter Signed-off-by: Mika Kuoppala --- Documentation/DocBook/drm.tmpl | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/Doc

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do only one posting read on forcewake put sequence

2015-01-28 Thread Mika Kuoppala
Ville Syrjälä writes: > On Wed, Jan 28, 2015 at 03:28:56PM +0200, Mika Kuoppala wrote: >> Chris Wilson writes: >> >> > On Wed, Jan 28, 2015 at 02:43:25PM +0200, Mika Kuoppala wrote: >> >> commit 05a2fb157e44a53c79133805d30eaada43911941 >> >> Author: Mika Kuoppala >> >> Date: Mon Jan 19 16:20

Re: [Intel-gfx] [PATCH] drm/i915/skl: Enabling PSR on Skylake

2015-01-28 Thread Daniel Vetter
On Thu, Jan 22, 2015 at 02:30:54PM +0530, Sonika Jindal wrote: > Mainly taking care of some register offsets, otherwise things are similar to > hsw. Also, programming ddi aux to use hardcoded values for psr data select. > > v2: introduce EDP_PSR_AUX_BASE macro (Chris) > v3: Moving to HW tracking

Re: [Intel-gfx] [PATCH 2/3] drm/i915: Do only one posting read on forcewake put sequence

2015-01-28 Thread Chris Wilson
On Wed, Jan 28, 2015 at 05:54:14PM +0200, Mika Kuoppala wrote: > Ville Syrjälä writes: > > > On Wed, Jan 28, 2015 at 03:28:56PM +0200, Mika Kuoppala wrote: > >> Chris Wilson writes: > >> > >> > On Wed, Jan 28, 2015 at 02:43:25PM +0200, Mika Kuoppala wrote: > >> >> commit 05a2fb157e44a53c7913380

Re: [Intel-gfx] [RFC v3] drm/i915: Android native sync support

2015-01-28 Thread Tvrtko Ursulin
On 01/28/2015 09:29 AM, Daniel Vetter wrote: On Tue, Jan 27, 2015 at 11:29:36AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Add Android native sync support with fences exported as file descriptors via the execbuf ioctl (rsvd2 field is used). This is a continuation of Jesse Barnes's pre

[Intel-gfx] [PATCH i-g-t 2/2] lib/tests: check that invalid subtest names are rejected

2015-01-28 Thread Thomas Wood
Signed-off-by: Thomas Wood --- lib/tests/Makefile.sources | 2 ++ lib/tests/igt_invalid_subtest_name.c | 31 +++ 2 files changed, 33 insertions(+) create mode 100644 lib/tests/igt_invalid_subtest_name.c diff --git a/lib/tests/Makefile.sources b/lib/tests/M

[Intel-gfx] [PATCH i-g-t 1/2] lib/tests: verify subtest enumeration output

2015-01-28 Thread Thomas Wood
Check that the subtest list is not empty if using --list-subtests returns with an exit code of 0, and that the list is empty if it returns with 79. Signed-off-by: Thomas Wood --- lib/tests/igt_command_line.sh | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/lib/

[Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-28 Thread Daniel Vetter
From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags. The proposal is to

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-28 Thread Tvrtko Ursulin
On 01/28/2015 05:37 PM, Daniel Vetter wrote: From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pas

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2 (v1.5)

2015-01-28 Thread Rob Clark
On Wed, Jan 28, 2015 at 12:37 PM, Daniel Vetter wrote: > From: Rob Clark > > In DRM/KMS we are lacking a good way to deal with tiled/compressed > formats. Especially in the case of dmabuf/prime buffer sharing, where > we cannot always rely on under-the-hood flags passed to driver specific > gem-

Re: [Intel-gfx] [PATCH] drm/i915/skl: Enabling PSR on Skylake

2015-01-28 Thread sonika
On Wednesday 28 January 2015 09:32 PM, Daniel Vetter wrote: On Thu, Jan 22, 2015 at 02:30:54PM +0530, Sonika Jindal wrote: Mainly taking care of some register offsets, otherwise things are similar to hsw. Also, programming ddi aux to use hardcoded values for psr data select. v2: introduce EDP

Re: [Intel-gfx] [PATCH v2] drm/i915/dsi: switch to drm_panel interface

2015-01-28 Thread Shobhit Kumar
On 01/23/2015 07:00 PM, Jani Nikula wrote: Replace intel_dsi_device and intel_dsi_dev_ops with drm_panel and drm_panel_funcs. They are adequate for what we have now, and if we end up needing more than this we should improve drm_panel. This will keep us better aligned with the drm core infrastruct

Re: [Intel-gfx] i915: WARN_ON(val > dev_priv->rps.max_freq_softlimit)

2015-01-28 Thread O'Rourke, Tom
On Wed, Jan 28, 2015 at 01:28:58PM +0200, Ville Syrjälä wrote: > On Wed, Jan 28, 2015 at 09:58:15AM +, Chris Wilson wrote: > > On Wed, Jan 28, 2015 at 12:43:21AM -0500, Michael Auchter wrote: > > > Testing out 3.19-rc6 on my 2014 Thinkpad X1 Carbon (Haswell) resulted in > > > this WARN at boot