Re: [Intel-gfx] [PATCH v7 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-12-13 Thread Lisovskiy, Stanislav
On Thu, 2019-12-12 at 20:22 -0800, Matt Roper wrote: > On Fri, Nov 29, 2019 at 03:37:06PM +0200, Stanislav Lisovskiy wrote: > > Current consensus that it is redundant as > > we already have skl_ddb_values struct out there, > > also this struct contains only single member > > which makes it unnecess

Re: [Intel-gfx] [PATCH v7 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-12-12 Thread Jani Nikula
On Thu, 12 Dec 2019, Matt Roper wrote: > On Fri, Nov 29, 2019 at 03:37:06PM +0200, Stanislav Lisovskiy wrote: >> struct skl_wm_level { >> @@ -1215,6 +1210,8 @@ struct drm_i915_private { >> bool distrust_bios_wm; >> } wm; >> >> +u8 enabled_slices; /* GEN11 has configurable

Re: [Intel-gfx] [PATCH v7 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-12-12 Thread Matt Roper
On Fri, Nov 29, 2019 at 03:37:06PM +0200, Stanislav Lisovskiy wrote: > Current consensus that it is redundant as > we already have skl_ddb_values struct out there, > also this struct contains only single member > which makes it unnecessary. > > v2: As dirty_pipes soon going to be nuked away >

[Intel-gfx] [PATCH v7 1/4] drm/i915: Remove skl_ddl_allocation struct

2019-11-29 Thread Stanislav Lisovskiy
Current consensus that it is redundant as we already have skl_ddb_values struct out there, also this struct contains only single member which makes it unnecessary. v2: As dirty_pipes soon going to be nuked away from skl_ddb_values, evacuating enabled_slices to safer in dev_priv. Signed-of