Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-14 Thread Eric Anholt
On Fri, 11 Nov 2011 21:18:31 +0100, Daniel Vetter wrote: > On Fri, Nov 11, 2011 at 20:58, Eric Anholt wrote: > > Oh, yeah, swap.  Good point, sounds like a plan.  If you manage to get > > reliable swapping of tiled data on 945g, I'll owe you all the beers. > > If you mean i945G as in desktop var

Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-11 Thread Daniel Vetter
On Fri, Nov 11, 2011 at 20:58, Eric Anholt wrote: > Oh, yeah, swap.  Good point, sounds like a plan.  If you manage to get > reliable swapping of tiled data on 945g, I'll owe you all the beers. If you mean i945G as in desktop variant, patch 6/9 should fix the swizzle detection on that one - it ca

Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-11 Thread Eric Anholt
On Fri, 11 Nov 2011 20:51:35 +0100, Daniel Vetter wrote: > On Fri, Nov 11, 2011 at 20:37, Eric Anholt wrote: > > I was assuming you were working on this because you were planning on > > building something that *used* this swizzling.  We removed all the > > userland because we never got it to actu

Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-11 Thread Daniel Vetter
On Fri, Nov 11, 2011 at 20:37, Eric Anholt wrote: > I was assuming you were working on this because you were planning on > building something that *used* this swizzling.  We removed all the > userland because we never got it to actually work. I have started to look into the swizzle test because w

Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-11 Thread Eric Anholt
On Fri, 11 Nov 2011 18:22:25 +0100, Daniel Vetter wrote: > On Fri, Nov 11, 2011 at 08:50:30AM -0800, Eric Anholt wrote: > > On Thu, 10 Nov 2011 14:18:07 +0100, Daniel Vetter > > wrote: > > > We have to do this manually. Somebody had a Great Idea. > > > > > > Signed-Off-by: Daniel Vetter > > >

Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-11 Thread Daniel Vetter
On Fri, Nov 11, 2011 at 08:50:30AM -0800, Eric Anholt wrote: > On Thu, 10 Nov 2011 14:18:07 +0100, Daniel Vetter > wrote: > > We have to do this manually. Somebody had a Great Idea. > > > > Signed-Off-by: Daniel Vetter > > People playing with this when not strictly required is scary to me. > M

Re: [Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-11 Thread Eric Anholt
On Thu, 10 Nov 2011 14:18:07 +0100, Daniel Vetter wrote: > We have to do this manually. Somebody had a Great Idea. > > Signed-Off-by: Daniel Vetter People playing with this when not strictly required is scary to me. Manually swizzling was a world of hurt. I got to play with things like "when

[Intel-gfx] [PATCH 9/9] drm/i915: swizzling support for snb/ivb

2011-11-10 Thread Daniel Vetter
We have to do this manually. Somebody had a Great Idea. Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_dma.c|2 +- drivers/gpu/drm/i915/i915_drv.c|4 +++- drivers/gpu/drm/i915/i915_drv.h|3 ++- drivers/gpu/drm/i915/i915_gem.c| 23