Re: [Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-28 Thread Dixit, Ashutosh
On Sun, 24 Apr 2022 15:00:24 -0700, Andi Shyti wrote: > > Hi Ashutosh, > > On Tue, Apr 19, 2022 at 11:25:05PM -0700, Ashutosh Dixit wrote: > > From: Dale B Stimson > > > > Add a couple of helpers to help formatting pcode commands and improve code > > readability. > > Can you please add some more d

[Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-28 Thread Ashutosh Dixit
From: Dale B Stimson Some dGfx pcode commands take additional sub-commands and parameters. Add a couple of helpers to help formatting these commands to improve code readability. v2: Fixed commit author (Rodrigo) v3: Function rename and convert to new uncore interface for pcode functions Remo

Re: [Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-24 Thread Andi Shyti
Hi Ashutosh, On Tue, Apr 19, 2022 at 11:25:05PM -0700, Ashutosh Dixit wrote: > From: Dale B Stimson > > Add a couple of helpers to help formatting pcode commands and improve code > readability. Can you please add some more details on the helpers? > v2: Fixed commit author (Rodrigo) > > Cc: Mi

[Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-19 Thread Ashutosh Dixit
From: Dale B Stimson Add a couple of helpers to help formatting pcode commands and improve code readability. v2: Fixed commit author (Rodrigo) Cc: Mike Ruhl Cc: Rodrigo Vivi Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915

[Intel-gfx] [PATCH 5/9] drm/i915/pcode: Add a couple of pcode helpers

2022-04-19 Thread Ashutosh Dixit
From: Dale B Stimson Add a couple of helpers to help formatting pcode commands and improve code readability. v2: Fixed commit author (Rodrigo) Cc: Mike Ruhl Cc: Rodrigo Vivi Signed-off-by: Dale B Stimson Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915