Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-11 Thread Jindal, Sonika
On 8/11/2014 5:53 PM, Daniel Vetter wrote: On Mon, Aug 11, 2014 at 05:37:20PM +0530, Jindal, Sonika wrote: On 8/11/2014 5:12 PM, Daniel Vetter wrote: On Mon, Aug 11, 2014 at 04:37:00PM +0530, Jindal, Sonika wrote: Hi Daniel, Are you taking this patch back in drm-intel? We should still c

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-11 Thread Daniel Vetter
On Mon, Aug 11, 2014 at 05:37:20PM +0530, Jindal, Sonika wrote: > > > On 8/11/2014 5:12 PM, Daniel Vetter wrote: > >On Mon, Aug 11, 2014 at 04:37:00PM +0530, Jindal, Sonika wrote: > >> > >>Hi Daniel, > >>Are you taking this patch back in drm-intel? > > > >We should still call the primary_plane->u

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-11 Thread Jindal, Sonika
On 8/11/2014 5:12 PM, Daniel Vetter wrote: On Mon, Aug 11, 2014 at 04:37:00PM +0530, Jindal, Sonika wrote: Hi Daniel, Are you taking this patch back in drm-intel? We should still call the primary_plane->update hook directly instead of open-coding it. -Daniel But we are already doing dev_pr

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-11 Thread Daniel Vetter
On Mon, Aug 11, 2014 at 04:37:00PM +0530, Jindal, Sonika wrote: > > Hi Daniel, > Are you taking this patch back in drm-intel? We should still call the primary_plane->update hook directly instead of open-coding it. -Daniel > > -Sonika > > On 8/7/2014 5:41 PM, Daniel Vetter wrote: > >On Thu, Aug

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-11 Thread Jindal, Sonika
Hi Daniel, Are you taking this patch back in drm-intel? -Sonika On 8/7/2014 5:41 PM, Daniel Vetter wrote: On Thu, Aug 07, 2014 at 01:45:31PM +0200, Daniel Vetter wrote: On Tue, Jul 15, 2014 at 11:11:37AM +0200, Daniel Vetter wrote: On Tue, Jul 15, 2014 at 02:10:28PM +0530, sonika.jin...@inte

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-07 Thread Daniel Vetter
On Thu, Aug 07, 2014 at 01:45:31PM +0200, Daniel Vetter wrote: > On Tue, Jul 15, 2014 at 11:11:37AM +0200, Daniel Vetter wrote: > > On Tue, Jul 15, 2014 at 02:10:28PM +0530, sonika.jin...@intel.com wrote: > > > + /* FBC does not work on some platforms for rotated planes */ > > > +

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-07 Thread Daniel Vetter
On Tue, Jul 15, 2014 at 11:11:37AM +0200, Daniel Vetter wrote: > On Tue, Jul 15, 2014 at 02:10:28PM +0530, sonika.jin...@intel.com wrote: > > + /* FBC does not work on some platforms for rotated planes */ > > + if (INTEL_INFO(dev)->gen <= 4 && !IS_G4X(dev)) { > > +

[Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-05 Thread sonika . jindal
From: Sonika Jindal Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlake_update_plane. v3: Checking if CRTC is active before issuein

[Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-08-04 Thread sonika . jindal
From: Sonika Jindal Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlake_update_plane. v3: Checking if CRTC is active before issuein

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-07-15 Thread Daniel Vetter
On Tue, Jul 15, 2014 at 03:08:37PM +0530, Jindal, Sonika wrote: > On 7/15/2014 2:41 PM, Daniel Vetter wrote: > >On Tue, Jul 15, 2014 at 02:10:28PM +0530, sonika.jin...@intel.com wrote: > >>From: Sonika Jindal > Ok, I will add > >Also Chris mentioned that on some platforms this won't work and it's

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-07-15 Thread Jindal, Sonika
On 7/15/2014 2:41 PM, Daniel Vetter wrote: On Tue, Jul 15, 2014 at 02:10:28PM +0530, sonika.jin...@intel.com wrote: From: Sonika Jindal Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source wid

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-07-15 Thread Daniel Vetter
On Tue, Jul 15, 2014 at 02:10:28PM +0530, sonika.jin...@intel.com wrote: > From: Sonika Jindal > > Primary planes support 180 degree rotation. Expose the feature > through rotation drm property. > > v2: Calculating linear/tiled offsets based on pipe source width and > height. Added 180 degree ro

[Intel-gfx] [PATCH 5/6] drm/i915: Add 180 degree primary plane rotation support

2014-07-15 Thread sonika . jindal
From: Sonika Jindal Primary planes support 180 degree rotation. Expose the feature through rotation drm property. v2: Calculating linear/tiled offsets based on pipe source width and height. Added 180 degree rotation support in ironlake_update_plane. v3: Checking if CRTC is active before issuein