Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use eLLC/LLC by default when available

2013-07-12 Thread Rodrigo Vivi
I don't have a strong opinion on iris x crw and you know that I like to split different things in different functions, however in this case I think either iris or crw are still hsw so if it is possible to get dev_priv->ellc_size inside hsw_pte_encode somehow I in favor of not creating another func

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use eLLC/LLC by default when available

2013-07-04 Thread Ben Widawsky
On Thu, Jul 04, 2013 at 08:17:09PM +0200, Daniel Vetter wrote: > On Thu, Jul 04, 2013 at 11:02:06AM -0700, Ben Widawsky wrote: > > DRI clients really should be using MOCS to get fine grained streaming > > cache controls. With that note, I *hope* that this patch doesn't improve > > performance overw

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Use eLLC/LLC by default when available

2013-07-04 Thread Daniel Vetter
On Thu, Jul 04, 2013 at 11:02:06AM -0700, Ben Widawsky wrote: > DRI clients really should be using MOCS to get fine grained streaming > cache controls. With that note, I *hope* that this patch doesn't improve > performance overwhelmingly, because if it does - it means there is a > problem elsewhere

[Intel-gfx] [PATCH 4/5] drm/i915: Use eLLC/LLC by default when available

2013-07-04 Thread Ben Widawsky
DRI clients really should be using MOCS to get fine grained streaming cache controls. With that note, I *hope* that this patch doesn't improve performance overwhelmingly, because if it does - it means there is a problem elsewhere. In any case, the kernel, and old userspace should get some benefit