Re: [Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

2014-04-02 Thread Chris Wilson
On Wed, Apr 02, 2014 at 03:10:13PM -0700, Jesse Barnes wrote: > On Wed, 2 Apr 2014 16:36:08 +0100 > Chris Wilson wrote: > > > +static void > > +i915_gem_stop_ringbuffers(struct drm_device *dev) > > +{ > > + struct drm_i915_private *dev_priv = dev->dev_private; > > + struct intel_ring_buffer

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

2014-04-02 Thread Jesse Barnes
On Wed, 2 Apr 2014 16:36:08 +0100 Chris Wilson wrote: > +static void > +i915_gem_stop_ringbuffers(struct drm_device *dev) > +{ > + struct drm_i915_private *dev_priv = dev->dev_private; > + struct intel_ring_buffer *ring; > + int i; > + > + for_each_ring(ring, dev_priv, i) > +

[Intel-gfx] [PATCH 3/6] drm/i915: Preserve ring buffers objects across resume

2014-04-02 Thread Chris Wilson
Tearing down the ring buffers across resume is overkill, risks unnecessary failure and increases fragmentation. After failure, since the device is still active we may end up trying to write into the dangling iomapping and trigger an oops. Reported-by: Jae-hyeon Park Bugzilla: https://bugzilla.ke