Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2

2012-10-30 Thread Jesse Barnes
On Tue, 30 Oct 2012 21:32:17 + Chris Wilson wrote: > On Tue, 30 Oct 2012 18:59:31 +0100, Daniel Vetter wrote: > > On Fri, Oct 26, 2012 at 10:08:38AM -0700, Jesse Barnes wrote: > > > The BIOS shouldn't be touching this memory across suspend/resume, so > > > just leave it alone. This saves us

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2

2012-10-30 Thread Daniel Vetter
On Tue, Oct 30, 2012 at 10:32 PM, Chris Wilson wrote: > On Tue, 30 Oct 2012 18:59:31 +0100, Daniel Vetter wrote: >> On Fri, Oct 26, 2012 at 10:08:38AM -0700, Jesse Barnes wrote: >> > The BIOS shouldn't be touching this memory across suspend/resume, so >> > just leave it alone. This saves us ~50m

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2

2012-10-30 Thread Chris Wilson
On Tue, 30 Oct 2012 18:59:31 +0100, Daniel Vetter wrote: > On Fri, Oct 26, 2012 at 10:08:38AM -0700, Jesse Barnes wrote: > > The BIOS shouldn't be touching this memory across suspend/resume, so > > just leave it alone. This saves us ~50ms on resume on my T420. > > > > v2: change gtt restore defa

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2

2012-10-30 Thread Daniel Vetter
On Fri, Oct 26, 2012 at 10:08:38AM -0700, Jesse Barnes wrote: > The BIOS shouldn't be touching this memory across suspend/resume, so > just leave it alone. This saves us ~50ms on resume on my T420. > > v2: change gtt restore default on pre-gen4 (Chris) > move needs_gtt_restore flag into dev_p

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2

2012-10-28 Thread Chris Wilson
On Fri, 26 Oct 2012 10:08:38 -0700, Jesse Barnes wrote: > The BIOS shouldn't be touching this memory across suspend/resume, so > just leave it alone. This saves us ~50ms on resume on my T420. > > v2: change gtt restore default on pre-gen4 (Chris) > move needs_gtt_restore flag into dev_priv

[Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume v2

2012-10-26 Thread Jesse Barnes
The BIOS shouldn't be touching this memory across suspend/resume, so just leave it alone. This saves us ~50ms on resume on my T420. v2: change gtt restore default on pre-gen4 (Chris) move needs_gtt_restore flag into dev_priv Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_dma.c |

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

2012-10-15 Thread Jesse Barnes
On Mon, 15 Oct 2012 10:42:03 +0100 Chris Wilson wrote: > On Mon, 15 Oct 2012 09:37:00 +0100, Chris Wilson > wrote: > > On Sun, 14 Oct 2012 19:10:38 -0700, Jesse Barnes > > wrote: > > > The BIOS shouldn't be touching this memory across suspend/resume, so > > > just leave it alone. This saves

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

2012-10-15 Thread Jesse Barnes
On Mon, 15 Oct 2012 09:41:33 +0200 Daniel Vetter wrote: > On Sun, Oct 14, 2012 at 07:10:38PM -0700, Jesse Barnes wrote: > > The BIOS shouldn't be touching this memory across suspend/resume, so > > just leave it alone. This saves us ~50ms on resume on my T420. > > Is that 50ms still accurate wit

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

2012-10-15 Thread Chris Wilson
On Mon, 15 Oct 2012 09:37:00 +0100, Chris Wilson wrote: > On Sun, 14 Oct 2012 19:10:38 -0700, Jesse Barnes > wrote: > > The BIOS shouldn't be touching this memory across suspend/resume, so > > just leave it alone. This saves us ~50ms on resume on my T420. > > > > Signed-off-by: Jesse Barnes

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

2012-10-15 Thread Chris Wilson
On Sun, 14 Oct 2012 19:10:38 -0700, Jesse Barnes wrote: > The BIOS shouldn't be touching this memory across suspend/resume, so > just leave it alone. This saves us ~50ms on resume on my T420. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/i915_drv.c |7 ++- > 1 file chan

Re: [Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

2012-10-15 Thread Daniel Vetter
On Sun, Oct 14, 2012 at 07:10:38PM -0700, Jesse Barnes wrote: > The BIOS shouldn't be touching this memory across suspend/resume, so > just leave it alone. This saves us ~50ms on resume on my T420. Is that 50ms still accurate with wc gtt ptes? -Daniel > > Signed-off-by: Jesse Barnes > --- > d

[Intel-gfx] [PATCH 3/3] drm/i915: don't rewrite the GTT on resume

2012-10-14 Thread Jesse Barnes
The BIOS shouldn't be touching this memory across suspend/resume, so just leave it alone. This saves us ~50ms on resume on my T420. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_drv.c |7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i