Re: [Intel-gfx] [PATCH 14/20] drm/i915: enable SDEIER later

2014-03-28 Thread Daniel Vetter
On Fri, Mar 28, 2014 at 7:20 AM, Ben Widawsky wrote: > On Thu, Mar 27, 2014 at 11:39:36AM -0300, Paulo Zanoni wrote: >> 2014-03-18 17:29 GMT-03:00 Ben Widawsky : >> > On Fri, Mar 07, 2014 at 08:10:30PM -0300, Paulo Zanoni wrote: >> >> From: Paulo Zanoni >> >> >> >> On the preinstall stage we shou

Re: [Intel-gfx] [PATCH 14/20] drm/i915: enable SDEIER later

2014-03-27 Thread Ben Widawsky
On Thu, Mar 27, 2014 at 11:39:36AM -0300, Paulo Zanoni wrote: > 2014-03-18 17:29 GMT-03:00 Ben Widawsky : > > On Fri, Mar 07, 2014 at 08:10:30PM -0300, Paulo Zanoni wrote: > >> From: Paulo Zanoni > >> > >> On the preinstall stage we should just disable all the interrupts, but > >> we currently ena

Re: [Intel-gfx] [PATCH 14/20] drm/i915: enable SDEIER later

2014-03-27 Thread Paulo Zanoni
2014-03-18 17:29 GMT-03:00 Ben Widawsky : > On Fri, Mar 07, 2014 at 08:10:30PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> On the preinstall stage we should just disable all the interrupts, but >> we currently enable all the south display interrupts due to the way we >> touch SDEIER at

Re: [Intel-gfx] [PATCH 14/20] drm/i915: enable SDEIER later

2014-03-18 Thread Ben Widawsky
On Fri, Mar 07, 2014 at 08:10:30PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > On the preinstall stage we should just disable all the interrupts, but > we currently enable all the south display interrupts due to the way we > touch SDEIER at the IRQ handlers (note: they are still masked an

[Intel-gfx] [PATCH 14/20] drm/i915: enable SDEIER later

2014-03-07 Thread Paulo Zanoni
From: Paulo Zanoni On the preinstall stage we should just disable all the interrupts, but we currently enable all the south display interrupts due to the way we touch SDEIER at the IRQ handlers (note: they are still masked and our IRQ handler is disabled). Instead of doing that, let's make the pr