On Fri, Mar 28, 2014 at 7:20 AM, Ben Widawsky <b...@bwidawsk.net> wrote: > On Thu, Mar 27, 2014 at 11:39:36AM -0300, Paulo Zanoni wrote: >> 2014-03-18 17:29 GMT-03:00 Ben Widawsky <b...@bwidawsk.net>: >> > On Fri, Mar 07, 2014 at 08:10:30PM -0300, Paulo Zanoni wrote: >> >> From: Paulo Zanoni <paulo.r.zan...@intel.com> >> >> >> >> On the preinstall stage we should just disable all the interrupts, but >> >> we currently enable all the south display interrupts due to the way we >> >> touch SDEIER at the IRQ handlers (note: they are still masked and our >> >> IRQ handler is disabled). >> > >> > I think this statement is false. The interrupt is enabled right after >> > preinstall(). For the nomodeset case, this actually seems to make some >> > difference. It still looks fine to me though. >> >> Could you please clarify this paragraph? > > The point was, "IRQ handler is disabled" is false. At least when I last > checked. We've registered the interrupt by then, which means we can > potentially get interrupts from the hardware. > > I think we just might disagree on what "enabled" means. Perhaps this is > due to me working for too long with buggy hardware. In any event, as I > said, it does look fine to me as is.
I think a polished comment to explain that despite the irq handler being register we shouldn't yet get interrupts and hence won't race is justified here? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
