Re: [Intel-gfx] [PATCH 1/5] drm/i915: Cleanup instdone state

2012-08-15 Thread Ben Widawsky
On 2012-08-15 02:14, Chris Wilson wrote: On Tue, 14 Aug 2012 14:35:13 -0700, Ben Widawsky wrote: Clear the cached instdone state to match what we expect from hardware and prevent us from comparing stale values. Actually, clearing the state is not the same as setting idle state. There would be

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Cleanup instdone state

2012-08-15 Thread Chris Wilson
On Tue, 14 Aug 2012 14:35:13 -0700, Ben Widawsky wrote: > Clear the cached instdone state to match what we expect from hardware > and prevent us from comparing stale values. > > Actually, clearing the state is not the same as setting idle state. > There would be a known state of idle (ie. all uni

[Intel-gfx] [PATCH 1/5] drm/i915: Cleanup instdone state

2012-08-14 Thread Ben Widawsky
Clear the cached instdone state to match what we expect from hardware and prevent us from comparing stale values. Actually, clearing the state is not the same as setting idle state. There would be a known state of idle (ie. all units are done), but since it differs for every platform, we can just