Re: [Intel-gfx] [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode

2015-06-12 Thread Jani Nikula
On Wed, 10 Jun 2015, "O'Rourke, Tom" wrote: >> > + >> > + dev_priv->rps.efficient_freq *= >> > + (IS_SKYLAKE(dev) ? GEN9_FREQ_SCALER : 1); > > This line seems awkward. I suppose a good compiler could > optimize out the multiply by one. > > I wou

Re: [Intel-gfx] [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode

2015-06-10 Thread O'Rourke, Tom
> > + > > + dev_priv->rps.efficient_freq *= > > + (IS_SKYLAKE(dev) ? GEN9_FREQ_SCALER : 1); This line seems awkward. I suppose a good compiler could optimize out the multiply by one. I would prefer something like: if(IS_SKYLAKE

Re: [Intel-gfx] [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode

2015-06-09 Thread Rodrigo Vivi
I have no access to this documentation, but overall it makes sense from the units I saw so feel free to use: Reviewed-by: Rodrigo Vivi On Sun, Jun 7, 2015 at 6:02 AM, wrote: > From: Akash Goel > > Read the efficient frequency (aka RPe) value through the the mailbox > command (0x1A) from the pc

[Intel-gfx] [PATCH 1/5] drm/i915/skl: Retrieve the Rpe value from Pcode

2015-06-07 Thread akash . goel
From: Akash Goel Read the efficient frequency (aka RPe) value through the the mailbox command (0x1A) from the pcode, as done on Haswell and Broadwell. The turbo minimum frequency softlimit is not revised as per the efficient frequency value. Issue: VIZ-5143 Signed-off-by: Akash Goel --- driver