Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-29 Thread Daniel Vetter
On Tue, Jul 29, 2014 at 02:38:36PM +0300, Imre Deak wrote: > On Sat, 2014-07-12 at 17:17 +0530, Shobhit Kumar wrote: > > Call to vlv_crtc_clock_get is not needed for DSI and was causing dpio > > read WARN dumps as well. Absence of ->get_config was casuing othet WARN > > dumps as well. With this the

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-29 Thread Imre Deak
On Sat, 2014-07-12 at 17:17 +0530, Shobhit Kumar wrote: > Call to vlv_crtc_clock_get is not needed for DSI and was causing dpio > read WARN dumps as well. Absence of ->get_config was casuing othet WARN > dumps as well. With this the last of the known WARN dumps for DSI should > be fixed. > > Signe

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-15 Thread Kumar, Shobhit
On 7/14/2014 9:20 PM, Daniel Vetter wrote: On Mon, Jul 14, 2014 at 4:36 PM, Kumar, Shobhit wrote: /* XXX: read flags, set to adjusted_mode */ + pipe_config->quirks = 1; Nack. First you need to use one of the symbolic quirk definitions (there's a bunch of them). Second this ne

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-14 Thread Daniel Vetter
On Mon, Jul 14, 2014 at 4:36 PM, Kumar, Shobhit wrote: >>> /* XXX: read flags, set to adjusted_mode */ >>> + pipe_config->quirks = 1; >> >> >> Nack. First you need to use one of the symbolic quirk definitions >> (there's a bunch of them). Second this needs a comment why exactly we >

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-14 Thread Kumar, Shobhit
On 7/12/2014 5:28 PM, Daniel Vetter wrote: On Sat, Jul 12, 2014 at 1:47 PM, Shobhit Kumar wrote: Call to vlv_crtc_clock_get is not needed for DSI and was causing dpio read WARN dumps as well. Absence of ->get_config was casuing othet WARN dumps as well. With this the last of the known WARN dump

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-12 Thread Daniel Vetter
On Sat, Jul 12, 2014 at 1:47 PM, Shobhit Kumar wrote: > Call to vlv_crtc_clock_get is not needed for DSI and was causing dpio > read WARN dumps as well. Absence of ->get_config was casuing othet WARN > dumps as well. With this the last of the known WARN dumps for DSI should > be fixed. > > Signed-

[Intel-gfx] [PATCH 1/3] drm/i915: Add get_config implementation for DSI encoder

2014-07-12 Thread Shobhit Kumar
Call to vlv_crtc_clock_get is not needed for DSI and was causing dpio read WARN dumps as well. Absence of ->get_config was casuing othet WARN dumps as well. With this the last of the known WARN dumps for DSI should be fixed. Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/intel_display.c |