Re: [Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-15 Thread Ben Widawsky
On Sun, Dec 15, 2013 at 09:24:11AM +, Chris Wilson wrote: > On Sat, Dec 14, 2013 at 05:42:42PM -0800, Ben Widawsky wrote: > > On Sat, Dec 14, 2013 at 09:45:34PM +, Chris Wilson wrote: > > > On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > > > > Having the ring id all set up w

Re: [Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-15 Thread Chris Wilson
On Sat, Dec 14, 2013 at 05:42:42PM -0800, Ben Widawsky wrote: > On Sat, Dec 14, 2013 at 09:45:34PM +, Chris Wilson wrote: > > On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > > > Having the ring id all set up will allow us to use some macro shortcuts > > > during ringbuffer init.

Re: [Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:45:34PM +, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > > Having the ring id all set up will allow us to use some macro shortcuts > > during ringbuffer init. Admittedly it leaves the code a bit confusing, > > having the initial

Re: [Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-14 Thread Chris Wilson
On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > Having the ring id all set up will allow us to use some macro shortcuts > during ringbuffer init. Admittedly it leaves the code a bit confusing, > having the initialization of the id member in a separate place - but I > think the savin

[Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-13 Thread Ben Widawsky
Having the ring id all set up will allow us to use some macro shortcuts during ringbuffer init. Admittedly it leaves the code a bit confusing, having the initialization of the id member in a separate place - but I think the savings is worth it. Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i91