On Sat, Dec 14, 2013 at 09:45:34PM +0000, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > > Having the ring id all set up will allow us to use some macro shortcuts > > during ringbuffer init. Admittedly it leaves the code a bit confusing, > > having the initialization of the id member in a separate place - but I > > think the savings is worth it. > > This is not required since the macro could be written more simply as > ring[i]->id == i. > -Chris >
It could be written as ring->id = i. Is that what you mean? I didn't quite follow the "not required" part. -- Ben Widawsky, Intel Open Source Technology Center _______________________________________________ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx
