Re: [Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-09 Thread Peter Clifton
On Tue, 2010-11-09 at 10:52 +, Peter Clifton wrote: > On Sun, 2010-11-07 at 10:25 +, Chris Wilson wrote: > I've not tried that yet, but the PRM does state that BLT pitch is in > DWORDs. Gah.. the PRM is badly written in places! In one place it states DWORDs, then in another you get the ac

Re: [Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-09 Thread Chris Wilson
On Tue, 09 Nov 2010 11:34:52 +, Peter Clifton wrote: > On Tue, 2010-11-09 at 10:52 +, Peter Clifton wrote: > > On Sun, 2010-11-07 at 10:25 +, Chris Wilson wrote: > > > I've not tried that yet, but the PRM does state that BLT pitch is in > > DWORDs. > > Gah.. the PRM is badly written

Re: [Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-09 Thread Peter Clifton
On Sun, 2010-11-07 at 10:25 +, Chris Wilson wrote: > On Sat, 06 Nov 2010 10:04:31 +, Peter Clifton wrote: > > Fixes corruption with glBufferSubData on my machine, > > > > Can someone review and push? > > Oddly, the pitch for BLT is in bytes and it should be sufficient to be a > multiple

Re: [Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-07 Thread Chris Wilson
On Sat, 06 Nov 2010 10:04:31 +, Peter Clifton wrote: > Fixes corruption with glBufferSubData on my machine, > > Can someone review and push? Oddly, the pitch for BLT is in bytes and it should be sufficient to be a multiple of element-size. Or two element-size depending on circumstances. Ju

[Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-06 Thread Peter Clifton
Fixes corruption with glBufferSubData on my machine, Can someone review and push? (Resent with code comment fixed) -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in

[Intel-gfx] [PATCH] intel: Fix emit_linear_blit to use DWORD aligned width blits

2010-11-06 Thread Peter Clifton
Fixes corruption with glBufferSubData on my machine, Can someone review and push? -- Peter Clifton Electrical Engineering Division, Engineering Department, University of Cambridge, 9, JJ Thomson Avenue, Cambridge CB3 0FA Tel: +44 (0)7729 980173 - (No signal in the lab!) Tel: +44 (0)1223 748328