Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-17 Thread Daniel Vetter
On Tue, Jan 17, 2012 at 07:08:09AM +0800, Wu Fengguang wrote: > On Mon, Jan 16, 2012 at 12:44:43PM -0800, Keith Packard wrote: > > On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter wrote: > > > > > Keith, does this address your concern and this patch is r-b: Keith or do > > > we want an > > > >

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Keith Packard
On Tue, 17 Jan 2012 07:08:09 +0800, Wu Fengguang wrote: > On Mon, Jan 16, 2012 at 12:44:43PM -0800, Keith Packard wrote: > > On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter wrote: > > > > > Keith, does this address your concern and this patch is r-b: Keith or do > > > we want an > > > > > > }

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Wu Fengguang
On Mon, Jan 16, 2012 at 12:44:43PM -0800, Keith Packard wrote: > On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter wrote: > > > Keith, does this address your concern and this patch is r-b: Keith or do > > we want an > > > > } else { > > I915_WRITE(aud_config, 0); > > } > > > > for paranoia?

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Keith Packard
On Mon, 16 Jan 2012 21:26:18 +0100, Daniel Vetter wrote: > Keith, does this address your concern and this patch is r-b: Keith or do > we want an > > } else { > I915_WRITE(aud_config, 0); > } > > for paranoia? I think we want this added, just to be sure we set the configuration correctly

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Daniel Vetter
On Mon, Jan 16, 2012 at 04:02:53PM +0800, Wu Fengguang wrote: > On Thu, Jan 12, 2012 at 09:33:34AM -0800, Keith Packard wrote: > > On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang > > wrote: > > > > > @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr > > > if (intel_pipe_has_type(

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Wu Fengguang
On Thu, Jan 12, 2012 at 09:33:34AM -0800, Keith Packard wrote: > On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang > wrote: > > > @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr > > if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) { > > DRM_DEBUG_DRIVER("ELD

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-12 Thread Keith Packard
On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang wrote: > @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr > if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) { > DRM_DEBUG_DRIVER("ELD: DisplayPort detected\n"); > eld[5] |= (1 << 2); /* C

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-09 Thread Wu Fengguang
On Mon, Jan 09, 2012 at 09:22:47AM -0800, Keith Packard wrote: > On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang > wrote: > > > +#define IBX_AUD_CONFIG_A 0xe2000 > > +#define CPT_AUD_CONFIG_A 0xe5000 > > These register addresses match the docs. > > > + I915_WRITE(

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-09 Thread Keith Packard
On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang wrote: > +#define IBX_AUD_CONFIG_A 0xe2000 > +#define CPT_AUD_CONFIG_A 0xe5000 These register addresses match the docs. > + I915_WRITE(aud_config, 1 << 29); /* N value index, 0x1 = DP */ Please don't use consta

[Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-09 Thread Wu Fengguang
It should be programmed to "0" for HDMI or "1" for DisplayPort. This enables DisplayPort audio for - HP EliteBook 8460p (whose BIOS does not set the N_value_index bit for us) - DisplayPort monitor hot plugged after boot (otherwise most BIOS will fill the N_value_index bit for us) Signed-off