Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-15 Thread Ville Syrjälä
On Thu, Oct 15, 2015 at 04:00:48PM -0700, Kevin Strasser wrote: > On Thu, Oct 15, 2015 at 11:20:59AM +0300, Ville Syrjälä wrote: > > On Wed, Oct 14, 2015 at 01:33:57PM -0700, Kevin Strasser wrote: > > > On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > > > > Does it? I just tried it

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-15 Thread Kevin Strasser
On Thu, Oct 15, 2015 at 11:20:59AM +0300, Ville Syrjälä wrote: > On Wed, Oct 14, 2015 at 01:33:57PM -0700, Kevin Strasser wrote: > > On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > > > Does it? I just tried it on IVB, and behaves just like you said. So not > > > sure how far back t

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-15 Thread Ville Syrjälä
On Wed, Oct 14, 2015 at 01:33:57PM -0700, Kevin Strasser wrote: > On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 14, 2015 at 11:59:59AM -0700, Kevin Strasser wrote: > [...] > > > Just to level set, these cases will produce different CRCs on HSW: > > > 1. Primary pla

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Kevin Strasser
On Wed, Oct 14, 2015 at 10:48:52PM +0300, Ville Syrjälä wrote: > On Wed, Oct 14, 2015 at 11:59:59AM -0700, Kevin Strasser wrote: [...] > > Just to level set, these cases will produce different CRCs on HSW: > > 1. Primary plane disabled, gamma correction disabled > > 2. Primary plane disabled, gam

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Ville Syrjälä
On Wed, Oct 14, 2015 at 11:59:59AM -0700, Kevin Strasser wrote: > On Wed, Oct 14, 2015 at 03:22:23PM +0300, Ville Syrjälä wrote: > > On Wed, Oct 14, 2015 at 01:12:27PM +0100, Chris Wilson wrote: > > > On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote: > > > > On Tue, Oct 13, 2015 at 02:

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Daniel Vetter
On Wed, Oct 14, 2015 at 8:44 PM, Kevin Strasser wrote: > On Wed, Oct 14, 2015 at 10:58:29AM +0300, Jani Nikula wrote: >> On Wed, 14 Oct 2015, Kevin Strasser wrote: >> > On HSW the crc differs between black and disabled primary planes, causing >> > an >> > assert to fail in the kms_universal_plan

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Kevin Strasser
On Wed, Oct 14, 2015 at 03:22:23PM +0300, Ville Syrjälä wrote: > On Wed, Oct 14, 2015 at 01:12:27PM +0100, Chris Wilson wrote: > > On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote: > > > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote: [...] > > > > - I915_

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Kevin Strasser
On Wed, Oct 14, 2015 at 10:58:29AM +0300, Jani Nikula wrote: > On Wed, 14 Oct 2015, Kevin Strasser wrote: > > On HSW the crc differs between black and disabled primary planes, causing an > > assert to fail in the kms_universal_plane test. It seems that things like > > gamma > > correction are cau

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Ville Syrjälä
On Wed, Oct 14, 2015 at 03:04:05PM +0200, Daniel Vetter wrote: > On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote: > > > On HSW the crc differs between black and disabled primary planes, causing > > > an > > > assert

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Daniel Vetter
On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote: > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote: > > On HSW the crc differs between black and disabled primary planes, causing an > > assert to fail in the kms_universal_plane test. It seems that things like > > gamma

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Ville Syrjälä
On Wed, Oct 14, 2015 at 01:12:27PM +0100, Chris Wilson wrote: > On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote: > > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote: > > > On HSW the crc differs between black and disabled primary planes, causing > > > an > > > assert t

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Chris Wilson
On Wed, Oct 14, 2015 at 03:07:41PM +0300, Ville Syrjälä wrote: > On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote: > > On HSW the crc differs between black and disabled primary planes, causing an > > assert to fail in the kms_universal_plane test. It seems that things like > > gamma

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Ville Syrjälä
On Tue, Oct 13, 2015 at 02:24:41PM -0700, Kevin Strasser wrote: > On HSW the crc differs between black and disabled primary planes, causing an > assert to fail in the kms_universal_plane test. It seems that things like > gamma > correction are causing the black primary plane case to result in a br

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Jani Nikula
On Wed, 14 Oct 2015, Jani Nikula wrote: > On Wed, 14 Oct 2015, Kevin Strasser wrote: >> On HSW the crc differs between black and disabled primary planes, causing an >> assert to fail in the kms_universal_plane test. It seems that things like >> gamma >> correction are causing the black primary p

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-14 Thread Jani Nikula
On Wed, 14 Oct 2015, Kevin Strasser wrote: > On HSW the crc differs between black and disabled primary planes, causing an > assert to fail in the kms_universal_plane test. It seems that things like > gamma > correction are causing the black primary plane case to result in a brighter > color than

Re: [Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-13 Thread Jesse Barnes
On 10/13/2015 02:24 PM, Kevin Strasser wrote: > On HSW the crc differs between black and disabled primary planes, causing an > assert to fail in the kms_universal_plane test. It seems that things like > gamma > correction are causing the black primary plane case to result in a brighter > color tha

[Intel-gfx] [PATCH] drm/i915: respect previous reg values on primary plane disable

2015-10-13 Thread Kevin Strasser
On HSW the crc differs between black and disabled primary planes, causing an assert to fail in the kms_universal_plane test. It seems that things like gamma correction are causing the black primary plane case to result in a brighter color than the disabled primary plane case. Only toggle the enabl