Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-24 Thread Daniel Vetter
On Tue, Sep 24, 2013 at 01:05:07PM +0100, Chris Wilson wrote: > On Tue, Sep 24, 2013 at 11:46:14AM +0200, Daniel Vetter wrote: > > This regression has been introduced in > > > > commit 9f11a9e4e50006b615ba94722dfc33ced89664cf > > Author: Daniel Vetter > > Date: Thu Jun 13 00:54:58 2013 +0200 >

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-24 Thread Chris Wilson
On Tue, Sep 24, 2013 at 11:46:14AM +0200, Daniel Vetter wrote: > This regression has been introduced in > > commit 9f11a9e4e50006b615ba94722dfc33ced89664cf > Author: Daniel Vetter > Date: Thu Jun 13 00:54:58 2013 +0200 > > drm/i915: set up PIPECONF explicitly for i9xx/vlv platforms > > Vi

[Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-24 Thread Daniel Vetter
This regression has been introduced in commit 9f11a9e4e50006b615ba94722dfc33ced89664cf Author: Daniel Vetter Date: Thu Jun 13 00:54:58 2013 +0200 drm/i915: set up PIPECONF explicitly for i9xx/vlv platforms Ville brough up the idea that this is just the pipe A quirk gone wrong. Note that

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-24 Thread Chris Wilson
On Tue, Sep 24, 2013 at 11:05:57AM +0200, Daniel Vetter wrote: > On Mon, Sep 23, 2013 at 10:55:35AM +0100, Chris Wilson wrote: > > On Mon, Sep 23, 2013 at 10:37:02AM +0200, Daniel Vetter wrote: > > > On Mon, Sep 23, 2013 at 10:17 AM, Ville Syrjälä > > > wrote: > > > > Hmm. Why not just this? > > >

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-24 Thread Daniel Vetter
On Mon, Sep 23, 2013 at 10:55:35AM +0100, Chris Wilson wrote: > On Mon, Sep 23, 2013 at 10:37:02AM +0200, Daniel Vetter wrote: > > On Mon, Sep 23, 2013 at 10:17 AM, Ville Syrjälä > > wrote: > > > Hmm. Why not just this? > > > > > > pipeconf = 0; > > > if (pipe == PIPE_A && QUIRK) > > > pipeconf |

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Chris Wilson
On Tue, Sep 24, 2013 at 12:18:32AM +0300, Meelis Roos wrote: > > Good news, testing nightly+ with patch results in machine death. Now > > seeing just where death creeps in. > > I am seeing these with just stock nightly. Maybe related... > > [ 3405.571241] shrink_slab: i915_gem_inactive_scan+0x0/0

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Meelis Roos
> Good news, testing nightly+ with patch results in machine death. Now > seeing just where death creeps in. I am seeing these with just stock nightly. Maybe related... [ 3405.571241] shrink_slab: i915_gem_inactive_scan+0x0/0x70 [i915] negative objects to delete nr=-1568632773 [ 3405.571331] shri

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Chris Wilson
On Mon, Sep 23, 2013 at 11:05:25PM +0300, Meelis Roos wrote: > > It works, thank you! No more WARNING. > > > > However, it now keeps spamming dmesg every 10 seconds about CRT not > > connected: > > No, false alarm - the current upstream of > 3.12.0-rc1-00336-gd8524ae-dirty is doing that even wi

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Meelis Roos
> It works, thank you! No more WARNING. > > However, it now keeps spamming dmesg every 10 seconds about CRT not > connected: No, false alarm - the current upstream of 3.12.0-rc1-00336-gd8524ae-dirty is doing that even without the pipe patch. -- Meelis Roos __

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Chris Wilson
On Sun, Sep 22, 2013 at 08:51:12PM +0200, Daniel Vetter wrote: > This regression has been introduced in > > commit 9f11a9e4e50006b615ba94722dfc33ced89664cf > Author: Daniel Vetter > Date: Thu Jun 13 00:54:58 2013 +0200 > > drm/i915: set up PIPECONF explicitly for i9xx/vlv platforms > > Vi

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Chris Wilson
On Mon, Sep 23, 2013 at 10:37:02AM +0200, Daniel Vetter wrote: > On Mon, Sep 23, 2013 at 10:17 AM, Ville Syrjälä > wrote: > > Hmm. Why not just this? > > > > pipeconf = 0; > > if (pipe == PIPE_A && QUIRK) > > pipeconf |= PIPECONF_ENABLE; > > After resume the bios might or might not have enabled

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Daniel Vetter
On Mon, Sep 23, 2013 at 10:17 AM, Ville Syrjälä wrote: > Hmm. Why not just this? > > pipeconf = 0; > if (pipe == PIPE_A && QUIRK) > pipeconf |= PIPECONF_ENABLE; After resume the bios might or might not have enabled pipe A already. We have a bit of magic to make sure that on resume we set up a de

Re: [Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-23 Thread Ville Syrjälä
On Sun, Sep 22, 2013 at 08:51:12PM +0200, Daniel Vetter wrote: > This regression has been introduced in > > commit 9f11a9e4e50006b615ba94722dfc33ced89664cf > Author: Daniel Vetter > Date: Thu Jun 13 00:54:58 2013 +0200 > > drm/i915: set up PIPECONF explicitly for i9xx/vlv platforms > > Vi

[Intel-gfx] [PATCH] drm/i915: preserve pipe A quirk in i9xx_set_pipeconf

2013-09-22 Thread Daniel Vetter
This regression has been introduced in commit 9f11a9e4e50006b615ba94722dfc33ced89664cf Author: Daniel Vetter Date: Thu Jun 13 00:54:58 2013 +0200 drm/i915: set up PIPECONF explicitly for i9xx/vlv platforms Ville brough up the idea that this is just the pipe A quirk gone wrong. Bugzilla: