Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-07-04 Thread Daniel Vetter
On Fri, Jun 22, 2012 at 06:53:01PM +0100, Chris Wilson wrote: > On Fri, 22 Jun 2012 10:40:22 -0700, Keith Packard wrote: > > Chris Wilson writes: > > > > > On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard > > > wrote: > > > > > It was structured to minimise lane count because certain chipset

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-22 Thread Chris Wilson
On Fri, 22 Jun 2012 10:40:22 -0700, Keith Packard wrote: > Chris Wilson writes: > > > On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard wrote: > > > It was structured to minimise lane count because certain chipsets did > > not wire up all the lanes, right? Is that still relevant as we are usin

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-22 Thread Keith Packard
Jesse Barnes writes: > In embedded applications, some of the lanes may not exist, but the DPCD > should indicate that (though as Keith says, some lie about it). But if > we set aside eDP it may be safe... Yeah, that's my thinking. We should probably include eDP hooked up to the PCH DP lanes (fo

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-22 Thread Keith Packard
Chris Wilson writes: > On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard wrote: > It was structured to minimise lane count because certain chipsets did > not wire up all the lanes, right? Is that still relevant as we are using > the advertised max_lane_count from the DPCD now? We've always use

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-22 Thread Jesse Barnes
On Fri, 22 Jun 2012 10:05:19 +0100 Chris Wilson wrote: > On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard wrote: > > Jesse Barnes writes: > > > > > High frequency link configurations have the potential to cause trouble > > > with long and/or cheap cables, so prefer slow and wide configuration

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-22 Thread Adam Jackson
On Fri, 2012-06-22 at 10:05 +0100, Chris Wilson wrote: > On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard wrote: > > Jesse Barnes writes: > > > > > High frequency link configurations have the potential to cause trouble > > > with long and/or cheap cables, so prefer slow and wide configurations

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-22 Thread Chris Wilson
On Thu, 21 Jun 2012 18:13:19 -0700, Keith Packard wrote: > Jesse Barnes writes: > > > High frequency link configurations have the potential to cause trouble > > with long and/or cheap cables, so prefer slow and wide configurations > > instead. This patch has the potential to cause trouble for e

Re: [Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-21 Thread Keith Packard
Jesse Barnes writes: > High frequency link configurations have the potential to cause trouble > with long and/or cheap cables, so prefer slow and wide configurations > instead. This patch has the potential to cause trouble for eDP > configurations that lie about available lanes, so if we run int

[Intel-gfx] [PATCH] drm/i915: prefer wide & slow to fast & narrow in DP configs

2012-06-21 Thread Jesse Barnes
High frequency link configurations have the potential to cause trouble with long and/or cheap cables, so prefer slow and wide configurations instead. This patch has the potential to cause trouble for eDP configurations that lie about available lanes, so if we run into that we can make it condition