Re: [Intel-gfx] [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M

2010-08-09 Thread Eric Anholt
On Mon, 09 Aug 2010 18:04:50 +0100, Chris Wilson wrote: > On Mon, 9 Aug 2010 09:45:38 -0700, Jesse Barnes > wrote: > > Is this hack even needed? I noticed on my 945GM that INSTDONE has a > > stuck bit when I use this code, removing it didn't seem to have any > > negative effects... > > I'm no

Re: [Intel-gfx] [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M

2010-08-09 Thread Chris Wilson
On Mon, 9 Aug 2010 09:45:38 -0700, Jesse Barnes wrote: > Is this hack even needed? I noticed on my 945GM that INSTDONE has a > stuck bit when I use this code, removing it didn't seem to have any > negative effects... I'm not sure why we need to trigger a Sync on the GPU at this point, I just as

Re: [Intel-gfx] [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M

2010-08-09 Thread Jesse Barnes
On Sun, 8 Aug 2010 19:39:40 +0100 Chris Wilson wrote: > From: Zhenyu Wang > > The sync flush enable mask on 845G and 830M is flipped. > So driver should invert it usage. > > Signed-off-by: Zhenyu Wang > Reviewed-by: Chris Wilson > --- > drivers/gpu/drm/i915/i915_dma.c | 10 -- >

[Intel-gfx] [PATCH] drm/i915: fix errata for sync flush enable on 845G/830M

2010-08-08 Thread Chris Wilson
From: Zhenyu Wang The sync flush enable mask on 845G and 830M is flipped. So driver should invert it usage. Signed-off-by: Zhenyu Wang Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_dma.c | 10 -- 1 files changed, 8 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr