Re: [Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

2013-04-24 Thread Jani Nikula
On Wed, 24 Apr 2013, Daniel Vetter wrote: > Our rps code relies on the interrupts being off to prevent re-arming > of the work items at inopportune moments. > > Also drop the redundant cancel_work for the main rps work, > disable_gt_powersave already takes care of that. > > Finally add a WARN_ON t

[Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

2013-04-24 Thread Daniel Vetter
Our rps code relies on the interrupts being off to prevent re-arming of the work items at inopportune moments. Also drop the redundant cancel_work for the main rps work, disable_gt_powersave already takes care of that. Finally add a WARN_ON to ensure we obey that piece of ordering constraint. Lon

Re: [Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

2013-04-24 Thread Jani Nikula
On Wed, 24 Apr 2013, Daniel Vetter wrote: > Our rps code relies on the interrupts being off to prevent re-arming > of the work items at inopportune moments. > > Also drop the redundant cancel_work for the main rps work, > disable_gt_powersave already takes care of that. > > Finally add a WARN_ON t

Re: [Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

2013-04-24 Thread Daniel Vetter
On Wed, Apr 24, 2013 at 10:35:16AM +0100, Chris Wilson wrote: > On Wed, Apr 24, 2013 at 11:19:20AM +0200, Daniel Vetter wrote: > > Our rps code relies on the interrupts being off to prevent re-arming > > of the work items at inopportune moments. > > > > Also drop the redundant cancel_work for the

Re: [Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

2013-04-24 Thread Chris Wilson
On Wed, Apr 24, 2013 at 11:19:20AM +0200, Daniel Vetter wrote: > Our rps code relies on the interrupts being off to prevent re-arming > of the work items at inopportune moments. > > Also drop the redundant cancel_work for the main rps work, > disable_gt_powersave already takes care of that. > > F

[Intel-gfx] [PATCH] drm/i915: disable interrupts earlier in the driver unload code

2013-04-24 Thread Daniel Vetter
Our rps code relies on the interrupts being off to prevent re-arming of the work items at inopportune moments. Also drop the redundant cancel_work for the main rps work, disable_gt_powersave already takes care of that. Finally add a WARN_ON to ensure we obey that piece of ordering constraint. Lon