Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-09-08 Thread Daniel Vetter
On Wed, Aug 27, 2014 at 04:00:22PM -0700, Jesse Barnes wrote: > On Wed, 27 Aug 2014 10:43:37 +0200 > Daniel Vetter wrote: > > > Now that vlv has runtime pm we kinda should check for that like on the > > pch split platforms. Looks like this was simply lost in the vlv rpm > > enabling. > > > > Cc:

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-09-04 Thread Jesse Barnes
On Thu, 4 Sep 2014 18:59:55 +0200 Daniel Vetter wrote: > On Thu, Sep 4, 2014 at 6:24 PM, Jesse Barnes wrote: > > On Thu, 4 Sep 2014 17:59:18 +0200 > > Daniel Vetter wrote: > > > >> On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes > >> wrote: > >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-09-04 Thread Daniel Vetter
On Thu, Sep 4, 2014 at 6:24 PM, Jesse Barnes wrote: > On Thu, 4 Sep 2014 17:59:18 +0200 > Daniel Vetter wrote: > >> On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes >> wrote: >> >> diff --git a/drivers/gpu/drm/i915/i915_irq.c >> >> b/drivers/gpu/drm/i915/i915_irq.c >> >> index 9eb303c1b621..76bc4

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-09-04 Thread Jesse Barnes
On Thu, 4 Sep 2014 17:59:18 +0200 Daniel Vetter wrote: > On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes > wrote: > >> diff --git a/drivers/gpu/drm/i915/i915_irq.c > >> b/drivers/gpu/drm/i915/i915_irq.c > >> index 9eb303c1b621..76bc4d0de5a4 100644 > >> --- a/drivers/gpu/drm/i915/i915_irq.c > >>

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-09-04 Thread Daniel Vetter
On Thu, Aug 28, 2014 at 1:00 AM, Jesse Barnes wrote: >> diff --git a/drivers/gpu/drm/i915/i915_irq.c >> b/drivers/gpu/drm/i915/i915_irq.c >> index 9eb303c1b621..76bc4d0de5a4 100644 >> --- a/drivers/gpu/drm/i915/i915_irq.c >> +++ b/drivers/gpu/drm/i915/i915_irq.c >> @@ -589,6 +589,7 @@ __i915_enab

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-08-27 Thread Jesse Barnes
On Wed, 27 Aug 2014 10:43:37 +0200 Daniel Vetter wrote: > Now that vlv has runtime pm we kinda should check for that like on the > pch split platforms. Looks like this was simply lost in the vlv rpm > enabling. > > Cc: Paulo Zanoni > Cc: Imre Deak > Cc: Jesse Barnes > Signed-off-by: Daniel Ve

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-08-27 Thread Daniel Vetter
On Wed, Aug 27, 2014 at 1:28 PM, Chris Wilson wrote: > On Wed, Aug 27, 2014 at 12:23:47PM +0200, Daniel Vetter wrote: >> On Wed, Aug 27, 2014 at 09:51:58AM +0100, Chris Wilson wrote: >> > On Wed, Aug 27, 2014 at 10:43:37AM +0200, Daniel Vetter wrote: >> > > Now that vlv has runtime pm we kinda sho

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-08-27 Thread Chris Wilson
On Wed, Aug 27, 2014 at 12:23:47PM +0200, Daniel Vetter wrote: > On Wed, Aug 27, 2014 at 09:51:58AM +0100, Chris Wilson wrote: > > On Wed, Aug 27, 2014 at 10:43:37AM +0200, Daniel Vetter wrote: > > > Now that vlv has runtime pm we kinda should check for that like on the > > > pch split platforms. L

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-08-27 Thread Daniel Vetter
On Wed, Aug 27, 2014 at 09:51:58AM +0100, Chris Wilson wrote: > On Wed, Aug 27, 2014 at 10:43:37AM +0200, Daniel Vetter wrote: > > Now that vlv has runtime pm we kinda should check for that like on the > > pch split platforms. Looks like this was simply lost in the vlv rpm > > enabling. > > Is the

Re: [Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-08-27 Thread Chris Wilson
On Wed, Aug 27, 2014 at 10:43:37AM +0200, Daniel Vetter wrote: > Now that vlv has runtime pm we kinda should check for that like on the > pch split platforms. Looks like this was simply lost in the vlv rpm > enabling. Is there a reason why setting up the pipestat prior to enabling interrupts is ve

[Intel-gfx] [PATCH] drm/i915: WARN if interrupts aren't on in en/disable_pipestat

2014-08-27 Thread Daniel Vetter
Now that vlv has runtime pm we kinda should check for that like on the pch split platforms. Looks like this was simply lost in the vlv rpm enabling. Cc: Paulo Zanoni Cc: Imre Deak Cc: Jesse Barnes Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_irq.c | 2 ++ 1 file changed, 2 inser