Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-27 Thread Dave Gordon
On 26/01/16 14:06, Chris Wilson wrote: On Tue, Jan 26, 2016 at 01:51:19PM +, Rodrigo Vivi wrote: On Tue, Jan 26, 2016 at 12:30 AM Chris Wilson <[1]ch...@chris-wilson.co.uk> wrote: On Mon, Jan 25, 2016 at 09:17:15PM +, Chris Wilson wrote: > On Mon, Jan 25, 2016 at 11:

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-26 Thread Chris Wilson
On Tue, Jan 26, 2016 at 01:51:19PM +, Rodrigo Vivi wrote: >On Tue, Jan 26, 2016 at 12:30 AM Chris Wilson ><[1]ch...@chris-wilson.co.uk> wrote: > > On Mon, Jan 25, 2016 at 09:17:15PM +, Chris Wilson wrote: > > On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: >

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-26 Thread Rodrigo Vivi
On Tue, Jan 26, 2016 at 12:30 AM Chris Wilson wrote: > On Mon, Jan 25, 2016 at 09:17:15PM +, Chris Wilson wrote: > > On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: > > > +++ b/drivers/gpu/drm/i915/intel_lrc.c > > > @@ -764,18 +764,18 @@ intel_logical_ring_advance_and_submit(str

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-26 Thread Chris Wilson
On Mon, Jan 25, 2016 at 09:17:15PM +, Chris Wilson wrote: > On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: > > +++ b/drivers/gpu/drm/i915/intel_lrc.c > > @@ -764,18 +764,18 @@ intel_logical_ring_advance_and_submit(struct > > drm_i915_gem_request *request) > > { > > struct i

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-25 Thread Chris Wilson
On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: > +++ b/drivers/gpu/drm/i915/intel_lrc.c > @@ -764,18 +764,18 @@ intel_logical_ring_advance_and_submit(struct > drm_i915_gem_request *request) > { > struct intel_ringbuffer *ringbuf = request->ringbuf; > struct drm_i915_pri

Re: [Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-25 Thread Ben Widawsky
On Mon, Jan 25, 2016 at 11:29:19AM -0800, Rodrigo Vivi wrote: > Commit 7c17d3773 (drm/i915: Use ordered seqno write interrupt generation > on gen8+ execlists) moved two MI_NOOPs to the advance_and_submit functions > and hardcoded the WA_TAIL_DWORDS. With this we don't have a clean way to > implemen

[Intel-gfx] [PATCH] drm/i915: Make wa_tail_dwords flexible for future platforms.

2016-01-25 Thread Rodrigo Vivi
Commit 7c17d3773 (drm/i915: Use ordered seqno write interrupt generation on gen8+ execlists) moved two MI_NOOPs to the advance_and_submit functions and hardcoded the WA_TAIL_DWORDS. With this we don't have a clean way to implement or remove WaIdleLiteRestore for different platforms. This patch aim