Re: [Intel-gfx] [PATCH] drm/i915: Drop rq->ring->vma peeking from error capture

2020-04-24 Thread Andi Shyti
> static void engine_record_execlists(struct intel_engine_coredump *ee) > @@ -1231,8 +1235,10 @@ static void engine_record_execlists(struct > intel_engine_coredump *ee) > struct i915_request * const *port = el->active; > unsigned int n = 0; > > - while (*port) > - re

Re: [Intel-gfx] [PATCH] drm/i915: Drop rq->ring->vma peeking from error capture

2020-04-24 Thread Mika Kuoppala
Chris Wilson writes: > We only hold the active spinlock while dumping the error state, and this > does not prevent another thread from retiring the request -- as it is > quite possible that despite us capturing the current state, the GPU has > completed the request. As such, it is dangerous to de

[Intel-gfx] [PATCH] drm/i915: Drop rq->ring->vma peeking from error capture

2020-04-24 Thread Chris Wilson
We only hold the active spinlock while dumping the error state, and this does not prevent another thread from retiring the request -- as it is quite possible that despite us capturing the current state, the GPU has completed the request. As such, it is dangerous to dereference state below the reque