>  static void engine_record_execlists(struct intel_engine_coredump *ee)
> @@ -1231,8 +1235,10 @@ static void engine_record_execlists(struct 
> intel_engine_coredump *ee)
>       struct i915_request * const *port = el->active;
>       unsigned int n = 0;
>  
> -     while (*port)
> -             record_request(*port++, &ee->execlist[n++]);
> +     while (*port) {
> +             if (record_request(*port++, &ee->execlist[n]))
> +                     n++;
> +     }

grrrr.... is this necessary?

Besides, in a one line while loop we aren't supposed to use
braces.

Andi
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to