Re: [Intel-gfx] [PATCH] drm/i915: Disable FDI link before retraining.

2010-08-09 Thread Chris Wilson
On Fri, 06 Aug 2010 22:57:33 +0100, Chris Wilson wrote: > On Fri, 06 Aug 2010 14:21:59 -0700, Eric Anholt wrote: > > With the drm fix to not re-dpms the crtc, is this one still needed? > > No. I had to disable both this and Dave Airlie's double dpms defense, but > with the drm crtc dpms fix thi

Re: [Intel-gfx] [PATCH] drm/i915: Disable FDI link before retraining.

2010-08-06 Thread Chris Wilson
On Fri, 06 Aug 2010 14:21:59 -0700, Eric Anholt wrote: > On Tue, 3 Aug 2010 08:12:12 +0100, Chris Wilson > wrote: > > At the moment, we have a habit of occasionally performing a double dpms > > on. This confuses the FDI link training performed on a dpms on as we can > > only adjust the settings

Re: [Intel-gfx] [PATCH] drm/i915: Disable FDI link before retraining.

2010-08-06 Thread Eric Anholt
On Tue, 3 Aug 2010 08:12:12 +0100, Chris Wilson wrote: > At the moment, we have a habit of occasionally performing a double dpms > on. This confuses the FDI link training performed on a dpms on as we can > only adjust the settings whilst the link is disabled and the second > attempt at training

[Intel-gfx] [PATCH] drm/i915: Disable FDI link before retraining.

2010-08-03 Thread Chris Wilson
At the moment, we have a habit of occasionally performing a double dpms on. This confuses the FDI link training performed on a dpms on as we can only adjust the settings whilst the link is disabled and the second attempt at training fails. A simple defensive workaround is to always disable the link