Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-29 Thread Sun, Yi
Sent: Thursday, August 28, 2014 3:59 AM > To: Daniel Vetter > Cc: intel-gfx; Oliver Hartkopp; Sun, Yi > Subject: Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of > PCU_EVENT interrupt > > Yi, can you get this one run through testing on multiple platforms? We just &

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-27 Thread Jesse Barnes
On Wed, 27 Aug 2014 23:33:05 +0200 Daniel Vetter wrote: > On Wed, Aug 27, 2014 at 9:59 PM, Jesse Barnes > wrote: > > Yi, can you get this one run through testing on multiple platforms? We > > just want to make sure there's not some path we missed that's gonna > > spew a warning with this chang

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-27 Thread Daniel Vetter
On Wed, Aug 27, 2014 at 9:59 PM, Jesse Barnes wrote: > Yi, can you get this one run through testing on multiple platforms? We > just want to make sure there's not some path we missed that's gonna > spew a warning with this change. I think that amount of testing is totally out of balance to keep

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-27 Thread Jesse Barnes
Yi, can you get this one run through testing on multiple platforms? We just want to make sure there's not some path we missed that's gonna spew a warning with this change. Thanks, Jesse On Tue, 26 Aug 2014 22:51:13 +0200 Daniel Vetter wrote: > > On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Oliver Hartkopp
On 26.08.2014 22:51, Daniel Vetter wrote: > > > Oliver, can you please test the below diff? > > diff --git a/drivers/gpu/drm/i915/i915_dma.c b/drivers/gpu/drm/i915/i915_dma.c > index f19dbff0e73b..915a60b48159 100644 > --- a/drivers/gpu/drm/i915/i915_dma.c > +++ b/drivers/gpu/drm/i915/i915_dm

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 11:18 PM, Jesse Barnes wrote: > Daniel Vetter wrote: > >> >> On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes >> wrote: >> > On Tue, 26 Aug 2014 09:23:54 +0200 >> > Daniel Vetter wrote: >> > >> >> On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: >> >> > This h

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Jesse Barnes
On Tue, 26 Aug 2014 22:51:13 +0200 Daniel Vetter wrote: > > On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes > wrote: > > On Tue, 26 Aug 2014 09:23:54 +0200 > > Daniel Vetter wrote: > > > >> On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: > >> > This happens in irq_postinstall befo

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Daniel Vetter
On Tue, Aug 26, 2014 at 8:52 PM, Jesse Barnes wrote: > On Tue, 26 Aug 2014 09:23:54 +0200 > Daniel Vetter wrote: > >> On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: >> > This happens in irq_postinstall before we've set the pm._irqs_disabled >> > flag, >> > but shouldn't warn. So

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Jesse Barnes
On Tue, 26 Aug 2014 21:03:11 +0200 Oliver Hartkopp wrote: > On 26.08.2014 20:52, Jesse Barnes wrote: > > On Tue, 26 Aug 2014 09:23:54 +0200 > > Daniel Vetter wrote: > > >>> This happens in irq_postinstall before we've set the pm._irqs_disabled > >>> flag, > >>> but shouldn't warn. So add a no

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Oliver Hartkopp
On 26.08.2014 20:52, Jesse Barnes wrote: > On Tue, 26 Aug 2014 09:23:54 +0200 > Daniel Vetter wrote: >>> This happens in irq_postinstall before we've set the pm._irqs_disabled flag, >>> but shouldn't warn. So add a nowarn variant to allow this to happen w/o >>> a backtrace and keep the rest of t

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Jesse Barnes
On Tue, 26 Aug 2014 09:23:54 +0200 Daniel Vetter wrote: > On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: > > This happens in irq_postinstall before we've set the pm._irqs_disabled flag, > > but shouldn't warn. So add a nowarn variant to allow this to happen w/o > > a backtrace and

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-26 Thread Daniel Vetter
On Mon, Aug 25, 2014 at 04:24:55PM -0700, Jesse Barnes wrote: > This happens in irq_postinstall before we've set the pm._irqs_disabled flag, > but shouldn't warn. So add a nowarn variant to allow this to happen w/o > a backtrace and keep the rest of the IRQ tracking code happy. > > Signed-off-by:

Re: [Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-25 Thread Oliver Hartkopp
On 26.08.2014 01:24, Jesse Barnes wrote: > This happens in irq_postinstall before we've set the pm._irqs_disabled flag, > but shouldn't warn. So add a nowarn variant to allow this to happen w/o > a backtrace and keep the rest of the IRQ tracking code happy. > > Signed-off-by: Jesse Barnes Repor

[Intel-gfx] [PATCH] drm/i915/ilk: special case enabling of PCU_EVENT interrupt

2014-08-25 Thread Jesse Barnes
This happens in irq_postinstall before we've set the pm._irqs_disabled flag, but shouldn't warn. So add a nowarn variant to allow this to happen w/o a backtrace and keep the rest of the IRQ tracking code happy. Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i915/i915_irq.c | 18 -