These are review comments for
1)
http://lists.freedesktop.org/archives/intel-gfx/2015-March/062167.html
2)
http://lists.freedesktop.org/archives/intel-gfx/2015-March/062168.html
Couple of comments:
1) Defines for DC_STATE_EN* are coming up as part of
http://lists.freedesktop.or
For patch at
http://lists.freedesktop.org/archives/intel-gfx/2015-March/062169.html
Reviewed-by: Sagar Kamble
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
For updated patch that is coming up per
http://lists.freedesktop.org/archives/intel-gfx/2015-March/062315.html
Reviewed-by: Sagar Kamble
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
From: Sagar Kamble
When RC6 along with Render power gating is enabled, GPU hang
happens due to lack of synchronization between GTI and Render
power gating.
v2: Updated commit message and WA name (Damien)
Change-Id: If1614206341eb52a21eadae8c5ebb2655029b50c
Reviewed-by: Damien Lespiau
Signed-of
+static int bxt_suspend_complete(struct drm_i915_private *dev_priv)
+{
+ struct drm_device *dev = dev_priv->dev;
+
+ /* TODO: when DC5 support is added disable DC5 here. */
+
+ bxt_uninit_cdclk(dev);
+ bxt_enable_dc9(dev_priv);
+
+ return 0;
+}
+
static int hsw_suspen
From: Akash Goel
During resume, modeset was being performed independent of DPMS state which
increased resume time as well as it kept display wells ON. With this change
this modeset will be skipped.
Signed-off-by: Akash Goel
Signed-off-by: Sagar Kamble
---
drivers/gpu/drm/i915/i915_drv.c | 33
From: Sagar Kamble
Due to disabling of RC6 in uncore_sanitize in early resume, power is drained
till it RC6 is re-enabled post resume.
With this change RC6 disabling will be done at beginning of resume only.
This helps yield additional power benefits.
Signed-off-by: Akash Goel
Signed-off-by: Sa
From: Sagar Kamble
RC6 was getting enabled through deferred work item which was scheduled
after 1s. This will keep render and media well ON for 1s. Since RC6 enabling
does
not involve PCU communication, processing time in intel_enable_gt_powersave will
not be increased. Enabling RC6 immediately
From: Sagar Kamble
With this change, intel_runtime_suspend and intel_runtime_resume functions
become completely platform agnostic. Platform specific suspend/resume
changes are moved to intel_suspend_complete and intel_resume_prepare.
Cc: Imre Deak
Cc: Paulo Zanoni
Cc: Daniel Vetter
Cc: Jani N
From: Sagar Kamble
On VLV, post S0i3 during i915_drm_thaw following issue is observed during ring
initialization.
[ 335.604039] [drm:stop_ring] ERROR render ring :timed out trying to stop ring
[ 336.607340] [drm:stop_ring] ERROR render ring :timed out trying to stop ring
[ 336.607345] [drm:init_
From: Sagar Kamble
v1:
Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
gunit registers need to be followed in
PM suspend and resume path similar to runtime suspend and resume.
v2:
1. Keeping GT access, wake, gunit save/restore related helpers static.
2. Moved GT acces
From: Sagar Kamble
Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
gunit registers need to be followed in
PM suspend and resume path similar to runtime suspend and resume.
v2:
1. Keeping GT access, wake, gunit save/restore related helpers static.
2. Moved GT access ch
From: Sagar Kamble
Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
gunit registers need to be followed in
PM suspend and resume path similar to runtime suspend and resume.
v2:
1. Keeping GT access, wake, gunit save/restore related helpers static.
2. Moved GT access ch
From: Sagar Kamble
Sequence to get gfx clocks on/off, allow/disallow wake and save/restore of
gunit registers need to be followed in
PM suspend and resume path similar to runtime suspend and resume.
Cc: Imre Deak
Cc: Paulo Zanoni
Cc: Daniel Vetter
Cc: Jani Nikula
Signed-off-by: Sagar Kamble
From: Borun Fu
On VLV, after i915_pm_suspend display power wells are staying
power ungated. So, after initiating mem sleep "echo mem > /sys/power/state"
Display is staing D0 State. There might be better way/place to power gate
these wells. Also, we need to make sure that if wells are power gated
From: Borun Fu
On VLV, after i915_pm_suspend display power wells are staying
power ungated. So, after initiating mem sleep "echo mem > /sys/power/state"
Display is staing D0 State. There might be better way/place to power gate
these wells. Also, we need to make sure that if wells are power gated
From: Sagar Kamble
With these patches runtime_suspend is triggered by updating runtime pm
usage count when display well is power gated and pci state is set to D3 hot
in runtime_suspend and set to D0 in runtime_resume.
Sagar Kamble (2):
drm/i915: do runtime_get/put during display well power gat
From: Sagar Kamble
Display power island is on during boot, we have one count for it
once this power gates, we do a put making sure runtime_suspend is
called
Cc: Daniel Vetter (supporter:INTEL DRM DRIVERS...)
Cc: Jani Nikula (supporter:INTEL DRM DRIVERS...)
Signed-off-by: Sagar Kamble
---
dri
From: Sagar Kamble
To do a platform wide S0i3 transition, Gfx is required to go
to D3_hot state. pci_save_state and pci_restore_state needed to avoid ring
hangs across D3_hot transitions.
Cc: Daniel Vetter (supporter:INTEL DRM DRIVERS...)
Cc: Jani Nikula (supporter:INTEL DRM DRIVERS...)
Signed
From: Sagar Kamble
This test will set various values for drm properties exposed by planes
and check for functional accuracy in some cases using CRC check.
Currently this test is enabled for "const-alpha" drm property.
Cc: daniel.vet...@ffwll.ch
Cc: jani.nik...@linux.intel.com
Cc: ville.syrj...@l
From: Sagar Kamble
Cc: rdun...@infradead.org
Cc: alexander.deuc...@amd.com
Cc: airl...@redhat.com
Cc: laurent.pinch...@ideasonboard.com
Cc: dh.herrm...@gmail.com
Cc: daniel.vet...@ffwll.ch
Cc: jani.nik...@linux.intel.com
Cc: ville.syrj...@linux.intel.com
Cc: indranil.mukher...@intel.com
Cc: shash
From: Sagar Kamble
Cc: daniel.vet...@ffwll.ch
Cc: jani.nik...@linux.intel.com
Cc: ville.syrj...@linux.intel.com
Cc: indranil.mukher...@intel.com
Cc: shashidhar.hirem...@intel.com
Cc: vandita.kulka...@intel.com
Cc: vijay.a.purushotha...@intel.com
Cc: ankitprasad.r.sha...@intel.com
Signed-off-by: S
From: Sagar Kamble
Testcase: kms_plane_props
Cc: daniel.vet...@ffwll.ch
Cc: jani.nik...@linux.intel.com
Cc: ville.syrj...@linux.intel.com
Cc: indranil.mukher...@intel.com
Cc: shashidhar.hirem...@intel.com
Cc: vandita.kulka...@intel.com
Cc: vijay.a.purushotha...@intel.com
Cc: ankitprasad.r.sha...@
From: Sagar Kamble
This patch series introduces drm property for plane level alpha.
These patches are based on following patches which are already under
review/reviewed:
Documentation: drm: describing drm properties exposed by various drivers
Propagate the error from intel_update_plane() up thr
From: Sagar Kamble
v2: Added description for "src-color" and "constant-alpha" property.
[Review by Laurent Pinchart]
v3: Fixed typos. [Review by David Herrmann]
v4: Additional formatting and modified description. [Review by David Herrmann]
Cc: r...@landley.net
Cc: airl...@redhat.com
Cc: da
From: Sagar Kamble
v2: Added description for "src-color" and "constant-alpha" property.
[Review by Laurent Pinchart]
v3: Fixed typos. [Review by David Herrmann]
Cc: Rob Landley
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Laurent Pinchart
Cc: David Herrmann
Cc: Alex Deucher
Cc: "Ville Syrjäl
From: Sagar Kamble
v2: Added description for "src-color" and "constant-alpha" property.
[Review by Laurent Pinchart]
v3: Fixed typos. [Review by David Hermann]
Cc: Rob Landley
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Laurent Pinchart
Cc: David Herrmann
Cc: Alex Deucher
Cc: "Ville Syrjälä
From: Sagar Kamble
v2: Added description for "src-color" and "constant-alpha" property.
Cc: Rob Landley
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Laurent Pinchart
Cc: David Herrmann
Cc: Alex Deucher
Cc: "Ville Syrjälä"
Cc: Sagar Kamble
Cc: "Purushothaman, Vijay A"
Cc: linux-doc at vger.kern
From: Sagar Kamble
With this patch new flag DRM_MODE_PROP_32BIT_PAIR is added that will help make
use
of 64 bit value of bitmask property as two 32 bit values.
Cc: airl...@linux.ie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Sagar Kamble
---
drivers/gpu
From: Sagar Kamble
This patch creates a generic blending bitmask property modeled after
glBlendFunc. Drivers may support subset of these values.
v2: Removing blend properties that are not applicable
[Damien's Review Comments].
Adding DRM_MODE_PROP_32BIT_PAIR flag to blend property.
Cc:
From: Sagar Kamble
This patch enables constant alpha property for Sprite planes.
Client has to set BIT(DRM_BLEND_CONSTANT_ALPHA) | ((alpha value) << 32)
for applying constant alpha on a plane. To disable constant alpha,
client has to set BIT(DRM_BLEND_SRC_COLOR)
v2: Fixing property value compari
From: arsharma
v1: This test currently tests constant alpha setting of sprite planes.
It verifies alpha setting of 0 and 255 with CRC.
Signed-off-by: Sharma, Ankitprasad R
Signed-off-by: Sagar Kamble
---
tests/Makefile.sources | 1 +
tests/kms_blend.c | 560
From: Sagar Kamble
Cursor size is changed now take care of larger cursor sizes.
wm calculation was hardcoded to 64 before so changing it.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: Damien Lespiau
Signed-off-by: Sagar Kamble
---
drivers/gpu/drm/i915/intel_pm.c | 2 +-
1 file changed, 1 insertion(
From: Sagar Kamble
v1: Added 128x128 and 256x256 cursor size support.
v2: Refined the test to use igt_subtest_f and automate enumeration.
v3: Restructuring test enumeration using drmGetCap. [Daniel's review comments]
Signed-off-by: Sagar Kamble
---
tests/kms_cursor_crc.c | 131 ++
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
With this patch we allow larger cursor planes of sizes 128x128
and 256x256.
v2: Added more precise check on size while setting cursor plane.
v3: Changes related to restructuring cursor size restrictions
and DRM_DEBUG usage.
v4: Indentation related changes for setting cursor
From: Sagar Kamble
v1: Added 128x128 and 256x256 cursor size support.
v2: Refined the test to use igt_subtest_f and automate enumeration.
Signed-off-by: Sagar Kamble
---
lib/igt_kms.c | 13 ++-
tests/kms_cursor_crc.c | 219 +++--
2 files c
From: Sagar Kamble
With this patch we allow larger cursor planes of sizes 128x128
and 256x256.
v2: Added more precise check on size while setting cursor plane.
v3: Changes related to restructuring cursor size restrictions
and DRM_DEBUG usage.
Testcase: igt/kms_cursor_crc
Cc: Daniel Vetter
Cc:
From: Sagar Kamble
This patch enables property for changin the pixel format
of plane to enable/disable pre-multiplied alpha format.
Client has to set BIT(DRM_BLEND_PREMULTIPLIED_ALPHA) | 0x0/0x1
to disable/enable pre-multiplied alpha format.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
From: Sagar Kamble
Cc: Rob Landley
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Laurent Pinchart
Cc: David Herrmann
Cc: Alex Deucher
Cc: "Ville Syrjälä"
Cc: Sagar Kamble
Cc: "Purushothaman, Vijay A"
Cc: linux-...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Sagar Kamble
-
From: Sagar Kamble
This patch creates a generic blending enum property.
Drivers may support subset of these values.
Cc: airl...@linux.ie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Sagar Kamble
---
drivers/gpu/drm/drm_crtc.c | 33
From: Sagar Kamble
This patch enables constant alpha property for Sprite planes.
Client has to set BIT(DRM_BLEND_CONSTANT_ALPHA) | (8 bit alpha value)
for applying constant alpha on a plane. To disable constant alpha,
client has to set BIT(DRM_BLEND_NONE)
Cc: Daniel Vetter
Cc: Jani Nikula
Cc:
From: Sagar Kamble
This patch series introduces drm property modelled after glBlendFuc function.
For i915
constant alpha is exposed through this property to start with. Additional new
property
value for controlling pre-multiplied alpha is added.
i-g-t test case is to be added.
These patches ar
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
v2: Added description of drm properties in armada, exynos, i2c/ch7006, novea
From: Sagar Kamble
Started documenting drm properties for drm drivers. This patch provides
information about properties in drm, i915, psb and cdv/gma-500. Information
about other properties can be added on top of these.
Cc: Rob Landley
Cc: Dave Airlie
Cc: Daniel Vetter
Cc: Laurent Pinchart
C
From: Sagar Kamble
Signed-off-by: Sagar Kamble
---
tests/kms_cursor_crc.c | 51 ++
1 file changed, 31 insertions(+), 20 deletions(-)
diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
index 38aa1ab..4458248 100644
--- a/tests/kms_cursor
From: Sagar Kamble
With this patch we allow larger cursor planes of sizes 128x128
and 256x256.
v2: Added more precise check on size while setting cursor plane.
Testcase: igt/kms_cursor_crc
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...
From: Sagar Kamble
With this patch two properties are added. One for CRTC+Sprite planes
and another for Cursor planes. Through these client will be able to
change the pixel format of the planes w.r.t Alpha channel.
Number of drm properties are limited so should we restrain from adding this
as drm
From: Sagar Kamble
With this patch we allow larger cursor planes of sizes 128x128
and 256x256. Planning to extend kms_cursor_crc test for verifying
these larger planes.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
Sign
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
From: Ville Syrjälä
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
v2: HSW handles the rotated buffer offset automagically
v3
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
From: Sagar Kamble
This test will verify 180 degree rotation of CRTC and sprite planes
by grabbing CRC for already rotated image and comparing with CRC calculated
after triggering rotation through DRM property.
v2: Using cairo_rotate to created reference rotated version of CRTC and
Sprite Image.
From: Ville Syrjälä
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
v2: HSW handles the rotated buffer offset automagically
v3
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
From: Ville Syrjälä
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
v2: HSW handles the rotated buffer offset automagically
Cc
From: Ville Syrjälä
Use the new drm_mode_create_rotation_property() in omapdrm.
v5: Fixed conflict due to change in the prior patch in call to
drm_property_create_bitmask()
Cc: David Airlie
Cc: Rob Clark
Cc: Sagar Kamble
Cc: "Ville Syrjälä"
Cc: Tomi Valkeinen
Cc: Greg Kroah-Hartman
Cc: dr
From: Sagar Kamble
With clipped sprites these transformations are not working. these
functions transform complete sprite irrespective of clipping present.
This leads to invisible portion of sprite show up when rotate 180 if
it was out of visible area before.
v4: Moved rotate transform for source
From: Ville Syrjälä
Propagate the error from intel_update_plane() up through
intel_plane_restore() to the caller. This will be used for
rollback purposes when setting properties fails.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger
From: Ville Syrjälä
drm_rotation_simplify() can be used to eliminate unsupported rotation
flags. It will check if any unsupported flags are present, and if so
it will modify the rotation to an alternate form by adding 180 degrees
to rotation angle, and flipping the reflect x and y bits. The hope
From: Ville Syrjälä
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
v2: HSW handles the rotated buffer offset automagically
Cc
From: Ville Syrjälä
Add some helper functions to move drm_rects between different rotated
coordinate spaces. One function does the forward transform and
another does the inverse.
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Add a function to create a standards compliant rotation property.
v4: For creating rotation bitmask property send number of values
as only number of set rotations
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.org
Signed-off-by: Ville Syrj
From: Ville Syrjälä
Sprite planes support 180 degree rotation. The lower layers are now in
place, so hook in the standard rotation property to expose the feature
to the users.
Cc: Daniel Vetter
Cc: Jani Nikula
Cc: David Airlie
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@vger.kernel.o
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
From: Ville Syrjälä
Make drm_property_create_bitmask() a bit more generic by allowing the
caller to specify which bits are in fact supported. This allows multiple
callers to use the same enum list, but still create different versions
of the same property with different list of supported bits.
v5
From: Ville Syrjälä
The rotation property stuff should be standardized among all drivers.
Move the bits to drm_crtc.h from omap_drv.h.
Cc: David Airlie
Cc: Tomi Valkeinen
Cc: Dave Airlie
Cc: Rob Clark
Cc: Daniel Vetter
Cc: Archit Taneja
Cc: dri-de...@lists.freedesktop.org
Cc: linux-ker...@
From: Sagar Kamble
These patches will enable 180 degree rotation for CRTC and Sprite planes.
Changelog:
1. drm: Add support_bits parameter to drm_property_create_bitmask()
Fixed caller of this function in omapdrm for bisectability of this patch.
2. drm/omap: Switch omapdrm over to drm_mode_create
From: Sagar Kamble
This test will verify 180 degree rotation of CRTC and sprite planes
by grabbing CRC for already rotated image and comparing with CRC calculated
after triggering rotation through DRM property.
v2: Using cairo_rotate to created reference rotated version of CRTC and
Sprite Image.
From: Ville Syrjälä
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
v2: HSW handles the rotated buffer offset automagically
Si
From: Ville Syrjälä
Sprite planes support 180 degree rotation. The lower layers are now in
place, so hook in the standard rotation property to expose the feature
to the users.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/
From: Ville Syrjälä
Use the new drm_mode_create_rotation_property() in omapdrm.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/omap_plane.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
b/drivers/gpu/drm/o
From: Sagar Kamble
With clipped sprites these transformations are not working. these
functions transform complete sprite irrespective of clipping present.
This leads to invisible portion of sprite show up when rotate 180 if
it was out of visible area before.
v4: Moved rotate transform for source
From: Ville Syrjälä
Propagate the error from intel_update_plane() up through
intel_plane_restore() to the caller. This will be used for
rollback purposes when setting properties fails.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/i915/intel_drv.h| 2 +-
driver
From: Ville Syrjälä
drm_rotation_simplify() can be used to eliminate unsupported rotation
flags. It will check if any unsupported flags are present, and if so
it will modify the rotation to an alternate form by adding 180 degrees
to rotation angle, and flipping the reflect x and y bits. The hope
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
From: Ville Syrjälä
Make drm_property_create_bitmask() a bit more generic by allowing the
caller to specify which bits are in fact supported. This allows multiple
callers to use the same enum list, but still create different versions
of the same property with different list of supported bits.
Si
From: Ville Syrjälä
The rotation property stuff should be standardized among all drivers.
Move the bits to drm_crtc.h from omap_drv.h.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/omapdrm/omap_drv.h | 7 ---
include/drm/drm_crtc.h | 8
2 fi
From: Ville Syrjälä
Add some helper functions to move drm_rects between different rotated
coordinate spaces. One function does the forward transform and
another does the inverse.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/drm_rect.c | 140
From: Ville Syrjälä
Add a function to create a standards compliant rotation property.
v4: For creating rotation bitmask property send number of values
as only number of set rotations
Signed-off-by: Ville Syrjälä
Signed-off-by: Sagar Kamble
Tested-by: Sagar Kamble
---
drivers/gpu/drm/drm_crt
From: Sagar Kamble
These patches will enable 180 degree rotation for CRTC and Sprite planes.
Changelog:
1. drm/i915: Add 180 degree primary plane rotation support
Addressed review comments for CRTC rotation from FBC, page flip, CRTC active/
inactive perspective.
2. drm/i915: Calling rotate and in
From: Ville Syrjälä
The sprite planes (in fact all display planes starting from gen4)
support 180 degree rotation. Add the relevant low level bits to the
sprite code to make use of that feature.
The upper layers are not yet plugged in.
v2: HSW handles the rotated buffer offset automagically
Si
From: Ville Syrjälä
drm_rotation_simplify() can be used to eliminate unsupported rotation
flags. It will check if any unsupported flags are present, and if so
it will modify the rotation to an alternate form by adding 180 degrees
to rotation angle, and flipping the reflect x and y bits. The hope
From: Sagar Kamble
DRM will not propagate the set_property call for bitmask drm
properties if they are not supported by underlying driver.
Signed-off-by: Sagar Kamble
Tested-by: Sagar Kamble
---
drivers/gpu/drm/drm_crtc.c | 18 ++
1 file changed, 18 insertions(+)
diff --git a
From: Ville Syrjälä
Add some helper functions to move drm_rects between different rotated
coordinate spaces. One function does the forward transform and
another does the inverse.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/drm_rect.c | 140
From: Ville Syrjälä
The rotation property stuff should be standardized among all drivers.
Move the bits to drm_crtc.h from omap_drv.h.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/omapdrm/omap_drv.h | 7 ---
include/drm/drm_crtc.h | 8
2 fi
From: Sagar Kamble
With clipped sprites these transformations are not working. these
functions transform complete sprite irrespective of clipping present.
This leads to invisible portion of sprite show up when rotate 180 if
it was out of visible area before.
Signed-off-by: Sagar Kamble
Tested-b
From: Ville Syrjälä
Make drm_property_create_bitmask() a bit more generic by allowing the
caller to specify which bits are in fact supported. This allows multiple
callers to use the same enum list, but still create different versions
of the same property with different list of supported bits.
Si
From: Ville Syrjälä
Use the new drm_mode_create_rotation_property() in omapdrm.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/omapdrm/omap_plane.c | 17 +++--
1 file changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_plane.c
b/drivers/gpu/drm/o
From: Ville Syrjälä
Add a function to create a standards compliant rotation property.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/drm_crtc.c | 18 ++
include/drm/drm_crtc.h | 2 ++
2 files changed, 20 insertions(+)
diff --git a/drivers/gpu/dr
From: Ville Syrjälä
Sprite planes support 180 degree rotation. The lower layers are now in
place, so hook in the standard rotation property to expose the feature
to the users.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/
From: Ville Syrjälä
Propagate the error from intel_update_plane() up through
intel_plane_restore() to the caller. This will be used for
rollback purposes when setting properties fails.
Signed-off-by: Ville Syrjälä
Tested-by: Sagar Kamble
---
drivers/gpu/drm/i915/intel_drv.h| 2 +-
driver
From: Sagar Kamble
Primary planes support 180 degree rotation. Expose the feature
through rotation drm property.
v2: Calculating linear/tiled offsets based on pipe source width and
height. Added 180 degree rotation support in ironlake_update_plane.
v3: Checking if CRTC is active before issueing
1 - 100 of 116 matches
Mail list logo
