Re: [Intel-gfx] [PATCH] drm/i915: use the new hdmi_force_audio enum more

2012-02-24 Thread Wu Fengguang
o. The > HDMI_AUDIO_ prefix is a bit a misnomer. But at least for sdvo it makes > sense (and you can also connect a hdmi monitor with a dp->hdmi cable), > so I've decided to stick with it. > > Cc: Wu Fengguang > Signed-Off-by: Dani

Re: [Intel-gfx] [PATCH] drm/i915: add a "force-dvi" HDMI audio mode

2012-02-13 Thread Wu Fengguang
On Mon, Feb 13, 2012 at 08:22:01PM +0100, Daniel Vetter wrote: > On Wed, Feb 08, 2012 at 10:48:20AM +0800, Wu Fengguang wrote: > > When HDMI-DVI converter is used, it's not only necessary to turn off > > audio, but also to disable HDMI_MODE_SELECT and video infoframe. Since

[Intel-gfx] [PATCH 3.2-stable] drm/i915: fix ELD writing for SandyBridge

2012-02-07 Thread Wu Fengguang
commit b3f33cbf7ace8fc149993ee35e0d0fd57f41d6d8 upstream. SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang Signed-off-by: Keith Packard --- drivers/gpu/drm/i915/intel_display.c | 10 +- 1 files changed, 5 insertions(+), 5 deletions

[Intel-gfx] [PATCH] drm/i915: add a "force-dvi" HDMI audio mode

2012-02-07 Thread Wu Fengguang
audio force-dvi Note that most users won't need to set this and happily rely on the EDID based DVI auto detection. Reported-by: Andrea Arcangeli Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_drv.h|7 +++ drivers/gpu/drm/i915/intel_hdmi.c |8 +---

Re: [Intel-gfx] [PATCH][rebased] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-29 Thread Wu Fengguang
wise most BIOS will fill the N_value_index bit for us) Tested-by: Robert Lemaire Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h | 12 drivers/gpu/drm/i915/intel_display.c |8 +++- 2 files changed, 19 insertions(+), 1 deletion(-) --- linux-next.orig/dr

[Intel-gfx] [PATCH][rebased] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-28 Thread Wu Fengguang
t for us) Tested-by: Robert Lemaire Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h | 12 drivers/gpu/drm/i915/intel_display.c |8 +++- 2 files changed, 19 insertions(+), 1 deletion(-) > I've tried to apply this patch but it has a conflict i

[Intel-gfx] [PATCH 2/2] intel_audio_dump: show more AUD_CONFIG bits

2012-01-16 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 35 +++ 1 file changed, 35 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2012-01-16 15:33:18.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2012-01-16 16:13

[Intel-gfx] [PATCH 1/2] intel_audio_dump: fix missing Audio DIP tabs

2012-01-16 Thread Wu Fengguang
This makes the SNB/IVY Audio DIP values aligned with others. Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2012-01-16 15:33:11.0 +0800 +++ intel-gpu-tools

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Wu Fengguang
splayPort monitor hot plugged after boot (otherwise most BIOS will fill the N_value_index bit for us) Tested-by: Robert Lemaire Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h | 12 drivers/gpu/drm/i915/intel_display.c |8 +++- 2 files changed, 19 ins

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-16 Thread Wu Fengguang
On Thu, Jan 12, 2012 at 09:33:34AM -0800, Keith Packard wrote: > On Tue, 10 Jan 2012 13:45:19 +0800, Wu Fengguang > wrote: > > > @@ -5943,6 +5947,7 @@ static void ironlake_write_eld(struct dr > > if (intel_pipe_has_type(crtc, INTEL_OUTPUT_DISPLAYPORT)) { > >

Re: [Intel-gfx] [PATCH] drm/i915: add an "off-dvi" HDMI audio mode

2012-01-10 Thread Wu Fengguang
On Sat, Jan 07, 2012 at 09:39:19PM +0800, Wu Fengguang wrote: > On Fri, Jan 06, 2012 at 07:08:33AM -0800, Jesse Barnes wrote: > > On Fri, 6 Jan 2012 11:26:40 +0800 > > Wu Fengguang wrote: > > > > > Andrea, > > > > > > Would you test th

Re: [Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-09 Thread Wu Fengguang
On Mon, Jan 09, 2012 at 09:22:47AM -0800, Keith Packard wrote: > On Mon, 9 Jan 2012 21:17:17 +0800, Wu Fengguang > wrote: > > > +#define IBX_AUD_CONFIG_A 0xe2000 > > +#define CPT_AUD_CONFIG_A 0xe5000 > > These register addresses match the docs. &g

[Intel-gfx] [PATCH] drm/i915: set AUD_CONFIG N_value_index for DisplayPort

2012-01-09 Thread Wu Fengguang
bit for us) Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h |3 +++ drivers/gpu/drm/i915/intel_display.c |5 + 2 files changed, 8 insertions(+) --- linux.orig/drivers/gpu/drm/i915/i915_reg.h 2012-01-06 15:00:55.0 +0800 +++ linux/drivers/gpu/drm/i915/i915

Re: [Intel-gfx] [PATCH] drm/i915: add an "off-dvi" HDMI audio mode

2012-01-07 Thread Wu Fengguang
On Fri, Jan 06, 2012 at 05:12:57PM +0100, Andrea Arcangeli wrote: > On Fri, Jan 06, 2012 at 07:08:33AM -0800, Jesse Barnes wrote: > > A better name might be off-dvi-mode or off-dvi-only or something. > > force-dvi is probably better name, off is counter intuitive. Yeah, "force-dvi" looks good! >

Re: [Intel-gfx] [PATCH] drm/i915: add an "off-dvi" HDMI audio mode

2012-01-07 Thread Wu Fengguang
On Fri, Jan 06, 2012 at 07:08:33AM -0800, Jesse Barnes wrote: > On Fri, 6 Jan 2012 11:26:40 +0800 > Wu Fengguang wrote: > > > Andrea, > > > > Would you test this patch at convenient time? > > > > Thanks, > > Fengguang > > > > --

[Intel-gfx] [PATCH] drm/i915: add an "off-dvi" HDMI audio mode

2012-01-05 Thread Wu Fengguang
ELECT and video infoframe. Since the DVI mode is mainly tied to audio functionality from end user POV, add a new "off-dvi" audio mode: xrandr --output HDMI1 --set audio off-dvi Reported-by: Andrea Arcangeli Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_drv.h|7

Re: [Intel-gfx] force DVI mode without audio

2011-12-31 Thread Wu Fengguang
On Sat, Dec 31, 2011 at 01:20:11PM +0100, Andrea Arcangeli wrote: > On Sat, Dec 31, 2011 at 09:28:37AM +0800, Wu Fengguang wrote: > > Hi Andrea, > > > > On Fri, Dec 30, 2011 at 08:07:27PM +0100, Andrea Arcangeli wrote: > > > Hi, > > > > > > after

Re: [Intel-gfx] force DVI mode without audio

2011-12-30 Thread Wu Fengguang
Hi Andrea, On Fri, Dec 30, 2011 at 08:07:27PM +0100, Andrea Arcangeli wrote: > Hi, > > after upgrading my HTPC to HD3000 graphics (2700K), I didn't find > anymore a way to disable the hdmi audio from the DVI2HDMI cable (I > connect DVI output of the motherboard to the HDMI input of the LCDTV > in

[Intel-gfx] i915_wait_request: BUG_ON(seqno == 0) triggered on IvyBridge

2011-12-18 Thread Wu Fengguang
Hi, I managed to trigger the below BUG_ON when switching modes in an IvyBridge box. i915_wait_request(): BUG_ON(seqno == 0); The call trace is at the bottom of the following dmesg. Any ideas? Thanks, Fengguang --- [ 554.872849] [drm:drm_mode_getconnector], [CONNECTOR:6:?] [ 554.8744

[Intel-gfx] Philips 221P3LPYEB has working DP audio

2011-12-09 Thread Wu Fengguang
On Mon, Nov 28, 2011 at 04:06:37PM +0800, Wu Fengguang wrote: > > The only missing part is hot plug notification for DP -- most DP monitors in > > the market don't support DP audio well. So I cannot test this for now. > > btw, we'd like to buy a Philips 221P3LPYEB tha

[Intel-gfx] [PATCH 1/5] drm/i915: fix ELD writing for SandyBridge

2011-12-09 Thread Wu Fengguang
SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) --- linux.orig/drivers/gpu/drm/i915/intel_display.c 2011-11-28 15:33:04.0

[Intel-gfx] [PATCH 5/5] drm/i915: DisplayPort hot remove notification to audio driver

2011-12-09 Thread Wu Fengguang
set to "Normal". Tested OK for both hot plug/remove and DPMS on/off. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_dp.c |1 + 1 file changed, 1 insertion(+) --- linux.orig/drivers/gpu/drm/i915/intel_dp.c 2011-12-09 16:51:21.0 +0800 +++ linux/drivers/gp

[Intel-gfx] [PATCH 4/5] drm/i915: HDMI hot remove notification to audio driver

2011-12-09 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_dp.c |4 +++- drivers/gpu/drm/i915/intel_hdmi.c |8 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) --- linux.orig/drivers/gpu/drm/i915/intel_hdmi.c2011-11-24 17:11:38.0 +0800 +++ linux/drivers/gpu

[Intel-gfx] [PATCH 3/5] drm/i915: dont trigger hotplug events on unchanged ELD

2011-12-09 Thread Wu Fengguang
The ELD may or may not change when switching the video mode. If unchanged, don't trigger hot plug events to HDMI audio driver. This avoids disturbing the user with repeated printks. Reported-by: Nick Bowler Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 2/5] drm/i915: rename audio ELD registers

2011-12-09 Thread Wu Fengguang
ggested-by: Keith Packard Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h | 22 +++--- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 2 files changed, 22 insertions(+), 22 deletions(-) --- linux.orig/drivers/gpu/drm/i915/i915_reg.h 201

[Intel-gfx] [PATCH 0/5] Intel HDMI ELD fixes v2

2011-12-09 Thread Wu Fengguang
Keith, The complete set of fixes for passing HDMI/DP ELD to audio driver. [PATCH 1/5] drm/i915: fix ELD writing for SandyBridge [PATCH 2/5] drm/i915: rename audio ELD registers [PATCH 3/5] drm/i915: dont trigger hotplug events on unchanged ELD [PATCH 4/5] drm/i915: HDMI hot remove notificatio

[Intel-gfx] [PATCH] drm/i915: DisplayPort hot remove notification to audio driver

2011-12-09 Thread Wu Fengguang
set to "Normal". Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_dp.c |1 + 1 file changed, 1 insertion(+) This works both on KMS console and gnome desktop. Hot plug/unplug and DPMS on/off are all tested OK. --- linux.orig/drivers/gpu/drm/i915/intel_dp.c 2011-1

[Intel-gfx] [PATCH 2/4 v2] drm/i915: rename audio ELD registers

2011-11-29 Thread Wu Fengguang
ggested-by: Keith Packard Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h | 22 +++--- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 2 files changed, 22 insertions(+), 22 deletions(-) --- linux.orig/drivers/gpu/drm/i915/i915_reg.h 201

[Intel-gfx] [PATCH 1/4 v2] drm/i915: fix ELD writing for SandyBridge

2011-11-29 Thread Wu Fengguang
SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) Sorry, this moves some necessary changes from patch 2/4 to here. --- linux.orig/drivers

Re: [Intel-gfx] [PATCH 0/4] Intel HDMI ELD fixes

2011-11-28 Thread Wu Fengguang
> The only missing part is hot plug notification for DP -- most DP monitors in > the market don't support DP audio well. So I cannot test this for now. btw, we'd like to buy a Philips 221P3LPYEB that _seems_ to have DP audio support. I'd appreciate if any one can help confirm. Thanks, Fengguang _

[Intel-gfx] [PATCH 2/4] drm/i915: rename audio ELD registers

2011-11-27 Thread Wu Fengguang
ggested-by: Keith Packard Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h | 22 +++--- drivers/gpu/drm/i915/intel_display.c | 22 +++--- 2 files changed, 22 insertions(+), 22 deletions(-) --- linux.orig/drivers/gpu/drm/i915/i915_reg.h 201

[Intel-gfx] [PATCH 4/4] drm/i915: HDMI hot remove notification to audio driver

2011-11-27 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_dp.c |4 +++- drivers/gpu/drm/i915/intel_hdmi.c |8 ++-- 2 files changed, 9 insertions(+), 3 deletions(-) --- linux.orig/drivers/gpu/drm/i915/intel_hdmi.c2011-11-24 17:11:38.0 +0800 +++ linux/drivers/gpu

[Intel-gfx] [PATCH 0/4] Intel HDMI ELD fixes

2011-11-27 Thread Wu Fengguang
Keith, The 4 patches are well tested and integrates the review comments. The only missing part is hot plug notification for DP -- most DP monitors in the market don't support DP audio well. So I cannot test this for now. Thanks, Fengguang ___ Intel-gf

[Intel-gfx] [PATCH 3/4] drm/i915: dont trigger hotplug events on unchanged ELD

2011-11-27 Thread Wu Fengguang
The ELD may or may not change when switching the video mode. If unchanged, don't trigger hot plug events to HDMI audio driver. This avoids disturbing the user with repeated printks. Reported-by: Nick Bowler Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 1/4] drm/i915: fix ELD writing for SandyBridge

2011-11-27 Thread Wu Fengguang
SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux.orig/drivers/gpu/drm/i915/intel_display.c 2011-11-24 08:09:41.0 +0800

Re: [Intel-gfx] [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-24 Thread Wu Fengguang
On Thu, Nov 24, 2011 at 03:26:49AM +0800, Keith Packard wrote: > On Wed, 23 Nov 2011 16:29:58 +0800, Wu Fengguang > wrote: > > > What I need is a hot plug hook that knows whether the monitor is > > plugged or removed, which is only possible if the hook is called > >

Re: [Intel-gfx] [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-23 Thread Wu Fengguang
On Wed, Nov 23, 2011 at 02:25:14AM +0800, Keith Packard wrote: > On Tue, 22 Nov 2011 15:40:55 +0800, Wu Fengguang > wrote: > > > So the v3 patch will behave equally well on KMS console, gnome desktop > > and bare X. Shall we just use it, or go back and use the original &

Re: [Intel-gfx] [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-22 Thread Wu Fengguang
te_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDI

Re: [Intel-gfx] [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
On Tue, Nov 22, 2011 at 12:55:43AM +0800, Keith Packard wrote: > On Mon, 21 Nov 2011 14:37:49 +0800, Wu Fengguang > wrote: > > On monitor hot plug/unplug, update ELD and set/clear SDVO_AUDIO_ENABLE > > or DP_AUDIO_OUTPUT_ENABLE accordingly. So that the audio driver will &g

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
On Mon, Nov 21, 2011 at 04:47:38PM +0800, Takashi Iwai wrote: > At Mon, 21 Nov 2011 09:58:09 +0800, > Wu Fengguang wrote: > > > > On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > > > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > > > wro

[Intel-gfx] [PATCH 3/3 v3] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-21 Thread Wu Fengguang
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE

[Intel-gfx] [PATCH 3/3 v2] drm/i915: hot plug/unplug notification to HDMI audio driver

2011-11-20 Thread Wu Fengguang
DIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE - X ->detect drm_edid_to_eld ->hotplug intel_write_eld set SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE On hot remove, the call sequence is ->hotplug clear SDVO_AUDIO_ENABLE/DP_AUDIO_OUTPUT_ENABLE

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-20 Thread Wu Fengguang
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > wrote: > > > However when in X, ->mode_set won't be called at all. Only > > ->get_modes and ->detect are called... > > The desktop softw

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-18 Thread Wu Fengguang
On Sat, Nov 19, 2011 at 01:46:44AM +0800, Keith Packard wrote: > On Fri, 18 Nov 2011 17:37:40 +0800, Wu Fengguang > wrote: > > > However when in X, ->mode_set won't be called at all. Only > > ->get_modes and ->detect are called... > > The desktop softw

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-18 Thread Wu Fengguang
However when in X, ->mode_set won't be called at all. Only ->get_modes and ->detect are called... Thanks, Fengguang On Wed, Nov 16, 2011 at 09:35:48PM +0800, Wu Fengguang wrote: > Sorry forgot to remove this left over chunk... > > Note that I've not yet got the h

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Wu Fengguang
> > > Below is the dmesg representing a video mode set. > > > > > > ELD writes from the graphics driver > > > > > > [ 424.254958] [drm:intel_write_eld], ELD on [CONNECTOR:12:HDMI-A-2], > > > [ENCODER:11:TMDS-11] > > > [ 424.257670] [drm:ironlake_write_eld], ELD on pipe B > > > [ 424.259833] [

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-16 Thread Wu Fengguang
On Wed, Nov 16, 2011 at 11:51:28PM +0800, Stephen Warren wrote: > Wu Fengguang wrote at Tuesday, November 15, 2011 7:48 PM: > > On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote: > > > Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM: > > > > The

[Intel-gfx] [PATCH 3/3 v2] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu Signed-off-by: Wu Fengguang --- drivers/gpu/drm

Re: [Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
Sorry forgot to remove this left over chunk... Note that I've not yet got the hardware to test the DisplayPort part of this patch, but should be able to do so this week. > --- linux.orig/drivers/gpu/drm/i915/intel_drv.h 2011-11-16 > 20:54:27.0 +0800 > +++ linux/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 3/3] drm/i915: hot removal notification to HDMI audio driver

2011-11-16 Thread Wu Fengguang
On monitor hot removal: 1) clear SDVO_AUDIO_ENABLE or DP_AUDIO_OUTPUT_ENABLE 2) clear ELD Valid bit So that the audio driver will receive hot plug events and take action to refresh its device state and ELD contents. cc: Wang Zhenyu Signed-off-by: Wu Fengguang --- drivers/gpu/drm

[Intel-gfx] [PATCH 1/3] drm/i915: fix ELD writing for SandyBridge

2011-11-16 Thread Wu Fengguang
SandyBridge should be using the same register addresses as IvyBridge. Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/i915_reg.h |6 +++--- drivers/gpu/drm/i915/intel_display.c | 10 +- 2 files changed, 8 insertions(+), 8 deletions(-) --- linux.orig/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD

2011-11-16 Thread Wu Fengguang
The ELD may or may not change when switching the video mode. If unchanged, don't trigger hot plug events to HDMI audio driver. This avoids disturbing the user with repeated printks. Reported-by: Nick Bowler Signed-off-by: Wu Fengguang --- drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 0/3] HDMI ELD fixes for 3.2

2011-11-16 Thread Wu Fengguang
Keith, Here are 3 fixes on HDMI/ELD audio. The third one adds a ->hot_remove hook to drm_connector_funcs. Please review. [PATCH 1/3] drm/i915: fix ELD writing for SandyBridge [PATCH 2/3] drm/i915: dont trigger hotplug events on unchanged ELD [PATCH 3/3] drm/i915: hot removal notification to HDMI

Re: [Intel-gfx] [alsa-devel] [PATCH 2/2] hda - delayed ELD repoll

2011-11-15 Thread Wu Fengguang
On Wed, Nov 16, 2011 at 02:25:00AM +0800, Stephen Warren wrote: > Wu Fengguang wrote at Tuesday, November 15, 2011 7:33 AM: > > The Intel HDMI chips (ironlake at least) are found to have ~250ms delay > > between the ELD_Valid=1 hotplug event is send and the ELD buffer becomes > &

Re: [Intel-gfx] [PATCH 2/2 v2] hda - delayed ELD repoll

2011-11-15 Thread Wu Fengguang
On Wed, Nov 16, 2011 at 01:10:37AM +0800, Takashi Iwai wrote: > At Wed, 16 Nov 2011 00:57:08 +0800, > Wu Fengguang wrote: > > +static void hda_eld_work(struct work_struct *work) > > +{ > > + struct hdmi_eld *eld = container_of( > > +

[Intel-gfx] [PATCH 2/2 v2] hda - delayed ELD repoll

2011-11-15 Thread Wu Fengguang
-off-by: Wu Fengguang --- sound/pci/hda/hda_local.h |2 + sound/pci/hda/patch_hdmi.c | 49 ++- 2 files changed, 44 insertions(+), 7 deletions(-) --- linux.orig/sound/pci/hda/hda_local.h2011-11-15 21:29:53.0 +0800 +++ linux/sound/pci/hda

Re: [Intel-gfx] [PATCH 2/2] hda - delayed ELD repoll

2011-11-15 Thread Wu Fengguang
> - if (eld_valid) > + if (eld_valid) { > if (!snd_hdmi_get_eld(eld, codec, pin_nid)) > snd_hdmi_show_eld(eld); > + else { Oops, forgot testing @retry here! Updated patch follows. > + queue_delayed_work(codec->bus->workq,

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Wu Fengguang
On Tue, Nov 15, 2011 at 10:45:15PM +0800, Takashi Iwai wrote: > At Tue, 15 Nov 2011 22:41:16 +0800, > Wu Fengguang wrote: > > > > On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: > > > At Tue, 15 Nov 2011 22:31:55 +0800, > > > Wu Fengguang wrote:

Re: [Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Wu Fengguang
On Tue, Nov 15, 2011 at 10:35:41PM +0800, Takashi Iwai wrote: > At Tue, 15 Nov 2011 22:31:55 +0800, > Wu Fengguang wrote: > > > > memset(eld) clears eld->proc_entry which will leak the struct > > snd_info_entry when unloading the module. > > > > Fix it by

[Intel-gfx] [PATCH 2/2] hda - delayed ELD repoll

2011-11-15 Thread Wu Fengguang
-off-by: Wu Fengguang --- sound/pci/hda/hda_local.h |2 + sound/pci/hda/patch_hdmi.c | 49 ++- 2 files changed, 44 insertions(+), 7 deletions(-) --- linux.orig/sound/pci/hda/hda_local.h2011-11-15 21:29:53.0 +0800 +++ linux/sound/pci/hda

[Intel-gfx] [PATCH 1/2] hda - fix ELD memory leak

2011-11-15 Thread Wu Fengguang
memset(eld) clears eld->proc_entry which will leak the struct snd_info_entry when unloading the module. Fix it by - remove memset(eld) - set eld->eld_valid to true _after_ all eld fields have been filled - don't access the other eld fields when (eld->eld_valid == false) Sig

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-14 Thread Wu Fengguang
On Mon, Nov 14, 2011 at 05:45:12PM +0800, Takashi Iwai wrote: > At Sat, 12 Nov 2011 10:27:26 +0800, > Wu Fengguang wrote: > > > > (snip) > > > > > > > And I'm not sure whether HDMI audio is played > > > > > > > while DPMS is off.

Re: [Intel-gfx] HDMI monitor hot remove handling

2011-11-13 Thread Wu Fengguang
On Mon, Nov 14, 2011 at 10:05:05AM +0800, Zhenyu Wang wrote: > On 2011.11.11 16:50:41 +0800, Wu Fengguang wrote: > > > > > I still think you should do those in hot_plug(), to call detect() for > > > > > current > > > > > status, write eld a

[Intel-gfx] [PATCH 11/18] intel_audio_dump: show DP control registers for Ironlake

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 30 ++ 1 file changed, 30 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:40.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52

[Intel-gfx] [PATCH 16/18] intel_audio_dump: show HDMI encoding

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 18 ++ 1 file changed, 18 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:49.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:50.0 +0800

[Intel-gfx] [PATCH 15/18] intel_audio_dump: show VIDEO_DIP_CTL_* for CPT

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 47 + 1 file changed, 47 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 11:11:41.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 11:11

[Intel-gfx] [PATCH 10/18] intel_audio_dump: explain Bits_per_Sample

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 27 ++- 1 file changed, 22 insertions(+), 5 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:39.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12

[Intel-gfx] [PATCH 12/18] intel_audio_dump: show detected chipset name

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:46.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:47.0

[Intel-gfx] [PATCH 17/18] intel_audio_dump: show interrupt enable bit

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |4 1 file changed, 4 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:50.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:50.0 +0800 @@ -567,6

[Intel-gfx] [PATCH 18/18] intel_audio_dump: show Gamut Metadata DIP

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:50.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:51.0 +0800

[Intel-gfx] [PATCH 14/18] intel_audio_dump: show ironlake ELD_access_address

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |2 ++ 1 file changed, 2 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:48.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:48.0 +0800 @@ -725,6 +725,7

[Intel-gfx] [PATCH 13/18] intel_audio_dump: show ELD contents for G45

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |8 1 file changed, 8 insertions(+) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:52:47.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 10:52:48.0 +0800 @@ -455,6

[Intel-gfx] [PATCH 07/18] intel_audio_dump: fix Ironlake detection

2011-11-11 Thread Wu Fengguang
The original test mistakenly calls dump_cpt() for Ironlake, due to HAS_PCH_SPLIT := IS_GEN5 || IS_GEN6 || IS_GEN7. Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11

[Intel-gfx] [PATCH 08/18] intel_audio_dump: fix DP control registers for CPT

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 47 + 1 file changed, 27 insertions(+), 20 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 10:19:06.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c

[Intel-gfx] [PATCH 05/18] intel_audio_dump: fix ironlake Stream_ID indents

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09 10:35:34.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35:34.0

[Intel-gfx] [PATCH 09/18] intel_audio_dump: fix DP port width for CPT

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09 10:35:35.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35:35.0

[Intel-gfx] [PATCH 03/18] intel_audio_dump: cleanup hex output

2011-11-11 Thread Wu Fengguang
- no need to show the 1-bit AUD_OUT_DIG_CNVT_* as hex value - show the Connection_select_Control_* bits as hex values Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) --- intel-gpu-tools.orig/tools

[Intel-gfx] [PATCH 06/18] intel_audio_dump: fix Digital_Port_D_Detected copy&paste error

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09 10:35:34.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-09 10:35:35.0

[Intel-gfx] [PATCH 04/18] intel_audio_dump: report effective channel count

2011-11-11 Thread Wu Fengguang
The raw channel count is not user friendly and may be misleading. Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-09 16:21:43.0 +0800

[Intel-gfx] [PATCH 01/18] intel_audio_dump: cleanup hyphen character

2011-11-11 Thread Wu Fengguang
Convert "­" (Hex 00ad) to "-" (Hex 2d), the former leads to ugly outputs in some situations. Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 70 ++--- 1 file changed, 35 insertions(+), 35 deletions(-) --- intel-

[Intel-gfx] [PATCH 02/18] intel_audio_dump: cleanup ACP DIP name for ironlake and CPT

2011-11-11 Thread Wu Fengguang
Signed-off-by: Wu Fengguang --- tools/intel_audio_dump.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) --- intel-gpu-tools.orig/tools/intel_audio_dump.c 2011-11-12 11:00:39.0 +0800 +++ intel-gpu-tools/tools/intel_audio_dump.c2011-11-12 11:01

[Intel-gfx] [PATCH 00/18] intel-gpu-tools: intel_audio_dump updates

2011-11-11 Thread Wu Fengguang
A bunch of cleanups, fixes and new fields to intel_audio_dump, tested OK on G45, Ironlake and IvyBridge. ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Wu Fengguang
(snip) > > > > > And I'm not sure whether HDMI audio is played > > > > > while DPMS is off. I haven't tested it. > > > > > > > > It will go silence on DPMS. I noticed this while doing long term HDMI > > > > audio playback tests. This should better be fixed in future on the > > > > graphics side.

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Wu Fengguang
On Fri, Nov 11, 2011 at 07:23:05PM +0800, Takashi Iwai wrote: > At Fri, 11 Nov 2011 19:12:57 +0800, > Wu Fengguang wrote: > > > > (snip) > > > > > One note that we don't rely on PD bit because not all (non-Intel) > > > > > hardware report it c

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Wu Fengguang
e printks' significantly. > > Well, this reminds me of another question -- do we need these printks > unconditionally? Maybe not. How about the attached patch to remove them all? > > And it feels not good that accessing ELD may be blocked for some time.. > > Understood. >

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Wu Fengguang
On Fri, Nov 11, 2011 at 04:49:57PM +0800, Takashi Iwai wrote: > At Fri, 11 Nov 2011 16:22:41 +0800, > Wu Fengguang wrote: > > > > On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote: > > > At Fri, 11 Nov 2011 10:29:25 +0800, > > > Wu Fengguang wrote: &

Re: [Intel-gfx] HDMI monitor hot remove handling

2011-11-11 Thread Wu Fengguang
t; > So looks currently nobody cares for hot removal, you need to set that by > yourself somewhere. Zhenyu, according to your comments, here is the patch, tested OK on HDMI :) DP not tested yet. This notifies the audio driver of the HDMI/DP monitor hot removal event. - clear SDVO_AU

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-11 Thread Wu Fengguang
On Fri, Nov 11, 2011 at 03:40:37PM +0800, Takashi Iwai wrote: > At Fri, 11 Nov 2011 10:29:25 +0800, > Wu Fengguang wrote: > > > > On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote: > > > At Thu, 10 Nov 2011 21:51:50 +0800, > > > Wu Fengguang wrote: &

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 10:28:19PM +0800, Takashi Iwai wrote: > At Thu, 10 Nov 2011 21:51:50 +0800, > Wu Fengguang wrote: > > > > > > > > So maybe the hardware is in some state that is unable to provide the > > > > > > real ELD content? > > &

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 09:47:46PM +0800, Wu Fengguang wrote: > > > Got the delay - it's 72.986623-72.747632 = 239ms. > > > > > > [ 72.739944] HDMI hot plug event: Codec=3 Pin=6 > > > Presence_Detect=1 ELD_Valid=0 > > > [ 72.

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 09:51:50PM +0800, Wu Fengguang wrote: > > > > > So maybe the hardware is in some state that is unable to provide the > > > > > real ELD content? > > > > That's my guess as well. I think the hardware may still be doing some

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
> > > > So maybe the hardware is in some state that is unable to provide the > > > > real ELD content? > > > That's my guess as well. I think the hardware may still be doing some > > > form of data negotiation with the HDMI display device at that stage, and > > > doesn't have the copy of the EDID

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
> > Got the delay - it's 72.986623-72.747632 = 239ms. > > > > [ 72.739944] HDMI hot plug event: Codec=3 Pin=6 > > Presence_Detect=1 ELD_Valid=0 > > [ 72.742541] HDMI status: Codec=3 Pin=6 Presence_Detect=1 > > ELD_Valid=0 > > [ 72.745082] HDMI hot plug event: Code

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 09:01:24PM +0800, Christopher White wrote: > On 11/10/11 1:56 PM, Wu Fengguang wrote: > > On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote: > >> On 11/10/11 12:22 PM, Takashi Iwai wrote: > >>> At Thu, 10 Nov 2011 12:00:53

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 07:50:11PM +0800, Christopher White wrote: > On 11/10/11 12:22 PM, Takashi Iwai wrote: > > At Thu, 10 Nov 2011 12:00:53 +0100, > > Christopher White wrote: > >> On 11/10/11 9:55 AM, Christopher White wrote: > >>> On 11/10/11 8:55 AM, Wu

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-10 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 03:55:22PM +0800, Wu Fengguang wrote: > On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote: > > Wow I reproduced the bug and got a very interesting dmesg: > > > > gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on > > [CONNE

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote: > Wow I reproduced the bug and got a very interesting dmesg: > > gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on > [CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11] > gfx =>[ 4561.291730] [drm:iro

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Wow I reproduced the bug and got a very interesting dmesg: gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on [CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11] gfx =>[ 4561.291730] [drm:ironlake_write_eld], ELD on pipe B gfx =>[ 4561.293804] [drm:ironlake_write_eld], Audio dir

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Christopher, On Thu, Nov 10, 2011 at 12:10:42PM +0800, Christopher White wrote: > On 11/10/11 4:27 AM, Wu Fengguang wrote: > > Christopher, > > > > Did you enabled CONFIG_SND_DEBUG and CONFIG_SND_DEBUG_VERBOSE in > > kconfig? I've been looking for the error messag

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Christopher, > The dump tool did not work with that environment variable either. > However, it occurred to me that intel_audio_dump may be too outdated in > my distro. It was built on 2010-04-01, v1.0.2+git20100324. If I look at > http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/ I can see tha

  1   2   >