Re: [Intel-gfx] [PATCH] i915/gem: Force HW tracking to exit PSR

2020-08-10 Thread Singh, Gaurav K
-Original Message- From: Chris Wilson Sent: Friday, August 7, 2020 5:30 PM To: Singh, Gaurav K ; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] i915/gem: Force HW tracking to exit PSR Quoting Gaurav K Singh (2020-08-07 12:56:33) > Instead of call

Re: [Intel-gfx] [PATCH] drm/i915: Fix S0ix/S3 suspend stress issue

2019-09-19 Thread Singh, Gaurav K
-Original Message- From: Souza, Jose Sent: Wednesday, September 18, 2019 11:14 PM To: Singh, Gaurav K ; intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: Fix S0ix/S3 suspend stress issue On Wed, 2019-09-18 at 11:23 +0530, Gaurav K Singh wrote: > During S0ix

Re: [Intel-gfx] [PATCH v4 06/25] drm/i915/dp: Validate modes using max Output BPP and slice count when DSC supported

2018-09-14 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: When DSC is supported we need to validate the modes based on the maximum supported compressed BPP and maximum supported slice count. This allows us to allow the modes with pixel clock greater than the available link BW as long as it meets the compresse

Re: [Intel-gfx] [PATCH v4 05/25] drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC

2018-09-14 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: This patch adds helpers for calculating the maximum compressed BPP supported with small joiner. This also adds a helper for calculating the slice count in case of small joiner. These are inside intel_dp since they take into account hardware limitations

Re: [Intel-gfx] [PATCH v4 05/25] drm/i915/dp: Add helpers for Compressed BPP and Slice Count for DSC

2018-09-14 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: This patch adds helpers for calculating the maximum compressed BPP supported with small joiner. This also adds a helper for calculating the slice count in case of small joiner. These are inside intel_dp since they take into account hardware limitations

Re: [Intel-gfx] [PATCH v4 04/25] drm/dp: DRM DP helper/macros to get DP sink DSC parameters

2018-09-12 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: This patch adds inline functions and helpers for obtaining DP sink's supported DSC parameters like DSC sink support, eDP compressed BPP supported, maximum slice count supported by the sink devices, DSC line buffer bit depth supported on DP sink, DSC si

Re: [Intel-gfx] [PATCH v4 02/25] drm/dp: Add DP DSC DPCD receiver capability size define and missing SHIFT

2018-09-12 Thread Singh, Gaurav K
On 9/12/2018 6:25 AM, Manasi Navare wrote: This patch defines the DP DSC receiver capability size that gives total number of DP DSC DPCD registers. This also adds a missing #defines for DP DSC support missed in the commit id (ab6a46ea6842ce "Add DPCD definitions for DP 1.4 DSC feature") v3: *

Re: [Intel-gfx] [PATCH v2 02/23] drm/i915/dp: Cache the DP/eDP DSC DPCD register set on Hotplug/eDP Init

2018-09-11 Thread Singh, Gaurav K
On 8/1/2018 2:36 AM, Manasi Navare wrote: DSC is supported on eDP starting GEN 10 display and on DP starting GEN 11. This patch implements the discovery phase of DSC. On hotplug, source reads the DSC DPCD register set (0x00060 - 0x006F) to Please correct it to 0x0006F in order to match the sp

Re: [Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-17 Thread Singh, Gaurav K
On 4/17/2018 11:58 PM, Du,Wenkai wrote: On 4/17/2018 11:22 AM, Gaurav K Singh wrote: On Geminilake, sometimes audio card is not getting detected after reboot. This is a spurious issue happening on Geminilake. HW codec and HD audio controller link was going out of sync for which there was a fi

Re: [Intel-gfx] [PATCH] drm/i915/audio: Fix audio detection issue on GLK

2018-04-11 Thread Singh, Gaurav K
On 4/10/2018 4:32 PM, Jani Nikula wrote: On Mon, 09 Apr 2018, "Kumar, Abhay" wrote: On 4/9/2018 4:20 PM, Pandiyan, Dhinakaran wrote: On Mon, 2018-04-09 at 12:18 -0700, Kumar, Abhay wrote: On 4/9/2018 12:10 PM, Rodrigo Vivi wrote: On Mon, Apr 09, 2018 at 05:07:31PM +0300, Jani Nikula wrote

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-04-05 Thread Singh, Gaurav K
On 3/5/2018 11:51 PM, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This was a spurious issue happening on Apollolake. HW codec and HD au

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-03-04 Thread Singh, Gaurav K
, Gaurav On Mar 4, 2018, at 10:09 PM, Singh, Gaurav K wrote: On 2/27/2018 11:00 PM, Runyan, Arthur J wrote: Ok, please update the workaround page to show all the impacted projects https://gfxspecs.intel.com/Predator/Home/Index/21829 Hi, Should we wait for Bspec to get updated or we can go

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-03-04 Thread Singh, Gaurav K
-Original Message- From: Mullah, Abid A Sent: Tuesday, 27 February, 2018 8:52 AM To: Runyan, Arthur J ; Pandiyan, Dhinakaran ; Singh, Gaurav K ; Neelagandan, Harigaran Cc: intel-gfx@lists.freedesktop.org; Vivi, Rodrigo ; Nikula, Jani Subject: RE: [Intel-gfx] [PATCH] drm: i915: Fix audio

Re: [Intel-gfx] [PATCH 01/10] drm: i915: Defining Compression Capabilities

2018-02-24 Thread Singh, Gaurav K
On 2/24/2018 5:24 AM, Manasi Navare wrote: On Fri, Feb 23, 2018 at 09:25:44PM +0530, Gaurav K Singh wrote: For Vesa Display Stream compression, defining structures for compression capabilities to be stored in encoder. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/i915_drv.h | 125

Re: [Intel-gfx] [PATCH 00/10] Enabling VDSC in i915 driver for GLK

2018-02-23 Thread Singh, Gaurav K
On 2/24/2018 4:23 AM, Manasi Navare wrote: Thanks for the patches. I am working on the DSC support on i915 for eDP/DP as well. Looking at the patches below, this is specific to VDSC enabling for eDP panels and not for the external DP. So please mention that specifically in the cover letter as w

Re: [Intel-gfx] [PATCH] drm: i915: Fix audio issue on BXT

2018-01-04 Thread Singh, Gaurav K
On 1/4/2018 2:48 AM, Rodrigo Vivi wrote: On Wed, Jan 03, 2018 at 08:31:10PM +, Pandiyan, Dhinakaran wrote: On Thu, 2018-01-04 at 00:48 +0530, Gaurav K Singh wrote: From: Gaurav Singh On Apollolake, with stress test warm reboot, audio card was not getting enumerated after reboot. This wa

Re: [Intel-gfx] [PATCH 0/4] DSI Dual link enabling on BXT

2015-09-22 Thread Singh, Gaurav K
On 9/16/2015 2:48 PM, Gaurav K Singh wrote: Hi, These patches enable DSI dual link mode on BXT boards. These set of patches build on top of the floated DSI Video mode patches on BXT (Uma's patches). Regards Gaurav Gaurav K Singh (4): drm/i915: Enable dual link mode in BXT drm/i915: Use

Re: [Intel-gfx] [RFC CABC PATCH v2 3/3] drm/i915: CABC support for backlight control

2015-08-05 Thread Singh, Gaurav K
On 7/30/2015 4:18 PM, Singh, Gaurav K wrote: On 7/24/2015 5:54 PM, Deepak M wrote: In CABC (Content Adaptive Brightness Control) content grey level scale can be increased while simultaneously decreasing brightness of the backlight to achieve same perceived brightness. The CABC is not

Re: [Intel-gfx] [RFC CABC PATCH v2 3/3] drm/i915: CABC support for backlight control

2015-07-30 Thread Singh, Gaurav K
On 7/24/2015 5:54 PM, Deepak M wrote: In CABC (Content Adaptive Brightness Control) content grey level scale can be increased while simultaneously decreasing brightness of the backlight to achieve same perceived brightness. The CABC is not standardized and panel vendors are free to follow thei

Re: [Intel-gfx] {Intel-gfx] [RFC 01/14] drm/i915: allocate gem memory for mipi dbi cmd buffer

2015-06-18 Thread Singh, Gaurav K
On 6/19/2015 3:32 AM, Gaurav K Singh wrote: Allocate gem memory for MIPI DBI command buffer. This memory will be used when sending command via DBI interface. v2: lock mutex before gem object unreference and later set gem obj ptr to NULL (Gaurav) Signed-off-by: Yogesh Mohan Marimuthu Signed-

Re: [Intel-gfx] [RFC 01/14] drm/i915: allocate gem memory for mipi dbi cmd buffer

2015-06-16 Thread Singh, Gaurav K
On 6/15/2015 4:00 PM, Daniel Vetter wrote: On Mon, Jun 01, 2015 at 02:03:15PM +0300, Ville Syrjälä wrote: On Fri, May 29, 2015 at 07:10:53PM +0200, Daniel Vetter wrote: On Fri, May 29, 2015 at 01:59:01PM +0300, Ville Syrjälä wrote: On Fri, May 29, 2015 at 04:06:53PM +0530, Gaurav K Singh wro

Re: [Intel-gfx] [RFC 11/14] drm/i915: Enable MIPI display self refresh mode

2015-06-16 Thread Singh, Gaurav K
On 6/15/2015 4:03 PM, Daniel Vetter wrote: On Sat, Jun 13, 2015 at 12:24:57PM +0530, Mohan Marimuthu, Yogesh wrote: On 5/29/2015 10:51 PM, Daniel Vetter wrote: On Fri, May 29, 2015 at 04:07:03PM +0530, Gaurav K Singh wrote: During enable sequence for MIPI encoder in command mode, enable MIP

Re: [Intel-gfx] [RFC 07/14] drm/i915: Disable MIPI display self refresh mode

2015-06-16 Thread Singh, Gaurav K
On 5/29/2015 10:50 PM, Daniel Vetter wrote: On Fri, May 29, 2015 at 07:16:36PM +0200, Daniel Vetter wrote: On Fri, May 29, 2015 at 04:06:59PM +0530, Gaurav K Singh wrote: During disable sequence for MIPI encoder in command mode, disable MIPI display self-refresh mode bit in Pipe Ctrl reg. Si

Re: [Intel-gfx] [RFC 06/14] drm/i915: Disable vlank interrupt for disabling MIPI cmd mode

2015-06-16 Thread Singh, Gaurav K
On 5/29/2015 10:53 PM, Daniel Vetter wrote: On Fri, May 29, 2015 at 07:14:43PM +0200, Daniel Vetter wrote: On Fri, May 29, 2015 at 04:06:58PM +0530, Gaurav K Singh wrote: vblank interrupt should be disabled before starting the disable sequence for MIPI command mode. Otherwise when pipe is dis

Re: [Intel-gfx] [PATCH] drm/i915: Changes required to enable DSI Video Mode on CHT

2015-01-14 Thread Singh, Gaurav K
On 12/12/2014 1:03 PM, Singh, Gaurav K wrote: On 12/10/2014 7:38 PM, Gaurav K Singh wrote: For CHT changes are required for calculating the correct m,n & p with minimal error +/- for the required DSI clock, so that the correct dividor & ctrl values are written in cck regs for DSI. Th

Re: [Intel-gfx] [PATCH] drm/i915: Changes required to enable DSI Video Mode on CHT

2014-12-11 Thread Singh, Gaurav K
On 12/10/2014 7:38 PM, Gaurav K Singh wrote: For CHT changes are required for calculating the correct m,n & p with minimal error +/- for the required DSI clock, so that the correct dividor & ctrl values are written in cck regs for DSI. This patch has been tested on CHT RVP with 1200 x 1920 panel

Re: [Intel-gfx] [PATCH 2/4] drm/i915: DSI sequence related changes for DSI Port C

2014-12-10 Thread Singh, Gaurav K
On 12/10/2014 2:50 PM, Daniel Vetter wrote: On Tue, Dec 09, 2014 at 12:30:49PM +0200, Jani Nikula wrote: On Tue, 09 Dec 2014, "Singh, Gaurav K" wrote: On 12/7/2014 4:13 PM, Gaurav K Singh wrote: For DSI Port A & C, the seq_port value has been set to 0 now in VBT Now the s

Re: [Intel-gfx] [PATCH 2/4] drm/i915: DSI sequence related changes for DSI Port C

2014-12-09 Thread Singh, Gaurav K
On 12/9/2014 4:00 PM, Jani Nikula wrote: On Tue, 09 Dec 2014, "Singh, Gaurav K" wrote: On 12/7/2014 4:13 PM, Gaurav K Singh wrote: For DSI Port A & C, the seq_port value has been set to 0 now in VBT Now the sequence of DSI single link on Port A and Port C will based on the DVO

Re: [Intel-gfx] [PATCH 2/4] drm/i915: DSI sequence related changes for DSI Port C

2014-12-09 Thread Singh, Gaurav K
On 12/7/2014 4:13 PM, Gaurav K Singh wrote: For DSI Port A & C, the seq_port value has been set to 0 now in VBT Now the sequence of DSI single link on Port A and Port C will based on the DVO port from VBT block 2. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_dsi_panel_vbt.c

Re: [Intel-gfx] [PATCH] drm/i915: Use DSI Pll1 for enabling MIPI DSI on Port C

2014-12-08 Thread Singh, Gaurav K
On 12/8/2014 5:03 PM, Jani Nikula wrote: On Sun, 07 Dec 2014, Gaurav K Singh wrote: DSI Pll1 is used for enabling DSI on Port C. Signed-off-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_dsi_pll.c |7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/gpu

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Get HW state changes required for DSI port C

2014-12-08 Thread Singh, Gaurav K
On 12/8/2014 5:07 PM, Jani Nikula wrote: On Sun, 07 Dec 2014, Gaurav K Singh wrote: Due to some hardware limitations, MIPI Port C DPI Enable bit does not get set. To check whether DSI Port C was enabled in BIOS, check the Pipe B enable bit for DSI Port C. In hardware, DSI Port C is linked with

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Singh, Gaurav K
On 12/5/2014 11:18 PM, Siluvery, Arun wrote: On 05/12/2014 17:36, Jani Nikula wrote: On Fri, 05 Dec 2014, "Siluvery, Arun" wrote: On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh wrote: For dual link M

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-05 Thread Singh, Gaurav K
On 12/5/2014 8:08 PM, Daniel Vetter wrote: On Fri, Dec 05, 2014 at 06:20:43PM +0530, Singh, Gaurav K wrote: On 12/4/2014 4:52 PM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 11:14:01AM +0200, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh wrote: This patch is in preparation of DSI

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Singh, Gaurav K
On 12/5/2014 10:24 PM, Siluvery, Arun wrote: On 05/12/2014 16:33, Singh, Gaurav K wrote: On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh wrote: For dual link MIPI Panels, each port needs half of pixel clock. Pixel overlap can be enabled if needed by panel, then

Re: [Intel-gfx] [PATCH 04/10] drm/i915: Pixel Clock changes for DSI dual link

2014-12-05 Thread Singh, Gaurav K
On 12/4/2014 2:57 PM, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh wrote: For dual link MIPI Panels, each port needs half of pixel clock. Pixel overlap can be enabled if needed by panel, then in that case, pixel clock will be increased for extra pixels. v2 : Address review comments

Re: [Intel-gfx] [PATCH 02/10] drm/i915: Added port as parameter to the functions which does read/write of DSI Controller

2014-12-05 Thread Singh, Gaurav K
On 12/4/2014 4:52 PM, Daniel Vetter wrote: On Thu, Dec 04, 2014 at 11:14:01AM +0200, Jani Nikula wrote: On Thu, 04 Dec 2014, Gaurav K Singh wrote: This patch is in preparation of DSI dual link panels. For dual link panels, few packets needs to be sent to Port A or Port C or both. Based on the

Re: [Intel-gfx] [PATCH 0/9] BYT DSI Dual Link Support

2014-12-03 Thread Singh, Gaurav K
On 12/1/2014 7:17 PM, Jani Nikula wrote: On Sat, 29 Nov 2014, Gaurav K Singh wrote: Hi, These set of patches build on top of the existing DSI Video mode support to enable dual link MIPI panels with high resolutions. These patches have been tested on a 25x16 panel and works well. Good job, it

Re: [Intel-gfx] [PATCH 3/9] drm/i915: Add support for port enable/disable for dual link configuration

2014-12-01 Thread Singh, Gaurav K
On 12/1/2014 7:41 PM, Jani Nikula wrote: On Mon, 01 Dec 2014, Jani Nikula wrote: On Sat, 29 Nov 2014, Gaurav K Singh wrote: For Dual Link MIPI Panels, both Port A and Port C should be enabled during the MIPI encoder enabling sequence. Similarly, during the disabling sequence, both ports need

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Enable DSI PLL for both DSI0 and DSI1 in case of dual link

2014-12-01 Thread Singh, Gaurav K
On 12/1/2014 6:57 PM, Jani Nikula wrote: On Sat, 29 Nov 2014, Gaurav K Singh wrote: For Dual link MIPI Panels, dsipll clock for both DSI0 and DSI1 needs to be enabled. v2: Address review comments by Jani - Added wait time for PLL to be locked. Signed-off-by: Gaurav K Singh Signed-off-

Re: [Intel-gfx] [PATCH 0/3] BYT DSI Dual Link Support

2014-11-26 Thread Singh, Gaurav K
On 11/24/2014 2:31 PM, Jani Nikula wrote: On Mon, 24 Nov 2014, "Singh, Gaurav K" wrote: Hi Jani, Thanks for the review comments. Regarding the first 2 patches, I was doing almost the same thing in my 3rd and 4th patch. But your patches are more generic. Regarding the 3rd patch

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Singh, Gaurav K
On 11/14/2014 8:24 PM, Jani Nikula wrote: MIPI DSI works on ports A and C, which map to pipes A and B, respectively. Things are going to get more complicated with the introduction of dual link DSI support, so clean up the register defines and code to match reality. Signed-off-by: Jani Nikula

Re: [Intel-gfx] [PATCH 2/3] drm/i915/dsi: add ports to intel_dsi to describe the ports being driven

2014-11-26 Thread Singh, Gaurav K
On 11/14/2014 8:24 PM, Jani Nikula wrote: Later on this can include multiple ports (e.g. (1 << PORT_A) | (1 << PORT_C)) to describe dual link DSI. Signed-off-by: Jani Nikula Reviewed-by: Gaurav K Singh --- drivers/gpu/drm/i915/intel_dsi.c | 7 +-- drivers/gpu/drm/i915/intel_dsi.h | 3

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Singh, Gaurav K
On 11/26/2014 11:38 PM, Daniel Vetter wrote: On Wed, Nov 26, 2014 at 10:50:46PM +0530, Singh, Gaurav K wrote: This patch has some style issues. Please address them. Please be more specific, that's rather non-actionable review. Also general rule of thumb is that if it doesn't look

Re: [Intel-gfx] [PATCH 0/3] BYT DSI Dual Link Support

2014-11-26 Thread Singh, Gaurav K
On 11/24/2014 2:31 PM, Jani Nikula wrote: On Mon, 24 Nov 2014, "Singh, Gaurav K" wrote: Hi Jani, Thanks for the review comments. Regarding the first 2 patches, I was doing almost the same thing in my 3rd and 4th patch. But your patches are more generic. Regarding the 3rd patch

Re: [Intel-gfx] [PATCH 1/3] drm/i915/dsi: clean up MIPI DSI pipe vs. port usage

2014-11-26 Thread Singh, Gaurav K
On 11/14/2014 8:24 PM, Jani Nikula wrote: MIPI DSI works on ports A and C, which map to pipes A and B, respectively. Things are going to get more complicated with the introduction of dual link DSI support, so clean up the register defines and code to match reality. Signed-off-by: Jani Nikula -

Re: [Intel-gfx] [PATCH 0/3] BYT DSI Dual Link Support

2014-11-24 Thread Singh, Gaurav K
Hi Jani, Thanks for the review comments. Regarding the first 2 patches, I was doing almost the same thing in my 3rd and 4th patch. But your patches are more generic. Regarding the 3rd patch, I have a comment: Since in case of dual link panels, few panels may require sequence to be sent only

Re: [Intel-gfx] [PATCH 3/9] drm/i915: MIPI Port Ctrl related changes for dual link configuration

2014-10-20 Thread Singh, Gaurav K
On 9/24/2014 2:57 PM, Jani Nikula wrote: On Wed, 24 Sep 2014, Gaurav K Singh wrote: Signed-off-by: Gaurav K Singh Signed-off-by: Shobhit Kumar --- drivers/gpu/drm/i915/i915_reg.h|1 + drivers/gpu/drm/i915/intel_dsi.c | 53 ++-- drivers/