Add a check to intel_dp_dpms() to skip setting the DP's DPMS mode if
the current mode is the same as the new one.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/intel_dp.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/dr
y(DPMSModeOff)
kernel: enable backlight, backlight=0
This restores the saved nonzero backlight value during the force on.
Signed-off-by: Simon Que
---
src/intel_display.c | 12 +---
1 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/src/intel_display.c b/src/intel_di
results
in no change to the PWM registers.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/intel_panel.c | 38 ++-
1 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_panel.c
b/drivers/gpu/drm/i915/intel_panel.c
index f15388c
results
in no change to the PWM registers.
Signed-off-by: Simon Que
To: intel-gfx@lists.freedesktop.org
To: Jesse Barnes
To: Chris Wilson
To: Eric Anholt
To: Matthew Garrett
Cc: Olof Johansson
Cc: Bryan Freed
Cc: Sameer Nanda
---
drivers/gpu/drm/i915/intel_panel.c | 36
results
in no change to the PWM registers.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/i915_reg.h|1 +
drivers/gpu/drm/i915/intel_panel.c | 37 +--
2 files changed, 31 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers
results
in no change to the PWM registers.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/i915_reg.h|1 +
drivers/gpu/drm/i915/intel_panel.c | 32 +---
2 files changed, 30 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu
There is an error in i915_read_blc_pwm_ctl, where the register values
are not being copied correctly. BLC_PWM_CTL and BLC_PWM_CTL2 are
getting mixed up. This patch fixes that so that saveBLC_PWM_CTL2 and
not saveBLC_PWM_CTL is copied to the BLC_PWM_CTL2 register.
Signed-off-by: Simon Que
On Tue, Nov 8, 2011 at 2:28 PM, Matthew Garrett wrote:
> On Tue, Nov 08, 2011 at 02:27:04PM -0800, Simon Que wrote:
>
> > This is for an x86-based Chromebook. Its firmware doesn't have the VBIOS
> > support. Previously, we had our own backlight driver that also did a
>
On Tue, Nov 8, 2011 at 2:10 PM, Matthew Garrett wrote:
> On Tue, Nov 08, 2011 at 02:05:14PM -0800, Simon Que wrote:
> > On Tue, Nov 8, 2011 at 1:42 PM, Matthew Garrett
> wrote:
> >
> > > I feel like I'm missing something here. Where's the firmware g
On Tue, Nov 8, 2011 at 1:42 PM, Matthew Garrett wrote:
> I feel like I'm missing something here. Where's the firmware getting its
> initial value from?
My understanding is that normally, the firmware's VBIOS can program the
value of the PWM register. But if the firmware doesn't have the VBIOS
Use 0x1000 as the default backlight PWM max value and period. This is
passed in as a module parameter to i915_drv and is used to program the
PWM registers. It can be set to other values based on the needs of each
system.
Signed-off-by: Simon Que
---
Matthew, this patch has been reworked to
There is an error in i915_read_blc_pwm_ctl, where the register values
are not being copied correctly. BLC_PWM_CTL and BLC_PWM_CTL2 are
getting mixed up. This patch fixes that so that saveBLC_PWM_CTL2 and
not saveBLC_PWM_CTL is copied to the BLC_PWM_CTL2 register.
Signed-off-by: Simon Que
On Tue, Nov 1, 2011 at 7:54 PM, Matthew Garrett wrote:
> Again, adding arbitrary constants without any explanation for why you're
> making this the default really isn't acceptable. We have no way to
> determine whether fixing one machine is worth making things worse for
> another.
The default is
Use 0x1000 as the default backlight PWM max value and period. This is
passed in as a module parameter to i915_drv and is used to program the
PWM registers. It can be set to other values based on the needs of each
system.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/i915_drv.c|3
Sorry, this is the wrong patch, please disregard.
On Tue, Nov 1, 2011 at 6:58 PM, Simon Que wrote:
> Use 0x1000 as the default backlight PWM max value and period. This is
> passed in as a module parameter to i915_drv and is used to program the
> PWM registers. It can be set to oth
Use 0x1000 as the default backlight PWM max value and period. This is
passed in as a module parameter to i915_drv and is used to program the
PWM registers. It can be set to other values based on the needs of each
system.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/i915_reg.h|1
On Fri, Oct 14, 2011 at 4:46 PM, Simon Que wrote:
> In the native backlight driver, use 4096 (0x1000) as the default backlight
> period, and use the period as the default max brightness.
>
> The default brightness is defined in a separate function that can be
> expanded to allo
Hi, could I get some feedback on this patch, please?
Simon
On Fri, Oct 14, 2011 at 4:46 PM, Simon Que wrote:
> In the native backlight driver, use 4096 (0x1000) as the default backlight
> period, and use the period as the default max brightness.
>
> The default brightness is
: Ie783b53dd034dcd7bf42e24ffc911cf2f10a5676
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/i915_reg.h|1 +
drivers/gpu/drm/i915/intel_panel.c | 22 ++
2 files changed, 19 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915
> Do you expect to have other settings that you won't get from a VBIOS VBT
> (e.g. video timings, dual refresh info)?
>
> If so, it might make more sense to have an alternate init path for the
> non-VBT values to replace all the VBT parsing. I.e. if your DMI match
> happens, call into something ot
is a DMI match list
for systems that are to use the non-alternate frequency. Currently,
only Lumpy is on the list.
Signed-off-by: Simon Que
---
drivers/gpu/drm/i915/intel_bios.c | 17 -
1 files changed, 16 insertions(+), 1 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_b
001
From: Simon Que
Date: Wed, 22 Sep 2010 14:24:10 -0700
Subject: [PATCH] i915: Added function to initialize VBT settings
Added a function that sets the LVDS values to default settings. This will be
called by intel_init_bios before checking for the VBT (video BIOS table). The
default values
devices will want dithering enabled.
Signed-off-by: Simon Que
BUG=none
TEST=Splash screen looks dithered upon boot.
Change-Id: If19c763824ee938ad107f655d8d94c65e39cfa56
---
drivers/gpu/drm/i915/intel_bios.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions
devices will want dithering enabled.
Signed-off-by: Simon Que
BUG=none
TEST=Splash screen looks dithered upon boot.
Change-Id: If19c763824ee938ad107f655d8d94c65e39cfa56
---
drivers/gpu/drm/i915/intel_bios.c | 29 +++--
1 files changed, 19 insertions(+), 10 deletions
ns for the no-VBT case
Added a function that sets the LVDS values to default settings (currently only
dither bit) when there is no VBT (video BIOS table) found. Also updated dither
bit in parse function to be set by default.
Signed-off-by: Simon Que
BUG=none
TEST=Splash screen looks dithered
Your message has been automatically rejected because this mailing list
only accepts mails from members (to avoid spam). You could subscribe
the membership at
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
-- Forwarded message --
From: Simon Que
To: Chris Wilson , Jesse B
26 matches
Mail list logo
