From: Sourab Gupta
This patch adds the functionality to output the virtual addresses
of each GFX buffer, mapped into process address space (via interfaces
such as mmap and mmap_gtt).
Signed-off-by: Sourab Gupta
Signed-off-by: Akash Goel
Signed-off-by: Nidhi Gupta
Signed-off-by: Praveen
rm fd cases (Daniel)
-Use div64_u64 for 64 bit divisions (Sagar)
Signed-off-by: Sourab Gupta
Signed-off-by: Akash Goel
Signed-off-by: Nidhi Gupta
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.c| 1 +
drivers/gpu/drm/i915/i915_drv.h| 4 +
drivers/gpu/drm
process,
along with their attributes such as size, pinneed, tiling, shared,
allocstate, gtt offset, etc.
v2:
-Use div64_u64 for 64 bit divisions (Sagar)
Signed-off-by: Sourab Gupta
Signed-off-by: Akash Goel
Signed-off-by: Nidhi Gupta
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_debu
hi Gupta
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.h | 8 ++
drivers/gpu/drm/i915/i915_gem.c | 47 +++-
drivers/gpu/drm/i915/i915_gem_shrinker.c | 18
drivers/gpu/drm/i915/i915_sysfs.c| 22 +++-
consumptions in the system
which is given out by the sysfs interface introduced earlier.
Signed-off-by: Sourab Gupta
Signed-off-by: Akash Goel
Signed-off-by: Nidhi Gupta
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.h| 2 ++
drivers/gpu/drm/i915/i915_gem.c| 38
This series introduces a new gfx driver interface for tracking graphics
memory usage at per process level. This interface is currently needed by
android memtracker HAL and it can also be used with driver's shrinker
interface (see patch 5).
This feature was last floated to ML by Sourab and the disc
Hi Paulo,
Thank you for the review and fix-ups :)
regards,
Praveen
On Saturday 26 August 2017 06:19 AM, Paulo Zanoni wrote:
Em Sex, 2017-08-11 às 00:00 +0530, Praveen Paneri escreveu:
When FBC is enabled for linear, legacy Y-tiled and Yf-tiled
surfaces on gen9, the cfb stride must be
)
- Used appropriate bit mask while writing the register (Paulo)
Cc: Paulo Zanoni
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.h | 1 +
drivers/gpu/drm/i915/i915_reg.h | 4
drivers/gpu/drm/i915/intel_fbc.c | 27 +++
3 files changed, 32
On Thu, Aug 3, 2017 at 11:07 PM, Rodrigo Vivi wrote:
> On Thu, Aug 3, 2017 at 10:32 AM, Praveen Paneri
> wrote:
>> This WA is required when decoupled frequencies for slice and unslice
>> are enabled. This disables DOP clock gating for skl.
>>
>> v2: enable the WA fo
only for SKL (Rodrigo)
Cc: David Weinehall
Reviewed-by: David Weinehall
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/intel_pm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 90c2d60..a880c94 100644
--- a
Just realized that I have sent out a wrong patch. Plz ignore this.
Gonna send the correct one in some time.
Thanks,
Praveen
Thanks,
Praveen
On Thu, Aug 3, 2017 at 7:21 PM, Praveen Paneri wrote:
> This WA is required when decoupled frequencies for slice and unslice
> are enabled. This di
only for SKL (Rodrigo)
Cc: David Weinehall
Reviewed-by: David Weinehall
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/intel_pm.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 3fc42aa
: David Weinehall
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/intel_pm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 3fc42aa..e369d77 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers/gpu/drm
This WA is required when decopled frequencies for slice
and unslice are enabled. This disables DOP clock gating
for SKL GT4.
Cc: David Weinehall
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/intel_pm.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpu/drm/i915
On Tuesday 25 July 2017 08:48 PM, Paulo Zanoni wrote:
Em Ter, 2017-07-18 às 22:52 +0530, Praveen Paneri escreveu:
This series adds Y-tiled buffer creation support into IGT libraries
and
goes on to use this capability to add support into FBC tests to use
Y-tiled buffers.
Everything reviewed
name and platform check (Ville)
v4: Added WA details in comment (Paulo)
v5:
- Read modified reg write to preserve other bit values (Paulo)
- Store modified stride value in reg_params (Paulo)
- Keep GLK out of the WA (Paulo)
Cc: Paulo Zanoni
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915
From: Paulo Zanoni
From: Paulo Zanoni
Most of the patch is to change the tile/untile functions so they can
work with Y-major tiling.
v2: (Praveen) No skipping on BLT for Y-tile now as we have a fix
for that.
Reviewed-by: Praveen Paneri
Signed-off-by: Paulo Zanoni
Signed-off-by: Praveen
support for Y tiling
tests/kms_draw_crc: add support for Y tiling
Praveen Paneri (3):
lib/igt_fb: Let others use igt_get_fb_tile_size
lib/igt_fb: Add helper function for tile_to_mod
igt/kms_fbc_crc.c : Add Y-tile tests
lib/igt_draw.c | 171
From: Praveen Paneri
This function can be used by igt_draw to get accurate
tile dimensions for all tile formats.
v2: Added comments to function igt_get_fb_tile_size (Daniel)
v3: Fixed errors in comments and coding style (Paulo)
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 15
From: Praveen Paneri
Now that we have support for Y-tiled buffers, add another
iteration of tests for Y-tiled buffers.
v3:
- Iterate over tiling modifier instead of tiling constant (Paulo)
- Improved logging and fixed indentation (Paulo)
Signed-off-by: Praveen Paneri
---
tests
From: Paulo Zanoni
From: Paulo Zanoni
This is the program that's supposed to test lib/igt_draw. We just
added Y tiling support for the library, so add the tests now.
Reviewed-by: Praveen Paneri
Signed-off-by: Paulo Zanoni
Signed-off-by: Praveen Paneri
---
tests/kms_draw_crc.c
From: Praveen Paneri
igt_get_fb_tile_size function takes modifer as an argument
This helper function will let users to convert tiling to
modifier and use igt_get_fb_tile_size()
v2: Improved code comment (Paulo)
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 26
On Friday 14 July 2017 07:55 PM, Paulo Zanoni wrote:
Em Sex, 2017-07-14 às 19:25 +0530, Praveen Paneri escreveu:
Hi Paulo,
On Thursday 13 July 2017 02:31 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
Now that we have support for Y-tiled buffers, add
On Friday 14 July 2017 03:03 AM, Paulo Zanoni wrote:
Em Sex, 2017-06-09 às 15:48 +0530, Praveen Paneri escreveu:
This patch adds Y-tiling support for igt_draw_rect function.
v2: Use helper function to get tile sizes (Ville)
v3: Moved igt_get_fb_tile_size() out of the for loop
for better
On Friday 14 July 2017 01:49 AM, Paulo Zanoni wrote:
Em Qua, 2017-07-12 às 13:45 +0530, Praveen Paneri escreveu:
Hi Paulo,
On Wednesday 12 July 2017 12:33 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
From: Paulo Zanoni
This is the program that&#
On Friday 14 July 2017 01:29 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
From: Akash Goel
v2: Moved identical code into a single function (Paulo)
My MI-fu is not very strong, but I tried to check this against BSpec
and I believe this patch is
Hi Paulo,
On Thursday 13 July 2017 02:31 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
Now that we have support for Y-tiled buffers, add another
iteration of tests for Y-tiled buffers.
Have you tested this on platforms that don't support Y-tiled bu
Hi Paulo,
On Thursday 13 July 2017 01:47 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
Allow tests to create Y-tiled bufferes using a separate
argument to the test without increasing the number of
subtests.
v2: Changed tiling option to string (Paulo)
I
Hi Paulo,
On Wednesday 12 July 2017 12:33 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
From: Paulo Zanoni
This is the program that's supposed to test lib/igt_draw. We just
added Y tiling support for the library, so add the tests now.
This is n
Hi Paulo,
Could you plz review this patch in context of this series.
https://patchwork.freedesktop.org/series/21467/
It should fix the issue that you highlighted.
Thanks,
Praveen
On Friday 09 June 2017 03:48 PM, Praveen Paneri wrote:
This patch adds Y-tiling support for igt_draw_rect
Hi Paulo,
On Tuesday 06 June 2017 10:28 PM, Paulo Zanoni wrote:
Em Sáb, 2017-04-29 às 08:44 +0530, Praveen Paneri escreveu:
HI Paulo,
On Sat, Apr 29, 2017 at 12:51 AM, Paulo Zanoni wrote:
Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
This series adds Y-tiled buffer creation
This patch adds Y-tiling support for igt_draw_rect function.
v2: Use helper function to get tile sizes (Ville)
v3: Moved igt_get_fb_tile_size() out of the for loop
for better performance (Paulo)
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 139
HI Paulo,
On Sat, Apr 29, 2017 at 12:51 AM, Paulo Zanoni wrote:
> Em Sex, 2017-04-28 às 20:07 +0530, Praveen Paneri escreveu:
>> This series adds Y-tiled buffer creation support into IGT libraries
>> and
>> goes on to use this capability to add support into FBC tests to u
Allow tests to create Y-tiled bufferes using a separate
argument to the test without increasing the number of
subtests.
v2: Changed tiling option to string (Paulo)
Signed-off-by: Praveen Paneri
---
tests/kms_frontbuffer_tracking.c | 48
1 file changed
Now that we have support for Y-tiled buffers, add another
iteration of tests for Y-tiled buffers.
Signed-off-by: Praveen Paneri
---
tests/kms_fbc_crc.c | 71 +
1 file changed, 39 insertions(+), 32 deletions(-)
diff --git a/tests/kms_fbc_crc.c
This patch adds Y-tiling support for igt_draw_rect function.
v2:
Use helper function to get tile sizes (Ville)
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 132 +
1 file changed, 87 insertions(+), 45 deletions(-)
diff --git a/lib
From: Akash Goel
v2: Moved identical code into a single function (Paulo)
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 33 +
1 file changed, 33 insertions(+)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index fcf8fba..27a69cd
From: Paulo Zanoni
This is the program that's supposed to test lib/igt_draw. We just
added Y tiling support for the library, so add the tests now.
Signed-off-by: Paulo Zanoni
Signed-off-by: Praveen Paneri
---
tests/kms_draw_crc.c | 58 ++
igt_get_fb_tile_size function takes modifer as an argument
This helper function will let users to convert tiling to
modifier and use igt_get_fb_tile_size()
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 26 ++
lib/igt_fb.h | 1 +
2 files changed, 27 insertions
tiling
Praveen Paneri (5):
lib/igt_fb: Let others use igt_get_fb_tile_size
lib/igt_fb: Add helper function for tile_to_mod
lib/igt_draw: Add Y-tiling support
igt/kms_frontbuffer_tracking: Add Y-tiling support
igt/kms_fbc_crc.c : Add Y-tile tests
lib/igt_draw.c | 165
This function can be used by igt_draw to get accurate
tile dimensions for all tile formats.
v2: Added comments to function igt_get_fb_tile_size (Daniel)
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 16 +---
lib/igt_fb.h | 3 ++-
2 files changed, 15 insertions(+), 4 deletions
Hi Paulo,
Thanks for your review.
On Wednesday 26 April 2017 08:21 PM, Paulo Zanoni wrote:
Em Qua, 2017-04-26 às 10:46 -0300, Paulo Zanoni escreveu:
Em Sáb, 2017-03-18 às 00:45 +0530, Praveen Paneri escreveu:
This series adds Y-tiled buffer creation support into IGT libraries
and
goes on to
name and platform check (Ville)
v4: Added WA details in comment (Paulo)
Cc: Paulo Zanoni
Cc: Ville Syrj??l??
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_fbc.c | 9 +
2 files changed, 12 insertions(+)
diff --git a/drivers/gpu
On Monday 20 March 2017 03:18 PM, Daniel Vetter wrote:
On Sat, Mar 18, 2017 at 12:45:20AM +0530, Praveen Paneri wrote:
This function can be used by igt_draw to get accurate
tile dimensions for all tile formats.
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 2 +-
lib/igt_fb.h | 3
On Fri, Mar 17, 2017 at 1:24 AM, Paulo Zanoni wrote:
> Em Qui, 2017-03-16 às 17:38 +0530, Praveen Paneri escreveu:
>> When FBC is enabled for linear, legacy Y-tiled and Yf-tiled
>> surfaces on gen9, the cfb stride must be programmed by SW as
>>
>> cfb_stride = ceili
Now that we have support for Y-tiled buffers, add another
iteration of tests for Y-tiled buffers.
Signed-off-by: Praveen Paneri
---
tests/kms_fbc_crc.c | 71 +
1 file changed, 39 insertions(+), 32 deletions(-)
diff --git a/tests/kms_fbc_crc.c
From: Paulo Zanoni
This is the program that's supposed to test lib/igt_draw. We just
added Y tiling support for the library, so add the tests now.
Signed-off-by: Paulo Zanoni
Signed-off-by: Praveen Paneri
---
tests/kms_draw_crc.c | 58 ++
From: Akash Goel
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index fcf8fba..17011d8 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -31,6
tiling
Praveen Paneri (5):
lib/igt_fb: Let others use igt_get_fb_tile_size
lib/igt_fb: Add helper function for tile_to_mod
lib/igt_draw: Add Y-tiling support
igt/kms_frontbuffer_tracking: Add Y-tiling support
igt/kms_fbc_crc.c : Add Y-tile tests
lib/igt_draw.c | 167
This function can be used by igt_draw to get accurate
tile dimensions for all tile formats.
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 2 +-
lib/igt_fb.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index d2b7e9e..6ecc36b 100644
--- a
Allow tests to create Y-tiled bufferes using a separate
argument to the test without increasing the number of
subtests.
Signed-off-by: Praveen Paneri
---
tests/kms_frontbuffer_tracking.c | 46 +++-
1 file changed, 27 insertions(+), 19 deletions(-)
diff --git
igt_get_fb_tile_size function takes modifer as an argument
This helper function will let users to convert tiling to
modifier and use igt_get_fb_tile_size()
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 27 +++
lib/igt_fb.h | 1 +
2 files changed, 28 insertions
This patch adds Y-tiling support for igt_draw_rect function.
v2:
Use helper function to get tile sizes (Ville)
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 132 +
1 file changed, 87 insertions(+), 45 deletions(-)
diff --git a/lib
name and platform check (Ville)
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_reg.h | 3 +++
drivers/gpu/drm/i915/intel_fbc.c | 8
2 files changed, 11 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 5d88c35..f4f0cb5 100644
Hi Ville,
On Wednesday 15 March 2017 03:53 PM, Ville Syrjälä wrote:
On Wed, Mar 15, 2017 at 12:29:35PM +0530, Praveen Paneri wrote:
FBC is only enabled for X-tiled framebuffers but there are
quite a few cases where we tend to use Y-tiled framebuffers.
So enabling it for non X-tiled
FBC is only enabled for X-tiled framebuffers but there are
quite a few cases where we tend to use Y-tiled framebuffers.
So enabling it for non X-tiled framebuffers.
v2: Minor fix for a build error
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
drivers/gpu/drm/i915
FBC is only enabled for X-tiled framebuffers but there are
quite a few cases where we tend to use Y-tiled framebuffers.
So enabling it for non X-tiled framebuffers.
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_reg.h | 2 ++
drivers/gpu/drm/i915/intel_fbc.c | 8
2 files
This patch adds Y-tiling support for igt_draw_rect function.
v2:
Use helper function to get tile sizes (Ville)
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 132 +
1 file changed, 87 insertions(+), 45 deletions(-)
diff --git a/lib
From: Paulo Zanoni
This is the program that's supposed to test lib/igt_draw. We just
added Y tiling support for the library, so add the tests now.
Signed-off-by: Paulo Zanoni
Signed-off-by: Praveen Paneri
---
tests/kms_draw_crc.c | 55 ++
From: Akash Goel
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 41 +
1 file changed, 41 insertions(+)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 0b04a59..e8fae1a 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
igt_get_fb_tile_size function takes modifer as an argument
This helper function will let users to convert tiling to
modifier and use igt_get_fb_tile_size()
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 27 +++
lib/igt_fb.h | 1 +
2 files changed, 28 insertions
This function can be used by igt_draw to get accurate
tile dimensions for all tile formats.
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 2 +-
lib/igt_fb.h | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index bb87869..32e0277 100644
--- a
Hi Tvrtko,
On Wednesday 16 November 2016 01:55 PM, Tvrtko Ursulin wrote:
On 15/11/2016 17:19, Praveen Paneri wrote:
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles for a single read/write and
avoids frequent software forcewake.
This
alignment and variable names (Chris)
- Write GEN9_DECOUPLED_REG0_DW1 register in just one go (Zhe Wang)
v5:
- Changed HAS_DECOUPLED_MMIO() argument name to dev_priv (Tvrtko)
- Sanitize info->had_decoupled_mmio at init (Chris)
Signed-off-by: Zhe Wang
Signed-off-by: Praveen Paneri
Reviewed
Hi Chris,
On Tuesday 15 November 2016 03:37 PM, Chris Wilson wrote:
On Tue, Nov 15, 2016 at 09:36:34AM +, Tvrtko Ursulin wrote:
On 15/11/2016 06:40, Praveen Paneri wrote:
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles for a single
Hi Tvrtko,
On Tuesday 15 November 2016 03:06 PM, Tvrtko Ursulin wrote:
On 15/11/2016 06:40, Praveen Paneri wrote:
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles for a single read/write and
avoids frequent software forcewake.
This
alignment and variable names (Chris)
- Write GEN9_DECOUPLED_REG0_DW1 register in just one go (Zhe Wang)
Signed-off-by: Zhe Wang
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.h | 18 +-
drivers/gpu/drm/i915/i915_pci.c | 1 +
drivers/gpu/drm/i915/i915_reg.h
From: Akash Goel
Signed-off-by: Akash Goel
---
lib/igt_draw.c | 35 +++
1 file changed, 35 insertions(+)
diff --git a/lib/igt_draw.c b/lib/igt_draw.c
index 29a725f..32600f0 100644
--- a/lib/igt_draw.c
+++ b/lib/igt_draw.c
@@ -31,6 +31,7 @@
#include "igt_core.h"
From: Paulo Zanoni
This is the program that's supposed to test lib/igt_draw. We just
added Y tiling support for the library, so add the tests now.
Change-Id: Id0a805aab2d804cf82c188326a8562f0ec75c874
Signed-off-by: Paulo Zanoni
---
tests/kms_draw_crc.c | 55
This patch adds Y-tiling support for igt_draw_rect function.
Change-Id: I139e9773b7df286febe9ffa3dce358df079dac14
Signed-off-by: Praveen Paneri
---
lib/igt_draw.c | 148 ++---
1 file changed, 110 insertions(+), 38 deletions(-)
diff --git a
This adds Y-tiling check in igt_create_fb_with_bo_size as
now we should also be able to create Y-tiled FBs.
Signed-off-by: Praveen Paneri
---
lib/igt_fb.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/lib/igt_fb.c b/lib/igt_fb.c
index 47472f4..bf1d372 100644
--- a/lib
Hi Chris,
On Wednesday 05 October 2016 01:26 AM, Chris Wilson wrote:
On Tue, Oct 04, 2016 at 09:16:06PM +0530, Praveen Paneri wrote:
+#define HAS_DECOUPLED_MMIO(dev) (INTEL_INFO(dev)->has_decoupled_mmio \
+ && IS_BXT_REVID(dev, BXT_REVID_C0, REVID_FOREVER))
Ed
Thanks Chris for the review. Will fix these and resend.
~Praveen
On Wednesday 05 October 2016 01:26 AM, Chris Wilson wrote:
On Tue, Oct 04, 2016 at 09:16:06PM +0530, Praveen Paneri wrote:
+#define HAS_DECOUPLED_MMIO(dev) (INTEL_INFO(dev)->has_decoupled_mmio \
+ && I
: Zhe Wang
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.h | 18 +-
drivers/gpu/drm/i915/i915_pci.c | 1 +
drivers/gpu/drm/i915/i915_reg.h | 7 +++
drivers/gpu/drm/i915/intel_uncore.c | 113
4 files changed, 138
held and skipped decoupled access
- Skipped writing 64 bit register through decoupled MMIO
Signed-off-by: Zhe Wang
Signed-off-by: Damien Lespiau
Signed-off-by: Ankitprasad Sharma
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_drv.h | 11
drivers/gpu/drm/i915/i915_reg.h
On Tuesday 06 September 2016 12:06 PM, Chris Wilson wrote:
On Tue, Sep 06, 2016 at 10:54:14AM +0530, Praveen Paneri wrote:
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles and avoids frequent software
forcewake.
How about when forcewake
Decoupled MMIO is an alternative way to access forcewake domain
registers, which requires less cycles and avoids frequent software
forcewake.
Signed-off-by: Zhe Wang
Signed-off-by: Damien Lespiau
Signed-off-by: Ankitprasad Sharma
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915
On Monday 02 May 2016 06:34 PM, Chris Wilson wrote:
On Mon, May 02, 2016 at 02:10:29PM +0530, Praveen Paneri wrote:
i915_gem_shrink() will scan the bound list only if device is not
suspended but in OOM failure scenario it becomes absolutely necessary
to release as much memory as possible
/put in i915_gem_shrinker_oom() and
i915_gem_shrinker_vmap() to ensure shrinking of bound objects as well.
Signed-off-by: Praveen Paneri
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915
.
Considering the power leakage due to intermediate resume, perform unbinding
operation only if device is already runtime active.
v2: Use newly implemented intel_runtime_pm_get_if_in_use (Chris)
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915
.
Considering the power leakage due to intermediate resume, perform unbinding
operation only if device is already runtime active.
v2: Using newly implemented intel_runtime_pm_get_if_in_use()
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915
i915_gem_shrink_all() will scan the bound list only if device is not
suspended but in OOM scenarios it becomes absolutely necessary to
release as much memory as possible. So, adding rpm get/put in
i915_shrinker_oom() to ensure shrinking of bound objects in OOM
scenario.
Signed-off-by: Praveen
.
Considering the power leakage due to intermediate resume, perform unbinding
operation only if device is already runtime active.
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
Reviewed-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 12
1 file changed, 12 insertions
.
Considering the power leakage due to intermediate resume, perform unbinding
operation only if device is already runtime active.
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
Cc: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 11 +++
1 file changed, 11 insertions(+)
diff
resume could cause power
leakage.
To avoid this intermediate resume of gfx device, don't consider
tiled(fenced) objects for purge in the shrinker path.
Signed-off-by: Akash Goel
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_gem_shrinker.c | 11 +++
1 file change
ed for its validation.
Signed-off-by: Deepak S
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/i915_debugfs.c | 55 +
drivers/gpu/drm/i915/i915_drv.h | 2 ++
2 files changed, 57 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_deb
: Deepak S
Signed-off-by: Praveen Paneri
---
drivers/gpu/drm/i915/intel_pm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c
index 4e24d2b..1082123 100644
--- a/drivers/gpu/drm/i915/intel_pm.c
+++ b/drivers
A call to SLLocate() is missing from the function drmSLLookupNeighbors()
Adding the same to fix this bug.
Signed-off-by: Praveen Paneri
---
xf86drmSL.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/xf86drmSL.c b/xf86drmSL.c
index edafe7b..9c6f65a 100644
--- a/xf86drmSL.c
+++ b/xf86drmSL.c
This patch adds check for various malloc/calloc function if they
were able to allocate memory as requested or not. Return
appropriate error if the allocation fails.
Signed-off-by: Praveen Paneri
---
intel/intel_bufmgr_fake.c | 4
intel/intel_bufmgr_gem.c | 3 +++
intel/intel_decode.c
Move the dereferencing below the check for valid ctx pointer.
Signed-off-by: Praveen Paneri
---
intel/intel_decode.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index b70d949..5dab9ca 100644
--- a/intel/intel_decode.c
+++ b
We must have upper bound on what we are going to write into a fixed
size buffer.
Signed-off-by: Praveen Paneri
---
intel/intel_decode.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/intel/intel_decode.c b/intel/intel_decode.c
index 7d5cbe5..b70d949 100644
--- a
Check on bo_fake before dereferencing the object in functions
evict_lru and evict_mru.
Signed-off-by: Praveen Paneri
---
intel/intel_bufmgr_fake.c | 16 ++--
1 file changed, 10 insertions(+), 6 deletions(-)
diff --git a/intel/intel_bufmgr_fake.c b/intel/intel_bufmgr_fake.c
index
If the allocation fails, return -ENOMEM. Handle the return value
at the caller funtion drmSLInsert() as well.
Signed-off-by: Praveen Paneri
---
xf86drmSL.c | 5 +
1 file changed, 5 insertions(+)
diff --git a/xf86drmSL.c b/xf86drmSL.c
index 45f3906..edafe7b 100644
--- a/xf86drmSL.c
+++ b
This patch adds check on various drmMalloc() calls if they
were able to allocate memory as requested or not. Return
appropriate error if the allocation fails.
Signed-off-by: Praveen Paneri
---
xf86drm.c | 51 ---
1 file changed, 40 insertions
HASH_RANDOM_INIT() can fail to allocate memory. In such case return an
invalid hash value (0x) from HashHash() function.
Caller functions check the hash value and act accordingly.
Signed-off-by: Praveen Paneri
---
xf86drmHash.c | 9 +
1 file changed, 9 insertions(+)
diff --git
This patch set fixes various issues reported by a static
analysis tool.
Praveen Paneri (12):
intel: Validate bo_fake before using.
intel: Validate output of realloc()
intel: Use snprintf instead of sprintf
intel: Validate pointer before using
xf86drm: Avoid negative array index value
Return value of drmHashCreate() and drmGetEntry() functions
can be NULL. It should be validated before being used.
Signed-off-by: Praveen Paneri
---
xf86drm.c | 24 +++-
1 file changed, 19 insertions(+), 5 deletions(-)
diff --git a/xf86drm.c b/xf86drm.c
index 373113b
realloc will return NULL if failed to allocate the extra memory
requested. Return from function if it fails.
Signed-off-by: Praveen Paneri
---
intel/intel_bufmgr_gem.c | 37 -
1 file changed, 28 insertions(+), 9 deletions(-)
diff --git a/intel
Variable retcode can be negative as well. Put the correct
condition on it before using it as array index.
Signed-off-by: Praveen Paneri
---
xf86drm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/xf86drm.c b/xf86drm.c
index e73cddd..1e25424 100644
--- a/xf86drm.c
+++ b
Validate the return value of SLCreateEntry() before using it.
Signed-off-by: Praveen Paneri
---
xf86drmSL.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/xf86drmSL.c b/xf86drmSL.c
index acddb54..45f3906 100644
--- a/xf86drmSL.c
+++ b/xf86drmSL.c
@@ -139,6 +139,7 @@ void *drmSLCreate
1 - 100 of 110 matches
Mail list logo
