Hi Dave & Sima,
Here goes the drm-intel-fixes PR towards v6.16-rc4.
Two Cc stable fixes, fix for HDMI 1080p@120Hz and DP AUX DPCD probing.
Then a followup build fix for GCOV + AutoFDO configs.
Regards, Joonas
***
drm-intel-fixes-2025-06-26:
- Fix for SNPS PHY HDMI for 1080p@120Hz
- Correct DP
On 6/25/25 12:22 AM, Stephen Rothwell wrote:
> Hi all,
>
> Changes since 20250624:
>
on i386, when both CONFIG_DRM_XE=y
and CONFIG_DRM_I915=y:
ld: drivers/gpu/drm/xe/xe_pcode.o: in function `intel_pcode_read':
xe_pcode.c:(.text+0x7d0): multiple definition of `intel_pcode_read';
drivers/gpu/
On Tue, 24 Jun 2025, Mitul Golani wrote:
> From: Ville Syrjälä
>
> Add function to control DC balance enable/disable bit via DSB.
>
> Signed-off-by: Ville Syrjälä
> Signed-off-by: Mitul Golani
> Reviewed-by: Ankit Nautiyal
> ---
> drivers/gpu/drm/i915/display/intel_dmc.c | 18
== Series Details ==
Series: drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro
URL : https://patchwork.freedesktop.org/series/150758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16754 -> Patchwork_150758v1
Summar
From: Ville Syrjälä
Initialise delayed vblank position for evasion logic.
Signed-off-by: Ville Syrjälä
Signed-off-by: Mitul Golani
Reviewed-by: Ankit Nautiyal
---
drivers/gpu/drm/i915/display/intel_vblank.c | 13 +
1 file changed, 9 insertions(+), 4 deletions(-)
diff --git a/dri
DISPLAY_PLANE_FLIP_PENDING() has been unused since commit fd3a40242e87
("drm/i915: Rip out legacy page_flip completion/irq handling"). Remove.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/i915_reg.h | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drive
On Tue, Jun 24, 2025 at 12:12:10PM +, 陈涛涛 Taotao Chen wrote:
> From: Taotao Chen
>
> Set the FOP_DONTCACHE flag in ext4_file_operations to indicate that
> ext4 supports IOCB_DONTCACHE handling in buffered write paths.
>
> Part of a series refactoring address_space_operations write_begin and
在 2025/6/24 20:53, Matthew Wilcox 写道:
On Tue, Jun 24, 2025 at 12:12:10PM +, 陈涛涛 Taotao Chen wrote:
From: Taotao Chen
Set the FOP_DONTCACHE flag in ext4_file_operations to indicate that
ext4 supports IOCB_DONTCACHE handling in buffered write paths.
I think this patch should be combined wi
From: Taotao Chen
Set the FOP_DONTCACHE flag in ext4_file_operations to indicate that
ext4 supports IOCB_DONTCACHE handling in buffered write paths.
Part of a series refactoring address_space_operations write_begin and
write_end callbacks to use struct kiocb for passing write context and
flags.
== Series Details ==
Series: Enable/Disable DC balance along with VRR DSB (rev7)
URL : https://patchwork.freedesktop.org/series/147799/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16747 -> Patchwork_147799v7
Summary
-
> -Original Message-
> From: Kandpal, Suraj
> Sent: Friday, June 20, 2025 12:05 PM
> To: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org; dri-
> de...@lists.freedesktop.org; nouv...@lists.freedesktop.org
> Cc: Murthy, Arun R ; Kandpal, Suraj
>
> Subject: [PATCH v3 04/13] d
On Wed, Jun 25, 2025 at 04:21:40PM +0300, Jani Nikula wrote:
> DISPLAY_PLANE_FLIP_PENDING() has been unused since commit fd3a40242e87
> ("drm/i915: Rip out legacy page_flip completion/irq handling"). Remove.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915
== Series Details ==
Series: drm/i915/display: Use static values for min_hblank
URL : https://patchwork.freedesktop.org/series/150684/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16748 -> Patchwork_150684v1
Summary
--
== Series Details ==
Series: drm/i915/panel: register drm_panel and call prepare/unprepare for eDP
(rev3)
URL : https://patchwork.freedesktop.org/series/150370/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16747 -> Patchwork_150370v3
=
From: Ville Syrjälä
The current PKG_C_LATENCY stuff looks busted in several ways:
- doesn't account for multiple pipes from different commits
correctly
- WM_LINETIME is in units of 0.125usec, PKG_C_LATENCY wants
units on 1 usec
- weird VRR state stuff being checked
- use of pointless RMW
Fix
From: Ville Syrjälä
AFAIK PKG_C_LATENCY.added_wake_time only matters for flip queue.
As long as we're not using that there's no point in adding any
extra wake time.
Reviewed-by: Uma Shankar
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/skl_watermark.c | 9 -
1 file cha
On Wed, Jun 25, 2025 at 10:21:58AM -0500, Dan Carpenter wrote:
> There was an error pointer vs NULL bug in __igt_breadcrumbs_smoketest().
> The __mock_request_alloc() function implements the
> smoketest->request_alloc() function pointer. It was supposed to return
> error pointers, but it propogate
== Series Details ==
Series: drm/i915: remove unused DISPLAY_PLANE_FLIP_PENDING() macro (rev2)
URL : https://patchwork.freedesktop.org/series/150758/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16757 -> Patchwork_150758v2
On Wed, Jun 25, 2025 at 11:04:07AM +0530, Arun R Murthy wrote:
> Use recommended values as per wa_14021694213 to compare with the
> calculated value and choose minimum of them.
>
> v2: corrected checkpatch warning and retain the restriction for
> min_hblank (Jani)
> v3: use calculated value to com
There was an error pointer vs NULL bug in __igt_breadcrumbs_smoketest().
The __mock_request_alloc() function implements the
smoketest->request_alloc() function pointer. It was supposed to return
error pointers, but it propogates the NULL return from mock_request()
so in the event of a failure, it
== Series Details ==
Series: drm/i915/selftests: Change mock_request() to return error pointers
URL : https://patchwork.freedesktop.org/series/150767/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16756 -> Patchwork_150767v1
From: Taotao Chen
Replace the write_begin/write_end loop in
i915_gem_object_create_shmem_from_data() with call to kernel_write().
This function initializes shmem-backed GEM objects. kernel_write()
simplifies the code by removing manual folio handling.
Part of a series refactoring address_space_
在 2025/6/24 20:23, Matthew Wilcox 写道:
On Tue, Jun 24, 2025 at 12:12:04PM +, 陈涛涛 Taotao Chen wrote:
+++ b/drivers/gpu/drm/i915/gem/i915_gem_shmem.c
@@ -637,8 +637,7 @@ i915_gem_object_create_shmem_from_data(struct
drm_i915_private *i915,
{
struct drm_i915_gem_object *obj;
On Tue, Jun 24, 2025 at 12:12:09PM +, 陈涛涛 Taotao Chen wrote:
> From: Taotao Chen
>
> Add support for the IOCB_DONTCACHE flag in ext4_write_begin() and
> ext4_da_write_begin(). When set in the kiocb, the FGP_DONTCACHE bit
> is passed to the page cache lookup, preventing written pages from
> be
Quoting Krzysztof Karas (2025-06-23 09:40:48)
> Hi Chris,
>
> > > Amend the problem by keeping the mock file open throughout the
> > > duration of this test and calling fput() from the test itself.
> >
> > That is not the problem; that is papering over whatever the problem
> > really is.
> Would
On Tue, 24 Jun 2025, Ville Syrjälä wrote:
> On Tue, Jun 24, 2025 at 10:10:53AM +0530, Nautiyal, Ankit K wrote:
>>
>> On 6/23/2025 8:12 PM, Ville Syrjälä wrote:
>> > On Fri, Jun 20, 2025 at 06:14:16PM +0530, Ankit Nautiyal wrote:
>> >> This reverts commit 584cf613c24a4250d9be4819efc841aa2624d5b6.
On Wed, Jun 25, 2025 at 03:39:38PM +0300, Jani Nikula wrote:
> Add pw_ctl_idx_to_pg() helper function to deduplicate the open-coded
> usage of the {SKL,ICL}_PW_CTL_IDX_TO_PG() macros.
>
> Signed-off-by: Jani Nikula
> ---
> .../i915/display/intel_display_power_well.c | 24 +--
>
On Wed, Jun 25, 2025 at 03:39:37PM +0300, Jani Nikula wrote:
> Move the {SKL,ICL}_PW_CTL_IDX_TO_PG() macros from intel_display_regs.h
> to intel_display_power_well.c. The mapping from index to PG can be
> hidden there.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> .../gpu/d
On Wed, Jun 25, 2025 at 03:39:36PM +0300, Jani Nikula wrote:
> When the display registers were split off from i915_reg.h, enum
> skl_power_gate was left behind. Move it to intel_display_regs.h.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Rodrigo Vivi
> ---
> drivers/gpu/drm/i915/display/intel
On Fri, 20 Jun 2025, Suraj Kandpal wrote:
> This series modifies drm dp edp helpers so that drivers can now use them
> to manipulate brightness using luminance value via the
> PANEL_TARGET_LUMINANCE_VALUE register. This feature was
> introduced frin eDP 1.5.
>
> Signed-off-by: Suraj Kandpal
>
> S
== Series Details ==
Series: drm/i915/power: power well register cleanups
URL : https://patchwork.freedesktop.org/series/150751/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16754 -> Patchwork_150751v1
Summary
---
*
Add pw_ctl_idx_to_pg() helper function to deduplicate the open-coded
usage of the {SKL,ICL}_PW_CTL_IDX_TO_PG() macros.
Signed-off-by: Jani Nikula
---
.../i915/display/intel_display_power_well.c | 24 +--
1 file changed, 11 insertions(+), 13 deletions(-)
diff --git a/drivers/gp
When the display registers were split off from i915_reg.h, enum
skl_power_gate was left behind. Move it to intel_display_regs.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_regs.h | 9 +
drivers/gpu/drm/i915/i915_reg.h | 10 --
2 f
Move the {SKL,ICL}_PW_CTL_IDX_TO_PG() macros from intel_display_regs.h
to intel_display_power_well.c. The mapping from index to PG can be
hidden there.
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_display_power_well.c | 13 +
drivers/gpu/drm/i915/display/intel_displa
Jani Nikula (3):
drm/i915/power: move enum skl_power_gate under display
drm/i915/power: relocate {SKL,ICL}_PW_CTL_IDX_TO_PG()
drm/i915/power: convert {SKL,ICL}_PW_CTL_IDX_TO_PG() macros to a
function
.../i915/display/intel_display_power_well.c | 19 +
.../gpu/drm/i91
== Series Details ==
Series: drm/i915/display: make all global state opaque (rev2)
URL : https://patchwork.freedesktop.org/series/150158/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16754 -> Patchwork_150158v2
Summary
---
> -Original Message-
> From: Jani Nikula
> Sent: Wednesday, June 25, 2025 2:33 PM
> To: Kandpal, Suraj ; intel...@lists.freedesktop.org;
> intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org;
> nouv...@lists.freedesktop.org; Lyude Paul
> Cc: Murthy, Arun R ; Kandpal, Suraj
Add intel_cdclk_logical() helper to avoid looking at struct
intel_cdclk_state internals outside of intel_cdclk.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/hsw_ips.c | 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +
drivers/gpu/drm/i9
Add intel_bw_pmdemand_needs_update() helper to avoid looking at struct
intel_bw_state internals outside of intel_bw.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bw.c | 14 ++
drivers/gpu/drm/i915/display/intel_bw.h | 2 ++
With all the code touching struct intel_bw_state moved inside
intel_bw.c, we move the struct definition there too, and make the type
opaque. to_intel_bw_state() needs to be turned into a proper
function. All of this nicely reduces includes from intel_bw.h.
Reviewed-by: Imre Deak
Signed-off-by: Ja
Add intel_cdclk_read_hw() function to avoid looking at struct
intel_cdclk_state internals outside of intel_cdclk.c.
intel_cdclk_init_hw() would be a better name, but we already have that.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cdclk.c
With all the code touching struct intel_cdclk_state moved inside
intel_cdclk.c, we move the struct definition there too, and make the
type opaque. This nicely reduces includes from intel_cdclk.h.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cdclk.c |
Add intel_cdclk_pmdemand_needs_update() helper to avoid looking at
struct intel_cdclk_state internals outside of intel_cdclk.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cdclk.c| 15 +++
drivers/gpu/drm/i915/display/intel_cdclk.h
Add intel_cdclk_actual() and intel_cdclk_actual_voltage_level() helpers
to avoid looking at struct intel_cdclk_state internals outside of
intel_cdclk.c.
v2: Better location (Imre)
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cdclk.c| 10 +
Add intel_cdclk_force_min_cdclk() helper to avoid modifying struct
intel_cdclk_state internals outside of intel_cdclk.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_audio.c | 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +
drivers/gpu/drm
Add intel_cdclk_bw_min_cdclk() helper to avoid looking at struct
intel_cdclk_state internals outside of intel_cdclk.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bw.c| 4 ++--
drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +
drivers/gpu/drm
Add intel_cdclk_min_cdclk() helper to avoid looking at struct
intel_cdclk_state internals outside of intel_cdclk.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 5 +
drivers/gpu/drm/i915/display/intel_cdclk.h | 1 +
drivers/gpu/drm/i915/
Add intel_bw_qgv_point_peakbw() helper to avoid looking at struct
intel_bw_state internals outside of intel_bw.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bw.c | 5 +
drivers/gpu/drm/i915/display/intel_bw.h | 1 +
drivers/gpu/drm/i
Prefer only looking at struct intel_bw_state internals inside
intel_bw.c. To that effect, move icl_sagv_{pre,post}_plane_update()
there.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bw.c | 68 +++-
drivers/gpu/drm/i915/display/int
Prefer only looking at struct intel_bw_state internals inside
intel_bw.c. To that effect, move intel_can_enable_sagv() there, and
rename to intel_bw_can_enable_sagv() to have consistent naming.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_bw.c |
With all the code touching struct intel_dbuf_state moved inside
skl_watermark.c, we move the struct definition there too, and make the
type opaque. This nicely reduces includes from skl_watermark.h.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/skl_watermark
Add intel_dbuf_num_enabled_slices() and intel_dbuf_num_active_pipes()
helpers to avoid looking at struct intel_dbuf_state internals outside of
skl_watermark.c.
Reviewed-by: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_pmdemand.c | 6 +++---
drivers/gpu/drm/i915/d
Add intel_dbuf_pmdemand_needs_update() helper to avoid looking at struct
intel_dbuf_state internals outside of skl_watermark.c.
With this, we can also move to_intel_dbuf_state(),
intel_atomic_get_old_dbuf_state(), and intel_atomic_get_new_dbuf_state()
inside skl_watermark.c.
Reviewed-by: Imre Dea
v2 of [1], primarily for CI.
[1] https://lore.kernel.org/r/cover.1749730224.git.jani.nik...@intel.com
Jani Nikula (16):
drm/i915/wm: abstract intel_dbuf_pmdemand_needs_update()
drm/i915/wm: add more accessors to dbuf state
drm/i915/wm: make struct intel_dbuf_state opaque type
drm/i915/bw:
Thanks, I really like the i915 work to stop the shmem abuse.
I still hate it that we just change the write_begin/end ops while still
in the address_space ops vs passing explicit callbacks, because that
means we'll some other version of that abuse back sooner or later :(
== Series Details ==
Series: drm/i915/display: Implement wa_16011342517 (rev4)
URL : https://patchwork.freedesktop.org/series/149118/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16753 -> Patchwork_149118v4
Summary
---
== Series Details ==
Series: drm/i915/display: Use the recomended min_hblank values
URL : https://patchwork.freedesktop.org/series/150726/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16753 -> Patchwork_150726v1
Summary
--
On Tue, Jun 24, 2025 at 01:51:51PM +0100, Matthew Wilcox wrote:
> On Tue, Jun 24, 2025 at 12:12:08PM +, 陈涛涛 Taotao Chen wrote:
> > -static int blkdev_write_end(struct file *file, struct address_space
> > *mapping,
> > +static int blkdev_write_end(struct kiocb *iocb, struct address_space
> > *
While doing voltage swing for type-c phy
for DP 1.62 and HDMI write the
LOADGEN_SHARING_PMD_DISABLE bit to 1.
-v2: Update commit.
Add bspec[Suraj]
-v3: Move w/a before DKL_TX_PMD_LANE_SUS.
Use DKL_TX_DPCNTL2[Ville]
-v4: Use intel_encoder_is_dp and
intel_encoder_is_hdmi. [Suraj]
Bsp
59 matches
Mail list logo