Pipe A is required to run the DC5 transaction. Adding log information
to indicate if any pipe other than Pipe A is selected.
Signed-off-by: Mohammed Thasleem
---
tests/intel/kms_pm_dc.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/intel/kms_pm_dc.c b/tests/intel/kms_pm_dc.c
index
Hi,
https://patchwork.freedesktop.org/series/145352/ - Re-reported.
i915.CI.BAT - Re-reported.
Thanks,
Ravali.
-Original Message-
From: I915-ci-infra On Behalf Of
Imre Deak
Sent: 25 February 2025 19:55
To: i915-ci-in...@lists.freedesktop.org
Cc: intel-gfx@lists.freedesktop.org
Subject:
== Series Details ==
Series: drm/dp: Fix link training interrupted by HPD pulse (rev3)
URL : https://patchwork.freedesktop.org/series/145352/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16178 -> Patchwork_145352v3
Summary
Hi all,
Today's linux-next merge of the drm-xe tree got a conflict in:
drivers/gpu/drm/xe/display/xe_display.c
between commit:
1b242ceec536 ("drm/i915/audio: convert to struct intel_display")
from the drm-intel tree and commit:
d41d048043c4 ("drm/xe/display: Drop xe_display_driver_remov
On Tue, 2025-02-18 at 23:18 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> The crtc state is expected to be fully cleared before readout,
> so there is no need to clear the shared_dpll pointers by hand.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_display.
* li...@treblig.org wrote:
> From: "Dr. David Alan Gilbert"
>
> The last use of iosf_mbi_unregister_pmic_bus_access_notifier() was
> removed in 2017 by
> commit a5266db4d314 ("drm/i915: Acquire PUNIT->PMIC bus for
> intel_uncore_forcewake_reset()")
>
> Remove it.
>
> Note the '_unlocked' ve
On Tue, 2025-02-18 at 23:18 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> We currently call intel_set_cdclk_post_plane_update() far
> too early. When pipes are active during the reprogramming
> the current spot only works for the cd2x divider update
> case, as that is synchronize to the p
On Tue, Feb 25, 2025 at 01:14:22PM +0200, Jani Nikula wrote:
> Drop the dependency on gt by providing a callback for trying to unbreak
> stuck modeset. Do intel_gt_set_wedged() via the callback.
>
> It's by no means pretty, but this is perhaps the most straightforward
> alternative.
>
> Cc: Matt
On Tue, Feb 25, 2025 at 01:14:21PM +0200, Jani Nikula wrote:
> Deduplicate the gpu_reset_clobbers_display() part by passing the
> information in from gt side.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Reviewed-by: Matt Roper
> ---
> drivers/gpu/drm/i915/display/intel_display_reset.c |
On Tue, Feb 25, 2025 at 01:14:20PM +0200, Jani Nikula wrote:
> Move the checks for whether display reset is needed as well as
> I915_RESET_MODESET flag handling to gt side of things.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
> ---
> .../drm/i915/display/intel_display_reset.c| 15 -
On Tue, Feb 25, 2025 at 01:14:19PM +0200, Jani Nikula wrote:
> More of the gt side of display reset will be moved away from
> display. Add small wrappers for display reset calls to not clutter the
> gt reset part of things.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
Reviewed-by: Matt Roper
On Tue, Feb 25, 2025 at 01:14:18PM +0200, Jani Nikula wrote:
> Add a helper for checking if we want to test display reset regardless of
> whether it's strictly necessary. This will come in handy in follow-up
> work where we want to check this from gt reset side.
>
> Cc: Matt Roper
> Signed-off-by
On Sat, 25 Jan 2025, "Andy Yan" wrote:
> 在 2025-01-24 19:43:07，"Jani Nikula" 写道：
>>On Fri, 24 Jan 2025, "Andy Yan" wrote:
>>> Hi，
>>>
>>> At 2025-01-23 23:09:09, "Jani Nikula" wrote:
The expectation is that the struct drm_device based logging helpers get
passed an actual struct drm_devi
>From PTL, LUT registers are made double buffered. This helps us
to program them in the active region without any concern of tearing.
This particulary helps in case of displays with high refresh rates
where vblank periods are shorter.
This series
- adds MMIO programming of LUT registers in
>From PTL, LUT registers are made double buffered. With this change,
we don't need to wait for vblank to program them. Start DSB1 for
programming them without waiting for vblank.
Signed-off-by: Chaitanya Kumar Borah
---
drivers/gpu/drm/i915/display/intel_display.c | 4 +++-
1 file changed, 3 ins
>From PTL, LUT registers are made double buffered. This helps us
to program them in the active region without any concern of tearing.
This particulary helps in case of displays with high refresh rates
where vblank periods are shorter.
This patch makes the following changes
- Adds the macr
On Tue, 2025-02-25 at 13:29 +0200, Jani Nikula wrote:
> On Fri, 21 Feb 2025, Dmitry Baryshkov wrote:
> > On Mon, Feb 03, 2025 at 12:57:55PM +0200, Abel Vesa wrote:
> > > Looking at both i915 and nouveau DP drivers, both are setting the first
> > > LTTPR (if found) in transparent mode first and the
On Tue, 25 Feb 2025, Imre Deak wrote:
> Add support for suspending the IRQ handling on the HPD pin of a given
> encoder, handling IRQs that arrived while in the suspended state after
> resuming the IRQ handling. This will be used by a follow-up change,
> which suspends/resumes the IRQ handling aro
On Tue, Feb 25, 2025 at 06:25:01PM +0200, Jani Nikula wrote:
> On Tue, 25 Feb 2025, Imre Deak wrote:
> > Add support for suspending the IRQ handling on the HPD pin of a given
> > encoder, handling IRQs that arrived while in the suspended state after
> > resuming the IRQ handling. This will be used
On 12-02-2025 21:19, Anirban, Sk wrote:
On 11-02-2025 21:23, Jani Nikula wrote:
On Tue, 11 Feb 2025, Sk Anirban wrote:
Improve RC6 power measurement and error handling. Add detailed error
messages, and introduce a threshold check for RC6 residency.
Improve how? Why?
BR,
Jani.
The power
On Thu, 23 Jan 2025 17:09:08 +0200
Jani Nikula wrote:
> The expectation is that the struct drm_device based logging helpers get
> passed an actual struct drm_device pointer rather than some random
> struct pointer where you can dereference the ->dev member.
>
> Convert drm_err(host, ...) to dev_
On Thu, 23 Jan 2025 17:09:12 +0200
Jani Nikula wrote:
> The expectation is that the struct drm_device based logging helpers get
> passed an actual struct drm_device pointer rather than some random
> struct pointer where you can dereference the ->dev member.
>
> Add a static inline helper to conv
Going forward, struct intel_display is the main display device data
pointer. Convert as much as possible of intel_fdi.[ch] to struct
intel_display.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 4 +-
.../drm/i915/display/intel_display_driver.c | 4 +-
drive
Going forward, struct intel_display is the main display device data
pointer. Convert as much as possible of intel_fbc.[ch] to struct
intel_display. In a few places, change the variable declaration order to
prefer having display first.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/i
Convert the intel_ddi.[ch] interfaces to struct intel_display. Postpone
further conversion to avoid conflicts.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 9 +++--
drivers/gpu/drm/i915/display/intel_ddi.h | 4 +---
drivers/gpu/drm/i915/display/intel_fdi.c | 6 ++
Going forward, struct intel_display is the main display device data
pointer. Convert the functions to set/get M/N values and check for M2/N2
support to struct intel_display.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 88 +--
drivers/gpu/drm/i91
Going forward, struct intel_display is the main display device data
pointer. Convert as much as possible of intel_display_rps.[ch] to struct
intel_display.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_atomic_plane.c | 8
drivers/gpu/drm/i915/display/intel_display_rp
On Mon, 03 Feb 2025 12:57:55 +0200, Abel Vesa wrote:
> Looking at both i915 and nouveau DP drivers, both are setting the first
> LTTPR (if found) in transparent mode first and then in non-transparent
> mode, just like the DP v2.0 specification mentions in section 3.6.6.1.
>
> Being part of the sta
Going forward, struct intel_display is the main display device data
pointer. Convert the intel_dpt.[ch] interfaces to struct intel_display,
though the file being very i915 specific, it's hard to convert the
implementation.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dpt.c |
Going forward, struct intel_display is the main display device data
pointer. Convert as much as possible of intel_drrs.[ch] to struct
intel_display.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_dp.c | 4 +-
drivers/gpu/drm/i915/display/intel_drrs.c | 39 +-
Going forward, struct intel_display is the main display device data
pointer. Convert the intel_snps_phy.[ch] to struct intel_display. Also
convert the very much related intel_phy_is_snps() helper.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
drivers/gpu/d
Going forward, struct intel_display is the main display device data
pointer. Convert intel_dkl_phy.[ch] to struct intel_display.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_driver.c | 2 +-
drivers/gpu/drm/i915/display/intel_dkl_phy.c| 8 +++-
drivers/gp
Going forward, struct intel_display is the main display device data
pointer. Convert the intel_tdf.[ch] glue to struct intel_display.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.c | 2 +-
drivers/gpu/drm/i915/display/intel_frontbuffer.c | 2 +-
drivers/gpu/drm/i
A number of unused struct drm_i915_private forward declarations have
been left behind. Remove them.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_atomic.h| 1 -
drivers/gpu/drm/i915/display/intel_ddi_buf_trans.h | 1 -
drivers/gpu/drm/i915/display/intel_hdmi.h
Nudge intel_display_debugfs.[ch] conversion to struct intel_display
forward.
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_debugfs.c | 26 +++
.../drm/i915/display/intel_display_debugfs.h | 6 ++---
.../drm/i915/display/intel_display_driver.c | 2 +-
3 f
More of the same.
Jani Nikula (12):
drm/i915/display: remove leftover struct drm_i915_private forward
declarations
drm/i915/debugfs: continue display debugfs struct intel_display
conversion
drm/i915/tdf: convert intel_tdf.[ch] to struct intel_display
drm/i915/snps: convert intel_sn
On Mon, 24 Feb 2025, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add the bit definitions needed for POST_LT_ADJ sequence.
>
> Signed-off-by: Ville Syrjälä
> ---
> include/drm/display/drm_dp.h | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/include/drm/display/drm_dp.h b/include/d
On Tue, 25 Feb 2025, Andi Shyti wrote:
> Hi Jani,
>
> On Tue, Feb 25, 2025 at 09:52:41AM +0200, Jani Nikula wrote:
>> On Mon, 24 Feb 2025, Andi Shyti wrote:
>> > Hi Ville,
>> >
>> > On Wed, Feb 12, 2025 at 01:19:37AM +0200, Ville Syrjala wrote:
>> >> From: Ville Syrjälä
>> >>
>> >> Convert the
On Tue, 25 Feb 2025, "Kandpal, Suraj" wrote:
>> -Original Message-
>> From: Kandpal, Suraj
>> Sent: Tuesday, February 25, 2025 2:25 PM
>> To: Jani Nikula ;
>> intel...@lists.freedesktop.org;
>> intel-gfx@lists.freedesktop.org
>> Cc: Nautiyal, Ankit K ; Shankar, Uma
>> ; Kahola, Mika
>> S
Hi Jani,
On Tue, Feb 25, 2025 at 09:52:41AM +0200, Jani Nikula wrote:
> On Mon, 24 Feb 2025, Andi Shyti wrote:
> > Hi Ville,
> >
> > On Wed, Feb 12, 2025 at 01:19:37AM +0200, Ville Syrjala wrote:
> >> From: Ville Syrjälä
> >>
> >> Convert the BDW+ EU/slice fuse bits to the modern REG_BIT()/etc.
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
1. All classes used by a module (declared DYNDBG_CLASSMAP_{DEFINE,USE}
by module code) must share 0..62 class-id space; ie their respective
base,+length reservations shouldn't overlap. Overlaps would lead to
unintended changes in ddebug enablements.
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
commit 47ea6f99d06e ("dyndbg: use ESCAPE_SPACE for cat control")
changed the control-file to display format strings with "\n" rather
than "\012". Update the docs to match the new reality.
Signed-off-by: Jim Cromie
Hi Jim,
I think this patch is
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
move the DYNDBG_CLASSMAP_PARAM macro from test-dynamic-debug.c into
the header, and refine it, by distinguishing the 2 use cases:
1.DYNDBG_CLASSMAP_PARAM_REF
for DRM, to pass in extern __drm_debug by name.
dyndbg keeps bits in it, so drm c
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
To prep for failing modprobe on classid conflicts, upgrade the
call-chain around ddebug_add_module(), in 2 ways:
1. in ddebug_add_module() add local reserved_ids to accumulate
reservations, pass it by ref to ddebug_attach_{,user_}module_classes()
so
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
The class_ct var was added to avoid 2 function calls, but to do this
it loops over all the module's debug callsites to determine the count.
But it doesn't really help, so remove it.
Signed-off-by: Jim Cromie
Hi Jim,
If you move the other patch e
Hi CI team,
On Tue, Feb 25, 2025 at 01:41:55PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/dp: Fix link training interrupted by HPD pulse (rev3)
> URL : https://patchwork.freedesktop.org/series/145352/
> State : failure
the issue reported below is unrelated, see my comment t
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
When modprobing a module, dyndbg currently logs/says "add-module", and
then "skipping" if the module has no prdbgs. Instead just check 1st
and return quietly.
no functional change
Signed-off-by: Jim Cromie
Reviewed-by: Louis Chauvet
---
li
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
struct _ddebug_info's jobs is to enapsulate the __sections of dyndbg
data from the linker. The data started as a single pair of fields:
descs - ref'g an array of descriptors & num_descs - counting the
"pertinent" descriptors. Then classes & num_cla
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
add for_subvec() macro to encapsulate a for-loop pattern thats used
repeatedly to iterate over a boxed.vector of N elements.
Signed-off-by: Jim Cromie
Hi Jim,
Do you think it is possible to move this patch earlier in the series, so
you can use
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
Add __DYNDBG_CLASSMAP_CHECK to implement these arg-checks at compile:
0 <= _base < 63
class_names is not empty
class_names[0] is a string
(class_names.length + _base) < 63
These compile-time checks will prevent severa
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
ARRAY_SIZE works here, since array decl is complete.
no functional change
Signed-off-by: Jim Cromie
Reviewed-by: Louis Chauvet
---
include/linux/dynamic_debug.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
DECLARE_DYNDBG_CLASSMAP() has a design error; its usage fails a basic
K&R rule: "define once, refer many times".
It is used across DRM core & drivers, each use re-defines the classmap
understood by that module; and all must match for the modules to
== Series Details ==
Series: drm/i915/power: move runtime power status info to power debugfs
URL : https://patchwork.freedesktop.org/series/145399/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16178 -> Patchwork_145399v1
S
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
Several new DYNDBG_CLASSMAP_* macros (added in following commits)
expand to multi-statement declarations, like module_param_named does.
They are invoked in file-scope, not in function scope, and cannot be
wrapped by a do-while, so add an exception by
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
old_bits arg is currently a pointer to the input bits, but this could
allow inadvertent changes to the input by the fn. Disallow this.
And constify new_bits while here.
Signed-off-by: Jim Cromie
Reviewed-by: Louis Chauvet
---
lib/dynamic_de
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
Change function's 1st arg-type, and deref in the caller.
The fn doesn't need any other fields in the struct.
no functional change.
Signed-off-by: Jim Cromie
Reviewed-by: Louis Chauvet
---
lib/dynamic_debug.c | 10 +-
1 file changed
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
In ddebug_apply_class_bitmap(), check for actual changes to the bits
before announcing them, to declutter logs.
no functional change.
Signed-off-by: Jim Cromie
Reviewed-by: Louis Chauvet
---
lib/dynamic_debug.c | 12 +++-
1 file ch
On Mon, Feb 24, 2025 at 06:28:50PM +, Patchwork wrote:
> == Series Details ==
>
> Series: drm/i915/dp_mst: Fix encoder HW state readout for UHBR MST
> URL : https://patchwork.freedesktop.org/series/145300/
> State : failure
Thanks for the review, patch is pushed to drm-intel-next.
The fail
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
currently, for verbose=3, these are logged (blank lines for clarity):
dyndbg: query 0: "class DRM_UT_CORE +p" mod:*
dyndbg: split into words: "class" "DRM_UT_CORE" "+p"
dyndbg: op='+'
dyndbg: flags=0x1
dyndbg: *flagsp=0x1 *maskp=0xfff
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
Split api-fn: param_set_dyndbg_classes(), adding modname param and
passing NULL in from api-fn.
The new arg allows caller to specify that only one module is affected
by a prdbgs update. This selectivity will be used later to narrow the
scope of cha
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
Add param: query_module to ddebug_apply_class_bitmap(), and pass it
thru to _ddebug_queries(), replacing NULL with query_module. This
allows its caller to update just one module, or all (as currently).
We'll use this later to propagate drm.debug to
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
Classmaps are stored in an elf section/array, but are individually
list-linked onto dyndbg's per-module ddebug_table for operation.
This is unnecessary; even when ddebug_attach_classmap() is handling
the builtin section (with classmaps for multiple
== Series Details ==
Series: drm/dp: Fix link training interrupted by HPD pulse (rev3)
URL : https://patchwork.freedesktop.org/series/145352/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16178 -> Patchwork_145352v3
Summary
== Series Details ==
Series: drm/dp: Fix link training interrupted by HPD pulse (rev3)
URL : https://patchwork.freedesktop.org/series/145352/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: display reset cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/143233/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16178 -> Patchwork_143233v2
Summary
---
**SUCC
== Series Details ==
Series: drm/i915: display reset cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/143233/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: display reset cleanups (rev2)
URL : https://patchwork.freedesktop.org/series/143233/
State : warning
== Summary ==
Error: dim checkpatch failed
4aee0c5c8245 drm/i915/display: convert display reset to struct intel_display *
08d24e29e256 drm/i915: move pend
== Series Details ==
Series: i915/selftest/igt_mmap: let mmap tests run in kthread
URL : https://patchwork.freedesktop.org/series/145391/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_16178 -> Patchwork_145391v1
Summary
---
== Series Details ==
Series: i915/selftest/igt_mmap: let mmap tests run in kthread
URL : https://patchwork.freedesktop.org/series/145391/
State : warning
== Summary ==
Error: dim checkpatch failed
8ffea5ad2c7b i915/selftest/igt_mmap: let mmap tests run in kthread
-:196: CHECK:LINE_SPACING: Ple
The i915 core debugfs has no business looking at power domain guts for
runtime power status. Move the info to the more appropriate place.
Cc: Imre Deak
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_power.c | 3 +++
drivers/gpu/drm/i915/i915_debugfs.c|
Add support for suspending the IRQ handling on the HPD pin of a given
encoder, handling IRQs that arrived while in the suspended state after
resuming the IRQ handling. This will be used by a follow-up change,
which suspends/resumes the IRQ handling around DP link training.
This is similar to the i
intel_hpd_disable/enable() have the same purpose as
intel_hpd_suspend/resume(), except that disable/enable will drop any HPD
IRQs which were triggered while the HPD was disabled, while
suspend/resume will handle such IRQs after the IRQ handling is resumed.
Use intel_hpd_suspend/resume() for crt as
On Tue, 25 Feb 2025, Jani Nikula wrote:
> Add a helper for checking if we want to test display reset regardless of
> whether it's strictly necessary. This will come in handy in follow-up
> work where we want to check this from gt reset side.
>
> Cc: Matt Roper
> Signed-off-by: Jani Nikula
> ---
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
struct ddebug_class_param keeps a ref to the state-storage of the
param; make both class-types use the same unsigned long storage type.
ISTM this is simpler and safer; it avoids an irrelevant difference,
and if 2 users somehow get class-type mixed u
On Fri, 21 Feb 2025, Dmitry Baryshkov wrote:
> On Mon, Feb 03, 2025 at 12:57:55PM +0200, Abel Vesa wrote:
>> Looking at both i915 and nouveau DP drivers, both are setting the first
>> LTTPR (if found) in transparent mode first and then in non-transparent
>> mode, just like the DP v2.0 specificatio
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
When a dyndbg classname is unknown to a kernel module (as before
previous patch), the callsite is un-addressable via >control queries.
The control-file displays this condition as "class unknown,"
currently. That spelling is sub-optimal/too-generic,
Le 25/01/2025 à 07:45, Jim Cromie a écrit :
A more careful reading of logging output from test_dynamic_debug.ko
reveals:
lib/test_dynamic_debug.c:103 [test_dynamic_debug]do_cats =pmf "doing
categories\n"
lib/test_dynamic_debug.c:105 [test_dynamic_debug]do_cats =p "LOW msg\n"
class:MID
lib/t
Drop the dependency on gt by providing a callback for trying to unbreak
stuck modeset. Do intel_gt_set_wedged() via the callback.
It's by no means pretty, but this is perhaps the most straightforward
alternative.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_
Move the checks for whether display reset is needed as well as
I915_RESET_MODESET flag handling to gt side of things.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_reset.c| 15 --
drivers/gpu/drm/i915/gt/intel_reset.c | 20 +
Deduplicate the gpu_reset_clobbers_display() part by passing the
information in from gt side.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_reset.c | 12 ++--
drivers/gpu/drm/i915/display/intel_display_reset.h | 2 +-
drivers/gpu/drm/i915/gt/i
v2 of [1], preserving patches 1-3, and rewriting everything else from
scratch with a different approach. It's not perfect, but I think it's a
better direction.
BR,
Jani.
[1] https://lore.kernel.org/r/cover.1736332802.git.jani.nik...@intel.com
Jani Nikula (8):
drm/i915/display: convert displ
More of the gt side of display reset will be moved away from
display. Add small wrappers for display reset calls to not clutter the
gt reset part of things.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/intel_reset.c | 23 ++-
1 file changed, 18 inser
Add a helper for checking if we want to test display reset regardless of
whether it's strictly necessary. This will come in handy in follow-up
work where we want to check this from gt reset side.
Cc: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_reset.c |
Add a helper for checking the gpu_reset_clobbers_display flag to make it
easier to relocate the flag later.
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +-
drivers/gpu/drm/i915/gt/intel_gt_pm.c | 2 +-
drivers/gpu/drm/i915/gt/intel_
pending_fb_pin is more about display than GPU reset. Move it to struct
intel_display. The restore sub-struct already contains reset related
members, so move it there.
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_core.h | 2 ++
drivers/gpu/d
Going forward, struct intel_display will be the main display device
structure. Convert display reset to it as much as possible.
Reviewed-by: Matt Roper
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_reset.c| 51 ++-
.../drm/i915/display/intel_display_reset
When driver is loaded on system with numa nodes it might be run in kthread.
This makes it impossible to use current->mm in selftests which currently
creates null pointer exception.
This patch allows selftest to use current->mm by using active_mm.
Signed-off-by: Mikolaj Wasiak
---
This patch is m
== Series Details ==
Series: DPLL framework redesign
URL : https://patchwork.freedesktop.org/series/145381/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16176 -> Patchwork_145381v1
Summary
---
**FAILURE**
Serious
On 2/19/2025 5:23 PM, Nemesa Garg wrote:
Load the lut values during pipe enable.
v2: Add the display version check
v3: Fix build issue
v4: Rebase
v5: Add HAS_CASF macro. [Ankit]
Add scaler_id check while reading state. [Ankit]
v6: Modify the disable condition.
Signed-off-by: Nemesa Garg
== Series Details ==
Series: DPLL framework redesign
URL : https://patchwork.freedesktop.org/series/145381/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: DPLL framework redesign
URL : https://patchwork.freedesktop.org/series/145381/
State : warning
== Summary ==
Error: dim checkpatch failed
9523ed1edd93 drm/i915/dpll: Rename intel_shared_dpll_state
778ac8bed0bd drm/i915/dpll: Rename macro for_each_shared_dpll
-:102:
> -Original Message-
> From: Kandpal, Suraj
> Sent: Tuesday, February 25, 2025 2:25 PM
> To: Jani Nikula ; intel...@lists.freedesktop.org;
> intel-gfx@lists.freedesktop.org
> Cc: Nautiyal, Ankit K ; Shankar, Uma
> ; Kahola, Mika
> Subject: RE: [PATCH 05/11] drm/i915/dpll: Move away from
> -Original Message-
> From: Nikula, Jani
> Sent: Monday, February 24, 2025 4:15 PM
> To: Manna, Animesh ; intel-
> g...@lists.freedesktop.org; intel...@lists.freedesktop.org
> Cc: Hogander, Jouni ; B, Jeevan
> ; Manna, Animesh
> Subject: Re: [PATCH v4 2/8] drm/i915/lobf: Disintegrate
== Series Details ==
Series: Expose modifiers/formats supported by async flips (rev7)
URL : https://patchwork.freedesktop.org/series/140935/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_16176 -> Patchwork_140935v7
Summary
On Tue, 25 Feb 2025, Suraj Kandpal wrote:
> Rename functions to move away from using shared dpll in the dpll
> framework as much as possible since dpll may not always be shared.
>
> Signed-off-by: Suraj Kandpal
...
> diff --git a/drivers/gpu/drm/i915/display/intel_dpll_mgr.h
> b/drivers/gpu/dr
== Series Details ==
Series: Expose modifiers/formats supported by async flips (rev7)
URL : https://patchwork.freedesktop.org/series/140935/
State : warning
== Summary ==
Error: dim sparse failed
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: Expose modifiers/formats supported by async flips (rev7)
URL : https://patchwork.freedesktop.org/series/140935/
State : warning
== Summary ==
Error: dim checkpatch failed
080bab9db88a drm/plane: Add new plane property IN_FORMATS_ASYNC
-:103: CHECK:PREFER_KERNEL_TYP
On Tue, 25 Feb 2025, "Manna, Animesh" wrote:
>> -Original Message-
>> From: Nikula, Jani
>> Sent: Monday, February 24, 2025 4:26 PM
>> To: Manna, Animesh ; intel-
>> g...@lists.freedesktop.org; intel...@lists.freedesktop.org
>> Cc: Hogander, Jouni ; B, Jeevan
>> ; Manna, Animesh
>> Subje
On 2/19/2025 5:23 PM, Nemesa Garg wrote:
Add new registers and related bits. Compute the strength
value and tap value based on display mode.
v2: Replace i915/dev_priv with display[Jani]
v3: Create separate file for defining register[Jani]
Add display->drm in debug prints[Jani]
v4: Rebase
On 2/19/2025 5:23 PM, Nemesa Garg wrote:
As only second scaler can be used for sharpness check if it
is available and also check if panel fitting is also not enabled,
then set the sharpness. Panel fitting will have the preference
over sharpness property.
v2: Add the panel fitting check before
1 - 100 of 119 matches
Mail list logo
