RE: [PATCH v3 1/2] drm/i915/display: Add MTL subplatforms definition

2024-12-16 Thread Bhadane, Dnyaneshwar
> -Original Message- > From: Jani Nikula > Sent: Monday, December 16, 2024 4:48 PM > To: Bhadane, Dnyaneshwar ; intel- > g...@lists.freedesktop.org > Cc: Bhadane, Dnyaneshwar > Subject: Re: [PATCH v3 1/2] drm/i915/display: Add MTL subplatforms definition > > On Fri, 13 Dec 2024, Dnyan

✓ i915.CI.BAT: success for series starting with [v2,1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-16 Thread Patchwork
== Series Details == Series: series starting with [v2,1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset URL : https://patchwork.freedesktop.org/series/142690/ State : success == Summary == CI Bug Log - changes from CI_DRM_15856 -> Patchwork_142690v1 ==

[PATCH v2 1/1] drm/i915/gt: Increase a time to retry RING_HEAD reset

2024-12-16 Thread Nitin Gote
Issue seen again where engine resets fails because the engine resumes from an incorrect RING_HEAD. HEAD is still not 0 even after writing into it. This seems to be timing issue and we experimented different values from 5ms to 50ms and found out that 50ms works best based on testing. So, if write do

✓ i915.CI.BAT: success for drm/i915/slpc: Add sysfs for SLPC power profiles

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Add sysfs for SLPC power profiles URL : https://patchwork.freedesktop.org/series/142685/ State : success == Summary == CI Bug Log - changes from CI_DRM_15855 -> Patchwork_142685v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/slpc: Add sysfs for SLPC power profiles

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Add sysfs for SLPC power profiles URL : https://patchwork.freedesktop.org/series/142685/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/slpc: Add sysfs for SLPC power profiles

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Add sysfs for SLPC power profiles URL : https://patchwork.freedesktop.org/series/142685/ State : warning == Summary == Error: dim checkpatch failed 3490606096c8 drm/i915/slpc: Add sysfs for SLPC power profiles -:68: CHECK:PARENTHESIS_ALIGNMENT: Align

Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN

2024-12-16 Thread Linus Torvalds
On Thu, 12 Dec 2024 at 21:47, Yafang Shao wrote: > > Since task->comm is guaranteed to be NUL-terminated, we can print it > directly without the need to copy it into a separate buffer. So i think we should do the "without copying into a separate buffer" part of this series, but I do think we shou

[PATCH] drm/i915/slpc: Add sysfs for SLPC power profiles

2024-12-16 Thread Vinay Belgaumkar
Default SLPC power profile is Base(0). Power Saving mode(1) has conservative up/down thresholds and is suitable for use with apps that typically need to be power efficient. Cc: Sushma Venkatesh Reddy Cc: Rodrigo Vivi Signed-off-by: Vinay Belgaumkar --- drivers/gpu/drm/i915/gt/intel_gt_sysfs_pm

Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN

2024-12-16 Thread Kees Cook
On Fri, Dec 13, 2024 at 01:46:08PM +0800, Yafang Shao wrote: > Since task->comm is guaranteed to be NUL-terminated, we can print it > directly without the need to copy it into a separate buffer. This > simplifies the code and avoids unnecessary operations. > > Signed-off-by: Yafang Shao Looks go

Re: [PATCH 5/7] security: Replace get_task_comm() with %pTN

2024-12-16 Thread Paul Moore
On Fri, Dec 13, 2024 at 12:47 AM Yafang Shao wrote: > > Since task->comm is guaranteed to be NUL-terminated, we can print it > directly without the need to copy it into a separate buffer. This > simplifies the code and avoids unnecessary operations. > > Signed-off-by: Yafang Shao > Cc: Kees Cook

✗ i915.CI.BAT: failure for Enable GuC SLPC default balancing strategies

2024-12-16 Thread Patchwork
== Series Details == Series: Enable GuC SLPC default balancing strategies URL : https://patchwork.freedesktop.org/series/142676/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15855 -> Patchwork_142676v1 Summary --- *

✗ Fi.CI.CHECKPATCH: warning for Enable GuC SLPC default balancing strategies

2024-12-16 Thread Patchwork
== Series Details == Series: Enable GuC SLPC default balancing strategies URL : https://patchwork.freedesktop.org/series/142676/ State : warning == Summary == Error: dim checkpatch failed 234da58b3759 drm/i915/guc/slpc: Enable GuC SLPC default strategies 5ca3fb3b7d8c drm/i915/guc/slpc: Print m

Re: [PATCH v2] i915/gt: Reapply workarounds in case the previous attempt failed.

2024-12-16 Thread Matt Roper
On Mon, Dec 16, 2024 at 03:46:49PM +, Sebastian Brzezinka wrote: > `wa_verify`sporadically detects lost workaround on application; this > is unusual behavior since wa are applied at `intel_gt_init_hw` and > verified right away by `intel_gt_verify_workarounds`, and  `wa_verify` > doesn't fail on

Re: [RFC PATCH] i915/gt: Reapply workarounds in case the previous attempt failed.

2024-12-16 Thread Matt Roper
On Thu, Dec 12, 2024 at 03:51:12PM +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Fri, Dec 06, 2024 at 10:38:24AM -0500, Rodrigo Vivi wrote: > > On Thu, Dec 05, 2024 at 03:47:35PM +, Sebastian Brzezinka wrote: > > > `wa_verify`sporadically detects lost workaround on application; this > > > is u

[PATCH 2/2] drm/i915/guc/slpc: Print more SLPC debug status information

2024-12-16 Thread Rodrigo Vivi
Let's peak on the Balancer and DCC status, now that we are using the default strategies. Cc: Vinay Belgaumkar Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c | 17 + 1 file changed, 17 insertions(+) diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_s

[PATCH 1/2] drm/i915/guc/slpc: Enable GuC SLPC default strategies

2024-12-16 Thread Rodrigo Vivi
The Balancer and DCC strategies were left off on a fear that these strategies would conflict with the i915's waitboost. However, these strategies are only active in certain conditions where the system is TDP limited. So, they don't conflict, but help the waitboost by guaranteeing a bit more of GT f

[PATCH 0/2] Enable GuC SLPC default balancing strategies

2024-12-16 Thread Rodrigo Vivi
They are complementary to waitboost and they can potentially improve performance in some very limited cases like when system is in high cpu and gpu usage and under TDP constrains. Signed-off-by: Rodrigo Vivi Rodrigo Vivi (2): drm/i915/guc/slpc: Enable GuC SLPC default strategies drm/i915/guc

Re: [PATCH v2 2/4] drm/nouveau/dp: Use the generic helper to control LTTPR transparent mode

2024-12-16 Thread Lyude Paul
Reviewed-by: Lyude Paul On Wed, 2024-12-11 at 15:04 +0200, Abel Vesa wrote: > LTTPRs operating modes are defined by the DisplayPort standard and the > generic framework now provides a helper to switch between them, which > is handling the explicit disabling of non-transparent mode and its > disab

Re: [PATCH 6/7] drivers: Repace get_task_comm() with %pTN

2024-12-16 Thread Lyude Paul
For the nouveau bits: Reviewed-by: Lyude Paul On Fri, 2024-12-13 at 13:46 +0800, Yafang Shao wrote: > Since task->comm is guaranteed to be NUL-terminated, we can print it > directly without the need to copy it into a separate buffer. This > simplifies the code and avoids unnecessary operations.

Re: [PATCH v2 1/5] drm/encoder_slave: make mode_valid accept const struct drm_display_mode

2024-12-16 Thread Lyude Paul
Reviewed-by: Lyude Paul On Sat, 2024-12-14 at 15:37 +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > accept const struct drm_display_mode argument. Change the mode_valid > callback of drm_encoder_slave to also accept const argument. > > Review

Re: [PATCH v2 5/5] drm/connector: make mode_valid take a const struct drm_display_mode

2024-12-16 Thread Lyude Paul
For the nouveau portions: Reviewed-by: Lyude Paul On Sat, 2024-12-14 at 15:37 +0200, Dmitry Baryshkov wrote: > The mode_valid() callbacks of drm_encoder, drm_crtc and drm_bridge > take a const struct drm_display_mode argument. Change the mode_valid > callback of drm_connector to also take a cons

Re: [PATCH 4/5] drm/amdgpu: Constify 'struct bin_attribute'

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 6:53 AM Thomas Weißschuh wrote: > > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Alex D

✓ i915.CI.BAT: success for drm/i915/cx0_phy: Fix C10 pll programming sequence

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/cx0_phy: Fix C10 pll programming sequence URL : https://patchwork.freedesktop.org/series/142671/ State : success == Summary == CI Bug Log - changes from CI_DRM_15854 -> Patchwork_142671v1 Summary --

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Harry Wentland
On 2024-12-16 10:31, Alex Deucher wrote: > On Mon, Dec 16, 2024 at 10:12 AM Dmitry Baryshkov > wrote: >> >> On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: >>> >>> >>> >>> On 2024-12-10 16:20, Dmitry Baryshkov wrote: On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: >>

✓ i915.CI.BAT: success for drm/i915/display: drop unnecessary i915_drv.h includes

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display: drop unnecessary i915_drv.h includes URL : https://patchwork.freedesktop.org/series/142669/ State : success == Summary == CI Bug Log - changes from CI_DRM_15854 -> Patchwork_142669v1 Summary --

✗ Fi.CI.BUILD: warning for drm/i915/display: drop unnecessary i915_drv.h includes

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display: drop unnecessary i915_drv.h includes URL : https://patchwork.freedesktop.org/series/142669/ State : warning == Summary == Error: make ARCH=i386 failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drive

✗ i915.CI.BAT: failure for drm/i915/display: program DBUF_CTL tracker state service to 0x8 (rev2)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/display: program DBUF_CTL tracker state service to 0x8 (rev2) URL : https://patchwork.freedesktop.org/series/142648/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15854 -> Patchwork_142648v2

✓ i915.CI.BAT: success for i915/gt: Reapply workarounds in case the previous attempt failed. (rev3)

2024-12-16 Thread Patchwork
== Series Details == Series: i915/gt: Reapply workarounds in case the previous attempt failed. (rev3) URL : https://patchwork.freedesktop.org/series/142188/ State : success == Summary == CI Bug Log - changes from CI_DRM_15854 -> Patchwork_142188v3 ==

Re: [PATCH v3 06/11] drm/amd/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 8:13 AM Imre Deak wrote: > > Hi Harry, Leo, Alex, Wayne, > > could you please ack this change as well? Patches 1-9 are: Acked-by: Alex Deucher Feel free to take this one through whichever tree you are planning to commit these to. Alex > > Thanks, > Imre > > A typo belo

RE: [PATCH v3 4/6] drm/i915/ddi: gracefully handle errors from intel_ddi_init_hdmi_connector()

2024-12-16 Thread Kandpal, Suraj
> -Original Message- > From: Nikula, Jani > Sent: Friday, December 13, 2024 7:46 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Nikula, Jani ; Sergey Senozhatsky > ; Ville Syrjala ; > Kandpal, Suraj > Subject: [PATCH v3 4/6] drm/i915/ddi: gracefully hand

✗ Fi.CI.BUILD: failure for drm/amdgpu: Use device wedged event

2024-12-16 Thread Patchwork
== Series Details == Series: drm/amdgpu: Use device wedged event URL : https://patchwork.freedesktop.org/series/142661/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/amd/amdgpu/amdgpu_

[PATCH] drm/i915/cx0_phy: Fix C10 pll programming sequence

2024-12-16 Thread Suraj Kandpal
According to spec VDR_CUSTOM_WIDTH register gets programmed after pll specific VDR registers and TX Lane programming registers are done. Moreover we only program into C10_VDR_CONTROL1 to update config and setup master lane once all VDR registers are written into. Bspec: 67636 Fixes: 51390cc0e00a (

✗ Fi.CI.CHECKPATCH: warning for i915/gt: Reapply workarounds in case the previous attempt failed. (rev3)

2024-12-16 Thread Patchwork
== Series Details == Series: i915/gt: Reapply workarounds in case the previous attempt failed. (rev3) URL : https://patchwork.freedesktop.org/series/142188/ State : warning == Summary == Error: dim checkpatch failed 85576582fae5 i915/gt: Reapply workarounds in case the previous attempt failed.

Re: ✗ i915.CI.Full: failure for drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Janusz Krzysztofik
Hi i915-ci-in...@lists.freedesktop.org, On Monday, 16 December 2024 16:42:29 CET Patchwork wrote: > == Series Details == > > Series: drm/i915/selftests: Use preemption timeout on cleanup > URL : https://patchwork.freedesktop.org/series/142582/ > State : failure > > == Summary == > > CI Bug Lo

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Janusz Krzysztofik
Hi Andi, Thanks for review. On Monday, 16 December 2024 14:26:58 CET Andi Shyti wrote: > Hi Janusz, > > ... > > > for_each_gt(gt, i915, i) { > > + struct intel_engine_cs *engine; > > + unsigned long timeout_ms = 0; > > + unsigned int id; > > + > > i

✓ i915.CI.BAT: success for drm/i915: Async flip + compression, and some plane cleanups (rev6)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915: Async flip + compression, and some plane cleanups (rev6) URL : https://patchwork.freedesktop.org/series/139807/ State : success == Summary == CI Bug Log - changes from CI_DRM_15854 -> Patchwork_139807v6

✗ Fi.CI.SPARSE: warning for drm/i915: Async flip + compression, and some plane cleanups (rev6)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915: Async flip + compression, and some plane cleanups (rev6) URL : https://patchwork.freedesktop.org/series/139807/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Async flip + compression, and some plane cleanups (rev6)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915: Async flip + compression, and some plane cleanups (rev6) URL : https://patchwork.freedesktop.org/series/139807/ State : warning == Summary == Error: dim checkpatch failed 8a6b085226c9 drm/i915: Allow async flips with render compression on TGL+ 4a5ebb88d7f

✗ Fi.CI.BUILD: failure for drm/amdgpu: Use device wedged event (rev2)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/amdgpu: Use device wedged event (rev2) URL : https://patchwork.freedesktop.org/series/142564/ State : failure == Summary == Error: make failed CALLscripts/checksyscalls.sh DESCEND objtool INSTALL libsubcmd_headers CC [M] drivers/gpu/drm/amd/amdgpu/

[PATCH] drm/i915/display: drop unnecessary i915_drv.h includes

2024-12-16 Thread Jani Nikula
Now that we don't include i915_drv.h via any headers from display, we can reliably remove unnecessary i915_drv.h includes and be sure they're not indirectly included. Add other includes where needed. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/dvo_ns2501.c | 1 -

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Lazar, Lijo
On 12/16/2024 6:45 PM, André Almeida wrote: > > > Em 16/12/2024 10:10, Christian König escreveu: >> Am 16.12.24 um 14:04 schrieb André Almeida: >>> Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: > Am 13.12.24 um 16:56 schrieb André A

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Lazar, Lijo
On 12/16/2024 7:09 PM, Christian König wrote: > Am 16.12.24 um 14:36 schrieb Lazar, Lijo: >> I had asked earlier about the utility of this one here. If this is just >> to inform userspace that driver has done a reset and recovered, it >> would >> need some additional context also

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Lazar, Lijo
On 12/16/2024 3:48 PM, Christian König wrote: > Am 13.12.24 um 16:56 schrieb André Almeida: >> Em 13/12/2024 11:36, Raag Jadav escreveu: >>> On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Christian, Em 13/12/2024 04:34, Christian König escreveu: > Am 12.12.2

Re: [RESEND 6/6] drm/i915/display: drop i915_drv.h include from intel_display_trace.h

2024-12-16 Thread Jani Nikula
On Fri, 13 Dec 2024, Luca Coelho wrote: > On Wed, 2024-11-20 at 14:03 +0200, Jani Nikula wrote: >> Finish the job of removing implicit dependencies on i915_drv.h via other >> includes in display code. Add a few missing explicit includes. >> >> Signed-off-by: Jani Nikula >> --- > > Done! Overall

[PATCH] drm/i915/display: program DBUF_CTL tracker state service to 0x8

2024-12-16 Thread Ravi Kumar Vodapalli
While display initialization along with MBUS credits programming DBUF_CTL register is also programmed, as a part of it the tracker state service field is also set to 0x8 value when default value is other than 0x8. so, for TGLLP, SVL, RYF, DG1, ACM, ACMPLUS, RKLC, RKLGM and ADLS platforms default va

[PATCH v3 0/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Raag Jadav is introducing a new DRM API for generating "device wedged events", to notify userspace when the device needs userspace intervention after a GPU reset[1]. I did a simple patch to add support for it for amdgpu for the telemetry aspect of the event. Tested in Steam Deck. This patch require

[PATCH v3 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Almeida --- v3: fix if co

Re: [PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Fri, 06 Dec 2024 11:43:03 +0200, Dmitry Baryshkov wrote: > The connector->eld is accessed by the .get_eld() callback. This access > can collide with the drm_edid_to_eld() updating the data at the same > time. Add drm_connector.eld_mutex to protect the data from concurrenct > access. > > The ind

Re: [PATCH v10 1/4] drm: Introduce device wedged event

2024-12-16 Thread Maxime Ripard
Hi, On Thu, Dec 12, 2024 at 12:37:59PM +0200, Raag Jadav wrote: > On Wed, Dec 11, 2024 at 06:14:12PM +0100, Maxime Ripard wrote: > > On Wed, Dec 04, 2024 at 01:17:17PM +0200, Raag Jadav wrote: > > > + misc maintainers > > > > > > On Tue, Dec 03, 2024 at 11:18:00AM +0100, Christian König wrote: >

[PATCH v2] i915/gt: Reapply workarounds in case the previous attempt failed.

2024-12-16 Thread Sebastian Brzezinka
`wa_verify`sporadically detects lost workaround on application; this is unusual behavior since wa are applied at `intel_gt_init_hw` and verified right away by `intel_gt_verify_workarounds`, and  `wa_verify` doesn't fail on initialization as one might suspect would happen. One approach that may be

Re: [PATCH v2 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Em 16/12/2024 12:27, Christian König escreveu: Am 16.12.24 um 16:02 schrieb André Almeida: Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the res

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Mon, 16 Dec 2024 at 17:32, Alex Deucher wrote: > > On Mon, Dec 16, 2024 at 10:12 AM Dmitry Baryshkov > wrote: > > > > On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: > > > > > > > > > > > > On 2024-12-10 16:20, Dmitry Baryshkov wrote: > > > > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmit

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Alex Deucher
On Mon, Dec 16, 2024 at 10:12 AM Dmitry Baryshkov wrote: > > On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: > > > > > > > > On 2024-12-10 16:20, Dmitry Baryshkov wrote: > > > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: > > >> Reading access to connector->eld can happen

RE: [PATCH v2 0/6] prunue audio frequencies based on bw limits for DP2

2024-12-16 Thread B, Jeevan
> -Original Message- > From: Intel-gfx On Behalf Of Vinod > Govindapillai > Sent: Wednesday, November 27, 2024 5:37 PM > To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org > Cc: Govindapillai, Vinod ; > kai.vehma...@linux.intel.co; Saarinen, Jani > Subject: [PATCH v2 0/6]

Re: [PATCH v2 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 16:02 schrieb André Almeida: Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma S

Re: [PATCH v2 00/10] drm/connector: add eld_mutex to protect connector->eld

2024-12-16 Thread Maxime Ripard
On Mon, Dec 16, 2024 at 01:24:29PM +0200, Dmitry Baryshkov wrote: > On Fri, Dec 06, 2024 at 11:43:03AM +0200, Dmitry Baryshkov wrote: > > The connector->eld is accessed by the .get_eld() callback. This access > > can collide with the drm_edid_to_eld() updating the data at the same > > time. Add drm

Re: [PATCH v3 0/5] drm/i915/dp: convert to struct intel_display

2024-12-16 Thread Jani Nikula
On Fri, 13 Dec 2024, Jani Nikula wrote: > Rebase of [1]. Thanks for the review, pushed to din. BR, Jani. > > BR, > Jani. > > > [1] https://lore.kernel.org/r/cover.1733827537.git.jani.nik...@intel.com > > > Jani Nikula (5): > drm/i915/dp: s/intel_encoder/encoder/ > drm/i915/dp: s/intel_con

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Dmitry Baryshkov
On Mon, 16 Dec 2024 at 16:53, Harry Wentland wrote: > > > > On 2024-12-10 16:20, Dmitry Baryshkov wrote: > > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: > >> Reading access to connector->eld can happen at the same time the > >> drm_edid_to_eld() updates the data. Take the new

Re: [PATCH] drm/i915/mst: use intel_dp_compute_config_limits() for DP MST

2024-12-16 Thread Jani Nikula
On Fri, 13 Dec 2024, "Nautiyal, Ankit K" wrote: > On 12/11/2024 8:13 PM, Jani Nikula wrote: >> There's a lot of duplication between mst_stream_compute_config_limits() >> and intel_dp_compute_config_limits(). Adjust the latter to suit the >> needs of the former, and use the same function for both.

[PATCH v2 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Use DRM's device wedged event to notify userspace that a reset had happened. For now, only use `none` method meant for telemetry capture. In the future we might want to report a recovery method if the reset didn't succeed. Acked-by: Shashank Sharma Signed-off-by: André Almeida --- v2: Only repo

[PATCH v2 0/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Raag Jadav is introducing a new DRM API for generating "device wedged events", to notify userspace when the device needs userspace intervention after a GPU reset[1]. I did a simple patch to add support for it for amdgpu for the telemetry aspect of the event. Tested in Steam Deck. This patch require

Re: [PATCH 5/5] drm/amd/display: Constify 'struct bin_attribute'

2024-12-16 Thread Harry Wentland
On 2024-12-16 06:34, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Harry Wentland Ha

Re: [PATCH v2 04/10] drm/amd/display: use eld_mutex to protect access to connector->eld

2024-12-16 Thread Harry Wentland
On 2024-12-10 16:20, Dmitry Baryshkov wrote: > On Fri, Dec 06, 2024 at 11:43:07AM +0200, Dmitry Baryshkov wrote: >> Reading access to connector->eld can happen at the same time the >> drm_edid_to_eld() updates the data. Take the newly added eld_mutex in >> order to protect connector->eld from co

Re: [PATCH v3 03/11] drm/connector: Add deprication notes for drm_connector_register/unregister

2024-12-16 Thread Simona Vetter
On Thu, Dec 12, 2024 at 02:02:58PM +0200, Imre Deak wrote: > On Thu, Dec 12, 2024 at 12:10:58PM +0200, Jani Nikula wrote: > > [...] > > On Thu, 12 Dec 2024, Imre Deak wrote: > > > @@ -863,9 +866,14 @@ EXPORT_SYMBOL(drm_connector_dynamic_register); > > > * drm_connector_unregister - unregister a

Re: [PATCH] drm/i915/mst: use intel_dp_compute_config_limits() for DP MST

2024-12-16 Thread Imre Deak
On Wed, Dec 11, 2024 at 04:43:10PM +0200, Jani Nikula wrote: > There's a lot of duplication between mst_stream_compute_config_limits() > and intel_dp_compute_config_limits(). Adjust the latter to suit the > needs of the former, and use the same function for both. This reduces > duplication and high

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Raag Jadav
On Mon, Dec 16, 2024 at 10:15:00AM -0300, André Almeida wrote: > Em 16/12/2024 10:10, Christian König escreveu: > > Am 16.12.24 um 14:04 schrieb André Almeida: > > > Em 16/12/2024 07:38, Lazar, Lijo escreveu: > > > > > > > > > > > > On 12/16/2024 3:48 PM, Christian König wrote: > > > > > Am 13.12

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 14:36 schrieb Lazar, Lijo: I had asked earlier about the utility of this one here. If this is just to inform userspace that driver has done a reset and recovered, it would need some additional context also. We have a mechanism in KFD which sends the context in which a reset has to

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 14:15 schrieb André Almeida: Em 16/12/2024 10:10, Christian König escreveu: Am 16.12.24 um 14:04 schrieb André Almeida: Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, R

RE: ✗ i915.CI.BAT: failure for drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Ravali, JupallyX
Hi , https://patchwork.freedesktop.org/series/142582/- re-reported i915.CI.BAT - Re-reported Thank you, Ravali -Original Message- From: I915-ci-infra On Behalf Of Janusz Krzysztofik Sent: 16 December 2024 15:13 To: i915-ci-in...@lists.freedesktop.org; Janusz Krzysztofik Cc: intel-

Re: [PATCH] drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Andi Shyti
Hi Janusz, ... > for_each_gt(gt, i915, i) { > + struct intel_engine_cs *engine; > + unsigned long timeout_ms = 0; > + unsigned int id; > + > if (intel_gt_is_wedged(gt)) > ret = -EIO; > > + for_each_engine(

Re: [PATCH 1/3] drm/i915: split out i9xx_wm_regs.h

2024-12-16 Thread Jani Nikula
On Mon, 16 Dec 2024, Luca Coelho wrote: > On Fri, 2024-12-13 at 13:51 +0200, Jani Nikula wrote: >> Very few files need the i9xx watermark related registers. Split them out >> to a dedicated file. >> >> Signed-off-by: Jani Nikula >> --- > > Reviewed-by: Luca Coelho Thanks for the review, series

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Em 16/12/2024 10:10, Christian König escreveu: Am 16.12.24 um 14:04 schrieb André Almeida: Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024

Re: [PATCH] drm/i915/display: program DBUF_CTL tracker state service to 0x8

2024-12-16 Thread Jani Nikula
On Mon, 16 Dec 2024, Ravi Kumar Vodapalli wrote: > Program Tracker state service(DBUF_CTL Register) for TGLLP, SVL, > RYF, DG1, ACM, ACMPLUS, RKLC, RKLGM, ADLS platforms to 0x8 which > is not the default value. Why? Every single commit message *must* state why the change is being made. What's t

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread Christian König
Am 16.12.24 um 14:04 schrieb André Almeida: Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Chris

Re: [PATCH 1/1] drm/amdgpu: Use device wedged event

2024-12-16 Thread André Almeida
Em 16/12/2024 07:38, Lazar, Lijo escreveu: On 12/16/2024 3:48 PM, Christian König wrote: Am 13.12.24 um 16:56 schrieb André Almeida: Em 13/12/2024 11:36, Raag Jadav escreveu: On Fri, Dec 13, 2024 at 11:15:31AM -0300, André Almeida wrote: Hi Christian, Em 13/12/2024 04:34, Christian Köni

✓ i915.CI.BAT: success for drm/i915/bios: add VBT DSI DSC debug logging (rev2)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/bios: add VBT DSI DSC debug logging (rev2) URL : https://patchwork.freedesktop.org/series/142562/ State : success == Summary == CI Bug Log - changes from CI_DRM_15849 -> Patchwork_142562v2 Summary -

[PATCH] drm/i915/display: program DBUF_CTL tracker state service to 0x8

2024-12-16 Thread Ravi Kumar Vodapalli
Program Tracker state service(DBUF_CTL Register) for TGLLP, SVL, RYF, DG1, ACM, ACMPLUS, RKLC, RKLGM, ADLS platforms to 0x8 which is not the default value. Bspec: 49213 Signed-off-by: Ravi Kumar Vodapalli --- drivers/gpu/drm/i915/display/intel_display_power.c | 4 +++- 1 file changed, 3 insertio

Re: [PATCH v3 06/11] drm/amd/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-12-16 Thread Imre Deak
Hi Harry, Leo, Alex, Wayne, could you please ack this change as well? Thanks, Imre A typo below in the commit log, can fix it while merging the patch here and in the i915/nouveau patches. On Thu, Dec 12, 2024 at 01:03:23AM +0200, Imre Deak wrote: > After a connector is added to the drm_mode_con

✗ i915.CI.BAT: failure for drm: Constify 'struct bin_attribute'

2024-12-16 Thread Patchwork
== Series Details == Series: drm: Constify 'struct bin_attribute' URL : https://patchwork.freedesktop.org/series/142646/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15849 -> Patchwork_142646v1 Summary --- **FAILURE

Re: [PATCH v3 0/7] drm/connector: Expose only a properly inited connector

2024-12-16 Thread Maxime Ripard
Hi, On Mon, Dec 16, 2024 at 02:22:49PM +0200, Imre Deak wrote: > are you ok to merge patches 1-9 to drm-misc-next? Patches 10,11 could be > merged then to drm-intel-next after back-merging drm-misc-next to > drm-intel-next. Sounds good to me Maxime signature.asc Description: PGP signature

Re: [PATCH v3 01/11] drm/connector: Add a way to init/add a connector in separate steps

2024-12-16 Thread Maxime Ripard
On Thu, 12 Dec 2024 01:03:18 +0200, Imre Deak wrote: > Atm when the connector is added to the drm_mode_config::connector_list, > the connector may not be fully initialized yet. This is not a problem > for static connectors initialized/added during driver loading, for which > the driver ensures that

Re: [PATCH v3 04/11] drm/dp_mst: Register connectors via drm_connector_dynamic_register()

2024-12-16 Thread Imre Deak
Hi Harry, Leo, Alex, Wayne, could you please ack this change? Thanks, Imre On Thu, Dec 12, 2024 at 01:03:21AM +0200, Imre Deak wrote: > MST connectors should be initialized/registered by calling > drm_connector_dynamic_init()/drm_connector_dynamic_register(). The > previous patch adding these fu

Re: [PATCH v3 0/7] drm/connector: Expose only a properly inited connector

2024-12-16 Thread Imre Deak
Hi Thomas, Maxime, Maarten, are you ok to merge patches 1-9 to drm-misc-next? Patches 10,11 could be merged then to drm-intel-next after back-merging drm-misc-next to drm-intel-next. Thanks, Imre On Thu, Dec 12, 2024 at 01:03:17AM +0200, Imre Deak wrote: > This is v3 of [1], with the following c

Re: [PATCH v3 09/11] drm/tests: Add tests for drm_connector_dynamic_init()/register()

2024-12-16 Thread Maxime Ripard
On Thu, 12 Dec 2024 01:03:26 +0200, Imre Deak wrote: > Add kunit tests for > drm_connector_dynamic_init()/drm_connector_dynamic_register() added in > this patchset. > > Suggested-by: Maxime Ripard > > [ ... ] Reviewed-by: Maxime Ripard Thanks! Maxime

✗ Fi.CI.SPARSE: warning for drm: Constify 'struct bin_attribute'

2024-12-16 Thread Patchwork
== Series Details == Series: drm: Constify 'struct bin_attribute' URL : https://patchwork.freedesktop.org/series/142646/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1

✗ Fi.CI.CHECKPATCH: warning for drm: Constify 'struct bin_attribute'

2024-12-16 Thread Patchwork
== Series Details == Series: drm: Constify 'struct bin_attribute' URL : https://patchwork.freedesktop.org/series/142646/ State : warning == Summary == Error: dim checkpatch failed fc4f080e12b3 drm/sysfs: Constify 'struct bin_attribute' 47acf9b40945 drm/lima: Constify 'struct bin_attribute' 048

Re: [PATCH v3 04/11] drm/dp_mst: Register connectors via drm_connector_dynamic_register()

2024-12-16 Thread Imre Deak
On Mon, Dec 16, 2024 at 01:03:42PM +0200, Jani Nikula wrote: > On Fri, 13 Dec 2024, Imre Deak wrote: > > On Thu, Dec 12, 2024 at 12:12:15PM +0200, Jani Nikula wrote: > >> On Thu, 12 Dec 2024, Imre Deak wrote: > >> > MST connectors should be initialized/registered by calling > >> > drm_connector_d

✓ i915.CI.BAT: success for drm/i915/selftests: Use preemption timeout on cleanup

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Use preemption timeout on cleanup URL : https://patchwork.freedesktop.org/series/142582/ State : success == Summary == CI Bug Log - changes from CI_DRM_15843 -> Patchwork_142582v1 Summary ---

Re: [PATCH 3/3] drm/i915: move DDI_CLK_VALFREQ next to other Cx0 PHY registers

2024-12-16 Thread Luca Coelho
On Fri, 2024-12-13 at 13:51 +0200, Jani Nikula wrote: > Relocate DDI_CLK_VALFREQ register definition next to other Cx0 PHY > register macros. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Luca Coelho -- Cheers, Luca.

Re: [PATCH 2/3] drm/i915: relocate _VGA_MSR_WRITE register definition

2024-12-16 Thread Luca Coelho
On Fri, 2024-12-13 at 13:51 +0200, Jani Nikula wrote: > Move _VGA_MSR_WRITE to intel_crt_regs.h. It's not necessarily the > optimal place for it, but hands down better than i915_reg.h. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Luca Coelho -- Cheers, Luca.

Re: [PATCH 1/3] drm/i915: split out i9xx_wm_regs.h

2024-12-16 Thread Luca Coelho
On Fri, 2024-12-13 at 13:51 +0200, Jani Nikula wrote: > Very few files need the i9xx watermark related registers. Split them out > to a dedicated file. > > Signed-off-by: Jani Nikula > --- Reviewed-by: Luca Coelho -- Cheers, Luca.

Re: [PATCH 3/5] drm/i915: Constify 'struct bin_attribute'

2024-12-16 Thread Jani Nikula
On Mon, 16 Dec 2024, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Jani Nikula > ---

Re: [PATCH 1/5] drm/sysfs: Constify 'struct bin_attribute'

2024-12-16 Thread Jani Nikula
On Mon, 16 Dec 2024, Thomas Weißschuh wrote: > The sysfs core now allows instances of 'struct bin_attribute' to be > moved into read-only memory. Make use of that to protect them against > accidental or malicious modifications. > > Signed-off-by: Thomas Weißschuh Reviewed-by: Jani Nikula > ---

[PATCH 5/5] drm/amd/display: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_hdcp.c | 8 1 file changed

✓ i915.CI.BAT: success for drm/i915/dp: convert to struct intel_display (rev4)

2024-12-16 Thread Patchwork
== Series Details == Series: drm/i915/dp: convert to struct intel_display (rev4) URL : https://patchwork.freedesktop.org/series/141929/ State : success == Summary == CI Bug Log - changes from CI_DRM_15849 -> Patchwork_141929v4 Summary -

RE: [PATCH v3 1/6] drm/i915/ddi: change intel_ddi_init_{dp,hdmi}_connector() return type

2024-12-16 Thread Jani Nikula
On Fri, 13 Dec 2024, "Kandpal, Suraj" wrote: >> -Original Message- >> From: Nikula, Jani >> Sent: Friday, December 13, 2024 7:46 PM >> To: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org >> Cc: Nikula, Jani ; Sergey Senozhatsky >> ; Ville Syrjala ; >> Kandpal, Suraj >> Su

[PATCH 0/5] drm: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- Thomas Weißschuh (5): drm/sysfs: Constify 'struct bin_attribute' drm/lim

[PATCH 2/5] drm/lima: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/lima/lima_drv.c | 8 1 file changed, 4 insertions(+), 4 de

[PATCH 4/5] drm/amdgpu: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 +++--- drivers/gpu/drm/amd/amdgpu/

[PATCH 3/5] drm/i915: Constify 'struct bin_attribute'

2024-12-16 Thread Thomas Weißschuh
The sysfs core now allows instances of 'struct bin_attribute' to be moved into read-only memory. Make use of that to protect them against accidental or malicious modifications. Signed-off-by: Thomas Weißschuh --- drivers/gpu/drm/i915/i915_gpu_error.c | 8 drivers/gpu/drm/i915/i915_sysf

  1   2   >