Hi Janusz,

...

>       for_each_gt(gt, i915, i) {
> +             struct intel_engine_cs *engine;
> +             unsigned long timeout_ms = 0;
> +             unsigned int id;
> +
>               if (intel_gt_is_wedged(gt))
>                       ret = -EIO;
>  
> +             for_each_engine(engine, gt, id) {
> +                     if (engine->props.preempt_timeout_ms > timeout_ms)
> +                             timeout_ms = engine->props.preempt_timeout_ms;
> +             }


the brackets are not really required here.

> +
>               cond_resched();
>  
> -             if (intel_gt_wait_for_idle(gt, HZ * 3) == -ETIME) {
> +             if (intel_gt_wait_for_idle(gt, HZ * timeout_ms / 500) == 
> -ETIME) {

where is this 500 coming from?

Thanks,
Andi

>                       pr_err("%pS timed out, cancelling all further 
> testing.\n",
>                              __builtin_return_address(0));
>  
> -- 
> 2.47.1

Reply via email to