RE: [PATCH 2/2] drm/i915/dislay: convert i9xx_display_sr.[ch] to struct intel_display

2024-11-26 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, 26 November 2024 12.12 > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Vivi, Rodrigo > > Subject: [PATCH 2/2] drm/i915/dislay: convert i9xx_display_sr.[ch] to struct > intel_display > > Going f

✓ i915.CI.BAT: success for Refactor VRR for different VRR timing generator

2024-11-26 Thread Patchwork
== Series Details == Series: Refactor VRR for different VRR timing generator URL : https://patchwork.freedesktop.org/series/141820/ State : success == Summary == CI Bug Log - changes from CI_DRM_15750 -> Patchwork_141820v1 Summary ---

RE: [PATCH 1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER in display s/r

2024-11-26 Thread Kahola, Mika
> -Original Message- > From: Intel-gfx On Behalf Of Jani > Nikula > Sent: Tuesday, 26 November 2024 12.12 > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Vivi, Rodrigo > > Subject: [PATCH 1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER > in display s/r > > Use dis

[PATCH v6 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-11-26 Thread Mika Kahola
There is a HW issue that arises when there are race conditions between TCSS entering/exiting TC7 or TC10 states while the driver is asserting/deasserting TCSS power request. As a workaround, Display driver will implement a mailbox sequence to ensure that the TCSS is in TC0 when TCSS power request i

[PATCH v6 2/2] drm/i915/display: Use struct intel_display instead of struct drm_i915_private

2024-11-26 Thread Mika Kahola
Let's start using struct intel_display instead of struct drm_i915_private when introducing new code. No functional changes. v2: Drop tc_to_intel_display() helper funtion (Jani) Signed-off-by: Mika Kahola Reviewed-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_tc.c | 9 ---

[PATCH v6 0/2] drm/i915/display: Power request asserting/deasserting

2024-11-26 Thread Mika Kahola
There is a HW issue that arises when there are race conditions between TCSS entering/exiting TC7 or TC10 states while the driver is asserting/deasserting TCSS power request. As a workaround, Display driver will implement a mailbox sequence to ensure that the TCSS is in TC0 when TCSS power request i

✗ Fi.CI.SPARSE: warning for Refactor VRR for different VRR timing generator

2024-11-26 Thread Patchwork
== Series Details == Series: Refactor VRR for different VRR timing generator URL : https://patchwork.freedesktop.org/series/141820/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bit

[PATCH 7/7] drm/i915/display: Add vrr mode to crtc_state dump

2024-11-26 Thread Ankit Nautiyal
Print Vrr mode along with other vrr members in crtc_state dump. Signed-off-by: Ankit Nautiyal --- .../drm/i915/display/intel_crtc_state_dump.c| 17 - 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_crtc_state_dump.c b/drivers/

[PATCH 3/7] drm/i915/vrr: Introduce new field for VRR mode

2024-11-26 Thread Ankit Nautiyal
The VRR timing generator can be used in multiple modes of operation: dynamic refresh rate (VRR), content-matched refresh rate (CMRR), and fixed refresh rate (Fixed_RR). Currently, VRR and CMRR modes are supported, with Fixed_RR mode forthcoming. To track the different operational modes of the VRR

[PATCH 4/7] drm/i915/vrr: Fill VRR timing generator mode for CMRR and VRR

2024-11-26 Thread Ankit Nautiyal
Fill vrr.mode during compute_config and update intel_vrr_get_config() to read vrr.mode based on CMRR and VRR enable conditions. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 1 + drivers/gpu/drm/i915/display/intel_vrr.c | 5 + 2 files changed, 6 inserti

[PATCH 6/7] drm/i915/display: Absorb cmrr attributes into vrr struct

2024-11-26 Thread Ankit Nautiyal
Since cmrr is now one of the mode of operation of VRR timing generator, move its elements in the vrr struct. Replace cmrr.enable with vrr.mode INTEL_VRRTG_MODE_CMRR and move cmrr_m and cmrr_n in vrr struct. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_display.c | 19 +++

[PATCH 5/7] drm/i915/display: Remove vrr.enable and instead check vrr.mode != NONE

2024-11-26 Thread Ankit Nautiyal
Since we now have vrr.mode to track the mode in which the VRR timing generator is running, we no longer need member vrr.enable. Replace the check for vrr.enable and use a helper to check vrr.mode != NONE. Signed-off-by: Ankit Nautiyal --- .../drm/i915/display/intel_crtc_state_dump.c | 2 +- d

[PATCH 2/7] drm/i915/vrr: Simplify CMRR Enable Check in intel_vrr_get_config

2024-11-26 Thread Ankit Nautiyal
Combine the CMRR capability and enable check into a single condition. Set crtc_state->cmrr.enable directly within the combined condition. This will make way to absorb cmrr members in vrr struct. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_vrr.c | 5 ++--- 1 file changed,

[PATCH 1/7] drm/i915/vrr: Refactor VRR Timing Computation

2024-11-26 Thread Ankit Nautiyal
Introduce helper functions to compute timings for different mode of operation of VRR timing generator. Signed-off-by: Ankit Nautiyal --- drivers/gpu/drm/i915/display/intel_vrr.c | 115 +++ 1 file changed, 75 insertions(+), 40 deletions(-) diff --git a/drivers/gpu/drm/i915/di

[PATCH 0/7] Refactor VRR for different VRR timing generator

2024-11-26 Thread Ankit Nautiyal
The VRR timing generator supports multiple modes: dynamic refresh rate (VRR), content-matched refresh rate (CMRR), and fixed refresh rate (Fixed_RR). To better track the different operational modes of the VRR timing generator refactor the existing vrr members and functions. This will also help to

✓ i915.CI.BAT: success for drm/i915/dpt: Try to make DPT shrinkable again

2024-11-26 Thread Patchwork
== Series Details == Series: drm/i915/dpt: Try to make DPT shrinkable again URL : https://patchwork.freedesktop.org/series/141815/ State : success == Summary == CI Bug Log - changes from CI_DRM_15750 -> Patchwork_141815v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915/dpt: Try to make DPT shrinkable again

2024-11-26 Thread Patchwork
== Series Details == Series: drm/i915/dpt: Try to make DPT shrinkable again URL : https://patchwork.freedesktop.org/series/141815/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH 0/4] drm/i915/dpt: Try to make DPT shrinkable again

2024-11-26 Thread Ville Syrjala
From: Ville Syrjälä Try to make DPT objects shrinakble once again. To overcome the earlier suspend/resume issues we'll just make sure all DPT VMAs are evicted during suspend, and thus resume won't care whether the DPT objects got kicked out or not. The proper solution would perhaps be to do the

[PATCH 4/4] Revert "drm/i915/dpt: Make DPT object unshrinkable"

2024-11-26 Thread Ville Syrjala
From: Ville Syrjälä This reverts commit 51064d471c53dcc8eddd2333c3f1c1d9131ba36c. Now that we forcefully evict all DPT VMAs during suspend there should be no problem allowing the shrinker to eat the DPT objects. Cc: Brian Geffon Cc: Vidya Srinivas Closes: https://gitlab.freedesktop.org/drm/i9

[PATCH 3/4] drm/i915/dpt: Evict all DPT VMAs on suspend

2024-11-26 Thread Ville Syrjala
From: Ville Syrjälä Currently intel_dpt_resume() tries to blindly rewrite all the PTEs for currently bound DPT VMAs. That is problematic because the CPU mapping for the DPT is only really guaranteed to exist while the DPT object has been pinned. In the past we worked around this issue by making D

[PATCH 1/4] drm/i915: Don't reuse commit_work for the cleanup

2024-11-26 Thread Ville Syrjala
From: Ville Syrjälä Currently we reuse the commit_work for a later cleanup step. Let's not do that so that atomic ioctl handler won't accidentally wait for the cleanup work when it really wants to just wait on the commit_tail() part. We'll just add another work struct for the cleanup. Cc: Brian

[PATCH 2/4] drm/i915: Intruduce display.wq.cleanup

2024-11-26 Thread Ville Syrjala
From: Ville Syrjälä Introduce a dedicated workqueue for the commit cleanup work. In the future we'll need this to guarantee all the cleanup works have finished at a specific point during suspend. Cc: Brian Geffon Cc: Vidya Srinivas Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/displa

Re: [PATCH 3/7] drm/i915: Enable 10bpc + CCS on TGL+

2024-11-26 Thread Ville Syrjälä
On Mon, Nov 25, 2024 at 02:55:34PM +0800, Xi Ruoyao wrote: > On Tue, 2024-10-08 at 12:01 +0300, Juha-Pekka Heikkila wrote: > > On 4.10.2024 21.03, Ville Syrjälä wrote: > > > On Fri, Oct 04, 2024 at 04:35:17PM +0300, Juha-Pekka Heikkila wrote: > > > > On 18.9.2024 17.44, Ville Syrjala wrote: > > > >

RE: [PATCH 11/12] drm/i915/dp: Make dsc helpers accept const crtc_state pointers

2024-11-26 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, November 20, 2024 4:08 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Kandpal, Suraj ; > jani.nik...@linux.intel.com; Deak, Imre > Subject: [PATCH 11/12] drm/i915/dp: Make dsc helpers acce

RE: [PATCH 09/12] drm/i915/dp_mst: Refactor pipe_bpp limits with dsc for mst

2024-11-26 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, November 20, 2024 4:08 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Kandpal, Suraj ; > jani.nik...@linux.intel.com; Deak, Imre > Subject: [PATCH 09/12] drm/i915/dp_mst: Refactor pipe_bpp

RE: [PATCH 04/12] drm/i915/dp: Remove HAS_DSC macro for intel_dp_dsc_max_src_input_bpc

2024-11-26 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, November 20, 2024 4:08 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Kandpal, Suraj ; > jani.nik...@linux.intel.com; Deak, Imre > Subject: [PATCH 04/12] drm/i915/dp: Remove HAS_DSC macro

RE: [PATCH 02/12] drm/i915/dp: Return early if DSC not supported

2024-11-26 Thread Kandpal, Suraj
> -Original Message- > From: Nautiyal, Ankit K > Sent: Wednesday, November 20, 2024 4:08 PM > To: intel-gfx@lists.freedesktop.org > Cc: intel...@lists.freedesktop.org; Kandpal, Suraj ; > jani.nik...@linux.intel.com; Deak, Imre > Subject: [PATCH 02/12] drm/i915/dp: Return early if DSC n

✓ i915.CI.BAT: success for drm/dp: Expose only a properly inited connector

2024-11-26 Thread Patchwork
== Series Details == Series: drm/dp: Expose only a properly inited connector URL : https://patchwork.freedesktop.org/series/141797/ State : success == Summary == CI Bug Log - changes from CI_DRM_15749 -> Patchwork_141797v1 Summary ---

✗ Fi.CI.SPARSE: warning for drm/dp: Expose only a properly inited connector

2024-11-26 Thread Patchwork
== Series Details == Series: drm/dp: Expose only a properly inited connector URL : https://patchwork.freedesktop.org/series/141797/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[PATCH v2 2/4] drm/i915/dp_mst: Expose a connector to kernel users after it's properly initialized

2024-11-26 Thread Imre Deak
After a connector is added to the drm_mode_config::connector_list, it's visible to any in-kernel users looking up connectors via the above list. Make sure that the connector is properly initialized before such look-ups. Reviewed-by: Rodrigo Vivi Signed-off-by: Imre Deak --- drivers/gpu/drm/i915

[PATCH v2 3/4] drm/i915/dp_mst: Fix error handling while adding a connector

2024-11-26 Thread Imre Deak
After an error during adding an MST connector the MST port and the intel_connector object could be leaked, fix this up. Reviewed-by: Rodrigo Vivi Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/display/intel_dp_mst.c | 17 + 1 file changed, 9 insertions(+), 8 deletions(-) dif

[PATCH v2 4/4] drm/i915/dp_mst: Use intel_connector vs. drm_connector pointer in intel_dp_mst.c

2024-11-26 Thread Imre Deak
Follow the canonical way in intel_dp_mst.c, referencing a connector only via a struct intel_connector pointer and naming this pointer 'connector' instead of 'intel_connector', the only exception being the casting of a drm_connector function parameter pointer to intel_connector, calling the drm_conn

[PATCH v2 1/4] drm/dp: Add a way to init/add a connector in separate steps

2024-11-26 Thread Imre Deak
Atm when the connector is added to the drm_mode_config::connector_list, the connector may not be fully initialized yet. This is not a problem for user space, which will see the connector only after it's registered later, it could be a problem for in-kernel users looking up connectors via the above

[PATCH v2 0/4] drm/dp: Expose only a properly inited connector

2024-11-26 Thread Imre Deak
This patchset is v2 of [1], without the first patch which is already merged, adding Rodrigo's R-bs and addressing Jani's review comments in patch 1 of this patchset and the newly added patch 4. Cc: Rodrigo Vivi Cc: Jani Nikula [1] https://lore.kernel.org/all/20241115164159.1081675-1-imre.d...@i

✗ i915.CI.BAT: failure for Plane Color Pipeline support for Intel platforms (rev2)

2024-11-26 Thread Patchwork
== Series Details == Series: Plane Color Pipeline support for Intel platforms (rev2) URL : https://patchwork.freedesktop.org/series/129811/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15749 -> Patchwork_129811v2 Summary -

✗ Fi.CI.SPARSE: warning for Plane Color Pipeline support for Intel platforms (rev2)

2024-11-26 Thread Patchwork
== Series Details == Series: Plane Color Pipeline support for Intel platforms (rev2) URL : https://patchwork.freedesktop.org/series/129811/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Plane Color Pipeline support for Intel platforms (rev2)

2024-11-26 Thread Patchwork
== Series Details == Series: Plane Color Pipeline support for Intel platforms (rev2) URL : https://patchwork.freedesktop.org/series/129811/ State : warning == Summary == Error: dim checkpatch failed 0aab9cd08484 drm: color pipeline base work -:46: WARNING:FILE_PATH_CHANGES: added, moved or del

[v2 09/25] drm: Add helper to initialize segmented 1D LUT

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add helper to initialize 1D segmented LUT Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_colorop.c | 27 ++- include/drm/drm_colorop.h | 4 2 files changed, 30 insertions(+), 1 deletion(-)

RE: [PATCH v5 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-11-26 Thread Jani Nikula
On Tue, 26 Nov 2024, "Kahola, Mika" wrote: >> -Original Message- >> From: Jani Nikula >> Sent: Tuesday, 26 November 2024 11.30 >> To: Kahola, Mika ; intel-gfx@lists.freedesktop.org >> Cc: Sousa, Gustavo ; Jadav, Raag >> ; Kahola, Mika >> Subject: Re: [PATCH v5 1/2] drm/i915/xe3lpd: Power

[v2 23/25] drm/i915/xelpd: Program Plane Post CSC Registers

2024-11-26 Thread Uma Shankar
Extract the LUT and program plane post csc registers. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/i915/display/intel_color.c | 109 + 1 file changed, 109 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/drivers

[v2 25/25] drm/doc/rfc: Add documentation for multi-segmented 1D LUT

2024-11-26 Thread Uma Shankar
Add documentation to explain properties of the exposed hardware 1D LUT blocks, its identification and computation of the LUT samples based on the number of samples, their distribution and precison. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- Documentation/gpu/rfc/color_p

[v2 24/25] drm/i915/color: Enable Plane Color Pipelines

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Expose color pipeline and add ability to program it. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/skl_universal_plane.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_uni

[v2 22/25] drm/i915/color: Program Pre-CSC registers

2024-11-26 Thread Uma Shankar
Add callback for programming Pre-CSC LUT for TGL and beyond Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 88 ++ 1 file changed, 88 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b/dr

[v2 21/25] drm/i915: Add register definitions for Plane Post CSC

2024-11-26 Thread Uma Shankar
Add macros to define Plane Post CSC registers Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- .../i915/display/skl_universal_plane_regs.h | 73 +++ 1 file changed, 73 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h b/dri

[v2 20/25] drm/i915/color: Add framework to program PRE/POST CSC LUT

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add framework that will help in loading LUT to Pre/Post CSC color blocks. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 27 ++ drivers/gpu/drm/i915/display/intel_color.h | 2 ++

[v2 19/25] drm/i915: Add register definitions for Plane Degamma

2024-11-26 Thread Uma Shankar
Add macros to define Plane Degamma registers Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- .../i915/display/skl_universal_plane_regs.h | 53 +++ 1 file changed, 53 insertions(+) diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane_regs.h b/driv

[v2 18/25] drm/i915/color: Add plane CTM callback for D13 and beyond

2024-11-26 Thread Uma Shankar
Add callback for setting CTM block in platforms D13 and beyond Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/drivers/gpu/drm/i915/display/intel_color.c b

[v2 17/25] drm/i915/color: Add new color callbacks for Xelpd

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Since we intend to add plane color callbacks from Xelpd(D13 and beyond), create a different structure for it. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 15 ++- 1 file changed, 14 ins

[v2 16/25] drm/i915/color: Add callbacks to set plane CTM

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add callback to intel color functions for setting plane CTM. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 23 ++ drivers/gpu/drm/i915/display/intel_color.h | 2 ++ 2 files chan

[v2 15/25] drm/i915/color: Add framework to set colorop

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add infrastructure to set colorop. We iterate through all the color ops in a selected COLOR PIPELINE and set them one by one. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 31 ++

[v2 14/25] drm/i915/color: Add and attach COLORPIPELINE plane property

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add supported color pipelines and attach it to plane. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 42 ++ drivers/gpu/drm/i915/display/intel_color.h | 3 ++ 2 files changed, 45

[v2 13/25] drm/i915/color: Create a transfer function color pipeline

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add a color pipeline with three colorops in the sequence 1D LUT MULTSEG - CTM - 1D LUT MULTSEG This pipeline can be used to do any color space conversion or HDR tone mapping Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/d

[v2 07/25] drm: Add 1D LUT multi-segmented color op

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add support for color ops that can be programmed by 1 dimensional multi segmented Look Up Tables. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c | 4 drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ include/uapi

[v2 12/25] drm/i915/color: Add helper to create intel colorop

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add intel colorop create helper Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_color.c | 39 ++ drivers/gpu/drm/i915/display/intel_color.h | 3 ++ 2 files changed, 42 insertions(+) diff -

[v2 02/25] drm: Add support for 3x3 CTM

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add support for 3x3 Color Transformation Matrices in Color Pipeline. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_atomic.c | 3 +++ drivers/gpu/drm/drm_atomic_uapi.c | 3 +++ drivers/gpu/drm/drm_colorop.c | 29 +

[v2 11/25] drm/i915: Add intel_color_op

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add data structure to store intel specific details of colorop Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- .../drm/i915/display/intel_display_types.h| 19 +++ 1 file changed, 19 insertions(+) diff --git a/drivers/gpu/drm/

RE: [PATCH v5 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-11-26 Thread Kahola, Mika
> -Original Message- > From: Jani Nikula > Sent: Tuesday, 26 November 2024 11.30 > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: Sousa, Gustavo ; Jadav, Raag > ; Kahola, Mika > Subject: Re: [PATCH v5 1/2] drm/i915/xe3lpd: Power request > asserting/deasserting > > On Tue, 05 No

[v2 10/25] drm/i915: Add identifiers for intel color blocks

2024-11-26 Thread Uma Shankar
From: Chaitanya Kumar Borah Add macros to identify intel color blocks. It will help in mapping drm_color_ops to intel color HW blocks Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/display/intel_display_limits.h | 13 + 1 file changed, 13

[v2 08/25] drm: Define helper for adding capability property for 1D LUT MULTSEG

2024-11-26 Thread Uma Shankar
This adds helper functions to create 1D multi-segmented Lut color block capabilities. It exposes the hardware block as segments which are converted to blob and passed in the property. Signed-off-by: Chaitanya Kumar Borah Signed-off-by: Uma Shankar --- drivers/gpu/drm/drm_colorop.c | 24

[v2 03/25] drm: Add Enhanced LUT precision structure

2024-11-26 Thread Uma Shankar
Existing LUT precision structure is having only 16 bit precision. This is not enough for upcoming enhanced hardwares and advance usecases like HDR processing. Hence added a new structure with 32 bit precision values. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gp

[v2 05/25] drm: Add Color ops capability property

2024-11-26 Thread Uma Shankar
Add capability property which a colorop can expose it's hardware's abilities. It's a blob property that can be filled with respective data structures depending on the colorop. The user space is expected to read this property and program the colorop accordingly. Signed-off-by: Uma Shankar Signed-o

[v2 06/25] drm: Define helper to create color ops capability property

2024-11-26 Thread Uma Shankar
Add a helper to create capability property for a colorop Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- drivers/gpu/drm/drm_colorop.c | 21 + 1 file changed, 21 insertions(+) diff --git a/drivers/gpu/drm/drm_colorop.c b/drivers/gpu/drm/drm_colorop.c ind

[v2 04/25] drm: Add Color lut range attributes

2024-11-26 Thread Uma Shankar
This defines a new structure to define color lut ranges, along with related macro definitions and enums. This will help describe segmented lut ranges/PWL LUTs in the hardware. Signed-off-by: Uma Shankar Signed-off-by: Chaitanya Kumar Borah --- include/uapi/drm/drm_mode.h | 64 ++

[v2 00/25] Plane Color Pipeline support for Intel platforms

2024-11-26 Thread Uma Shankar
This series intends to add support for Plane Color Management for Intel platforms. This is based on the design which has been agreed upon by the community. Series implementing the design for generic DRM core has been sent out by Harry Wentland and is under review below: https://patchwork.freedeskto

Re: ✗ i915.CI.BAT: failure for drm/dp_mst: Fix MST sideband message body length check

2024-11-26 Thread Imre Deak
On Mon, Nov 25, 2024 at 10:04:46PM +, Patchwork wrote: > == Series Details == > > Series: drm/dp_mst: Fix MST sideband message body length check > URL : https://patchwork.freedesktop.org/series/141772/ > State : failure Thanks for the review, patch is pushed to drm-misc-fixes. The failure

✓ i915.CI.BAT: success for series starting with [1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER in display s/r

2024-11-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER in display s/r URL : https://patchwork.freedesktop.org/series/141783/ State : success == Summary == CI Bug Log - changes from CI_DRM_15747 -> Patchwork_141783v1 =

✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER in display s/r

2024-11-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER in display s/r URL : https://patchwork.freedesktop.org/series/141783/ State : warning == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/141783/revisions/1/

RE: [PATCH v5 2/2] drm/i915/display: Use struct intel_display instead of struct drm_i915_private

2024-11-26 Thread Kahola, Mika
> -Original Message- > From: Borah, Chaitanya Kumar > Sent: Tuesday, 26 November 2024 11.04 > To: Kahola, Mika ; intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; Sousa, Gustavo ; > Jadav, Raag ; Kahola, Mika > Subject: RE: [PATCH v5 2/2] drm/i915/display: Use struct inte

RE: [PATCH 2/2] [RFC] drm/i915: Unbind the vma in suspend if it was bound

2024-11-26 Thread Srinivas, Vidya
> -Original Message- > From: Srinivas, Vidya > Sent: 25 November 2024 17:01 > To: Brian Geffon > Cc: intel-gfx@lists.freedesktop.org; Syrjala, Ville ; > ville.syrj...@linux.intel.com; Lee, Shawn C > Subject: RE: [PATCH 2/2] [RFC] drm/i915: Unbind the vma in suspend if it was > bound >

[PATCH 2/2] drm/i915/dislay: convert i9xx_display_sr.[ch] to struct intel_display

2024-11-26 Thread Jani Nikula
Going forward, struct intel_display is the main device data structure for display. Switch to it. Cc: Rodrigo Vivi Signed-off-by: Jani Nikula --- .../gpu/drm/i915/display/i9xx_display_sr.c| 76 +-- .../gpu/drm/i915/display/i9xx_display_sr.h| 6 +- drivers/gpu/drm/i915/i9

[PATCH 1/2] drm/i915/display: prefer DISPLAY_VER over GRAPHICS_VER in display s/r

2024-11-26 Thread Jani Nikula
Use display version checks for display scratch registers, not graphics version. And for the older platforms it's the same thing anyway. Cc: Rodrigo Vivi Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_display_sr.c | 16 1 file changed, 8 insertions(+), 8 deleti

Re: [PATCH v5 1/2] drm/i915/xe3lpd: Power request asserting/deasserting

2024-11-26 Thread Jani Nikula
On Tue, 05 Nov 2024, Mika Kahola wrote: > There is a HW issue that arises when there are race conditions > between TCSS entering/exiting TC7 or TC10 states while the > driver is asserting/deasserting TCSS power request. As a > workaround, Display driver will implement a mailbox sequence > to ensur

Re: [PATCH] drm/i915/ddi: clarify intel_ddi_connector_get_hw_state() for DP MST

2024-11-26 Thread Jani Nikula
On Mon, 25 Nov 2024, Imre Deak wrote: > On Mon, Nov 25, 2024 at 02:09:59PM +0200, Jani Nikula wrote: >> encoder->get_hw_state() returns false for DP MST, and currently always >> interprets 128b/132b as MST. Therefore the DDI MST mode checks in >> intel_ddi_connector_get_hw_state() are redundant. >

RE: [PATCH v5 2/2] drm/i915/display: Use struct intel_display instead of struct drm_i915_private

2024-11-26 Thread Borah, Chaitanya Kumar
> -Original Message- > From: Intel-gfx On Behalf Of Mika > Kahola > Sent: Tuesday, November 5, 2024 6:48 PM > To: intel-gfx@lists.freedesktop.org > Cc: jani.nik...@linux.intel.com; Sousa, Gustavo ; > Jadav, Raag ; Kahola, Mika > Subject: [PATCH v5 2/2] drm/i915/display: Use struct inte

Re: [PATCH v9 1/4] drm: Introduce device wedged event

2024-11-26 Thread Christian König
Am 26.11.24 um 07:38 schrieb Raag Jadav: On Mon, Nov 25, 2024 at 10:32:42AM +0100, Christian König wrote: Am 22.11.24 um 17:02 schrieb Raag Jadav: On Fri, Nov 22, 2024 at 11:09:32AM +0100, Christian König wrote: Am 22.11.24 um 08:07 schrieb Raag Jadav: On Mon, Nov 18, 2024 at 08:26:37PM +0530