✗ Fi.CI.BUILD: failure for drm/xe/pm: Change HPD to polling on runtime suspend (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/xe/pm: Change HPD to polling on runtime suspend (rev2) URL : https://patchwork.freedesktop.org/series/136917/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/136917/revisions/2/mbox/ not applied Applying: drm/xe/dis

[v2PATCH] drm/xe/display: Change HPD to polling on runtime suspend

2024-08-07 Thread Arun R Murthy
HPD is interrupt based and on runtime suspend change it to polling as HPD is not a wakeup event. A worker thread is scheduled for doing this polling and it keeps polling for HPD live status on an internval of 10s. On runtime resume disable polling and fallback to interrupt mechanism. v2: move poll

✗ Fi.CI.IGT: failure for drm/i915/bmg: Read display register timeout (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/bmg: Read display register timeout (rev3) URL : https://patchwork.freedesktop.org/series/136497/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15196_full -> Patchwork_136497v3_full Summ

✓ Fi.CI.BAT: success for Consider joiner calculation for panel fitting (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: Consider joiner calculation for panel fitting (rev3) URL : https://patchwork.freedesktop.org/series/136561/ State : success == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136561v3 Summary

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-07 Thread Thomas Zimmermann
Hi Am 07.08.24 um 21:47 schrieb Alex Deucher: On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann wrote: Hi Am 05.08.24 um 21:00 schrieb Deucher, Alexander: [Public] -Original Message- From: Thomas Zimmermann Sent: Wednesday, July 31, 2024 8:17 AM To: maarten.lankho...@linux.intel.co

[PATCH 2/2] drm/i915/display: Call panel_fitting from pipe_config

2024-08-07 Thread Nemesa Garg
In panel fitter/pipe scaler scenario the pch_pfit configuration currently takes place before accounting for pipe_src width for joiner. This causes issue when pch_pfit and joiner get enabled together. Introduce a new boolean flag need_joiner which is set during dp compute_config in joiner case and

Re: [PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Raag Jadav
On Wed, Aug 07, 2024 at 02:24:27PM +0100, Andi Shyti wrote: > Hi Raag, > > > +static umode_t > > +hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr) > > +{ > > + struct i915_hwmon *hwmon = ddat->hwmon; > > + > > + switch (attr) { > > + case hwmon_fan_input: > > + return i

✓ Fi.CI.BAT: success for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev2) URL : https://patchwork.freedesktop.org/series/136975/ State : success == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136975v2 S

✗ Fi.CI.SPARSE: warning for drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable (rev2) URL : https://patchwork.freedesktop.org/series/136975/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v3] drm/i915: Explicitly cast divisor and use div_u64()

2024-08-07 Thread Andi Shyti
Hi Thorsten, > diff --git a/drivers/gpu/drm/i915/i915_perf.c > b/drivers/gpu/drm/i915/i915_perf.c > index 025a79fe5920..6ff905d2b78f 100644 > --- a/drivers/gpu/drm/i915/i915_perf.c > +++ b/drivers/gpu/drm/i915/i915_perf.c > @@ -4063,17 +4063,13 @@ static int read_properties_unlocked(struct i915_p

✓ Fi.CI.BAT: success for Allow partial memory mapping for cpu memory (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: Allow partial memory mapping for cpu memory (rev2) URL : https://patchwork.freedesktop.org/series/136981/ State : success == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136981v2 Summary --

✗ Fi.CI.IGT: failure for drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable URL : https://patchwork.freedesktop.org/series/136975/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15194_full -> Patchwork_136975v1_full

Re: [PATCH] drm/i915: Fix NULL ptr deref in intel_async_flip_check_uapi()

2024-08-07 Thread Andi Shyti
Hi Ma, > diff --git a/drivers/gpu/drm/i915/display/intel_display.c > b/drivers/gpu/drm/i915/display/intel_display.c > index c2c388212e2e..9dd7b5985d57 100644 > --- a/drivers/gpu/drm/i915/display/intel_display.c > +++ b/drivers/gpu/drm/i915/display/intel_display.c > @@ -6115,7 +6115,7 @@ static in

Re: [PATCH 1/9] drm/amdgpu: Use backlight power constants

2024-08-07 Thread Alex Deucher
On Tue, Aug 6, 2024 at 3:06 AM Thomas Zimmermann wrote: > > Hi > > Am 05.08.24 um 21:00 schrieb Deucher, Alexander: > > [Public] > > > >> -Original Message- > >> From: Thomas Zimmermann > >> Sent: Wednesday, July 31, 2024 8:17 AM > >> To: maarten.lankho...@linux.intel.com; mrip...@kernel.

Re: [PATCH 09/10] drm/i915/hdcp: migrate away from kdev_to_i915() in GSC messaging

2024-08-07 Thread Gustavo Sousa
Quoting Jani Nikula (2024-08-06 11:14:00-03:00) >On Tue, 06 Aug 2024, Jani Nikula wrote: >> On Thu, 01 Aug 2024, Gustavo Sousa wrote: >>> Quoting Jani Nikula (2024-07-29 11:30:10-03:00) Use to_intel_display() instead of kdev_to_i915() in the HDCP component API hooks. Avoid further drive-b

Re: [PATCH 03/10] drm/xe/tests: fix drvdata usage

2024-08-07 Thread Lucas De Marchi
On Tue, Aug 06, 2024 at 03:14:02PM GMT, Jani Nikula wrote: On Tue, 06 Aug 2024, Jani Nikula wrote: On Thu, 01 Aug 2024, Gustavo Sousa wrote: Quoting Jani Nikula (2024-07-29 11:30:04-03:00) The test code seems to assume struct drm_device * is stored in drvdata. This is (currently) not the cas

✓ Fi.CI.BAT: success for Trivial double space style fix (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix (rev3) URL : https://patchwork.freedesktop.org/series/136995/ State : success == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136995v3 Summary --- **SUCCES

✗ Fi.CI.SPARSE: warning for Trivial double space style fix (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix (rev3) URL : https://patchwork.freedesktop.org/series/136995/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Trivial double space style fix (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix (rev3) URL : https://patchwork.freedesktop.org/series/136995/ State : warning == Summary == Error: dim checkpatch failed 7f0b95c3cf8d drm/i915: Replace double blank with single blank after comma in gem/ and gt/ 7b29ef50efd0 drm/i915:

✓ Fi.CI.BAT: success for drm/i915/bmg: Read display register timeout (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/bmg: Read display register timeout (rev3) URL : https://patchwork.freedesktop.org/series/136497/ State : success == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136497v3 Summary --

Re: [PATCH v2] drm/i915: Explicitly cast divisor and use div_u64()

2024-08-07 Thread Andi Shyti
Hi Thorsten, > > /* This check is primarily to ensure that oa_period <= > > -* UINT32_MAX (before passing to do_div which only > > +* UINT32_MAX (before passing it to div_u64 which only > > * accepts a u32 denominator

Re: [PATCH 3/3] drm/i915: remove __i915_printk()

2024-08-07 Thread Andi Shyti
Hi Jani, On Tue, Aug 06, 2024 at 04:38:32PM +0300, Jani Nikula wrote: > With the previous cleanups, the last remaining user of __i915_printk() > is i915_probe_error(). Switch that to use drm_dbg() and drm_err() > instead, dropping the request to report bugs in the few remaining > specific cases. >

Re: [PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-07 Thread Andi Shyti
Hi Jani, On Tue, Aug 06, 2024 at 04:38:31PM +0300, Jani Nikula wrote: > i915_report_error() has only two users, both in driver probe. I doubt > these cases are worth having a dedicated wrapper to also print bug > reporting info. Just switch them to regular drm_err() and remove the > wrapper. > >

Re: [PATCH 1/3] drm/i915: remove a few __i915_printk() uses

2024-08-07 Thread Andi Shyti
Hi Jani, On Tue, Aug 06, 2024 at 04:38:30PM +0300, Jani Nikula wrote: > __i915_printk() does nothing for notice/info levels. Just use the > regular drm_notice() and drm_info() calls. > > Signed-off-by: Jani Nikula With the commit log improvements suggested by Tvrtko and yourself: Reviewed-by:

Re: [PATCH] i915: change pr_info to pr_info_ratelimited

2024-08-07 Thread Andi Shyti
Hi Mikulaus, On Mon, Aug 05, 2024 at 04:29:52PM +0200, Mikulas Patocka wrote: > Zdenek Kabelac reported that his syslog was flooded with many messages: > Purging GPU memory, 0 pages freed, 0 pages still pinned, 2029 pages left > available. Checkpatch complains here: WARNING:COMMIT_LOG_LONG_LINE

✗ Fi.CI.BAT: failure for Trivial double space style fix (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix (rev2) URL : https://patchwork.freedesktop.org/series/136995/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136995v2 Summary --- **FAILUR

✗ Fi.CI.SPARSE: warning for Trivial double space style fix (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix (rev2) URL : https://patchwork.freedesktop.org/series/136995/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Trivial double space style fix (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix (rev2) URL : https://patchwork.freedesktop.org/series/136995/ State : warning == Summary == Error: dim checkpatch failed 1130089304ff drm/i915: Replace double blank with single blank after comma in gem/ and gt/ af7a3374fd65 drm/i915:

Re: [PATCH 3/3] drm/i915: remove __i915_printk()

2024-08-07 Thread Tvrtko Ursulin
On 07/08/2024 12:40, Jani Nikula wrote: On Wed, 07 Aug 2024, Tvrtko Ursulin wrote: On 06/08/2024 14:38, Jani Nikula wrote: With the previous cleanups, the last remaining user of __i915_printk() is i915_probe_error(). Switch that to use drm_dbg() and drm_err() instead, dropping the request to

[PATCH v3] drm/i915/bmg: Read display register timeout

2024-08-07 Thread Mitul Golani
Log the address of the register that caused the timeout interrupt by reading RMTIMEOUTREG_CAPTURE --v2: - Update RMTIMEOUTREG_CAPTURE naming (Suraj) --v3: - XeLpdp naming convention. - Use if condition instead of else if Signed-off-by: Mitul Golani Reviewed-by: Suraj Kandpal --- drivers/gpu/d

Re: [PATCH] drm/i915/dg2: Enable Wa_14019159160 for DG2

2024-08-07 Thread Andi Shyti
Hi John, On Mon, Aug 05, 2024 at 05:57:19PM -0700, john.c.harri...@intel.com wrote: > From: John Harrison > > The context switch hold out workaround also applies to DG2. > > Signed-off-by: John Harrison Reviewed-by: Andi Shyti Thanks, Andi

Re: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-07 Thread Imre Deak
On Wed, Aug 07, 2024 at 12:15:33PM +0300, Murthy, Arun R wrote: > > > -Original Message- > > From: Deak, Imre > > Sent: Tuesday, August 6, 2024 10:11 PM > > To: Murthy, Arun R > > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > > Subject: Re: [PATCH] drm/xe/pm: Chan

RE: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Wednesday, August 7, 2024 2:10 AM To: intel-gfx ; dri-devel Cc: Chris Wilson ; Das, Nirmoy ; Cavitt, Jonathan ; Andi Shyti Subject: [PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable > > From: Chris Wilson > > After we detect

RE: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Cavitt, Jonathan
-Original Message- From: Andi Shyti Sent: Wednesday, August 7, 2024 3:46 AM To: intel-gfx ; dri-devel Cc: Niemiec, Krzysztof ; Andi Shyti ; Cavitt, Jonathan Subject: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt() > > By moving the pfn calculation to the

✗ Fi.CI.BAT: failure for Trivial double space style fix

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix URL : https://patchwork.freedesktop.org/series/136995/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15196 -> Patchwork_136995v1 Summary --- **FAILURE**

✗ Fi.CI.BUILD: failure for drm/i915/dp_mst: Fix MST state after a sink reset (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/dp_mst: Fix MST state after a sink reset (rev2) URL : https://patchwork.freedesktop.org/series/136443/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/136443/revisions/2/mbox/ not applied Applying: drm/i915/dp_

✗ Fi.CI.SPARSE: warning for Trivial double space style fix

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix URL : https://patchwork.freedesktop.org/series/136995/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Trivial double space style fix

2024-08-07 Thread Patchwork
== Series Details == Series: Trivial double space style fix URL : https://patchwork.freedesktop.org/series/136995/ State : warning == Summary == Error: dim checkpatch failed 0075161e228e drm/i915: Replace double blank with single blank after comma in gem/ and gt/ 2b5f0fa917e4 drm/i915: Replac

Re: [PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Andi Shyti
Hi Raag, > +static umode_t > +hwm_fan_is_visible(const struct hwm_drvdata *ddat, u32 attr) > +{ > + struct i915_hwmon *hwmon = ddat->hwmon; > + > + switch (attr) { > + case hwmon_fan_input: > + return i915_mmio_reg_valid(hwmon->rg.fan_speed) ? 0444 : 0; > + default: > +

Re: [PATCH 0/2] Trivial double space style fix

2024-08-07 Thread Jani Nikula
On Wed, 07 Aug 2024, Andi Shyti wrote: > Hi, > > I was bothered a few times to see the double space in the > parameters list so that I decided to replace once and for all all > the double spaces that are not added on purpose to maintain some > visual alignment in the code. > > Checkpatch doesn't h

[PATCH 2/2] drm/i915: Replace double blank with single blank after comma

2024-08-07 Thread Andi Shyti
Do not use double blanks, ", " in function parameters where it's not required by any alignment purpose. Replase it with a single blank, ", ". Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/display/i9xx_wm.c | 2 +- drivers/gpu/drm/i915/display/intel_ddi.c | 2 +- d

[PATCH 1/2] drm/i915: Replace double blank with single blank after comma in gem/ and gt/

2024-08-07 Thread Andi Shyti
Do not use double blanks, ", " in function parameters where it's not required by any alignment purpose. Replase it with a single blank, ", ". Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_object_types.h | 2 +- drivers/gpu/drm/i915/gt/selftest_migrate.c | 2 +- d

[PATCH 0/2] Trivial double space style fix

2024-08-07 Thread Andi Shyti
Hi, I was bothered a few times to see the double space in the parameters list so that I decided to replace once and for all all the double spaces that are not added on purpose to maintain some visual alignment in the code. Checkpatch doesn't have any rules for that because, indeed, this is used a

✓ Fi.CI.BAT: success for drm/i915/hwmon: expose fan speed (rev3)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: expose fan speed (rev3) URL : https://patchwork.freedesktop.org/series/136036/ State : success == Summary == CI Bug Log - changes from CI_DRM_15195 -> Patchwork_136036v3 Summary --- **SUCC

Re: [core-for-CI PATCH] usb: typec: ucsi: Fix a potential deadlock in ucsi_send_command_common()

2024-08-07 Thread Jani Nikula
On Wed, 07 Aug 2024, "Coelho, Luciano" wrote: > On Wed, 2024-08-07 at 11:57 +0530, Chaitanya Kumar Borah wrote: >> From: Heikki Krogerus >> >> The function returns with the ppm_lock held if there's an >> error or the PPM reports BUSY condition. >> >> This is a core-for-ci patch for [1] >> >> [

✓ Fi.CI.BAT: success for drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt() URL : https://patchwork.freedesktop.org/series/136985/ State : success == Summary == CI Bug Log - changes from CI_DRM_15195 -> Patchwork_136985v1 ===

[PATCH v3] drm/i915/hwmon: expose fan speed

2024-08-07 Thread Raag Jadav
Add hwmon support for fan1_input attribute, which will expose fan speed in RPM. With this in place we can monitor fan speed using lm-sensors tool. $ sensors i915-pci-0300 Adapter: PCI adapter in0: 653.00 mV fan1:3833 RPM power1: N/A (max = 43.00 W) energy1: 32.02 k

Re: [PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Krzysztof Niemiec
On 2024-08-07 at 11:45:53 GMT, Andi Shyti wrote: > By moving the pfn calculation to the set_address_limits() > function we improve code readability. This way, > set_address_limits() is responsible for calculating all memory > mapping paramenters: "start", "end" and "pfn". > > This suggestion from

Re: [core-for-CI PATCH] usb: typec: ucsi: Fix a potential deadlock in ucsi_send_command_common()

2024-08-07 Thread Coelho, Luciano
On Wed, 2024-08-07 at 11:57 +0530, Chaitanya Kumar Borah wrote: > From: Heikki Krogerus > > The function returns with the ppm_lock held if there's an > error or the PPM reports BUSY condition. > > This is a core-for-ci patch for [1] > > [1] > https://lore.kernel.org/linux-usb/20240806112029.29

Re: [PATCH 3/3] drm/i915: remove __i915_printk()

2024-08-07 Thread Jani Nikula
On Wed, 07 Aug 2024, Tvrtko Ursulin wrote: > On 06/08/2024 14:38, Jani Nikula wrote: >> With the previous cleanups, the last remaining user of __i915_printk() >> is i915_probe_error(). Switch that to use drm_dbg() and drm_err() >> instead, dropping the request to report bugs in the few remaining >

Re: [PATCH 1/3] drm/i915: remove a few __i915_printk() uses

2024-08-07 Thread Jani Nikula
On Wed, 07 Aug 2024, Tvrtko Ursulin wrote: > On 06/08/2024 14:38, Jani Nikula wrote: >> __i915_printk() does nothing for notice/info levels. Just use the >> regular drm_notice() and drm_info() calls. > > "does nothing"? You mean does nothing _special_? Yeah, does nothing in addition to the regula

✓ Fi.CI.BAT: success for Allow partial memory mapping for cpu memory

2024-08-07 Thread Patchwork
== Series Details == Series: Allow partial memory mapping for cpu memory URL : https://patchwork.freedesktop.org/series/136981/ State : success == Summary == CI Bug Log - changes from CI_DRM_15194 -> Patchwork_136981v1 Summary --- **

Re: Too large alloc in gem_exec_reloc test? (was Re: [linus:master] [mm/slab] 2e8000b826: WARNING:at_mm/util.c:#__kvmalloc_node_noprof)

2024-08-07 Thread Tvrtko Ursulin
Hi, On 05/08/2024 19:48, Kees Cook wrote: This seems like some kind of pre-existing issue in the igt test, reachable via eb_copy_relocations(). The only warning in kvmalloc_node_noprof() is: /* Don't even allow crazy sizes */ if (unlikely(size > INT_MAX)) {

Re: [PATCH] drm/i915: 2 GiB of relocations ought to be enough for anybody*

2024-08-07 Thread Joonas Lahtinen
Quoting Tvrtko Ursulin (2024-05-21 13:12:01) > From: Tvrtko Ursulin > > Kernel test robot reports i915 can hit a warn in kvmalloc_node which has > a purpose of dissalowing crazy size kernel allocations. This was added in > 7661809d493b ("mm: don't allow oversized kvmalloc() calls"): > >/

✓ Fi.CI.BAT: success for drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable URL : https://patchwork.freedesktop.org/series/136975/ State : success == Summary == CI Bug Log - changes from CI_DRM_15194 -> Patchwork_136975v1 Summary

[PATCH] drm/i915/gem: Improve pfn calculation readability in vm_fault_gtt()

2024-08-07 Thread Andi Shyti
By moving the pfn calculation to the set_address_limits() function we improve code readability. This way, set_address_limits() is responsible for calculating all memory mapping paramenters: "start", "end" and "pfn". This suggestion from Jonathan was made during the review of commit 8bdd9ef7e9b1 ("

Re: [PATCH 3/3] drm/i915: remove __i915_printk()

2024-08-07 Thread Tvrtko Ursulin
On 06/08/2024 14:38, Jani Nikula wrote: With the previous cleanups, the last remaining user of __i915_printk() is i915_probe_error(). Switch that to use drm_dbg() and drm_err() instead, dropping the request to report bugs in the few remaining specific cases. Aren't those few cases legitimate

✗ Fi.CI.SPARSE: warning for drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/gt: Mark the GT as dead when mmio is unreliable URL : https://patchwork.freedesktop.org/series/136975/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH 2/3] drm/i915: remove i915_report_error()

2024-08-07 Thread Tvrtko Ursulin
On 06/08/2024 14:38, Jani Nikula wrote: i915_report_error() has only two users, both in driver probe. I doubt these cases are worth having a dedicated wrapper to also print bug reporting info. Just switch them to regular drm_err() and remove the wrapper. Signed-off-by: Jani Nikula --- drive

RE: [PATCH 1/5] drm/i915/display: Add support for histogram

2024-08-07 Thread Murthy, Arun R
> > +static int intel_histogram_enable(struct intel_crtc *intel_crtc) { > > + struct drm_i915_private *i915 = to_i915(intel_crtc->base.dev); > > + struct intel_histogram *histogram = intel_crtc->histogram; > > + int pipe = intel_crtc->pipe; > > + u64 res; > > + u32 gbandthreshold; > > + >

Re: [PATCH 1/3] drm/i915: remove a few __i915_printk() uses

2024-08-07 Thread Tvrtko Ursulin
On 06/08/2024 14:38, Jani Nikula wrote: __i915_printk() does nothing for notice/info levels. Just use the regular drm_notice() and drm_info() calls. "does nothing"? You mean does nothing _special_? The patch itself looks okay. Regards, Tvrtko Signed-off-by: Jani Nikula --- drivers/gpu

[PATCH 2/2] drm/i915/gem: Calculate object page offset for partial memory mapping

2024-08-07 Thread Andi Shyti
To enable partial memory mapping of GPU virtual memory, it's necessary to introduce an offset to the object's memory (obj->mm.pages) scatterlist. This adjustment compensates for instances when userspace mappings do not start from the beginning of the object. Based on a patch by Chris Wilson. Sign

[PATCH 1/2] drm/i915/gem: Do not look for the exact address in node

2024-08-07 Thread Andi Shyti
In preparation for the upcoming partial memory mapping feature, we want to make sure that when looking for a node we consider also the offset and not just the starting address of the virtual memory node. Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_mman.c | 6 +++--- 1 file ch

[PATCH 0/2] Allow partial memory mapping for cpu memory

2024-08-07 Thread Andi Shyti
Hi, This patch series concludes on the memory mapping fixes and improvements by allowing partial memory mapping for the cpu memory as well. The partial memory mapping by adding an object offset was implicitely included in commit 8bdd9ef7e9b1 ("drm/i915/gem: Fix Virtual Memory mapping boundaries c

Re: [PATCH 1/5] drm/i915/display: Add support for histogram

2024-08-07 Thread Jani Nikula
On Fri, 05 Jul 2024, Arun R Murthy wrote: > +/* GLOBAL_HIST related registers */ > +#define _DPST_CTL_A 0x490C0 > +#define _DPST_CTL_B 0x491C0 > +#define DPST_CTL(pipe) > _MMIO_PIPE(pipe, _DPST

Re: [PATCH 5/5] drm/i915/display/histogram: Histogram changes for Display LNL+

2024-08-07 Thread Jani Nikula
On Fri, 05 Jul 2024, Arun R Murthy wrote: > In LNL+, histogram/IE data and index registers are added which was > included in the control registers in the legacy platforms. The new > registers are used for reading histogram and writing the IET LUT data. > > Signed-off-by: Arun R Murthy > --- > ..

Re: [PATCH 2/5] drm/i915/display: histogram interrupt handling

2024-08-07 Thread Jani Nikula
On Fri, 05 Jul 2024, Arun R Murthy wrote: > Upon enabling histogram an interrupt is trigerred after the generation > of the statistics. This patch registers the histogram interrupt and > handles the interrupt. > > Signed-off-by: Arun R Murthy > --- > .../gpu/drm/i915/display/intel_display_irq.c

Re: [linux-next:master] [fs] cdc4ad36a8: kernel_BUG_at_include/linux/page-flags.h

2024-08-07 Thread Christian Brauner
On Wed, Aug 07, 2024 at 04:46:15AM GMT, Matthew Wilcox wrote: > On Tue, Aug 06, 2024 at 10:26:17PM +0800, kernel test robot wrote: > > kernel test robot noticed "kernel_BUG_at_include/linux/page-flags.h" on: > > > > commit: cdc4ad36a871b7ac43fcc6b2891058d332ce60ce ("fs: Convert > > aops->write_be

Re: [PATCH 1/5] drm/i915/display: Add support for histogram

2024-08-07 Thread Jani Nikula
On Fri, 05 Jul 2024, Arun R Murthy wrote: > Statistics is generated from the image frame that is coming to display > and an event is sent to user after reading this histogram data. > This statistics/histogram is then shared with the user upon getting a > request from user. User can then use this h

✗ Fi.CI.IGT: failure for drm/i915/bmg: Read display register timeout (rev2)

2024-08-07 Thread Patchwork
== Series Details == Series: drm/i915/bmg: Read display register timeout (rev2) URL : https://patchwork.freedesktop.org/series/136497/ State : failure == Summary == CI Bug Log - changes from CI_DRM_15191_full -> Patchwork_136497v2_full Summ

RE: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend

2024-08-07 Thread Murthy, Arun R
> -Original Message- > From: Deak, Imre > Sent: Tuesday, August 6, 2024 10:11 PM > To: Murthy, Arun R > Cc: intel...@lists.freedesktop.org; intel-gfx@lists.freedesktop.org > Subject: Re: [PATCH] drm/xe/pm: Change HPD to polling on runtime suspend > > On Tue, Aug 06, 2024 at 02:25:13PM

[PATCH] drm/i915/gt: Mark the GT as dead when mmio is unreliable

2024-08-07 Thread Andi Shyti
From: Chris Wilson After we detect that mmio is returning all 0xff, we believe that the GPU has dropped off the pci bus and is dead. Mark the device as wedged such that we can propagate the failure back to userspace and wait for recovery. Signed-off-by: Chris Wilson Signed-off-by: Andi Shyti -

RE: [PATCH v2] drm/i915/bmg: Read display register timeout

2024-08-07 Thread Kandpal, Suraj
> -Original Message- > From: Golani, Mitulkumar Ajitkumar > > Sent: Wednesday, August 7, 2024 9:33 AM > Cc: intel-gfx@lists.freedesktop.org; intel...@lists.freedesktop.org; Kandpal, > Suraj > Subject: [PATCH v2] drm/i915/bmg: Read display register timeout > > Log the address of the re

✓ Fi.CI.BAT: success for usb: typec: ucsi: Fix a potential deadlock in ucsi_send_command_common()

2024-08-07 Thread Patchwork
== Series Details == Series: usb: typec: ucsi: Fix a potential deadlock in ucsi_send_command_common() URL : https://patchwork.freedesktop.org/series/136962/ State : success == Summary == CI Bug Log - changes from CI_DRM_15192 -> Patchwork_136962v1 ==

Re: [linux-next:master] [fs] cdc4ad36a8: kernel_BUG_at_include/linux/page-flags.h

2024-08-07 Thread Ryan Roberts
On 07/08/2024 04:46, Matthew Wilcox wrote: > On Tue, Aug 06, 2024 at 10:26:17PM +0800, kernel test robot wrote: >> kernel test robot noticed "kernel_BUG_at_include/linux/page-flags.h" on: >> >> commit: cdc4ad36a871b7ac43fcc6b2891058d332ce60ce ("fs: Convert >> aops->write_begin to take a folio") >>