Re: [PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-23 Thread Vignesh Raman
Hi Dmitry, On 23/05/24 15:29, Dmitry Baryshkov wrote: On Thu, 23 May 2024 at 09:07, Vignesh Raman wrote: Hi Dmitry, On 20/05/24 16:13, Dmitry Baryshkov wrote: On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote: zlib.net is not allowing tarball download anymore and results in bel

Re: [PATCH v2 01/17] drm/i915/psr: Store pr_dpcd in intel_dp

2024-05-23 Thread Hogander, Jouni
On Fri, 2024-05-24 at 05:55 +, Manna, Animesh wrote: > > > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, May 21, 2024 2:17 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Manna, Animesh ; Kahola, Mika > > ; Hogander, Jouni > > Subject: [PATCH v2 01/17] drm/i91

RE: [PATCH v2 04/17] drm/i915/psr: Move printing PSR mode to own function

2024-05-23 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, May 21, 2024 2:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh ; Kahola, Mika > ; Hogander, Jouni > Subject: [PATCH v2 04/17] drm/i915/psr: Move printing PSR mode to own > function > > intel_psr_status has g

RE: [PATCH v2 01/17] drm/i915/psr: Store pr_dpcd in intel_dp

2024-05-23 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, May 21, 2024 2:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh ; Kahola, Mika > ; Hogander, Jouni > Subject: [PATCH v2 01/17] drm/i915/psr: Store pr_dpcd in intel_dp > > We need pr_dpcd contents for early tr

RE: [PATCH v2 00/17] Panel Replay eDP support

2024-05-23 Thread Manna, Animesh
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, May 21, 2024 2:17 PM > To: intel-gfx@lists.freedesktop.org > Cc: Manna, Animesh ; Kahola, Mika > ; Hogander, Jouni > Subject: [PATCH v2 00/17] Panel Replay eDP support > > This patch set is implementing eDP1.5 Panel Replay f

✓ Fi.CI.BAT: success for drm/i915: Increase FLR timeout from 3s to 9s

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: Increase FLR timeout from 3s to 9s URL : https://patchwork.freedesktop.org/series/133994/ State : success == Summary == CI Bug Log - changes from CI_DRM_14813 -> Patchwork_133994v1 Summary --- *

[PATCH v2] drm/i915: Increase FLR timeout from 3s to 9s

2024-05-23 Thread Andi Shyti
Following the guidelines it takes 3 seconds to perform an FLR reset. Let's give it a bit more slack because this time can change depending on the platform and on the firmware Signed-off-by: Andi Shyti --- Hi, In this second version I removed patch 2 that was ignoring the FLR reset timeouts, unti

Re: [PATCH] drm/i915: 2 GiB of relocations ought to be enough for anybody*

2024-05-23 Thread Kees Cook
On Tue, May 21, 2024 at 11:12:01AM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Kernel test robot reports i915 can hit a warn in kvmalloc_node which has > a purpose of dissalowing crazy size kernel allocations. This was added in > 7661809d493b ("mm: don't allow oversized kvmalloc() cal

Re: [PATCH v2] drm/i915/mtl: Update workaround 14018778641

2024-05-23 Thread Matt Roper
On Fri, May 24, 2024 at 12:31:26AM +0200, Andi Shyti wrote: > Hi Angus, > > On Mon, May 13, 2024 at 02:19:17PM +, Chen, Angus wrote: > > The WA should be extended to cover VDBOX engine. We found that > > 28-channels 1080p VP9 encoding may hit this issue. > > > > Signed-off-by: Chen, Angus >

✓ Fi.CI.BAT: success for drm/i915/display: Expand runtime_pm protection to atomic commit work

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Expand runtime_pm protection to atomic commit work URL : https://patchwork.freedesktop.org/series/133991/ State : success == Summary == CI Bug Log - changes from CI_DRM_14813 -> Patchwork_133991v1 ==

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Expand runtime_pm protection to atomic commit work

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Expand runtime_pm protection to atomic commit work URL : https://patchwork.freedesktop.org/series/133991/ State : warning == Summary == Error: dim checkpatch failed 1305d1256d13 drm/i915/display: Expand runtime_pm protection to atomic commit work

Re: [PATCH v2] drm/i915/mtl: Update workaround 14018778641

2024-05-23 Thread Andi Shyti
Hi Angus, On Mon, May 13, 2024 at 02:19:17PM +, Chen, Angus wrote: > The WA should be extended to cover VDBOX engine. We found that > 28-channels 1080p VP9 encoding may hit this issue. > > Signed-off-by: Chen, Angus > --- > drivers/gpu/drm/i915/gt/intel_workarounds.c | 3 +++ > 1 file chang

[PATCH] drm/i915/display: Expand runtime_pm protection to atomic commit work

2024-05-23 Thread Rodrigo Vivi
Xe memory management relies on outer bound callers of runtime PM protection and it will warn us when some is missing: <4> [274.904535] xe :00:02.0: Missing outer runtime PM protection <4> [274.905051] ? xe_pm_runtime_get_noresume+0x48/0x60 [xe] <4> [274.905118] xe_ggtt_remove_node+0x28/0x90

✓ Fi.CI.BAT: success for drm/i915: intel_color_check() cleanup

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: intel_color_check() cleanup URL : https://patchwork.freedesktop.org/series/133985/ State : success == Summary == CI Bug Log - changes from CI_DRM_14813 -> Patchwork_133985v1 Summary --- **SUCCES

✗ Fi.CI.SPARSE: warning for drm/i915: intel_color_check() cleanup

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: intel_color_check() cleanup URL : https://patchwork.freedesktop.org/series/133985/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:

Re: [PATCH 05/10] drm/i915/display: add platform descriptors

2024-05-23 Thread Rodrigo Vivi
On Wed, May 22, 2024 at 08:33:42PM +0300, Jani Nikula wrote: > We'll need to start identifying the platforms independently in display > code in order to break free from the i915 and xe IS_() > macros. This is fairly straightforward, as we already identify most > platforms by PCI ID in display probe

[PULL] drm-misc-fixes

2024-05-23 Thread Thomas Zimmermann
Hi Dave, Sima, here's the weekly PR for drm-misc-fixes. There's one important patch included, which fixes a kernel panic that can be triggered from userspace. Best regards Thomas drm-misc-fixes-2024-05-23: Short summary of fixes pull: buddy: - stop using PAGE_SIZE shmem-helper: - avoid kernel

Re: [PATCH 07/10] drm/i915/display: change display probe to identify GMD ID based platforms

2024-05-23 Thread Rodrigo Vivi
On Wed, May 22, 2024 at 08:33:44PM +0300, Jani Nikula wrote: > We'll need to identify all platforms, including the ones that have > display defined by GMD ID. Add MTL and LNL. Their display info will > still be probed via GMD ID. Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jani Nikula > --- >

Re: [PATCH 08/10] drm/i915/display: identify platforms with enum and name

2024-05-23 Thread Rodrigo Vivi
On Wed, May 22, 2024 at 08:33:45PM +0300, Jani Nikula wrote: > Add enum intel_display_platform and add that and name to all platform > descriptors. Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jani Nikula > --- > .../drm/i915/display/intel_display_device.c | 48 +++ > .../drm/

Re: [PATCH 09/10] drm/i915/display: add support for subplatforms

2024-05-23 Thread Rodrigo Vivi
On Wed, May 22, 2024 at 08:33:46PM +0300, Jani Nikula wrote: > Add support for subplatforms. This is similar to what the xe driver is > doing. The subplatform is an enum and it's exclusive, i.e. only one > subplatform can match, and it completely identifies the platform and > subplatform. This is d

Re: [PATCH 10/10] drm/i915/display: add probe message

2024-05-23 Thread Rodrigo Vivi
On Wed, May 22, 2024 at 08:33:47PM +0300, Jani Nikula wrote: > Add an info message about which display device was probed. Reviewed-by: Rodrigo Vivi > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_display_device.c | 5 + > 1 file changed, 5 insertions(+) > > diff

Re: [PATCH 06/10] drm/i915: add LNL PCI IDs

2024-05-23 Thread Rodrigo Vivi
On Wed, May 22, 2024 at 08:33:43PM +0300, Jani Nikula wrote: > Although not supported by i915 core, the display code needs to know the > LNL PCI IDs. perhaps we should add a comment in the header near the IDs? > > Long term, xe and i915 should probably share the file defining PCI IDs. although

[PATCH 3/3] drm/i915: Bury c8_planes_changed() in intel_color_check()

2024-05-23 Thread Ville Syrjala
From: Ville Syrjälä The c8_planes_changed() check in the high level atomic code is a bit of an eyesore. Push it inside intel_color_check() so the high level code doesn't have to care about this stuff. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 11 ++

[PATCH 2/3] drm/i915: Hide the intel_crtc_needs_color_update() inside intel_color_check()

2024-05-23 Thread Ville Syrjala
From: Ville Syrjälä Move the intel_crtc_needs_color_update() into intel_color_check() so that the caller doesn't have to care about this. This will also enable us to hide the c8_planes_changed() thing better. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_color.c | 5 +++

[PATCH 1/3] drm/i915: Plumb the entire atomic state into intel_color_check()

2024-05-23 Thread Ville Syrjala
From: Ville Syrjälä Bunch of stuff in intel_color_check() needs to look at both the old and new crtc states. Currently we do that by digging the full atomic state via the crtc_state->state pointer. That thing is a total footgun if I ever saw one, as it's only valid during specific parts of the at

[PATCH 0/3] drm/i915: intel_color_check() cleanup

2024-05-23 Thread Ville Syrjala
From: Ville Syrjälä Eliminate the crtc_state->state footgun from intel_color_check(), and hide some mundane C8 plane details inside it. Ville Syrjälä (3): drm/i915: Plumb the entire atomic state into intel_color_check() drm/i915: Hide the intel_crtc_needs_color_update() inside intel_colo

Re: [PATCH v2 14/21] drm/i915/dp: Disable link retraining after the last fallback step

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:28:12PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:12PM +0300, Imre Deak wrote: > > After a link training failure if the link parameters can't be further > > reduced, there is no point in trying to retrain the link in the driver. > > This avoids excessive

Re: [PATCH v2 19/21] drm/i915/dp: Add debugfs entry to force link training failure

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:29:34PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:17PM +0300, Imre Deak wrote: > > Add a connector debugfs entry to force a failure during the following > > 1-2 link training. The entry will auto-reset after the specified link > > training events are com

Re: [PATCH v2 17/21] drm/i915/dp: Add debugfs entries to set a target link rate/lane count

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:25:08PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:15PM +0300, Imre Deak wrote: > > Add connector debugfs entries to set a target link rate/lane count to be > > used by a link training afterwards. After setting a target link > > rate/lane count reset the

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:43:40PM +0300, Ville Syrjälä wrote: > On Thu, May 23, 2024 at 06:29:21PM +0300, Imre Deak wrote: > > On Thu, May 23, 2024 at 06:08:40PM +0300, Ville Syrjälä wrote: > > > On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > > > > Simplify things by retraining a DP

Re: [PATCH v2 04/21] drm/i915/dp: Sanitize intel_dp_get_link_train_fallback_values()

2024-05-23 Thread Jani Nikula
On Wed, 22 May 2024, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:02PM +0300, Imre Deak wrote: >> Reduce the indentation in intel_dp_get_link_train_fallback_values() by >> adding separate helpers to reduce the link rate and lane count. Also >> simplify things by passing crtc_state to the f

✓ Fi.CI.BAT: success for drm/i915/display: Add comparison for pipe config for MTL+ >

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Add comparison for pipe config for MTL+ > URL : https://patchwork.freedesktop.org/series/133968/ State : success == Summary == CI Bug Log - changes from CI_DRM_14809 -> Patchwork_133968v1 Summa

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 06:29:21PM +0300, Imre Deak wrote: > On Thu, May 23, 2024 at 06:08:40PM +0300, Ville Syrjälä wrote: > > On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > > > Simplify things by retraining a DP link if a bad link is detected in the > > > connector detect handler fr

✗ Fi.CI.SPARSE: warning for drm/i915/display: Add comparison for pipe config for MTL+ >

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Add comparison for pipe config for MTL+ > URL : https://patchwork.freedesktop.org/series/133968/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Add comparison for pipe config for MTL+ >

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915/display: Add comparison for pipe config for MTL+ > URL : https://patchwork.freedesktop.org/series/133968/ State : warning == Summary == Error: dim checkpatch failed 840f16a219ec drm/i915/display: Revert "drm/i915/display: Skip C10 state verification in ca

Re: [PATCH v2 19/21] drm/i915/dp: Add debugfs entry to force link training failure

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:17PM +0300, Imre Deak wrote: > Add a connector debugfs entry to force a failure during the following > 1-2 link training. The entry will auto-reset after the specified link > training events are complete. > > v2: Add the entry from intel_dp_link_training.c (Jani) > >

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 06:08:40PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > > Simplify things by retraining a DP link if a bad link is detected in the > > connector detect handler from the encoder's check link state work, > > similarly to how this i

Re: [PATCH v2 14/21] drm/i915/dp: Disable link retraining after the last fallback step

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:12PM +0300, Imre Deak wrote: > After a link training failure if the link parameters can't be further > reduced, there is no point in trying to retrain the link in the driver. > This avoids excessive retrain attempts after detecting a bad link, for > instance while hand

Re: [PATCH v2 17/21] drm/i915/dp: Add debugfs entries to set a target link rate/lane count

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:15PM +0300, Imre Deak wrote: > Add connector debugfs entries to set a target link rate/lane count to be > used by a link training afterwards. After setting a target link > rate/lane count reset the link training parameters and for a non-auto > target disable reducing t

✓ Fi.CI.BAT: success for amd, i915, xe: drop redundant warnings from driver makefiles

2024-05-23 Thread Patchwork
== Series Details == Series: amd, i915, xe: drop redundant warnings from driver makefiles URL : https://patchwork.freedesktop.org/series/133965/ State : success == Summary == CI Bug Log - changes from CI_DRM_14809 -> Patchwork_133965v1 Summ

Re: [PATCH v2 12/21] drm/i915/dp: Use check link state work in the detect handler

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:10PM +0300, Imre Deak wrote: > Simplify things by retraining a DP link if a bad link is detected in the > connector detect handler from the encoder's check link state work, > similarly to how this is done after a modeset link training failure. > > Signed-off-by: Imre

✗ Fi.CI.SPARSE: warning for amd, i915, xe: drop redundant warnings from driver makefiles

2024-05-23 Thread Patchwork
== Series Details == Series: amd, i915, xe: drop redundant warnings from driver makefiles URL : https://patchwork.freedesktop.org/series/133965/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 05:54:10PM +0300, Ville Syrjälä wrote: > On Thu, May 23, 2024 at 05:47:36PM +0300, Imre Deak wrote: > > On Thu, May 23, 2024 at 05:41:17PM +0300, Ville Syrjälä wrote: > > > On Mon, May 20, 2024 at 09:58:07PM +0300, Imre Deak wrote: > > > > From: Imre Deak > > > > > > > > T

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 05:54:10PM +0300, Ville Syrjälä wrote: > On Thu, May 23, 2024 at 05:47:36PM +0300, Imre Deak wrote: > > On Thu, May 23, 2024 at 05:41:17PM +0300, Ville Syrjälä wrote: > > > On Mon, May 20, 2024 at 09:58:07PM +0300, Imre Deak wrote: > > > > From: Imre Deak > > > > > > > > T

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 05:47:36PM +0300, Imre Deak wrote: > On Thu, May 23, 2024 at 05:41:17PM +0300, Ville Syrjälä wrote: > > On Mon, May 20, 2024 at 09:58:07PM +0300, Imre Deak wrote: > > > From: Imre Deak > > > > > > The next patch adds sending a modeset-retry uevent after a link training > >

✓ Fi.CI.BAT: success for drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h URL : https://patchwork.freedesktop.org/series/133961/ State : success == Summary == CI Bug Log - changes from CI_DRM_14809 -> Patchwork_133961v1

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 05:41:17PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:07PM +0300, Imre Deak wrote: > > From: Imre Deak > > > > The next patch adds sending a modeset-retry uevent after a link training > > failure to all MST connectors on link. This requires the atomic stat

Re: [PATCH v2 09/21] drm/i915/dp: Pass atomic state to link training function

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:07PM +0300, Imre Deak wrote: > From: Imre Deak > > The next patch adds sending a modeset-retry uevent after a link training > failure to all MST connectors on link. This requires the atomic state, > so pass it to intel_dp_start_link_train(). In case of SST where > re

✗ Fi.CI.SPARSE: warning for drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h URL : https://patchwork.freedesktop.org/series/133961/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x

✗ Fi.CI.CHECKPATCH: warning for drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h URL : https://patchwork.freedesktop.org/series/133961/ State : warning == Summary == Error: dim checkpatch failed c6ca7406f7f7 drm/i915: pass dev_priv explicitly to DSPADDR_VLV f3e2cda96093 drm/i915:

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 04:58:38PM +0300, Ville Syrjälä wrote: > On Thu, May 23, 2024 at 04:46:30PM +0300, Imre Deak wrote: > > On Thu, May 23, 2024 at 04:30:18PM +0300, Ville Syrjälä wrote: > > > On Mon, May 20, 2024 at 09:58:05PM +0300, Imre Deak wrote: > > > > Recheck the link state after a pass

✗ Fi.CI.IGT: failure for drm/i915: identify all platforms in display probe

2024-05-23 Thread Patchwork
== Series Details == Series: drm/i915: identify all platforms in display probe URL : https://patchwork.freedesktop.org/series/133932/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14804_full -> Patchwork_133932v1_full Summa

[linux-next:master] BUILD REGRESSION 3689b0ef08b70e4e03b82ebd37730a03a672853a

2024-05-23 Thread kernel test robot
tree/branch: https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git master branch HEAD: 3689b0ef08b70e4e03b82ebd37730a03a672853a Add linux-next specific files for 20240523 Unverified Error/Warning (likely false positive, please contact us if interested): drivers/gpu/drm/xe

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 04:46:30PM +0300, Imre Deak wrote: > On Thu, May 23, 2024 at 04:30:18PM +0300, Ville Syrjälä wrote: > > On Mon, May 20, 2024 at 09:58:05PM +0300, Imre Deak wrote: > > > Recheck the link state after a passing link training, with a 2 sec delay > > > to account for cases where

[PATCH v2 2/2] drm/i915/display: Add compare config for MTL+ platforms

2024-05-23 Thread Mika Kahola
Currently, we may bump into pll mismatch errors during the state verification stage. This happens when we try to use fastset instead of full modeset. Hence, we would need to add a check for pipe configuration to ensure that the sw and the hw configuration will match. In case of hw and sw mismatch,

[PATCH v2 1/2] drm/i915/display: Revert "drm/i915/display: Skip C10 state verification in case of fastset"

2024-05-23 Thread Mika Kahola
This reverts commit a1d91c6e989d0e66b89aa911f2cd459d7bdebbe5. Signed-off-by: Mika Kahola --- drivers/gpu/drm/i915/display/intel_cx0_phy.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_cx0_phy.c b/drivers/gpu/drm/i915/display/intel_cx0_phy.c index 1b1eb

[PATCH v2 0/2] drm/i915/display: Add comparison for pipe config for MTL+ >

2024-05-23 Thread Mika Kahola
Currently, we may bump into pll mismatch errors during the state verification stage. This happens when we try to use fastset instead of full modeset. Hence, we would need to add a check for pipe configuration to ensure that the sw and the hw configuration will match. In case of hw and sw mismatch,

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 02:14:56PM +0100, Tvrtko Ursulin wrote: > > On 23/05/2024 13:24, Ville Syrjälä wrote: > > On Thu, May 23, 2024 at 01:07:24PM +0100, Tvrtko Ursulin wrote: > >> > >> On 23/05/2024 12:19, Ville Syrjälä wrote: > >>> On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 04:30:18PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:05PM +0300, Imre Deak wrote: > > Recheck the link state after a passing link training, with a 2 sec delay > > to account for cases where the link goes bad following the link training > > and the sink does

[PATCH 2/3] drm/xe: drop redundant W=1 warnings from Makefile

2024-05-23 Thread Jani Nikula
Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default across the subsystem"), most of the extra warnings in the driver Makefile are redundant. Remove them. Note that -Wmissing-declarations and -Wmissing-prototypes are always enabled by default in scripts/Makefile.extrawarn. Signe

[PATCH 3/3] drm/amdgpu: drop redundant W=1 warnings from Makefile

2024-05-23 Thread Jani Nikula
Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default across the subsystem"), most of the extra warnings in the driver Makefile are redundant. Remove them. Note that -Wmissing-declarations and -Wmissing-prototypes are always enabled by default in scripts/Makefile.extrawarn. Signe

[PATCH 1/3] drm/i915: drop redundant W=1 warnings from Makefile

2024-05-23 Thread Jani Nikula
Since commit a61ddb4393ad ("drm: enable (most) W=1 warnings by default across the subsystem"), most of the extra warnings in the driver Makefile are redundant. Remove them. Note that -Wmissing-declarations and -Wmissing-prototypes are always enabled by default in scripts/Makefile.extrawarn. Signe

[PATCH 0/3] amd, i915, xe: drop redundant warnings from driver makefiles

2024-05-23 Thread Jani Nikula
I'm sending these together, as they're related, and almost identical, but I expect them to be merged individually to each driver. BR, Jani. Jani Nikula (3): drm/i915: drop redundant W=1 warnings from Makefile drm/xe: drop redundant W=1 warnings from Makefile drm/amdgpu: drop redundant W=1 w

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:05PM +0300, Imre Deak wrote: > Recheck the link state after a passing link training, with a 2 sec delay > to account for cases where the link goes bad following the link training > and the sink doesn't report this via an HPD IRQ. > > The delayed work added here will b

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 04:23:44PM +0300, Ville Syrjälä wrote: > On Wed, May 22, 2024 at 04:38:54PM +0300, Imre Deak wrote: > > On Mon, May 20, 2024 at 09:58:05PM +0300, Imre Deak wrote: > > > [...] > > > +static void intel_ddi_link_check_work_fn(struct work_struct *work) > > > +{ > > > + struct in

Re: [PATCH v2 06/21] drm/i915/dp: Use a commit modeset for link retraining MST links

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 03:58:30PM +0300, Ville Syrjälä wrote: > On Mon, May 20, 2024 at 09:58:04PM +0300, Imre Deak wrote: > > Instead of direct calls to the link train functions, retrain the link > > via a commit modeset. The direct call means that the output port will be > > disabled/re-enabled

Re: [PATCH v2 07/21] drm/i915/dp: Recheck link state after modeset

2024-05-23 Thread Ville Syrjälä
On Wed, May 22, 2024 at 04:38:54PM +0300, Imre Deak wrote: > On Mon, May 20, 2024 at 09:58:05PM +0300, Imre Deak wrote: > > [...] > > +static void intel_ddi_link_check_work_fn(struct work_struct *work) > > +{ > > + struct intel_digital_port *dig_port = > > + container_of(work, typeof(*d

Re: [PATCH 16/16] drm/i915: pass dev_priv explicitly to PIPEGCMAX

2024-05-23 Thread Jani Nikula
On Thu, 23 May 2024, Ville Syrjälä wrote: > On Thu, May 23, 2024 at 03:59:44PM +0300, Jani Nikula wrote: >> Avoid the implicit dev_priv local variable use, and pass dev_priv >> explicitly to the PIPEGCMAX register macro. >> >> Signed-off-by: Jani Nikula >> --- >> drivers/gpu/drm/i915/display/in

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

2024-05-23 Thread Tvrtko Ursulin
On 23/05/2024 13:24, Ville Syrjälä wrote: On Thu, May 23, 2024 at 01:07:24PM +0100, Tvrtko Ursulin wrote: On 23/05/2024 12:19, Ville Syrjälä wrote: On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote: On 22/05/2024 16:29, Vidya Srinivas wrote: In some scenarios, the DPT object

Re: [PATCH 16/16] drm/i915: pass dev_priv explicitly to PIPEGCMAX

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 03:59:44PM +0300, Jani Nikula wrote: > Avoid the implicit dev_priv local variable use, and pass dev_priv > explicitly to the PIPEGCMAX register macro. > > Signed-off-by: Jani Nikula > --- > drivers/gpu/drm/i915/display/intel_color.c | 13 +++-- > drivers/gpu/

Re: [RESEND 0/6] drm, nouveau/radeon/amdpgu: edid_blob_ptr cleanups

2024-05-23 Thread Jani Nikula
On Mon, 13 May 2024, Alex Deucher wrote: > On Mon, May 13, 2024 at 8:20 AM Jani Nikula wrote: >> >> On Fri, 10 May 2024, Alex Deucher wrote: >> > On Fri, May 10, 2024 at 11:17 AM Jani Nikula wrote: >> > Series is: >> > Acked-by: Alex Deucher >> >> Thanks, do you want to pick these up via your

[PATCH 14/16] drm/i915: pass dev_priv explicitly to PRIMSIZE

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PRIMSIZE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletion

[PATCH 06/16] drm/i915: pass dev_priv explicitly to DSPPOS

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPPOS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/intel_gvt_mmio_table.c|

[PATCH 05/16] drm/i915: pass dev_priv explicitly to DSPSTRIDE

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPSTRIDE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++-- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/gvt/cmd_parser.c

[PATCH 13/16] drm/i915: pass dev_priv explicitly to PRIMPOS

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PRIMPOS register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions

[PATCH 15/16] drm/i915: pass dev_priv explicitly to PRIMCNSTALPHA

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PRIMCNSTALPHA register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 3 ++- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 4 ++-- 2 files changed, 4 insertions(+), 3 de

[PATCH 16/16] drm/i915: pass dev_priv explicitly to PIPEGCMAX

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the PIPEGCMAX register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/intel_color.c | 13 +++-- drivers/gpu/drm/i915/display/intel_color_regs.h | 6 +++--- 2 files changed, 10 insert

[PATCH 07/16] drm/i915: pass dev_priv explicitly to DSPSIZE

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPSIZE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/intel_gvt_mmio_table.c

[PATCH 10/16] drm/i915: pass dev_priv explicitly to DSPOFFSET

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPOFFSET register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 5 +++-- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/intel_gvt_mmio_table.

[PATCH 08/16] drm/i915: pass dev_priv explicitly to DSPSURF

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPSURF register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 12 ++-- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/display/intel_

[PATCH 12/16] drm/i915: pass dev_priv explicitly to DSPGAMC

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPGAMC register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/i9xx_plane_re

[PATCH 11/16] drm/i915: pass dev_priv explicitly to DSPSURFLIVE

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPSURFLIVE register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/gvt/handlers.c| 4 ++-- drivers/gpu/drm/i915/intel_gvt_mmio_table

[PATCH 09/16] drm/i915: pass dev_priv explicitly to DSPTILEOFF

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPTILEOFF register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++-- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/gvt/fb_decoder.c

[PATCH 04/16] drm/i915: pass dev_priv explicitly to DSPLINOFF

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPLINOFF register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 4 ++-- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- 2 files changed, 3 insertions(+), 3 deletio

[PATCH 03/16] drm/i915: pass dev_priv explicitly to DSPADDR

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPADDR register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 8 drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/display/intel_fbc.c

[PATCH 02/16] drm/i915: pass dev_priv explicitly to DSPCNTR

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPCNTR register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 10 +- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- drivers/gpu/drm/i915/display/intel_co

[PATCH 01/16] drm/i915: pass dev_priv explicitly to DSPADDR_VLV

2024-05-23 Thread Jani Nikula
Avoid the implicit dev_priv local variable use, and pass dev_priv explicitly to the DSPADDR_VLV register macro. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/display/i9xx_plane.c | 2 +- drivers/gpu/drm/i915/display/i9xx_plane_regs.h | 2 +- 2 files changed, 2 insertions(+), 2 deletio

[PATCH 00/16] drm/i915: dev_priv fixes for i9xx_plane_regs.h/intel_color_regs.h

2024-05-23 Thread Jani Nikula
Pass dev_priv explicitly in i9xx_plane_regs.h/intel_color_regs.h. The main changes are scripted, with some manual indentation cleanups on top. BR, Jani. Jani Nikula (16): drm/i915: pass dev_priv explicitly to DSPADDR_VLV drm/i915: pass dev_priv explicitly to DSPCNTR drm/i915: pass dev_priv

Re: [PATCH v2 06/21] drm/i915/dp: Use a commit modeset for link retraining MST links

2024-05-23 Thread Ville Syrjälä
On Mon, May 20, 2024 at 09:58:04PM +0300, Imre Deak wrote: > Instead of direct calls to the link train functions, retrain the link > via a commit modeset. The direct call means that the output port will be > disabled/re-enabled while the rest of the pipeline (transcoder) is > active, which doesn't

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 01:07:24PM +0100, Tvrtko Ursulin wrote: > > On 23/05/2024 12:19, Ville Syrjälä wrote: > > On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote: > >> > >> On 22/05/2024 16:29, Vidya Srinivas wrote: > >>> In some scenarios, the DPT object gets shrunk but > >>> the a

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

2024-05-23 Thread Tvrtko Ursulin
On 23/05/2024 12:19, Ville Syrjälä wrote: On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote: On 22/05/2024 16:29, Vidya Srinivas wrote: In some scenarios, the DPT object gets shrunk but the actual framebuffer did not and thus its still there on the DPT's vm->bound_list. Then it

Re: [PATCH 06/13] drm/i915: Define SEL_FETCH_PLANE registers via PICK_EVEN_2RANGES()

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 12:15:53PM +0300, Jani Nikula wrote: > On Thu, 16 May 2024, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Instead of that huge _PICK() let's use PICK_EVEN_2RANGES() > > for the SEL_FETCH_PLANE registers. A bit more tedious to have > > to define 8 raw register offset

Re: [PATCH v8 7/7] drm/i915/display: Compute vrr vsync params

2024-05-23 Thread Nautiyal, Ankit K
On 5/9/2024 1:28 PM, Mitul Golani wrote: Compute vrr vsync params in case of FAVT as well instead of only to AVT mode of operation. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_vrr.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/gpu/drm/i915/dis

Re: [PATCH v8 5/7] drm/i915/display: Add support for pack and unpack

2024-05-23 Thread Nautiyal, Ankit K
On 5/9/2024 1:28 PM, Mitul Golani wrote: Add support of pack and unpack for target_rr_divider. Signed-off-by: Mitul Golani --- drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gp

Re: [PATCH v8 3/7] drm/i915: Compute CMRR and calculate vtotal

2024-05-23 Thread Nautiyal, Ankit K
On 5/9/2024 1:28 PM, Mitul Golani wrote: Compute Fixed Average Vtotal/CMRR with resepect to userspace VRR enablement. Also calculate required parameters in case of CMRR is enabled. During intel_vrr_compute_config, CMRR is getting enabled based on userspace has enabled Adaptive Sync Vtotal mode

Re: [PATCH] drm/i915/dpt: Make DPT object unshrinkable

2024-05-23 Thread Ville Syrjälä
On Thu, May 23, 2024 at 09:25:45AM +0100, Tvrtko Ursulin wrote: > > On 22/05/2024 16:29, Vidya Srinivas wrote: > > In some scenarios, the DPT object gets shrunk but > > the actual framebuffer did not and thus its still > > there on the DPT's vm->bound_list. Then it tries to > > rewrite the PTEs vi

Re: [PATCH] drm/i915: Fix audio component initialization

2024-05-23 Thread Imre Deak
On Thu, May 23, 2024 at 12:41:32PM +0300, Jani Nikula wrote: > On Tue, 21 May 2024, Imre Deak wrote: > > After registering the audio component in i915_audio_component_init() > > the audio driver may call i915_audio_component_get_power() via the > > component ops. This could program AUD_FREQ_CNTRL

RE: [RESEND 6/6] drm/connector: update edid_blob_ptr documentation

2024-05-23 Thread Borah, Chaitanya Kumar
> -Original Message- > From: dri-devel On Behalf Of Jani > Nikula > Sent: Friday, May 10, 2024 8:38 PM > To: dri-de...@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org; nouv...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; Nikula, Jani > Subject: [RESEND 6/6] drm/co

RE: [RESEND 5/6] drm/edid: add a helper for EDID sysfs property show

2024-05-23 Thread Borah, Chaitanya Kumar
> -Original Message- > From: dri-devel On Behalf Of Jani > Nikula > Sent: Friday, May 10, 2024 8:38 PM > To: dri-de...@lists.freedesktop.org > Cc: amd-...@lists.freedesktop.org; nouv...@lists.freedesktop.org; intel- > g...@lists.freedesktop.org; Nikula, Jani > Subject: [RESEND 5/6] drm/ed

Re: [PATCH v2 1/6] drm/ci: uprev mesa version

2024-05-23 Thread Dmitry Baryshkov
On Thu, 23 May 2024 at 09:07, Vignesh Raman wrote: > > Hi Dmitry, > > On 20/05/24 16:13, Dmitry Baryshkov wrote: > > On Fri, May 17, 2024 at 02:54:57PM +0530, Vignesh Raman wrote: > >> zlib.net is not allowing tarball download anymore and results > >> in below error in kernel+rootfs_arm32 containe

  1   2   >