Re: [PATCH] drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-22 Thread Hogander, Jouni
On Tue, 2024-01-23 at 09:41 +0200, Ville Syrjälä wrote: > On Tue, Jan 23, 2024 at 09:11:03AM +0200, Jouni Högander wrote: > > We want to request full modeset in initial fast check to force PSR > > state > > computation. Otherwise PSR is not enabled on initial commit but on > > first > > commit with

✗ Fi.CI.CHECKPATCH: warning for drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915/psr: Request modeset on initial commit to compute PSR state URL : https://patchwork.freedesktop.org/series/129068/ State : warning == Summary == Error: dim checkpatch failed 82ba3b886668 drm/i915/psr: Request modeset on initial commit to compute PSR state

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Sakari Ailus
Hi Rafael, Björn, Thanks for the review. On Mon, Jan 22, 2024 at 07:16:54PM +0100, Rafael J. Wysocki wrote: > On Mon, Jan 22, 2024 at 7:12 PM Bjorn Helgaas wrote: > > > > On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > > > There are two ways to opportunistically increment a devic

Re: [PATCH] drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-22 Thread Ville Syrjälä
On Tue, Jan 23, 2024 at 09:11:03AM +0200, Jouni Högander wrote: > We want to request full modeset in initial fast check to force PSR state > computation. Otherwise PSR is not enabled on initial commit but on first > commit with modeset or fastset. With this change Initial commit will still > end up

[PATCH] drm/i915/psr: Request modeset on initial commit to compute PSR state

2024-01-22 Thread Jouni Högander
We want to request full modeset in initial fast check to force PSR state computation. Otherwise PSR is not enabled on initial commit but on first commit with modeset or fastset. With this change Initial commit will still end up using fastset (unless something else requires full modeset) as PSR para

[PATCH 49/82] drm/i915: Refactor intentional wrap-around test

2024-01-22 Thread Kees Cook
In an effort to separate intentional arithmetic wrap-around from unexpected wrap-around, we need to refactor places that depend on this kind of math. One of the most common code patterns of this is: VAR + value < VAR Notably, this is considered "undefined behavior" for signed and pointer

✗ Fi.CI.BAT: failure for drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race URL : https://patchwork.freedesktop.org/series/129026/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14159 -> Patchwork_129026v1 Summary

Re: [PATCH v4 2/3] Manually revert "drm/i915: Fix a VMA UAF for multi-gt platform"

2024-01-22 Thread Rodrigo Vivi
On Mon, Jan 22, 2024 at 03:04:43PM +0100, Janusz Krzysztofik wrote: > This reverts changes introduced by commit f56fe3e91787, obsoleted by > "drm/i915/vma: Fix UAF on destroy against retire race". I believe the good chunk of the first commit message should be moved here instead. But why did you d

Re: [PATCH v4 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-22 Thread Rodrigo Vivi
On Mon, Jan 22, 2024 at 03:04:42PM +0100, Janusz Krzysztofik wrote: > Object debugging tools were sporadically reporting illegal attempts to > free a still active i915 VMA object when parking a GPU tile believed to be > idle. > > [161.359441] ODEBUG: free active (active state 0) object: 888116

✗ Fi.CI.SPARSE: warning for drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: Fix VMA UAF on destroy against deactivate race

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Fix VMA UAF on destroy against deactivate race URL : https://patchwork.freedesktop.org/series/129026/ State : warning == Summary == Error: dim checkpatch failed 55cc6a52bd6b drm/i915/vma: Fix UAF on destroy against retire race 90d6c8b0ef9a Manually revert

Re: [PATCH] drm/i915/gt: Reflect the true and current status of rc6_enable

2024-01-22 Thread Rodrigo Vivi
On Tue, Jan 16, 2024 at 09:29:19AM -0800, Juan Escamilla wrote: > The sysfs file is named 'enabled', thus users might want to know the > true state of the RC6 instead of only the indication if the RC6 > should be enabled. > > Let's use rc6.enable directly instead of rc6.supported. For a moment I

Re: [PATCH 3/4] drm/xe/xe2: Limit ccs framebuffers to tile4 only

2024-01-22 Thread Juha-Pekka Heikkila
On 19.1.2024 17.22, Matthew Auld wrote: On 18/01/2024 15:27, Juha-Pekka Heikkila wrote: Display engine support ccs only with tile4, prevent other modifiers from using compressed memory. Signed-off-by: Juha-Pekka Heikkila ---   drivers/gpu/drm/xe/display/xe_fb_pin.c | 17 +   1 f

Re: [PATCH 2/4] drm/xe: store bind time pat index to xe_bo

2024-01-22 Thread Juha-Pekka Heikkila
Hi Matthew, thanks for looking into these. Below few thoughts. On 19.1.2024 17.45, Matthew Auld wrote: On 18/01/2024 15:27, Juha-Pekka Heikkila wrote: Store pat index from xe_vma to xe_bo Signed-off-by: Juha-Pekka Heikkila ---   drivers/gpu/drm/xe/xe_pt.c | 4   1 file changed, 4 insertio

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Rafael J. Wysocki
On Mon, Jan 22, 2024 at 7:12 PM Bjorn Helgaas wrote: > > On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > > There are two ways to opportunistically increment a device's runtime PM > > usage count, calling either pm_runtime_get_if_active() or > > pm_runtime_get_if_in_use(). The forme

Re: [PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Bjorn Helgaas
On Mon, Jan 22, 2024 at 01:41:21PM +0200, Sakari Ailus wrote: > There are two ways to opportunistically increment a device's runtime PM > usage count, calling either pm_runtime_get_if_active() or > pm_runtime_get_if_in_use(). The former has an argument to tell whether to > ignore the usage count or

Re: linux-next: build warning after merge of the drm-intel tree

2024-01-22 Thread Jani Nikula
On Mon, 22 Jan 2024, Stephen Rothwell wrote: >> [1] >> https://patchwork.freedesktop.org/patch/msgid/20231114081033.27343-1-bagasdo...@gmail.com > > This is still not fixed. Thanks for the reminder. Commit 1a84c213146a ("drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() co

Re: [PATCH] drm/dp_mst: Separate @failing_port list in drm_dp_mst_atomic_check_mgr() comment

2024-01-22 Thread Jani Nikula
On Tue, 14 Nov 2023, Bagas Sanjaya wrote: > Stephen Rothwell reported htmldocs warnings when merging drm-intel > tree: > > Documentation/gpu/drm-kms-helpers:296: > drivers/gpu/drm/display/drm_dp_mst_topology.c:5484: ERROR: Unexpected > indentation. > Documentation/gpu/drm-kms-helpers:296: > dri

Re: ✗ Fi.CI.IGT: failure for drm/i915: Cursor vblank evasion (rev4)

2024-01-22 Thread Ville Syrjälä
On Mon, Jan 22, 2024 at 03:03:03PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Cursor vblank evasion (rev4) > URL : https://patchwork.freedesktop.org/series/127744/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_14153_full -> Patchwork_127744v

RE: [PATCH v3 16/16] drm/i915: Annotate more of the BIOS fb takeover failure paths

2024-01-22 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, January 16, 2024 1:27 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v3 16/16] drm/i915: Annotate more of the BIOS fb takeover > failure paths > > From: Ville Syrjälä > > Annotate a few mo

RE: [PATCH v3 08/16] drm/i915: Fix region start during initial plane readout

2024-01-22 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, January 16, 2024 1:26 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v3 08/16] drm/i915: Fix region start during initial plane > readout > > From: Ville Syrjälä > > On MTL the stolen regi

RE: [PATCH v3 09/16] drm/i915: Fix MTL initial plane readout

2024-01-22 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Tuesday, January 16, 2024 1:26 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH v3 09/16] drm/i915: Fix MTL initial plane readout > > From: Ville Syrjälä > > MTL stolen memory looks more like local m

Re: Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2024-01-22 Thread Yury Norov
On Thu, Jan 18, 2024 at 02:42:12PM -0600, Lucas De Marchi wrote: > Hi, > > Reviving this thread as now with xe driver merged we have 2 users for > a fixed-width BIT/GENMASK. Can you point where and why? > On Wed, Jun 21, 2023 at 07:20:59PM -0700, Yury Norov wrote: > > Hi Lucas, all! > > > > (T

Re: Re: Re: [Intel-xe] [PATCH 2/3] linux/bits.h: Add fixed-width GENMASK and BIT macros

2024-01-22 Thread Yury Norov
On Thu, Jan 18, 2024 at 05:25:00PM -0600, Lucas De Marchi wrote: > SA2PR11MB4874 > X-OriginatorOrg: intel.com > Status: RO > Content-Length: 6257 > Lines: 150 > > On Thu, Jan 18, 2024 at 01:48:43PM -0800, Yury Norov wrote: > > On Thu, Jan 18, 2024 at 02:42:12PM -0600, Lucas De Marchi wrote: > > >

[PATCH v4 3/3] Revert "drm/i915: Wait for active retire before i915_active_fini()"

2024-01-22 Thread Janusz Krzysztofik
This reverts commit 7a2280e8dcd2f1f436db9631287c0b21cf6a92b0, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/i915_vma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/

[PATCH v4 2/3] Manually revert "drm/i915: Fix a VMA UAF for multi-gt platform"

2024-01-22 Thread Janusz Krzysztofik
This reverts changes introduced by commit f56fe3e91787, obsoleted by "drm/i915/vma: Fix UAF on destroy against retire race". Signed-off-by: Janusz Krzysztofik --- drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c | 17 - 1 file changed, 17 deletions(-) diff --git a/drivers/gpu/drm/

[PATCH v4 1/3] drm/i915/vma: Fix UAF on destroy against retire race

2024-01-22 Thread Janusz Krzysztofik
Object debugging tools were sporadically reporting illegal attempts to free a still active i915 VMA object when parking a GPU tile believed to be idle. [161.359441] ODEBUG: free active (active state 0) object: 88811643b958 object type: i915_active hint: __i915_vma_active+0x0/0x50 [i915] [161.

✓ Fi.CI.BAT: success for drm/i915: Cursor vblank evasion (rev4)

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Cursor vblank evasion (rev4) URL : https://patchwork.freedesktop.org/series/127744/ State : success == Summary == CI Bug Log - changes from CI_DRM_14153 -> Patchwork_127744v4 Summary --- **SUCCE

✗ Fi.CI.SPARSE: warning for drm/i915: Cursor vblank evasion (rev4)

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915: Cursor vblank evasion (rev4) URL : https://patchwork.freedesktop.org/series/127744/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116

[PATCH v3 1/2] pm: runtime: Simplify pm_runtime_get_if_active() usage

2024-01-22 Thread Sakari Ailus
There are two ways to opportunistically increment a device's runtime PM usage count, calling either pm_runtime_get_if_active() or pm_runtime_get_if_in_use(). The former has an argument to tell whether to ignore the usage count or not, and the latter simply calls the former with ign_usage_count set

[PATCH v3 0/2] Small runtime PM API changes

2024-01-22 Thread Sakari Ailus
Hi folks, Here's a small but a different set of patches for making two relatively minor changes to runtime PM API. I restarted version numbering as this is meaningfully different from the previous set. pm_runtime_get_if_active() loses its second argument as it only made sense to have ign_usage_co

✓ Fi.CI.BAT: success for drm/i915/display: Move display params to i915_display_capabilities

2024-01-22 Thread Patchwork
== Series Details == Series: drm/i915/display: Move display params to i915_display_capabilities URL : https://patchwork.freedesktop.org/series/129011/ State : success == Summary == CI Bug Log - changes from CI_DRM_14153 -> Patchwork_129011v1

Re: [PATCH] drm/i915/display: Move display params to i915_display_capabilities

2024-01-22 Thread Jani Nikula
On Mon, 22 Jan 2024, Bhanuprakash Modem wrote: > Instead of mixing display & non-display stuff together, move > display parameters i915_display_capabilities debugfs. This patch > will also drops unnecessary locking. The locking removal could've been a separate patch. *shrug* Reviewed-by: Jani Ni

Re: [PATCH] mm: Remove double faults once write a device pfn

2024-01-22 Thread Christian König
Am 22.01.24 um 04:32 schrieb Xianrong Zhou: The vmf_insert_pfn_prot could cause unnecessary double faults on a device pfn. Because currently the vmf_insert_pfn_prot does not make the pfn writable so the pte entry is normally read-only or dirty catching. What? How do you got to this conclusion?

RE: [PATCH] drm/i915: Try to preserve the current shared_dpll for fastset on type-c ports

2024-01-22 Thread Kandpal, Suraj
> Subject: [PATCH] drm/i915: Try to preserve the current shared_dpll for fastset > on type-c ports > > From: Ville Syrjälä > > Currently icl_compute_tc_phy_dplls() assumes that the active PLL will be the > TC PLL (as opposed to the TBT PLL). The actual PLL will be selected during the > modeset e