[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/mtl: Disable MC6 for MTL A step (rev2)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/mtl: Disable MC6 for MTL A step (rev2) URL : https://patchwork.freedesktop.org/series/114833/ State : success == Summary == CI Bug Log - changes from CI_DRM_12835 -> Patchwork_114833v2 Summary ---

[Intel-gfx] [PATCH v2 1/1] drm/i915/mtl: Disable MC6 for MTL A step

2023-03-09 Thread Badal Nilawar
The Wa_14017073508 require to send Media Busy/Idle mailbox while accessing Media tile. As of now it is getting handled while __gt_unpark, __gt_park. But there are various corner cases where forcewakes are taken without __gt_unpark i.e. without sending Busy Mailbox especially during register reads.

[Intel-gfx] [PATCH v2 0/1] drm/i915/mtl: Disable MC6 for MTL A step

2023-03-09 Thread Badal Nilawar
Disabling MC6 for A step as it is not feasible to extend Wa_14017073508 in forcewake path to cover all corner cases. Reverting the commit 8f70f1ec587da. v2 - Combined patch1 and patch2 from rev1 Badal Nilawar (1): drm/i915/mtl: Disable MC6 for MTL A step drivers/gpu/drm/i915/gt/intel_gt

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/mtl: Fix Wa_16015201720 implementation

2023-03-09 Thread Sripada, Radhakrishna
Sure Andi. Will be more cautious. Radhakrishna Sripada > -Original Message- > From: Andi Shyti > Sent: Thursday, March 9, 2023 3:09 PM > To: Sripada, Radhakrishna > Cc: Andi Shyti ; intel-gfx@lists.freedesktop.org; > De > Marchi, Lucas ; Roper, Matthew D > > Subject: Re: [Intel-gfx] [

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-09 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Friday, March 10, 2023 1:31 PM > > > From: Yi Liu > > Sent: Wednesday, March 8, 2023 9:29 PM > > > > This is another method to issue PCI hot reset for the users that bounds > > device to a positive iommufd value. In such case, iommufd is a proof of > > device ownership

Re: [Intel-gfx] [PATCH v6 02/10] drm/hdcp: Avoid changing crtc state in hdcp atomic check

2023-03-09 Thread Kandpal, Suraj
> -Original Message- > From: Intel-gfx On Behalf Of Mark > Yacoub > Sent: Thursday, January 19, 2023 1:00 AM > To: quic_khs...@quicinc.com; linux-arm-...@vger.kernel.org; dri- > de...@lists.freedesktop.org; freedr...@lists.freedesktop.org; > devicet...@vger.kernel.org; linux-ker...@vger

Re: [Intel-gfx] [PATCH v5 16/19] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-03-09 Thread Liu, Yi L
> From: Alexey Kardashevskiy > Sent: Friday, March 10, 2023 10:39 AM > > On 27/2/23 22:11, Yi Liu wrote: > > This adds ioctl for userspace to bind device cdev fd to iommufd. > > > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain > DMA > > control pr

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Rename GuC log relay debugfs descriptively

2023-03-09 Thread Teres Alexis, Alan Previn
> > > -static int guc_log_relay_open(struct inode *inode, struct file *file) > > > +static int guc_log_relay_ctl_open(struct inode *inode, struct file *file) > > > > Again not objecting, but what is the purpose/thinking behind adding _ctl_ > > to these function names? The previous names seemed fin

Re: [Intel-gfx] [PATCH v6 11/24] vfio/pci: Accept device fd in VFIO_DEVICE_PCI_HOT_RESET ioctl

2023-03-09 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Friday, March 10, 2023 1:08 PM > > > From: Liu, Yi L > > Sent: Wednesday, March 8, 2023 9:29 PM > > > > @@ -1319,8 +1319,14 @@ static int vfio_pci_ioctl_pci_hot_reset(struct > > vfio_pci_core_device *vdev, > > break; > > } > > > > -

Re: [Intel-gfx] [PATCH v6 12/24] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-03-09 Thread Tian, Kevin
> From: Yi Liu > Sent: Wednesday, March 8, 2023 9:29 PM > > This is another method to issue PCI hot reset for the users that bounds > device to a positive iommufd value. In such case, iommufd is a proof of > device ownership. By passing a zero-length fd array, user indicates kernel > to do ownersh

Re: [Intel-gfx] [PATCH v6 01/10] drm/hdcp: Add drm_hdcp_atomic_check()

2023-03-09 Thread Kandpal, Suraj
> > From: Sean Paul > > This patch moves the hdcp atomic check from i915 to drm_hdcp so other > drivers can use it. No functional changes, just cleaned up some of the code > when moving it over. > > Acked-by: Jani Nikula > Acked-by: Jani Nikula > Reviewed-by: Rodrigo Vivi > Reviewed-by: Abhi

Re: [Intel-gfx] [PATCH v6 11/24] vfio/pci: Accept device fd in VFIO_DEVICE_PCI_HOT_RESET ioctl

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:29 PM > > @@ -1319,8 +1319,14 @@ static int vfio_pci_ioctl_pci_hot_reset(struct > vfio_pci_core_device *vdev, > break; > } > > - /* Ensure the FD is a vfio group FD.*/ > - if (!vfio_f

Re: [Intel-gfx] [PATCH v6 10/24] vfio/pci: Rename the helpers and data in hot reset path to accept device fd

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:29 PM > > No function change is intended, just to make the helpers and structures > to be prepared to accept device fds as proof of device ownership. > > Signed-off-by: Yi Liu > --- > drivers/vfio/pci/vfio_pci_core.c | 40 ---

Re: [Intel-gfx] [PATCH v6 09/24] vfio/pci: Only need to check opened devices in the dev_set for hot reset

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:29 PM > > @@ -2429,10 +2429,23 @@ static int vfio_pci_dev_set_hot_reset(struct > vfio_device_set *dev_set, > > list_for_each_entry(cur_vma, &dev_set->device_list, > vdev.dev_set_list) { > /* > - * Test whether a

Re: [Intel-gfx] [PATCH v6 07/24] vfio: Block device access via device fd until device is opened

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:29 PM > > @@ -1114,6 +1114,10 @@ static long vfio_device_fops_unl_ioctl(struct file > *filep, > struct vfio_device *device = df->device; > int ret; > > + /* Paired with smp_store_release() in vfio_device_group_open() */ > +

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Ensure DSC has enough BW and stays within HW limits (rev3)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915: Ensure DSC has enough BW and stays within HW limits (rev3) URL : https://patchwork.freedesktop.org/series/114679/ State : success == Summary == CI Bug Log - changes from CI_DRM_12827_full -> Patchwork_114679v3_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/pmu: Use common freq functions with sysfs

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use common freq functions with sysfs URL : https://patchwork.freedesktop.org/series/114942/ State : success == Summary == CI Bug Log - changes from CI_DRM_12834 -> Patchwork_114942v1 Summary --

Re: [Intel-gfx] [PATCH v1 5/5] vfio: Check the presence for iommufd callbacks in __vfio_register_dev()

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:14 PM > > After making the no-DMA drivers (samples/vfio-mdev) providing iommufd > callbacks, __vfio_register_dev() should check the presence of the iommufd > callbacks if CONFIG_IOMMUFD is enabled. > > Signed-off-by: Yi Liu > --- > drivers/v

Re: [Intel-gfx] [PATCH v1 4/5] Samples/mdev: Uses the vfio emulated iommufd ops set in the mdev sample drivers

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:14 PM > > @@ -32,12 +32,8 @@ int vfio_iommufd_bind(struct vfio_device *vdev, > struct iommufd_ctx *ictx) > return 0; > } > > - /* > - * If the driver doesn't provide this op then it means the device does > - *

Re: [Intel-gfx] [PATCH v1 3/5] vfio-iommufd: Make vfio_iommufd_emulated_bind() return iommufd_access ID

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:14 PM > > vfio device cdev needs to return iommufd_access ID to userspace if > bind_iommufd succeeds. > > Signed-off-by: Yi Liu Reviewed-by: Kevin Tian

Re: [Intel-gfx] [PATCH v1 1/5] iommufd: Create access in vfio_iommufd_emulated_bind()

2023-03-09 Thread Tian, Kevin
> From: Liu, Yi L > Sent: Wednesday, March 8, 2023 9:14 PM > > @@ -449,33 +450,18 @@ iommufd_access_create(struct iommufd_ctx *ictx, > u32 ioas_id, > access->data = data; > access->ops = ops; > > - obj = iommufd_get_object(ictx, ioas_id, IOMMUFD_OBJ_IOAS); > - if (IS_ERR(obj))

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-09 Thread Dixit, Ashutosh
On Thu, 09 Mar 2023 01:20:09 -0800, Tvrtko Ursulin wrote: > Hi Tvrtko, > On 09/03/2023 03:46, Ashutosh Dixit wrote: > > Expose intel_rps_read_actual_frequency_fw to read the actual freq without > > taking forcewake for use by PMU. The code is refactored to use a common set > > of functions across

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Remove fallback to requested freq for SLPC

2023-03-09 Thread Ashutosh Dixit
The fallback to requested freq does not work for SLPC because SLPC does not use 'struct intel_rps'. Also for SLPC requested freq can only be obtained from a hw register after acquiring forcewake which we don't want to do for PMU. Therefore remove fallback to requested freq for SLPC. The actual freq

[Intel-gfx] [PATCH 0/2] drm/i915/pmu: Use common freq functions with sysfs

2023-03-09 Thread Ashutosh Dixit
Expose intel_rps_read_actual_frequency_fw to read the actual freq without taking forcewake for use by PMU. The code is refactored to use a common set of functions across sysfs and PMU. Using common functions with sysfs in PMU solves the issues of missing support for MTL and missing support for olde

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-09 Thread Ashutosh Dixit
Expose intel_rps_read_actual_frequency_fw to read the actual freq without taking forcewake for use by PMU. The code is refactored to use a common set of functions across sysfs and PMU. Using common functions with sysfs in PMU solves the issues of missing support for MTL and missing support for olde

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for Fix a couple of issues with the GSC worker timing (rev2)

2023-03-09 Thread Ceraolo Spurio, Daniele
On 3/9/2023 9:32 AM, Patchwork wrote: Project List - Patchwork *Patch Details* *Series:* Fix a couple of issues with the GSC worker timing (rev2) *URL:* https://patchwork.freedesktop.org/series/114306/ *State:*failure *Details:* https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork

Re: [Intel-gfx] [PATCH v4 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-03-09 Thread Dixit, Ashutosh
On Thu, 09 Mar 2023 14:34:04 -0800, Umesh Nerlige Ramappa wrote: > Hi Umesh, > On Wed, Mar 08, 2023 at 10:08:13AM -0800, Dixit, Ashutosh wrote: > > On Tue, 07 Mar 2023 12:16:10 -0800, Umesh Nerlige Ramappa wrote: > >> > > > >> One or more engines map to a specific OA unit. All reports from these

Re: [Intel-gfx] [PATCH v4 9/9] drm/i915/perf: Add support for OA media units

2023-03-09 Thread Dixit, Ashutosh
On Tue, 07 Mar 2023 12:16:11 -0800, Umesh Nerlige Ramappa wrote: > Hi Umesh, > -static int gen8_configure_context(struct i915_gem_context *ctx, > +static int gen8_configure_context(struct i915_perf_stream *stream, > + struct i915_gem_context *ctx, >

Re: [Intel-gfx] [PATCH v2 5/5] drm/i915/guc: Move guc_log_relay_chan debugfs path to uc

2023-03-09 Thread Teres Alexis, Alan Previn
On Wed, 2022-12-07 at 09:24 -0800, Dixit, Ashutosh wrote: > On Tue, 06 Dec 2022 01:21:00 -0800, Alan Previn wrote: > > > > alan: snip > > intel_gt_debugfs_register_files(root, files, ARRAY_SIZE(files), uc); > > > > intel_guc_debugfs_register(&uc->guc, root); > > After moving the line a

Re: [Intel-gfx] [PATCH v2 4/5] drm/i915/guc: Rename GuC log relay debugfs descriptively

2023-03-09 Thread Teres Alexis, Alan Previn
Again, only now having time to relook at this. Will re-rev and reconnect with Ashutosh offline since I've been absent on this for too long. Thanks again Ashutosh for reviewing all these back in May. On Wed, 2022-12-07 at 08:50 -0800, Dixit, Ashutosh wrote: > On Tue, 06 Dec 2022 01:20:59 -0800, Al

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915/guc: Provide debugfs for log relay sub-buf info

2023-03-09 Thread Teres Alexis, Alan Previn
Finally got some time to relook at this series. Responses. I'll re-rev this and re-connect with Ashutosh offline considering how long i've been silent on this. On Wed, 2022-12-07 at 08:43 -0800, Dixit, Ashutosh wrote: > On Tue, 06 Dec 2022 01:20:58 -0800, Alan Previn wrote: > > > > diff --git a

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/mtl: Fix Wa_16015201720 implementation

2023-03-09 Thread Andi Shyti
Hi Radhakrishna, > Since most of the comments aligned with Matt's suggestion pushed with Matt's > r-b. OK, but next time, please hold on a bit as I might also have had disagreements on your answers or I want to see it tested again with the new changes. It's not the case as I would have r-b it a

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915/opregion: Fix opregion setup during system resume on platforms without display (rev3)

2023-03-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/opregion: Fix opregion setup during system resume on platforms without display (rev3) URL : https://patchwork.freedesktop.org/series/114866/ State : success == Summary == CI Bug Log - changes from CI_DRM_12832 -> Patchwork_11

Re: [Intel-gfx] [PATCH v4 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-03-09 Thread Umesh Nerlige Ramappa
On Tue, Mar 07, 2023 at 05:45:48PM -0800, Dixit, Ashutosh wrote: On Tue, 07 Mar 2023 12:16:10 -0800, Umesh Nerlige Ramappa wrote: Hi Umesh, + /* Defaults when class:instance is not passed */ + class = I915_ENGINE_CLASS_RENDER; + instance = 0; + for (i = 0; i < n_pr

Re: [Intel-gfx] [PATCH v4 8/9] drm/i915/perf: Add engine class instance parameters to perf

2023-03-09 Thread Umesh Nerlige Ramappa
On Wed, Mar 08, 2023 at 10:08:13AM -0800, Dixit, Ashutosh wrote: On Tue, 07 Mar 2023 12:16:10 -0800, Umesh Nerlige Ramappa wrote: Hi Umesh, One or more engines map to a specific OA unit. All reports from these engines are captured in the OA buffer managed by this OA unit. Current i915 OA i

Re: [Intel-gfx] [PATCH] drm/i915/mtl: Disable stolen memory backed FB for A0

2023-03-09 Thread Andi Shyti
Hi Nirmoy, On Thu, Mar 09, 2023 at 05:49:05PM +0100, Nirmoy Das wrote: > Stolen memory is not usable for MTL A0 stepping beyond > certain access size and we have no control over userspace > access size of /dev/fb which can be backed by stolen memory. > So disable stolen memory backed fb by setting

Re: [Intel-gfx] [PATCH] drm/i915/gt: Update engine_init_common documentation

2023-03-09 Thread Andi Shyti
Hi Nirmoy, On Thu, Mar 09, 2023 at 05:58:52PM +0100, Nirmoy Das wrote: > Change the function doc to reflect updated name. > > Cc: Andi Shyti > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/d

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/3] drm/i915/opregion: Fix opregion setup during system resume on platforms without display (rev3)

2023-03-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915/opregion: Fix opregion setup during system resume on platforms without display (rev3) URL : https://patchwork.freedesktop.org/series/114866/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast m

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display: Restore dsparb_lock.

2023-03-09 Thread Rodrigo Vivi
On Thu, Mar 09, 2023 at 12:03:19AM +0200, Ville Syrjälä wrote: > On Wed, Mar 08, 2023 at 11:58:58AM -0500, Rodrigo Vivi wrote: > > uncore->lock only protects the forcewake domain itself, > > not the register accesses. > > > > uncore's _fw alternatives are for cases where the domains > > are not ne

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/display: Restore dsparb_lock. (rev2)

2023-03-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/display: Restore dsparb_lock. (rev2) URL : https://patchwork.freedesktop.org/series/114868/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12832 -> Patchwork_114868v2 ==

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: prevent forcewake releases during BAR resize (rev5)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: prevent forcewake releases during BAR resize (rev5) URL : https://patchwork.freedesktop.org/series/114836/ State : success == Summary == CI Bug Log - changes from CI_DRM_12832 -> Patchwork_114836v5

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry

2023-03-09 Thread Dixit, Ashutosh
On Thu, 09 Mar 2023 11:48:41 -0800, Vinay Belgaumkar wrote: > > The entry for gt_idle_freq_mhz does not exist. > > Fixes: d1ea62b3f759 (igt: Add gem_ctx_freq to exercise requesting freq via > sysfs) Reviewed-by: Ashutosh Dixit > > Cc: Umesh Nerlige Ramappa > Signed-off-by: Vinay Belgaumkar >

[Intel-gfx] [PATCH i-g-t] gem_ctx_freq: Remove reference to non-existent sysfs entry

2023-03-09 Thread Vinay Belgaumkar
The entry for gt_idle_freq_mhz does not exist. Fixes: d1ea62b3f759 (igt: Add gem_ctx_freq to exercise requesting freq via sysfs) Cc: Umesh Nerlige Ramappa Signed-off-by: Vinay Belgaumkar --- tests/i915/gem_ctx_freq.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Update engine_init_common documentation

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: Update engine_init_common documentation URL : https://patchwork.freedesktop.org/series/114926/ State : success == Summary == CI Bug Log - changes from CI_DRM_12832 -> Patchwork_114926v1 Summary

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Load DMC on MTL (rev2)

2023-03-09 Thread Matt Roper
On Thu, Mar 09, 2023 at 03:41:35PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915/dmc: Load DMC on MTL (rev2) > URL : https://patchwork.freedesktop.org/series/114576/ > State : success > > == Summary == > > CI Bug Log - changes from CI_DRM_12827_full -> Patchwork_114576v2_

Re: [Intel-gfx] [PATCH] drm/i915/gt: Update engine_init_common documentation

2023-03-09 Thread Das, Nirmoy
On 3/9/2023 6:33 PM, Matt Roper wrote: On Thu, Mar 09, 2023 at 05:58:52PM +0100, Nirmoy Das wrote: Change the function doc to reflect updated name. Cc: Andi Shyti Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/pmu: Use common freq functions with sysfs

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/pmu: Use common freq functions with sysfs URL : https://patchwork.freedesktop.org/series/114814/ State : success == Summary == CI Bug Log - changes from CI_DRM_12827_full -> Patchwork_114814v1_full Summ

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/mtl: Fix Wa_16015201720 implementation

2023-03-09 Thread Sripada, Radhakrishna
Hi Andi, > -Original Message- > From: Andi Shyti > Sent: Thursday, March 9, 2023 8:30 AM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; De Marchi, Lucas > > Subject: Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/mtl: Fix Wa_16015201720 > implementation > > Hi Radhakrishna

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/fbdev: lock the fbdev obj before vma pin

2023-03-09 Thread Sripada, Radhakrishna
Thank you for the Review. Pushed. -Radhakrishna Sripada > -Original Message- > From: Andi Shyti > Sent: Thursday, March 9, 2023 9:18 AM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; Auld, Matthew ; > Wilson, Chris P > Subject: Re: [Intel-gfx] [PATCH v3 4/5] drm/i91

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/display/mtl: Program latch to phy reset

2023-03-09 Thread Sripada, Radhakrishna
Thank you for the Review. Pushed. -Radhakrishna Sripada > -Original Message- > From: Andi Shyti > Sent: Thursday, March 9, 2023 9:29 AM > To: Sripada, Radhakrishna > Cc: intel-gfx@lists.freedesktop.org; Roper, Matthew D > > Subject: Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/display/mtl:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: disable sampler indirect state in bindless heap

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915: disable sampler indirect state in bindless heap URL : https://patchwork.freedesktop.org/series/114920/ State : success == Summary == CI Bug Log - changes from CI_DRM_12831 -> Patchwork_114920v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915/gt: Update engine_init_common documentation

2023-03-09 Thread Matt Roper
On Thu, Mar 09, 2023 at 05:58:52PM +0100, Nirmoy Das wrote: > Change the function doc to reflect updated name. > > Cc: Andi Shyti > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/d

[Intel-gfx] ✗ Fi.CI.IGT: failure for Fix a couple of issues with the GSC worker timing (rev2)

2023-03-09 Thread Patchwork
== Series Details == Series: Fix a couple of issues with the GSC worker timing (rev2) URL : https://patchwork.freedesktop.org/series/114306/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12827_full -> Patchwork_114306v2_full

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/display/mtl: Program latch to phy reset

2023-03-09 Thread Andi Shyti
Hi, On Wed, Mar 01, 2023 at 12:10:53PM -0800, Radhakrishna Sripada wrote: > From: José Roberto de Souza > > Latch reset of phys during DC9 and when driver is unloaded to avoid > phy reset. > > Specification ask us to program it closer to the step that enables > DC9 in DC_STATE_EN but doing this

Re: [Intel-gfx] [PATCH v3 4/5] drm/i915/fbdev: lock the fbdev obj before vma pin

2023-03-09 Thread Andi Shyti
Hi Radhakrishna, On Wed, Mar 01, 2023 at 12:10:52PM -0800, Radhakrishna Sripada wrote: > From: Tejas Upadhyay > > lock the fbdev obj before calling into > i915_vma_pin_iomap(). This helps to solve below : > > <7>[ 93.563308] i915 :00:02.0: [drm:intelfb_create [i915]] no BIOS fb, > alloca

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: disable sampler indirect state in bindless heap

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915: disable sampler indirect state in bindless heap URL : https://patchwork.freedesktop.org/series/114920/ State : warning == Summary == Error: dim checkpatch failed e4889ef6bb9b drm/i915: disable sampler indirect state in bindless heap -:14: WARNING:TYPO_SPE

[Intel-gfx] [PATCH] drm/i915/gt: Update engine_init_common documentation

2023-03-09 Thread Nirmoy Das
Change the function doc to reflect updated name. Cc: Andi Shyti Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gt/intel_engine_cs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/gt/intel_engine_cs.c b/drivers/gpu/drm/i915/gt/intel_engine_cs.c inde

[Intel-gfx] [PATCH] drm/i915/mtl: Disable stolen memory backed FB for A0

2023-03-09 Thread Nirmoy Das
Stolen memory is not usable for MTL A0 stepping beyond certain access size and we have no control over userspace access size of /dev/fb which can be backed by stolen memory. So disable stolen memory backed fb by setting i915->dsm.usable_size to zero. Cc: Matthew Auld Cc: Andi Shyti Cc: Daniele C

Re: [Intel-gfx] [PATCH 3/7] drm/i915/hwmon: Power PL1 limit and TDP setting

2023-03-09 Thread Guenter Roeck
On Tue, Feb 28, 2023 at 01:18:55PM -0800, Dixit, Ashutosh wrote: > On Fri, 12 Aug 2022 11:06:58 -0700, Guenter Roeck wrote: > > > > Hi Guenter/linux-hwmon, > > > > On 8/12/22 10:37, Badal Nilawar wrote: > > > From: Dale B Stimson > > > > > > Use i915 HWMON to display/modify dGfx power PL1 limit

Re: [Intel-gfx] [PATCH v3 1/5] drm/i915/mtl: Fix Wa_16015201720 implementation

2023-03-09 Thread Andi Shyti
Hi Radhakrishna, On Wed, Mar 01, 2023 at 12:10:49PM -0800, Radhakrishna Sripada wrote: > The commit 2357f2b271ad ("drm/i915/mtl: Initial display workarounds") > extended the workaround Wa_16015201720 to MTL. However the registers > that the original WA implemented moved for MTL. > > Implement the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: use ref_tracker library for tracking wakerefs (rev5)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915: use ref_tracker library for tracking wakerefs (rev5) URL : https://patchwork.freedesktop.org/series/100327/ State : success == Summary == CI Bug Log - changes from CI_DRM_12831 -> Patchwork_100327v5 Su

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dmc: Load DMC on MTL (rev2)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/dmc: Load DMC on MTL (rev2) URL : https://patchwork.freedesktop.org/series/114576/ State : success == Summary == CI Bug Log - changes from CI_DRM_12827_full -> Patchwork_114576v2_full Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: use ref_tracker library for tracking wakerefs (rev5)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915: use ref_tracker library for tracking wakerefs (rev5) URL : https://patchwork.freedesktop.org/series/100327/ State : warning == Summary == Error: dim checkpatch failed 21d94d8537c5 lib/ref_tracker: add unlocked leak print helper -:6: WARNING:COMMIT_LOG_LON

[Intel-gfx] [PATCH] drm/i915: disable sampler indirect state in bindless heap

2023-03-09 Thread Lionel Landwerlin
By default the indirect state sampler data (border colors) are stored in the same heap as the SAMPLER_STATE structure. For userspace drivers that can be 2 different heaps (dynamic state heap & bindless sampler state heap). This means that border colors have to copied in 2 different places so that t

Re: [Intel-gfx] [RFC PATCH 00/20] Initial Xe driver submission

2023-03-09 Thread Daniel Vetter
On Thu, 2 Mar 2023 at 00:00, Rodrigo Vivi wrote: > On Fri, Feb 17, 2023 at 09:51:37PM +0100, Daniel Vetter wrote: > > Hi all, > > > > [I thought I've sent this out earlier this week, but alas got stuck, kinda > > bad timing now since I'm out next week but oh well] > > > > So xe is a quite substant

Re: [Intel-gfx] [bug report] drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them

2023-03-09 Thread Jani Nikula
On Thu, 09 Mar 2023, Dan Carpenter wrote: > Hello Jani Nikula, > > This is a semi-automatic email about new static checker warnings. > > The patch 1b28c1c789d0: "drm/i915/dmc: add i915_to_dmc() and > dmc->i915 and use them" from Mar 1, 2023, leads to the following > Smatch complaint: > > dri

[Intel-gfx] [bug report] drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them

2023-03-09 Thread Dan Carpenter
Hello Jani Nikula, This is a semi-automatic email about new static checker warnings. The patch 1b28c1c789d0: "drm/i915/dmc: add i915_to_dmc() and dmc->i915 and use them" from Mar 1, 2023, leads to the following Smatch complaint: drivers/gpu/drm/i915/display/intel_dmc.c:1162 intel_dmc_debu

Re: [Intel-gfx] [PATCH 1/2] Revert "drm/i915/mtl: Add Wa_14017073508 for SAMedia"

2023-03-09 Thread Rodrigo Vivi
On Thu, Mar 09, 2023 at 11:08:09AM +0530, Nilawar, Badal wrote: > > > On 08-03-2023 20:55, Nilawar, Badal wrote: > > Hi Jani, > > > > On 08-03-2023 16:48, Jani Nikula wrote: > > > On Wed, 08 Mar 2023, Badal Nilawar wrote: > > > > This reverts commit 8f70f1ec587da0b0d52d768fd8c3defbc5e5b55c. > >

[Intel-gfx] [PATCH v3 3/3] drm/ttm: Make the call to ttm_tt_populate() interruptible when faulting

2023-03-09 Thread Thomas Hellström
When swapping in, or under memory pressure ttm_tt_populate() may sleep for a substantiable amount of time. Allow interrupts during the sleep. This will also allow us to inject -EINTR errors during swapin in upcoming patches. Also avoid returning VM_FAULT_OOM, since that will confuse the core mm, m

[Intel-gfx] [PATCH v3 2/3] drm/ttm: Reduce the number of used allocation orders for TTM pages

2023-03-09 Thread Thomas Hellström
When swapping out, we will split multi-order pages both in order to move them to the swap-cache and to be able to return memory to the swap cache as soon as possible on a page-by-page basis. Reduce the page max order to the system PMD size, as we can then be nicer to the system and avoid splitting

[Intel-gfx] [PATCH v3 1/3] drm/ttm/pool: Fix ttm_pool_alloc error path

2023-03-09 Thread Thomas Hellström
When hitting an error, the error path forgot to unmap dma mappings and could call set_pages_wb() on already uncached pages. Fix this by introducing a common ttm_pool_free_range() function that does the right thing. v2: - Simplify that common function (Christian König) v3: - Rename that common fun

[Intel-gfx] [PATCH v3 0/3] drm/ttm: Small fixes / cleanups in prep for shrinking

2023-03-09 Thread Thomas Hellström
I collected the, from my POW, uncontroversial patches from V1 of the TTM shrinker series, some corrected after the initial patch submission, one patch added from the Xe RFC ("drm/ttm: Don't print error message if eviction was interrupted"). It would be nice to have these reviewed and merged while r

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Patchwork
== Series Details == Series: drm/ttm: let struct ttm_device_funcs be placed in rodata URL : https://patchwork.freedesktop.org/series/114907/ State : success == Summary == CI Bug Log - changes from CI_DRM_12829 -> Patchwork_114907v1 Summary

Re: [Intel-gfx] [PATCH] drm/i915: Implement UHBR bandwidth check

2023-03-09 Thread Ville Syrjälä
On Mon, Feb 27, 2023 at 01:20:30PM +0200, Stanislav Lisovskiy wrote: > According to spec, we should check if output_bpp * pixel_rate is less > than DDI clock * 72, if UHBR is used. > > v2: - s/pipe_config/crtc_state/ (Jani Nikula) > - Merged previous patch into that one, to remove empty functi

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Patchwork
== Series Details == Series: drm/ttm: let struct ttm_device_funcs be placed in rodata URL : https://patchwork.freedesktop.org/series/114907/ State : warning == Summary == Error: dim checkpatch failed dd44fba80630 drm/ttm: let struct ttm_device_funcs be placed in rodata -:6: WARNING:COMMIT_LOG_

Re: [Intel-gfx] [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Jani Nikula
On Thu, 09 Mar 2023, Christian König wrote: > Am 09.03.23 um 13:37 schrieb Jani Nikula: >> Make the struct ttm_device_funcs pointers const so the data can be placed in >> rodata. >> >> Cc: Christian Koenig >> Cc: Huang Rui >> Signed-off-by: Jani Nikula > > Good idea, Reviewed-by: Christian Kön

Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const

2023-03-09 Thread Jani Nikula
On Thu, 09 Mar 2023, Andrzej Hajda wrote: > On 09.03.2023 09:16, Jani Nikula wrote: >> There's no need for any of these to be mutable, constify: >> >> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0020 files.0 >> drivers/gpu/drm/i915/gt/sysfs_engines.o: .data

Re: [Intel-gfx] [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Christian König
Am 09.03.23 um 13:37 schrieb Jani Nikula: Make the struct ttm_device_funcs pointers const so the data can be placed in rodata. Cc: Christian Koenig Cc: Huang Rui Signed-off-by: Jani Nikula Good idea, Reviewed-by: Christian König Should I push it to drm-misc-next or do you need it on some

[Intel-gfx] [PATCH] drm/ttm: let struct ttm_device_funcs be placed in rodata

2023-03-09 Thread Jani Nikula
Make the struct ttm_device_funcs pointers const so the data can be placed in rodata. Cc: Christian Koenig Cc: Huang Rui Signed-off-by: Jani Nikula --- drivers/gpu/drm/ttm/ttm_device.c | 2 +- include/drm/ttm/ttm_device.h | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --g

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2023 at 12:09:55PM +0100, Maarten Lankhorst wrote: > > On 2023-03-09 12:04, Hogander, Jouni wrote: > > On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: > >> On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: > >>> Hey, > >>> > >>> On 2023-03-06 16:23, Souza,

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't roundup max bpp, while computing compressed bpp

2023-03-09 Thread Nautiyal, Ankit K
Thanks Stan for the review. On 3/9/2023 4:14 PM, Lisovskiy, Stanislav wrote: On Thu, Feb 23, 2023 at 05:25:09PM +0530, Ankit Nautiyal wrote: While computing compressed bpp, maximum value of bits_per_pixel is calculated that can be supported with the given link configuration for a given mode. Av

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/ttm: Small fixes / cleanups in prep for shrinking

2023-03-09 Thread Patchwork
== Series Details == Series: drm/ttm: Small fixes / cleanups in prep for shrinking URL : https://patchwork.freedesktop.org/series/114774/ State : success == Summary == CI Bug Log - changes from CI_DRM_12824_full -> Patchwork_114774v1_full S

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: make kobj attributes const (rev2)

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: make kobj attributes const (rev2) URL : https://patchwork.freedesktop.org/series/114898/ State : success == Summary == CI Bug Log - changes from CI_DRM_12829 -> Patchwork_114898v2 Summary ---

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-09 Thread Maarten Lankhorst
On 2023-03-09 12:04, Hogander, Jouni wrote: On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: Hey, On 2023-03-06 16:23, Souza, Jose wrote: On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: As a fallback if w

Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const

2023-03-09 Thread Das, Nirmoy
On 3/9/2023 9:16 AM, Jani Nikula wrote: There's no need for any of these to be mutable, constify: drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0020 files.0 drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0050 files.1 drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 00

Re: [Intel-gfx] [Intel-xe] [PATCH] drm/xe/display: Do not use i915 frontbuffer tracking implementation

2023-03-09 Thread Hogander, Jouni
On Mon, 2023-03-06 at 22:58 +0200, Ville Syrjälä wrote: > On Mon, Mar 06, 2023 at 09:23:50PM +0100, Maarten Lankhorst wrote: > > Hey, > > > > On 2023-03-06 16:23, Souza, Jose wrote: > > > On Mon, 2023-03-06 at 15:16 +0100, Maarten Lankhorst wrote: > > > > As a fallback if we decide not to merge th

Re: [Intel-gfx] [PATCH] drm/i915/gt: make kobj attributes const

2023-03-09 Thread Andrzej Hajda
On 09.03.2023 09:16, Jani Nikula wrote: There's no need for any of these to be mutable, constify: drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0020 files.0 drivers/gpu/drm/i915/gt/sysfs_engines.o: .data 0050 files.1 drivers/gpu/drm/i915/gt/sysfs_engines.o: .data

Re: [Intel-gfx] [PATCH] drm/i915/dp: Don't roundup max bpp, while computing compressed bpp

2023-03-09 Thread Lisovskiy, Stanislav
On Thu, Feb 23, 2023 at 05:25:09PM +0530, Ankit Nautiyal wrote: > While computing compressed bpp, maximum value of bits_per_pixel is > calculated that can be supported with the given link configuration > for a given mode. Avoid rounding up of this max bits_per_pixel. > Also improve documentation fo

Re: [Intel-gfx] [PATCH v10 00/15] dma-fence: Deadline awareness

2023-03-09 Thread Pekka Paalanen
On Wed, 8 Mar 2023 07:52:51 -0800 Rob Clark wrote: > From: Rob Clark > > This series adds a deadline hint to fences, so realtime deadlines > such as vblank can be communicated to the fence signaller for power/ > frequency management decisions. > > This is partially inspired by a trick i915 do

Re: [Intel-gfx] [PATCH v10 03/13] drm/i915/dp: Add Scaler constraint for YCbCr420 output

2023-03-09 Thread Ville Syrjälä
On Thu, Mar 09, 2023 at 02:01:06PM +0530, Nautiyal, Ankit K wrote: > Hi Ville, > > Thanks for the comments and suggestions. Please find my response inline: > > On 3/8/2023 8:56 PM, Ville Syrjälä wrote: > > On Wed, Mar 08, 2023 at 05:10:57PM +0200, Ville Syrjälä wrote: > >> On Mon, Feb 27, 2023 at

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Tvrtko Ursulin
On 09/03/2023 09:59, Andrzej Hajda wrote: On 09.03.2023 10:43, Tvrtko Ursulin wrote: On 09/03/2023 09:34, Andrzej Hajda wrote: On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_captu

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: make kobj attributes const

2023-03-09 Thread Patchwork
== Series Details == Series: drm/i915/gt: make kobj attributes const URL : https://patchwork.freedesktop.org/series/114898/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12829 -> Patchwork_114898v1 Summary --- **FAIL

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Andrzej Hajda
On 09.03.2023 10:43, Tvrtko Ursulin wrote: On 09/03/2023 09:34, Andrzej Hajda wrote: On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try t

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Tvrtko Ursulin
On 09/03/2023 09:34, Andrzej Hajda wrote: On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Andrzej Hajda
On 09.03.2023 10:08, Tvrtko Ursulin wrote: On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE

Re: [Intel-gfx] [PATCH 1/2] drm/i915/pmu: Use functions common with sysfs to read actual freq

2023-03-09 Thread Tvrtko Ursulin
On 09/03/2023 03:46, Ashutosh Dixit wrote: Expose intel_rps_read_actual_frequency_fw to read the actual freq without taking forcewake for use by PMU. The code is refactored to use a common set of functions across sysfs and PMU. Using common functions with sysfs in PMU solves the issues of missi

Re: [Intel-gfx] [PATCH v5 4/4] drm/i915: add guard page to ggtt->error_capture

2023-03-09 Thread Tvrtko Ursulin
On 08/03/2023 15:39, Andrzej Hajda wrote: Write-combining memory allows speculative reads by CPU. ggtt->error_capture is WC mapped to CPU, so CPU/MMU can try to prefetch memory beyond the error_capture, ie it tries to read memory pointed by next PTE in GGTT. If this PTE points to invalid addres

Re: [Intel-gfx] [PATCH v10 03/13] drm/i915/dp: Add Scaler constraint for YCbCr420 output

2023-03-09 Thread Nautiyal, Ankit K
Hi Ville, Thanks for the comments and suggestions. Please find my response inline: On 3/8/2023 8:56 PM, Ville Syrjälä wrote: On Wed, Mar 08, 2023 at 05:10:57PM +0200, Ville Syrjälä wrote: On Mon, Feb 27, 2023 at 09:33:14AM +0530, Ankit Nautiyal wrote: For YCbCr420 output, scaler is required f

Re: [Intel-gfx] [PATCH v2] drm/i915/gt: prevent forcewake releases during BAR resize

2023-03-09 Thread Das, Nirmoy
On 3/9/2023 8:54 AM, Andrzej Hajda wrote: On 08.03.2023 18:29, Das, Nirmoy wrote: On 3/8/2023 2:36 PM, Andrzej Hajda wrote: Tests on DG2 machines show that releasing forcewakes during BAR resize results later in forcewake ack timeouts. Do we have a fdo/issues url for that? Having that as Ref

[Intel-gfx] ✓ Fi.CI.BAT: success for Enable HDCP2.x via GSC CS (rev12)

2023-03-09 Thread Patchwork
== Series Details == Series: Enable HDCP2.x via GSC CS (rev12) URL : https://patchwork.freedesktop.org/series/111876/ State : success == Summary == CI Bug Log - changes from CI_DRM_12829 -> Patchwork_111876v12 Summary --- **SUCCESS**

  1   2   >