[Intel-gfx] [PATCH v5 06/19] drm/i915/vm_bind: Support for VM private BOs

2022-10-24 Thread Niranjana Vishwanathapura
Each VM creates a root_obj and shares it with all of its private objects to use it as dma_resv object. This has a performance advantage as it requires a single dma_resv object update for all private BOs vs list of dma_resv objects update for shared BOs, in the execbuf path. VM private BOs can be o

[Intel-gfx] [PATCH v5 05/19] drm/i915/vm_bind: Implement bind and unbind of object

2022-10-24 Thread Niranjana Vishwanathapura
Add uapi and implement support for bind and unbind of an object at the specified GPU virtual addresses. The vm_bind mode is not supported in legacy execbuf2 ioctl. It will be supported only in the newer execbuf3 ioctl. v2: On older platforms ctx->vm is not set, check for it. In vm_bind call,

[Intel-gfx] [PATCH v5 03/19] drm/i915/vm_bind: Expose i915_gem_object_max_page_size()

2022-10-24 Thread Niranjana Vishwanathapura
Expose i915_gem_object_max_page_size() function non-static which will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_create.c | 18 +- drivers/gpu/drm/i915/gem/i9

[Intel-gfx] [PATCH v5 08/19] drm/i915/vm_bind: Support persistent vma activeness tracking

2022-10-24 Thread Niranjana Vishwanathapura
Do not use i915_vma activeness tracking for persistent vmas. As persistent vmas are part of working set for each execbuf submission on that address space (VM), a persistent vma is active if the VM active. As vm->root_obj->base.resv will be updated for each submission on that VM, it correctly repre

[Intel-gfx] [PATCH v5 09/19] drm/i915/vm_bind: Add out fence support

2022-10-24 Thread Niranjana Vishwanathapura
Add support for handling out fence for vm_bind call. v2: Reset vma->vm_bind_fence.syncobj to NULL at the end of vm_bind call. v3: Remove vm_unbind out fence uapi which is not supported yet. v4: Return error if I915_TIMELINE_FENCE_WAIT fence flag is set. Wait for bind to complete iff I915_T

[Intel-gfx] [PATCH v5 01/19] drm/i915/vm_bind: Expose vm lookup function

2022-10-24 Thread Niranjana Vishwanathapura
Make i915_gem_vm_lookup() function non-static as it will be used by the vm_bind feature. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura Signed-off-by: Andi Shyti --- drivers/gpu/drm/i915/gem/i915_gem_context.c | 11 ++- drivers/gpu/drm/i915/gem/i915_gem_context.h |

[Intel-gfx] [PATCH v5 00/19] drm/i915/vm_bind: Add VM_BIND functionality

2022-10-24 Thread Niranjana Vishwanathapura
DRM_I915_GEM_VM_BIND/UNBIND ioctls allows UMD to bind/unbind GEM buffer objects (BOs) or sections of a BOs at specified GPU virtual addresses on a specified address space (VM). Multiple mappings can map to the same physical pages of an object (aliasing). These mappings (also referred to as persiste

[Intel-gfx] [PATCH v5 04/19] drm/i915/vm_bind: Add support to create persistent vma

2022-10-24 Thread Niranjana Vishwanathapura
Add i915_vma_instance_persistent() to create persistent vmas. Persistent vmas will use i915_gtt_view to support partial binding. vma_lookup is tied to segment of the object instead of section of VA space. Hence, it do not support aliasing. ie., multiple mappings (at different VA) point to the same

[Intel-gfx] [PATCH v5 07/19] drm/i915/vm_bind: Add support to handle object evictions

2022-10-24 Thread Niranjana Vishwanathapura
Support eviction by maintaining a list of evicted persistent vmas for rebinding during next submission. Ensure the list do not include persistent vmas that are being purged. v2: Remove unused I915_VMA_PURGED definition. v3: Properly handle __i915_vma_unbind_async() case. Reviewed-by: Matthew Auld

[Intel-gfx] [PATCH v5 02/19] drm/i915/vm_bind: Add __i915_sw_fence_await_reservation()

2022-10-24 Thread Niranjana Vishwanathapura
Add function __i915_sw_fence_await_reservation() for asynchronous wait on a dma-resv object with specified dma_resv_usage. This is required for async vma unbind with vm_bind. Reviewed-by: Matthew Auld Signed-off-by: Niranjana Vishwanathapura --- drivers/gpu/drm/i915/i915_sw_fence.c | 28 +++

Re: [Intel-gfx] [PATCH v3 6/6] freezer, sched: Rewrite core freezer logic

2022-10-24 Thread Ville Syrjälä
On Fri, Oct 21, 2022 at 08:22:41PM +0300, Ville Syrjälä wrote: > On Mon, Aug 22, 2022 at 01:18:22PM +0200, Peter Zijlstra wrote: > > +#ifdef CONFIG_LOCKDEP > > + /* > > +* It's dangerous to freeze with locks held; there be dragons there. > > +*/ > > + if (!(state & __TASK_FREEZABLE_UNSA

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/slpc: Use platform limits for min/max frequency (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Use platform limits for min/max frequency (rev4) URL : https://patchwork.freedesktop.org/series/109632/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_109632v4 S

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/25 3:11, Jani Nikula wrote: On Tue, 25 Oct 2022, Akihiko Odaki wrote: That aside, the first patch in this series can be applied without the later patches so you may have a look at it. It's fine if you don't merge it though since it does not fix really a pragmatic bug as its message s

Re: [Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

2022-10-24 Thread Dixit, Ashutosh
On Mon, 24 Oct 2022 14:09:53 -0700, Gwan-gyeong Mun wrote: > Hi GG, > If a non-constant variable is used as the first argument of the FIELD_PREP > macro, a build error occurs when using the clang compiler. > > Fix the following build error used with clang compiler: > > drivers/gpu/drm/i915/i915_h

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915/slpc: Use platform limits for min/max frequency (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Use platform limits for min/max frequency (rev4) URL : https://patchwork.freedesktop.org/series/109632/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: prepare for uC loading on MTL (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL (rev4) URL : https://patchwork.freedesktop.org/series/108925/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_108925v4 Summary ---

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: prepare for uC loading on MTL (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL (rev4) URL : https://patchwork.freedesktop.org/series/108925/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: prepare for uC loading on MTL (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: prepare for uC loading on MTL (rev4) URL : https://patchwork.freedesktop.org/series/108925/ State : warning == Summary == Error: dim checkpatch failed 1f2227f5acd6 drm/i915/huc: only load HuC on GTs that have VCS engines -:44: WARNING:AVOID_BUG: Do not cr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/hwmon: Fix a build error used with clang compiler

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Fix a build error used with clang compiler URL : https://patchwork.freedesktop.org/series/110094/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_110094v1 Summar

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/hwmon: Fix a build error used with clang compiler

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/hwmon: Fix a build error used with clang compiler URL : https://patchwork.freedesktop.org/series/110094/ State : warning == Summary == Error: dim checkpatch failed be30883f7e71 drm/i915/hwmon: Fix a build error used with clang compiler -:23: WARNING:COMMIT

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915: CAGF and RC6 changes for MTL (rev11)

2022-10-24 Thread Patchwork
== Series Details == Series: i915: CAGF and RC6 changes for MTL (rev11) URL : https://patchwork.freedesktop.org/series/108156/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_108156v11 Summary --- **

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for i915: CAGF and RC6 changes for MTL (rev11)

2022-10-24 Thread Patchwork
== Series Details == Series: i915: CAGF and RC6 changes for MTL (rev11) URL : https://patchwork.freedesktop.org/series/108156/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.BAT: failure for overflow: Introduce overflows_type() and castable_to_type() (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: overflow: Introduce overflows_type() and castable_to_type() (rev4) URL : https://patchwork.freedesktop.org/series/109076/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_109076v4

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for overflow: Introduce overflows_type() and castable_to_type() (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: overflow: Introduce overflows_type() and castable_to_type() (rev4) URL : https://patchwork.freedesktop.org/series/109076/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for overflow: Introduce overflows_type() and castable_to_type() (rev4)

2022-10-24 Thread Patchwork
== Series Details == Series: overflow: Introduce overflows_type() and castable_to_type() (rev4) URL : https://patchwork.freedesktop.org/series/109076/ State : warning == Summary == Error: dim checkpatch failed 9f9dcc2b4db8 overflow: Introduce overflows_type() and castable_to_type() -:88: CHECK

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43

2022-10-24 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43 URL : https://patchwork.freedesktop.org/series/110084/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_110084v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43

2022-10-24 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43 URL : https://patchwork.freedesktop.org/series/110084/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43

2022-10-24 Thread Patchwork
== Series Details == Series: series starting with [1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43 URL : https://patchwork.freedesktop.org/series/110084/ State : warning == Summary == Error: dim checkpatch failed 493d5c1d6f7b drm/i915/pxp: Separate PXP FW interface

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/userptr: restore probe_range behaviour

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/userptr: restore probe_range behaviour URL : https://patchwork.freedesktop.org/series/110083/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12288 -> Patchwork_110083v1 Summary ---

[Intel-gfx] [PATCH v4] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-24 Thread Vinay Belgaumkar
GuC will set the min/max frequencies to theoretical max on ATS-M. This will break kernel ABI, so limit min/max frequency to RP0(platform max) instead. Also modify the SLPC selftest to update the min frequency when we have a server part so that we can iterate between platform min and max. v2: Chec

[Intel-gfx] [PATCH] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread Daniele Ceraolo Spurio
From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed, with separate partitioning in WOPCM for the root GT GuC and the media GT GuC. The size of WOPCM is 4MB with the lower 2MB reserved for the media GT and the upper 2MB for the root GT. Given that MTL has

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/slpc: Optmize waitboost for SLPC (rev5)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/slpc: Optmize waitboost for SLPC (rev5) URL : https://patchwork.freedesktop.org/series/109840/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12287 -> Patchwork_109840v5 Summary ---

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread Ceraolo Spurio, Daniele
On 10/24/2022 2:46 PM, John Harrison wrote: On 10/24/2022 14:39, Ceraolo Spurio, Daniele wrote: On 10/24/2022 2:33 PM, John Harrison wrote: On 10/21/2022 17:10, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread John Harrison
On 10/24/2022 14:39, Ceraolo Spurio, Daniele wrote: On 10/24/2022 2:33 PM, John Harrison wrote: On 10/21/2022 17:10, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC a

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread Ceraolo Spurio, Daniele
On 10/24/2022 2:33 PM, John Harrison wrote: On 10/21/2022 17:10, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size of WOPCM is 4MB with lowe

Re: [Intel-gfx] [PATCH v3 5/7] drm/i915/mtl: Handle wopcm per-GT and limit calculations.

2022-10-24 Thread John Harrison
On 10/21/2022 17:10, Daniele Ceraolo Spurio wrote: From: Aravind Iddamsetty With MTL standalone media architecture the wopcm layout has changed with separate partitioning in WOPCM for GCD/GT GuC and SA Media GuC. The size of WOPCM is 4MB with lower 2MB for SA Media and upper 2MB for GCD/GT. Giv

[Intel-gfx] [PATCH] drm/i915/hwmon: Fix a build error used with clang compiler

2022-10-24 Thread Gwan-gyeong Mun
If a non-constant variable is used as the first argument of the FIELD_PREP macro, a build error occurs when using the clang compiler. Fix the following build error used with clang compiler: drivers/gpu/drm/i915/i915_hwmon.c:115:16: error: result of comparison of constant 18446744073709551615 wit

Re: [Intel-gfx] [PATCH v3 3/7] drm/i915/uc: use different ggtt pin offsets for uc loads

2022-10-24 Thread John Harrison
On 10/21/2022 17:10, Daniele Ceraolo Spurio wrote: Our current FW loading process is the same for all FWs: - Pin FW to GGTT at the start of the ggtt->uc_fw node - Load the FW - Unpin This worked because we didn't have a case where 2 FWs would be loaded on the same GGTT at the same time. On MTL,

Re: [Intel-gfx] [PATCH v5 02/31] drm/i915: Don't register backlight when another backlight should be used (v2)

2022-10-24 Thread Matthew Garrett
On Tue, Sep 27, 2022 at 01:04:52PM +0200, Hans de Goede wrote: > So to fix this we need to make acpi_video_get_backlight_type() > return native on the Acer Chromebook Spin 713. Isn't the issue broader than that? Unless the platform is Windows 8 or later, we'll *always* (outside of some corner ca

Re: [Intel-gfx] [PATCH v3 7/7] drm/i915/guc: handle interrupts from media GuC

2022-10-24 Thread Ceraolo Spurio, Daniele
On 10/21/2022 5:10 PM, Daniele Ceraolo Spurio wrote: The render and media GuCs share the same interrupt enable register, so we can no longer disable interrupts when we disable communication for one of the GuCs as this would impact the other GuC. Instead, we keep the interrupts always enabled i

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Add GuC-Error-Capture-Init coverage of new engine types (rev3)

2022-10-24 Thread Teres Alexis, Alan Previn
I believe that the issues below are not related to this series because they were running on platforms that do not use guc-submission. Additionally, both patches of this series impact steps very early in the guc initialization phase and never again - and do not impact runtime operation of display

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove unwanted ghost obj check

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: Remove unwanted ghost obj check URL : https://patchwork.freedesktop.org/series/110065/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285_full -> Patchwork_110065v1_full Summary -

[Intel-gfx] [PATCH 3/5] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-24 Thread Ashutosh Dixit
From: Badal Nilawar Update CAGF functions for MTL to get actual resolved frequency of 3D and SAMedia. v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) Move MTL branches in cagf functions to top (MattR) Fix commit message (Andi) v3: Added comment about registers not needing fo

[Intel-gfx] [PATCH 2/5] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-24 Thread Ashutosh Dixit
From: Don Hiatt On GEN12+ use GEN12_RPSTAT register to get actual resolved GT freq. GEN12_RPSTAT does not require a forcewake and will return 0 freq if GT is in RC6. v2: - Fixed review comments(Ashutosh) - Added function intel_rps_read_rpstat_fw to read RPSTAT without forcewake, required

[Intel-gfx] [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Ashutosh Dixit
From: Badal Nilawar Add support for C6 residency and C state type for MTL SAMedia. Also add mtl_drpc. v2: Fixed review comments (Ashutosh) v3: Sort registers and fix whitespace errors in intel_gt_regs.h (Matt R) Remove MTL_CC_SHIFT (Ashutosh) Adapt to RC6 residency register code refactor

[Intel-gfx] [PATCH 4/5] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-24 Thread Ashutosh Dixit
Previously RC6 residency functions directly accepted RC6 residency register MMIO offsets (there are four RC6 residency registers). This worked but required an assumption on the residency register layout so was not future proof. Therefore change RC6 residency functions to accept RC6 residency types

[Intel-gfx] [PATCH 1/5] drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf

2022-10-24 Thread Ashutosh Dixit
Instead of masks/shifts settle on REG_FIELD_GET as the standard way to extract reg fields. This allows future patches touching this code to also consistently use REG_FIELD_GET and friends. Suggested-by: Rodrigo Vivi Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 0/5] i915: CAGF and RC6 changes for MTL

2022-10-24 Thread Ashutosh Dixit
This series includes the code changes to get CAGF, RC State and C6 Residency of MTL. v3: Included "Use GEN12 RPSTAT register" patch v4: - Rebased - Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it v5: - Included "drm/i915/gt: Change RC6 re

[Intel-gfx] [PATCH v5] overflow: Introduce overflows_type() and castable_to_type()

2022-10-24 Thread Gwan-gyeong Mun
From: Kees Cook Implement a robust overflows_type() macro to test if a variable or constant value would overflow another variable or type. This can be used as a constant expression for static_assert() (which requires a constant expression[1][2]) when used on constant values. This must be construc

Re: [Intel-gfx] [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Rodrigo Vivi
On Mon, Oct 24, 2022 at 12:13:13PM -0700, Ashutosh Dixit wrote: > From: Badal Nilawar > > Add support for C6 residency and C state type for MTL SAMedia. Also add > mtl_drpc. > > v2: Fixed review comments (Ashutosh) > v3: Sort registers and fix whitespace errors in intel_gt_regs.h (Matt R) >

Re: [Intel-gfx] [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Rodrigo Vivi
On Mon, Oct 24, 2022 at 12:16:28PM -0700, Dixit, Ashutosh wrote: > On Fri, 21 Oct 2022 09:35:32 -0700, Rodrigo Vivi wrote: > > > > Hi Rodrigo, > > > On Wed, Oct 19, 2022 at 04:37:21PM -0700, Ashutosh Dixit wrote: > > > From: Badal Nilawar > > > > > > Add support for C6 residency and C state type

Re: [Intel-gfx] [PATCH v3] drm/i915/slpc: Use platform limits for min/max frequency

2022-10-24 Thread Belgaumkar, Vinay
On 10/21/2022 10:26 PM, Dixit, Ashutosh wrote: On Fri, 21 Oct 2022 18:38:57 -0700, Belgaumkar, Vinay wrote: On 10/20/2022 3:57 PM, Dixit, Ashutosh wrote: On Tue, 18 Oct 2022 11:30:31 -0700, Vinay Belgaumkar wrote: Hi Vinay, diff --git a/drivers/gpu/drm/i915/gt/selftest_slpc.c b/drivers/gpu

Re: [Intel-gfx] [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Dixit, Ashutosh
On Fri, 21 Oct 2022 09:35:32 -0700, Rodrigo Vivi wrote: > Hi Rodrigo, > On Wed, Oct 19, 2022 at 04:37:21PM -0700, Ashutosh Dixit wrote: > > From: Badal Nilawar > > > > Add support for C6 residency and C state type for MTL SAMedia. Also add > > mtl_drpc. > > I believe this patch deserves a slip b

[Intel-gfx] [PATCH 3/5] drm/i915/mtl: Modify CAGF functions for MTL

2022-10-24 Thread Ashutosh Dixit
From: Badal Nilawar Update CAGF functions for MTL to get actual resolved frequency of 3D and SAMedia. v2: Update MTL_MIRROR_TARGET_WP1 position/formatting (MattR) Move MTL branches in cagf functions to top (MattR) Fix commit message (Andi) v3: Added comment about registers not needing fo

[Intel-gfx] [PATCH 2/5] drm/i915: Use GEN12_RPSTAT register for GT freq

2022-10-24 Thread Ashutosh Dixit
From: Don Hiatt On GEN12+ use GEN12_RPSTAT register to get actual resolved GT freq. GEN12_RPSTAT does not require a forcewake and will return 0 freq if GT is in RC6. v2: - Fixed review comments(Ashutosh) - Added function intel_rps_read_rpstat_fw to read RPSTAT without forcewake, required

[Intel-gfx] [PATCH 5/5] drm/i915/mtl: C6 residency and C state type for MTL SAMedia

2022-10-24 Thread Ashutosh Dixit
From: Badal Nilawar Add support for C6 residency and C state type for MTL SAMedia. Also add mtl_drpc. v2: Fixed review comments (Ashutosh) v3: Sort registers and fix whitespace errors in intel_gt_regs.h (Matt R) Remove MTL_CC_SHIFT (Ashutosh) Adapt to RC6 residency register code refactor

[Intel-gfx] [PATCH 0/5] i915: CAGF and RC6 changes for MTL

2022-10-24 Thread Ashutosh Dixit
This series includes the code changes to get CAGF, RC State and C6 Residency of MTL. v3: Included "Use GEN12 RPSTAT register" patch v4: - Rebased - Dropped "Use GEN12 RPSTAT register" patch from this series going to send separate series for it v5: - Included "drm/i915/gt: Change RC6 re

[Intel-gfx] [PATCH 4/5] drm/i915/gt: Use RC6 residency types as arguments to residency functions

2022-10-24 Thread Ashutosh Dixit
Previously RC6 residency functions directly accepted RC6 residency register MMIO offsets (there are four RC6 residency registers). This worked but required an assumption on the residency register layout so was not future proof. Therefore change RC6 residency functions to accept RC6 residency types

[Intel-gfx] [PATCH 1/5] drm/i915/rps: Prefer REG_FIELD_GET in intel_rps_get_cagf

2022-10-24 Thread Ashutosh Dixit
Instead of masks/shifts settle on REG_FIELD_GET as the standard way to extract reg fields. This allows future patches touching this code to also consistently use REG_FIELD_GET and friends. Suggested-by: Rodrigo Vivi Signed-off-by: Ashutosh Dixit Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i9

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Prep work for finishing (de)gamma readout (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: Prep work for finishing (de)gamma readout (rev2) URL : https://patchwork.freedesktop.org/series/109229/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_109229v2 Summar

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Prep work for finishing (de)gamma readout (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: Prep work for finishing (de)gamma readout (rev2) URL : https://patchwork.freedesktop.org/series/109229/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] [PATCH 1/1] drm/i915/pxp: Separate PXP FW interface structures for both v42 and 43

2022-10-24 Thread Alan Previn
Previously, we only used PXP FW interface version-42 structures for PXP arbitration session on ADL/TGL products and version-43 for HuC authentication on DG2. That worked fine despite not differentiating such versioning of the PXP firmware interaction structures. This was okay back then because the

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: use intel_uncore_rmw when appropriate

2022-10-24 Thread Andi Shyti
Hi Andrzej, On Wed, Oct 19, 2022 at 04:38:17PM +0200, Andrzej Hajda wrote: > This patch replaces all occurences of the form > intel_uncore_write(reg, intel_uncore_read(reg) OP val) > with intel_uncore_rmw. > > Signed-off-by: Andrzej Hajda both the patches pushed in drm-intel-gt-next. Thanks, A

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove unwanted ghost obj check

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: Remove unwanted ghost obj check URL : https://patchwork.freedesktop.org/series/110065/ State : success == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_110065v1 Summary --- **SU

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Jani Nikula
On Tue, 25 Oct 2022, Akihiko Odaki wrote: > That aside, the first patch in this series can be applied without the > later patches so you may have a look at it. It's fine if you don't merge > it though since it does not fix really a pragmatic bug as its message says. I think it's problematic bec

[Intel-gfx] ✗ Fi.CI.BAT: failure for mm/huge_memory: do not clobber swp_entry_t during THP split (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: mm/huge_memory: do not clobber swp_entry_t during THP split (rev2) URL : https://patchwork.freedesktop.org/series/110061/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_110061v2

Re: [Intel-gfx] [PATCH v2 09/16] drm/edid: detach debugfs EDID override from EDID property update

2022-10-24 Thread Ville Syrjälä
On Mon, Oct 24, 2022 at 03:33:37PM +0300, Jani Nikula wrote: > Having the EDID override debugfs directly update the EDID property is > problematic. The update is partial only. The driver has no way of > knowing it's been updated. Mode list is not updated. It's an > inconsistent state. > > Detach d

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for mm/huge_memory: do not clobber swp_entry_t during THP split (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: mm/huge_memory: do not clobber swp_entry_t during THP split (rev2) URL : https://patchwork.freedesktop.org/series/110061/ State : warning == Summary == Error: dim checkpatch failed ddb160aab750 mm/huge_memory: do not clobber swp_entry_t during THP split -:10: WARNI

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/pps: improve eDP power on flow. (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/pps: improve eDP power on flow. (rev2) URL : https://patchwork.freedesktop.org/series/110038/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_110038v2 Summary ---

[Intel-gfx] [PATCH] drm/i915/userptr: restore probe_range behaviour

2022-10-24 Thread Matthew Auld
The conversion looks harmless, however the addr value is updated inside the loop with the previous vm_end, which then incorrectly leads to for_each_vma_range() iterating over stuff outside the range we care about. Fix this by storing the end value separately. Testcase: igt@gem_userptr_blits@probe

[Intel-gfx] ✗ Fi.CI.BAT: failure for Fallback to native backlight

2022-10-24 Thread Patchwork
== Series Details == Series: Fallback to native backlight URL : https://patchwork.freedesktop.org/series/110054/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_110054v1 Summary --- **FAILURE** Se

[Intel-gfx] [PATCH v5] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-24 Thread Vinay Belgaumkar
Waitboost (when SLPC is enabled) results in a H2G message. This can result in thousands of messages during a stress test and fill up an already full CTB. There is no need to request for boost if min softlimit is equal or greater than it. v2: Add the tracing back, and check requested freq in the wo

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Fallback to native backlight

2022-10-24 Thread Patchwork
== Series Details == Series: Fallback to native backlight URL : https://patchwork.freedesktop.org/series/110054/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:117:1: warnin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Fallback to native backlight

2022-10-24 Thread Patchwork
== Series Details == Series: Fallback to native backlight URL : https://patchwork.freedesktop.org/series/110054/ State : warning == Summary == Error: dim checkpatch failed 2f7142a8164b drm/i915/opregion: Improve backlight request condition d16e5a739419 ACPI: video: Introduce acpi_video_get_bac

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: fix repeated words in comments (rev6)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915: fix repeated words in comments (rev6) URL : https://patchwork.freedesktop.org/series/107885/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_107885v6 Summary ---

Re: [Intel-gfx] [PATCH v4] drm/i915/slpc: Optmize waitboost for SLPC

2022-10-24 Thread Belgaumkar, Vinay
On 10/22/2022 12:22 PM, Dixit, Ashutosh wrote: On Sat, 22 Oct 2022 10:56:03 -0700, Belgaumkar, Vinay wrote: Hi Vinay, diff --git a/drivers/gpu/drm/i915/gt/intel_rps.c b/drivers/gpu/drm/i915/gt/intel_rps.c index fc23c562d9b2..32e1f5dde5bb 100644 --- a/drivers/gpu/drm/i915/gt/intel_rps.c +++ b

[Intel-gfx] [PATCH v2 5/5] drm/i915: Stop loading linear degamma LUT on glk needlessly

2022-10-24 Thread Ville Syrjala
From: Ville Syrjälä Make glk_load_luts() a bit lighter for the common case where neither the degamma LUT nor pipe CSC are enabled by not loading the linear degamma LUT. Making .load_luts() as lightweight as possible is a good idea since it may need to execute from a vblank worker under tight dead

[Intel-gfx] [PATCH v2 3/5] drm/i915: Assert {pre, post}_csc_lut were assigned sensibly

2022-10-24 Thread Ville Syrjala
From: Ville Syrjälä Since we now have the extra step from hw.(de)gamma_lut into {pre,post}_csc_lut let's make sure we didn't forget to assign them appropriately. Ie. basically making sure intel_color_check() was called when necessary (and that it did its job suitable well). Reviewed-by: Uma Shan

[Intel-gfx] [PATCH v2 4/5] drm/i915: Get rid of glk_load_degamma_lut_linear()

2022-10-24 Thread Ville Syrjala
From: Ville Syrjälä Since we now have a place (pre_csc_lut) to stuff a purely internal LUT we can replace glk_load_degamma_lut_linear() with such a thing and just rely on the normal glk_load_degamma_lut() to load it as well. drm_mode_config_cleanup() will clean this up for us. v2: Pass on the e

[Intel-gfx] [PATCH v2 2/5] drm/i915: Introduce crtc_state->{pre, post}_csc_lut

2022-10-24 Thread Ville Syrjala
From: Ville Syrjälä Add an extra remapping step between the logical state of the LUTs (hw.(de)gamma_lut) as specified via uapi/bigjoiner copy vs. the actual state of the LUTs programmed into the hardware. With this we should be finally able finish the (de)gamma readout/state checker support for

[Intel-gfx] [PATCH v2 1/5] drm/i915: Make ilk_load_luts() deal with degamma

2022-10-24 Thread Ville Syrjala
From: Ville Syrjälä Make ilk_load_luts() ready for a degamma lut. Currently we never have one, but soon we may get one from readout, and I think we may want to change the state computation such that we may end up with one even when userspace has simply supplied a gamma lut. At least the code now

[Intel-gfx] [PATCH v2 0/5] drm/i915: Prep work for finishing (de)gamma readout

2022-10-24 Thread Ville Syrjala
From: Ville Syrjälä Add another layer of LUT blobs in order to make gamma state readout/check possible on ilk-skl. As a bonus we can also simplify the glk degamma vs. csc mess. The actual state readout/checker stuff that we're currently missing will follow later. v2: Half the series alrady push

[Intel-gfx] ✗ Fi.CI.BAT: failure for i915/display: fix repeated words in comments (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: i915/display: fix repeated words in comments (rev2) URL : https://patchwork.freedesktop.org/series/107887/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_107887v2 Summary -

Re: [Intel-gfx] PR for HuC 7.10.3

2022-10-24 Thread Josh Boyer
On Tue, Oct 18, 2022 at 11:22 AM Daniele Ceraolo Spurio wrote: > > The following changes since commit 48407ffd7adb9511701547068b1e6f0956bd1c94: > > cnm: update chips&media wave521c firmware. (2022-10-17 10:20:43 -0400) > > are available in the Git repository at: > > git://anongit.freedesktop.o

Re: [Intel-gfx] [PATCH v2 16/16] drm/edid: convert to device specific logging

2022-10-24 Thread Ville Syrjälä
On Mon, Oct 24, 2022 at 03:33:44PM +0300, Jani Nikula wrote: > Convert to drm_kms_dbg/drm_err where possible, and reference the > connector using [CONNECTOR:%d:%s]. Pass connectors around a bit more to > enable this. Where this is not possible, unify the rest of the debugs to > DRM_DEBUG_KMS. > >

Re: [Intel-gfx] [PATCH v2 14/16] drm/edid/firmware: convert to drm device specific logging

2022-10-24 Thread Ville Syrjälä
On Mon, Oct 24, 2022 at 03:33:42PM +0300, Jani Nikula wrote: > Conform to device specific logging. > > v2: Include [CONNECTOR:%d:%s] (Ville) > > Signed-off-by: Jani Nikula Reviewed-by: Ville Syrjälä > --- > drivers/gpu/drm/drm_edid_load.c | 12 > 1 file changed, 8 insertions(+),

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Remove inappropriate DSC slice alignment warning

2022-10-24 Thread Patchwork
== Series Details == Series: drm/i915/psr: Remove inappropriate DSC slice alignment warning URL : https://patchwork.freedesktop.org/series/109983/ State : success == Summary == CI Bug Log - changes from CI_DRM_12270_full -> Patchwork_109983v1_full ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-24 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/ttm: rework on ttm_resource to use size_t type URL : https://patchwork.freedesktop.org/series/110055/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_110055v1

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-24 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/ttm: rework on ttm_resource to use size_t type URL : https://patchwork.freedesktop.org/series/110055/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separate

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/6] drm/ttm: rework on ttm_resource to use size_t type

2022-10-24 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/ttm: rework on ttm_resource to use size_t type URL : https://patchwork.freedesktop.org/series/110055/ State : warning == Summary == Error: dim checkpatch failed b400c116c652 drm/ttm: rework on ttm_resource to use size_t type 472c5abe

Re: [Intel-gfx] [PATCH v2 02/16] drm/i915/hdmi: stop using connector->override_edid

2022-10-24 Thread Ville Syrjälä
On Mon, Oct 24, 2022 at 03:33:30PM +0300, Jani Nikula wrote: > The connector->override_edid flag is strictly for EDID override debugfs > management, and drivers have no business using it. > > The check for override_edid was added in commit 301906290553 ("drm/i915: > Ignore TMDS clock limit for DP+

Re: [Intel-gfx] [PATCH 2/2] drm/i915/selftests: add igt_vma_move_to_active_unlocked

2022-10-24 Thread Andi Shyti
Hi Andrzej, On Mon, Oct 24, 2022 at 04:05:57PM +0200, Andrzej Hajda wrote: > On 21.10.2022 17:39, Andi Shyti wrote: > > Hi Andrzej, > > > > [...] > > > > > +static inline int __must_check > > > +igt_vma_move_to_active_unlocked(struct i915_vma *vma, struct > > > i915_request *rq, > > > +

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/edid: EDID override refactoring and fixes (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/edid: EDID override refactoring and fixes (rev2) URL : https://patchwork.freedesktop.org/series/109579/ State : failure == Summary == CI Bug Log - changes from CI_DRM_12285 -> Patchwork_109579v2 Summary

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Akihiko Odaki
On 2022/10/24 23:37, Hans de Goede wrote: Hi, On 10/24/22 16:31, Akihiko Odaki wrote: On 2022/10/24 23:06, Akihiko Odaki wrote: On 2022/10/24 22:21, Hans de Goede wrote: Hi, On 10/24/22 14:58, Akihiko Odaki wrote: On 2022/10/24 20:53, Hans de Goede wrote: Hi Akihiko, On 10/24/22 13:34,

Re: [Intel-gfx] [PATCH] drm/i915: Remove unwanted ghost obj check

2022-10-24 Thread Matthew Auld
On 24/10/2022 15:45, Nirmoy Das wrote: vm_fault_ttm() should not expect ttm ghost obj so remove that check. Suggested-by: Matthew Auld Signed-off-by: Nirmoy Das Reviewed-by: Matthew Auld

Re: [Intel-gfx] [PATCH] i915/display: fix repeated words in comments

2022-10-24 Thread Rodrigo Vivi
On Sat, Oct 22, 2022 at 02:09:47PM +0800, wangjianli wrote: > Delete the redundant word 'the'. I believe we should put an end in patches like this. Please accumulate all the s/the the/the and other small comment fixes that are under drivers/gpu/drm/i915 in a single commit. > > Signed-off-by: wa

[Intel-gfx] [PATCH] drm/i915: Remove unwanted ghost obj check

2022-10-24 Thread Nirmoy Das
vm_fault_ttm() should not expect ttm ghost obj so remove that check. Suggested-by: Matthew Auld Signed-off-by: Nirmoy Das --- drivers/gpu/drm/i915/gem/i915_gem_ttm.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_ge

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/edid: EDID override refactoring and fixes (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/edid: EDID override refactoring and fixes (rev2) URL : https://patchwork.freedesktop.org/series/109579/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/edid: EDID override refactoring and fixes (rev2)

2022-10-24 Thread Patchwork
== Series Details == Series: drm/edid: EDID override refactoring and fixes (rev2) URL : https://patchwork.freedesktop.org/series/109579/ State : warning == Summary == Error: dim checkpatch failed fbb979246d72 drm/i915/hdmi: do dual mode detect only if connected 3483553167f1 drm/i915/hdmi: stop

Re: [Intel-gfx] [PATCH 00/22] Fallback to native backlight

2022-10-24 Thread Hans de Goede
Hi, On 10/24/22 16:31, Akihiko Odaki wrote: > On 2022/10/24 23:06, Akihiko Odaki wrote: >> On 2022/10/24 22:21, Hans de Goede wrote: >>> Hi, >>> >>> On 10/24/22 14:58, Akihiko Odaki wrote: On 2022/10/24 20:53, Hans de Goede wrote: > Hi Akihiko, > > On 10/24/22 13:34, Akihiko Odaki

  1   2   3   >